In T358896#9690242, @OTichonova wrote:

Hi @Dmantena, updates are looking good thank you!
2 small things.

The above work is up in this branch: https://github.com/wikimedia/wikipedia-ios/tree/onboarding-refactor.

In T358896#9648882, @OTichonova wrote:

Hi @Dmantena, looking good! Couple of things:

1. Can the area with the Button and link be sticky to the bottom and have the scroller show up when people access the page just like we have it for the Notifications onboarding page?

Notifications

2)The leading/line height of the text seems tall. Based on typography guidelines I think for Title 1 the leading is 34 pts and for Subhead the leading is 20 pts.
3)Looking back at the onboarding screens from the last couple of features I see that the spacing varies between title & text and between text sections. Can the spacing between title & text stay as it is and the space between text sections be 24pts?

A piece of additional work that may be useful: if the user decides to watch an article as they edit it, when they publish the change and return to the article view we should refresh the article view's overflow menu to reflect its watched status.

@Dbrant Awesome – thank you for confirming the details and for the example JSON!

@Dmantena okay thank you for including the screen shots. A couple of things I noticed.

1. Could we get rid of the border that is at the bottom of the list & at the bottom of 'Other' in the first version and just at the bottom of 'Other' in the version where they are all together?

2. In the case where I typed something in 'Other' and then proceeded to tap on other options from the list the cursor & keyboard stayed active. Is it possible to close the keyboard and get rid of the active cursor if someone selects or deselects other options from the list?

RPReplay_Final1711124982.MP41 MBDownload

3. Last slightly adjacent thing. I made this border color update proposition T351943 where I propose the border color to be gray300. Is it better to keep the borders the current gray400 and then when the ticket is picked up the border colors will be update to gray300 or is it worth changing this in the current designs?

@Dbrant Hey Dmitry – wanted to confirm some things that came up in engineering sync to be sure we have parity with Android:

In T358896#9658716, @HNordeenWMF wrote:

hi @Dmantena, we discussed Amir's feedback this in slack with @Tsevener and @OTichonova.
Please update the link at bottom from Learn about add an image to Learn more about suggested edits

@OTichonova This is now ready for design review in TestFlight Experimental build 7.4.10 (96). Note that the cancel and submit button currently do nothing, and I need to follow-up for some more accessibility work.

Hi @OTichonova this is ready for design review (Wikipedia Experimental 7.4.9 (94) in TestFlight). It leverages our existing Onboarding component, and the steps to see it when Suggested Edits is turned on in your Explore feed settings are detailed here: https://github.com/wikimedia/wikipedia-ios/pull/4778

@JTannerWMF Thanks for these links! To be clear, I don't perceive the "Not Sure"/"Skip" button as problematic but rather the "No" button requiring some form feedback response for forward progress with more recommendations as so (which from my initial survey of these docs seems to have originated from wanting to improve the research team's image training algorithm before publishing actual changes).

@OTichonova Awesome thank you – will give them a read.

1. It is normal iOS behavior to keep that text field standard one line. When designing I thought that would stay that way.

@HNordeenWMF @OTichonova A few questions that came up during eng. sync that affect our estimates:

In T358896#9634151, @HNordeenWMF wrote:

Hi @Dmantena, the FAQ link in the task description was incorrect (my error), here is the correct one:
https://www.mediawiki.org/wiki/Wikimedia_Apps/iOS_Suggested_edits#Add_an_image

PR: https://github.com/wikimedia/wikipedia-ios/pull/4778

PR here: https://github.com/wikimedia/wikipedia-ios/pull/4745. Description from PR (emphasis mine):

As mentioned in sync, looks like the wrong version (7.4.9 (3298)) got smoketested. To access the precise build from the task description in TestFlight, they need to open TestFlight > Tap Wikipedia > Tap "Versions & Builds" on the page > 7.4.8 > then tap 7.4.8 (3263).

PR: https://github.com/wikimedia/wikipedia-ios/pull/4776

Partial PR: https://github.com/wikimedia/wikipedia-ios/pull/4771

Partial PR: https://github.com/wikimedia/wikipedia-ios/pull/4764

@JTannerWMF Updated bottom of description with breakdown of complete and remaining engineering tasks to conclude this task.

PRs:

• https://github.com/wikimedia/wikipedia-ios/pull/4746
• https://github.com/wikimedia/wikipedia-ios/pull/4747
• https://github.com/wikimedia/wikipedia-ios/pull/4755

Just an internal documentation change, no QA needed.

@ARamadan-WMF I slowed down the video and it appeared like the user had a Picture of the day card in their explore feed, but can we check with them to confirm whether they currently have Picture of the day turned on in Settings > Explore feed > Picture of the day? This may help us understand some of the bounds of this problem.

Having a distinction between production and beta tags are not something that fit well into our release and beta style with TestFlight. But we should be able to use a post clone or pre build script (per https://developer.apple.com/documentation/xcode/writing-custom-build-scripts) to creatively inject the build date into the reported version identifier.

If we can measure 3. How many users open the app through one of the widgets? by user, can we also measure app open events by user/date so we can get usage frequency? But if we can measure engagement (as tapping the widget) as well, as an event by unique by date that gives us more data to compare widget popularity.

Here're updates on this task.

Hi @Sj – it looks like this task was tagged on both iOS and Android app boards. Which iOS web browser are you using and intending to open the article in?

@SNowick_WMF Thanks for making this ticket!

In T346188#9408240, @JTannerWMF wrote:

Either they should not be allowed to skip any of the steps in the onboarding (remove skip as an option for onboarding), or we pop up the modal.

I am fine with going with the first option so that both needs are met.

We talked a bit about this in engineering sync this week. Both changes (updating the onboarding flow and the data sharing modal) are certainly technically possible. But we feel the data sharing modal (in the explore feed, outside of the onboarding flow) may be perceived as slightly user hostile.

PR: https://github.com/wikimedia/wikipedia-ios/pull/4701

See our "Explore Wikipedia" widget here: https://phabricator.wikimedia.org/T259843

Cooltey confirmed on the Android side that the date in their version identifier is actually the build date, not the submission or release date of the app version.

@JTannerWMF Any chance you can provide more precise repro steps to trigger an in-app Meta wiki notification in the style of what you're encountering? There certainly seem to be some diff history URL title parsing/navigation issues, but I'd like to be sure I'm addressing what you're encountering.

PR: https://github.com/wikimedia/wikipedia-ios/pull/4684

Unfortunately this appears to be a byproduct of Google Translate. For non-English release notes, we use Google Translate. Specifically in this situation, Google Sheet's Google Translate feature (aka =GOOGLETRANSLATE(X,Y,Z)) was used. Oddly, it appears for the original English string, Google Sheet's translation and Google Translate's (translate.google.com) translations are different. Originally as a layer of extra checks, I had ran translated strings that seemed odd back into English through Google Translate, but I suppose I missed this (and as a result, the French Canada region translation).

@ABorbaWMF The build is now available for all testers: the internal App Store Connect users and our external beta tester group.

PR for open_filter_settings action: https://github.com/wikimedia/wikipedia-ios/pull/4678

PR for header link: https://github.com/wikimedia/wikipedia-ios/pull/4677

@ABorbaWMF 7.4.5 (2871) is available to test for internal App Store Connect users, currently waiting for review for release to our external beta testers.

@SNowick_WMF From a quick look, it's looks like the local trigger to log that event may be missing or lost in a previous merge. Will get a PR up tomorrow to address this!

In T349114#9314965, @JTannerWMF wrote:

The Learn more on the onboarding modal should point to https://www.mediawiki.org/wiki/Wikimedia_Apps/iOS_Suggested_edits

Updated links, updated onboarding items and translations, and updated form guidance text and translations are now wrapped. I believe I've addressed everything in this task now, but take a look!

PR: https://github.com/wikimedia/wikipedia-ios/pull/4668

Let's hold off on this refactor until after our Components button work is underway. The decisions from that work will naturally inform the implementation here. Adding as child task to Components Library epic and marking as resolved from outstanding issues for now as it does not change functionality.

Provide users an entry point to update update their languages in the filter view.