User Details
- User Since
- Mar 30 2020, 10:05 PM (148 w, 5 d)
- Availability
- Available
- LDAP User
- Dmantena
- MediaWiki User
- DMantena (WMF) [ Global Accounts ]
Tue, Jan 31
Tue, Jan 24
Mon, Jan 23
@OTichonova Thanks for looking into the logic questions above.
Fri, Jan 20
Wed, Jan 18
Tue, Jan 17
PR (including test steps): https://github.com/wikimedia/wikipedia-ios/pull/4449
Fri, Jan 13
Thu, Jan 12
Mon, Jan 9
Jan 4 2023
Dec 20 2022
Dec 19 2022
Dec 16 2022
Dec 15 2022
Dec 14 2022
Here's my current understanding of how the app's navigation/article state restoration works[1][2]:
Dec 13 2022
Dec 8 2022
Two big clean up tasks remain:
- Convert our remaining Core Data based widgets over to use the new self-sustaining data retrieval pattern that Feature Article uses. There seems to have been in increase in Core Data related SQLite file lock issues that manifest in multiple widgets of the same type on the home screen at the same time sometimes not working.
- Await feedback from Apple Radar about handling images in widgets. There seems to be new enforcement (but no documentation yet) in iOS 16 of image dimensions having maximum sizes in widgets, where exceeding that maximum size prevents a widget from archiving/rendering. We did some preventative work here that resizes POTD images to 1000x1000 max before displaying, but we need to revisit this if we get guidance or documentation from Apple.
Dec 7 2022
Dec 6 2022
Dec 5 2022
Should be resolved as part of https://phabricator.wikimedia.org/T321061
Dec 2 2022
Dec 1 2022
Just wanted to drop a quick note from my current investigation and work on this so far if future Znuny emails come in: the behavior of images in widgets in the previous version of iOS 15 and the current shipping version of iOS 16 have indeed changed. This also explains why the widget gallery doesn't show a placeholder image for the POTD widget. This was unfortunately an undocumented change made by Apple in their OS and not made by us or communicated to us. The good news is we'll have a fix to address this behavior out in a future release of the app.
Nov 21 2022
Our first objective on the engineering side before any potential logic change is made is to audit the existing work to confirm how it currently works and the potential flexibility we have.
Nov 18 2022
Nov 16 2022
Nov 15 2022
Nov 2 2022
Hey @ABorbaWMF, we made some design updates to this vanishing view. Before we ship, we'd like to do some very light regression testing of the view to be sure we didn't break any functionality. The part of the process you don't need to repeat is sending the actual vanishing email itself, but when you're able can you take a look at this on iPhone and iPad? I believe we'd like to prioritize this over other current iOS work as it's currently blocking our release of 6.9.4. The build in TestFlight is 6.9.4 (build 2000).
Nov 1 2022
@OTichonova 6.9.4 (1998) in TestFlight now. In addition to your feedback above, also includes the keyboard show/hide button changes we discussed. When the user taps the Additional information field and the keyboard appears, the button stack disappears. When they finish with the field, the button reappears again. This is in both device orientations.
Oct 31 2022
@OTichonova Updates are coming in an experimental TestFlight build (6.9.4) for you to review! There are some areas in which I had to fight the system's spacing, but if it's still not as expected let me know!
Oct 28 2022
Oct 27 2022
Oct 25 2022
Right! I am with you now, sorry for taking so long to understand the ask.
Oct 21 2022
Oct 20 2022
Oct 18 2022
@OTichonova No worries - sorry, I should have been more clear! Indeed you're right we use yellow50 as a value in app for different UI elements, but it doesn't seem like we have one specific semantic theme element (e.g. baseBackground, warning, etc.) that maps to using yellow50 as the value for each theme (light, dark, black, sepia).
- Sorry, just to clarify, which background color are you referring to?
Oct 17 2022
Currently, we're blocked on this. We're awaiting the trust & safety email address to use in-app.
Hey @OTichonova! Can you confirm the 1. background color and 2. theme element we should be using for the highlighted background shown here? https://phab.wmfusercontent.org/file/data/3nhdayomawj2dopfdjst/PHID-FILE-top6xydb3q2qiobmewwi/Search_primate_.png
Oct 11 2022
Oct 5 2022
Sep 30 2022
Sep 26 2022
Remaining work in topic cells:
- Confirm RTL support
- Confirm VoiceOver support
- Confirm dynamic type support
Sep 14 2022
Talk page engineering work needing updates after this work is implemented:
- Coffee roll container background color
- Talk page view background color
Sep 13 2022
@OTichonova Do you have per theme colors available for the coffee roll background color?