Maniphest T347425

Fix Diff Header Compare View alignment
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

None

Authored By

	Mazevedo
	Sep 26 2023, 7:15 PM

Tags

Referenced Files

	F37805750: iOS Watchlist 10 B.png
	Sep 26 2023, 7:15 PM

	F37805748: Screenshot 2023-09-26 at 16.08.15.png
	Sep 26 2023, 7:15 PM

Subscribers

Description

When side-by-side, if there's no comment to one of the diffs, the compare view items do not align correctly.

Screenshot 2023-09-26 at 16.08.15.png (268×1 px, 55 KB)

All the items should be top-aligned:

iOS Watchlist 10 B.png (1×786 px, 246 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):
7.4.0

Related Objects

Mentioned In: T352818: Release 7.4.6
T347915: [XL] Address outstanding issues for Watchlist

Event Timeline

Mazevedo created this task.Sep 26 2023, 7:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 26 2023, 7:15 PM

JTannerWMF mentioned this in T347915: [XL] Address outstanding issues for Watchlist .Oct 4 2023, 2:41 PM

JTannerWMF triaged this task as Low priority.Oct 4 2023, 3:10 PM

JTannerWMF moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.

JTannerWMF moved this task from Tasks from Product Backlog to Ready for Development on the iOS Release FY2023-24 (Archive) board.Nov 21 2023, 6:37 PM

• Dmantena moved this task from Ready for Development to Needs Code Review on the iOS Release FY2023-24 (Archive) board.Nov 29 2023, 9:23 PM

PR: https://github.com/wikimedia/wikipedia-ios/pull/4684

Tsevener moved this task from Needs Code Review to Waiting for Build on the iOS Release FY2023-24 (Archive) board.Nov 29 2023, 11:11 PM

Can be tested in TestFlight 7.4.6 (2963).

Tsevener moved this task from Waiting for Build to Needs QA on the iOS Release FY2023-24 (Archive) board.Dec 4 2023, 4:00 PM

Tsevener moved this task from Needs QA to Waiting for Build on the iOS Release FY2023-24 (Archive) board.Dec 5 2023, 9:18 PM

Tsevener moved this task from Waiting for Build to Needs QA on the iOS Release FY2023-24 (Archive) board.Dec 6 2023, 1:49 AM

Looks fixed on 7.4.6 (2963)

Tsevener mentioned this in T352818: Release 7.4.6.Dec 11 2023, 7:50 PM

JTannerWMF moved this task from Ready for PM Signoff to Ready for Release on the iOS Release FY2023-24 (Archive) board.Dec 13 2023, 4:45 PM

Tsevener closed this task as Resolved.Dec 14 2023, 6:12 PM