Page MenuHomePhabricator

Add edit summaries to short description edits (iOS)
Closed, ResolvedPublicFeature

Description

Feature summary (what you would like to be able to do and where): When editing or adding short descriptions/article descriptions on the Wikipedia-iOS-App-Backlog there is no option to leave an edit summary and it does not provide an automated summary. Either would be nice.

Use case(s) (list the steps that you performed to discover that problem, and describe the actual underlying problem which you want to solve. Do not describe only a solution): On a Wikipedia article clicking the pen to edit, selecting “Edit article description”, making the edit, and selecting “Publish description.” There is no option to leave an edit summary and the automated summary just leaves a minor edit tag.

Benefits (why should this be implemented?): Either an automated summary (something like “article description” or “short description”) or the ability for me to enter my own summary before publishing would improve the information available to other editors.

Note: This is the first time I’ve used this form. Sorry for any errors.

Edit summaries made through this feature currently show up as #article-add-desc

Eng Notes

We are automatically adding "Updated short description" and "Added short description" to the edit summary for short description edits. See screenshots in https://phabricator.wikimedia.org/T351649#9652090.

Event Timeline

JTannerWMF triaged this task as Medium priority.Nov 21 2023, 5:37 PM
JTannerWMF subscribed.

Thank you for filing this, we are going to prioritize it within the quarter.

Hello! This would be my first contribution to the app - this ticket would solve a problem that has personally bugged me, and I have a good idea how to fix it.

I'm working on a PR at the moment, and I'll try and follow the contribution process, but if I mess up anywhere then I'm sorry for any errors!

HNordeenWMF renamed this task from Add edit summaries to short description edits to Add edit summaries to short description edits (iOS).Mar 12 2024, 12:49 AM
HNordeenWMF removed Philh as the assignee of this task.
HNordeenWMF added a subscriber: Philh.

PR here: https://github.com/wikimedia/wikipedia-ios/pull/4745. Description from PR (emphasis mine):

Notes

  • This is my first PR to this project, so apologies for any errors!
  • This PR uses the existing summary parameter in sectionUploader.uploadWikiText(...) to provide a default edit summary when updating an existing short description
  • Also copies the summary parameter to sectionUploader.prepend(...) for the same purpose, when adding a new short description

Test Steps
Add flow

  • Find an article without a short description
  • Use the "+ Add article description" button to provide a new description
  • View the edit history and see that the edit has a summary "Added short description"

Update flow

  • Find an article with a short description that could be improved
  • Use the Pen button > "Edit article description" to update the description
  • View the edit history and see that the edit has a summary "Updated short description"

Here are some screenshots from my testing:

Screenshot 2024-03-21 at 3.49.06 PM (1×559 px, 250 KB)

Screenshot 2024-03-21 at 3.48.56 PM (1×559 px, 241 KB)

Tsevener updated the task description. (Show Details)