[L] Create explore feed card for Image Recs
Open, LowPublic
Actions

Assigned To

None

Authored By

	Mazevedo
	Feb 6 2024, 10:07 PM

Description

Create the explore feed card according to the Figma reference

Screenshot 2024-02-06 at 19.03.00.png (380×768 px, 62 KB)

Requirements

Card should never be the first on the explore feed
User needs to have at least 50 edits to see the card
Check if the wiki has the suggested edits task before displaying the card
Add the card only once for the Main app language

Related Spike: T355328

Items:

Create card UI
Create displaying logic based on requirements above

Testing

Please test in TestFlight Wikipedia app 7.5.0 (3509).

@ABorbaWMF Note that once we saw the card not appear due to the Explore feed settings toggle being off by default upon first launch. We can no longer repro though. Please keep an eye out for this and let us know if you can get a screen recording of this issue.

Related Objects
Search...

Status	Assigned	Task
Open	None	T344258 [Main Epic] 2023-2024 Enhancements to Editing on the iOS app
Open	None	T355270 [Sub Epic] Image Recommendations - Add an Image on iOS
Open	None	T355271 [Engineering Epic] iOS - Image Recommendations - Add an Image main flow and actions
Open	None	T356811 [L] Create explore feed card for Image Recs

Event Timeline

Mazevedo created this task.Feb 6 2024, 10:07 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 6 2024, 10:07 PM

Mazevedo updated the task description. (Show Details)Feb 6 2024, 10:17 PM

Mazevedo removed a project: Epic.Feb 6 2024, 10:26 PM

Tsevener moved this task from Tasks from Product Backlog to Needs Engineering Sync on the iOS Release FY2023-24 (Archive) board.Feb 12 2024, 10:10 PM

Seddon edited parent tasks, added: T357840: [Engineering Epic] Image Recommendations - Add an Image on iOS; removed: T355270: [Sub Epic] Image Recommendations - Add an Image on iOS .Feb 17 2024, 12:10 AM

Seddon mentioned this in T357840: [Engineering Epic] Image Recommendations - Add an Image on iOS.Feb 17 2024, 1:16 AM

Tsevener updated the task description. (Show Details)Feb 26 2024, 6:32 PM

Seddon mentioned this in T355271: [Engineering Epic] iOS - Image Recommendations - Add an Image main flow and actions.Feb 27 2024, 2:47 PM

Seddon added a parent task: T355271: [Engineering Epic] iOS - Image Recommendations - Add an Image main flow and actions.

Seddon removed a parent task: T357840: [Engineering Epic] Image Recommendations - Add an Image on iOS.Feb 27 2024, 2:53 PM

HNordeenWMF triaged this task as Low priority.Feb 27 2024, 7:27 PM

HNordeenWMF moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.

Tsevener claimed this task.Feb 27 2024, 10:42 PM

Tsevener moved this task from Needs Engineering Sync to Doing on the iOS Release FY2023-24 (Archive) board.

Tsevener renamed this task from [Task] Create explore feed card for Image Recs to [L] Create explore feed card for Image Recs.Feb 28 2024, 4:34 PM

Hi @OTichonova. Since your Suggested Edits explore card mock has the 3-dot-icon for hiding, I'm adding in the ability to hide the card via Explore feed preferences (this seems to match Android as well).

Can you give me an icon, title text, subtitle text, and icon foreground and background colors for this row?

Screenshot 2024-02-28 at 3.53.51 PM (939×497 px, 262 KB)

PR laying groundwork: https://github.com/wikimedia/wikipedia-ios/pull/4767

Tsevener moved this task from Doing to Blocked or Waiting on the iOS Release FY2023-24 (Archive) board.Feb 28 2024, 10:12 PM

For users with multiple language wikis in their app, how does it generally work with displaying Suggested Edits cards? For example if they only had rights on German Wikipedia, but had English enabled as well: Would we add a "From German Wikipedia" subtitle below the title of Suggested edits card in the explore feed?

Screenshot 2024-03-01 at 11.20.42.jpeg (327×1 px, 131 KB)

In T356811#9585627, @Tsevener wrote:

Can you give me an icon, title text, subtitle text, and icon foreground and background colors for this row?

Hi @Tsevener
I realized that the page looks slightly different if one has a single 'Wikipedia language' or multiple 'Wikipedia languages' in the app.

Single language	Multiple languages
{F42400611}	{F42400613}
{F42400516}	{F42400519}

Icon: OOUI pencil

Icon color: blue600
Background color: blue100

Title: Suggested edits
Subtitle text for single language: Suggestions to add content to Wikipedia
Subtitle text for multiple languages: Not language specific

In T356811#9591633, @HNordeenWMF wrote:

For users with multiple language wikis in their app, how does it generally work with displaying Suggested Edits cards? For example if they only had rights on German Wikipedia, but had English enabled as well: Would we add a "From German Wikipedia" subtitle below the title of Suggested edits card in the explore feed?

I asked Android about this. They display a single Suggested Edits card per "day" of the feed, and it's for the primary language of the app. So it's sort of language-specific in that it's only suggesting things against the primary app language, but it's not language-specific in that you do not see additional suggested edits cards per language in the feed. I don't think Android shows any language indicator in their Explore card.

Mazevedo updated the task description. (Show Details)Mar 5 2024, 7:30 PM

Tsevener moved this task from Blocked or Waiting to Doing on the iOS Release FY2023-24 (Archive) board.Mar 5 2024, 8:40 PM

Seddon moved this task from Engineering Backlog to iOS Release FY2023-24 on the Wikipedia-iOS-App-Backlog board.Mar 8 2024, 10:45 AM

Seddon edited projects, added Wikipedia-iOS-App-Backlog (iOS Release FY2023-24); removed Wikipedia-iOS-App-Backlog.

Seddon moved this task from Tasks from Product Backlog to Doing on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.Mar 8 2024, 11:04 AM

PR: https://github.com/wikimedia/wikipedia-ios/pull/4775

@OTichonova I kicked off an Experimental build #88 for design review.

Tsevener removed Tsevener as the assignee of this task.Mar 8 2024, 9:06 PM

Tsevener updated the task description. (Show Details)

Tsevener moved this task from Doing to Needs Design Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.

Tsevener subscribed.

Hi @Tsevener, it is looking good. 1 small tweak. I realized now that the header size in the other cards is 16pts (Callout) not 15pts (Subhead). Could the header text inside the card -> 'Add an image' be increased to 16pts (Callout)? Sorry about that.

Additionally, when I set Arabic as my primary language or Hebrew the card doesn't show up in the experimental build 88, should I be testing RTL in a different experimental build?

cc @Mazevedo

OTichonova moved this task from Needs Design Review to Ready for Development on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.Mar 12 2024, 10:25 PM

@OTichonova My guess is that you don't have 50+ edits on those wikis. Here are some screenshots from temporarily removing that requirement:

LTR device language, RTL app primary language: