[S] Update "Add image details" screen for Image Recs
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	HNordeenWMF
	Mar 1 2024, 9:54 PM

Description

Note: We'll reuse the existing "Add image details" view from the existing insert image wizard.

InsertMediaViewController

We'll need to updated the UI according to the Figma reference.
Both places will use the new updated UI, according to the information available in each flow.

Requirements

When no information is added people may tap 'Next' but it is not progressive.
Once caption and/or alt text is added the 'Next' button becomes progressive.
Text entry expands to display all entered text (same behavior as "Add image details" view from the existing insert image wizard.)

Nice to have: meet additional relevant requirements from Alt text Epic T357437 requirements

Warning when alt-text exceeds 125 characters
Do not allow users to copy and paste in image caption

Testing

Please test in TestFlight Wikipedia app 7.5.0 (3509).

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		None	T344258 [Main Epic] 2023-2024 Enhancements to Editing on the iOS app
Resolved		None	T355270 [Sub Epic] Image Recommendations - Add an Image on iOS
Resolved		None	T355271 [Engineering Epic] iOS - Image Recommendations - Add an Image main flow and actions
Resolved		HNordeenWMF	T358917 [S] Update "Add image details" screen for Image Recs
Declined		None	T358918 [M] Create view model - all the data handling for Image Recs
Declined		None	T358919 [M] Update UI fro existing "Add image details" screen
Resolved	BUG REPORT	HNordeenWMF	T363944 Markdown shown in image description of "Add image details"

Event Timeline

HNordeenWMF created this task.Mar 1 2024, 9:54 PM

HNordeenWMF updated the task description. (Show Details)

HNordeenWMF updated the task description. (Show Details)Mar 1 2024, 10:13 PM

HNordeenWMF updated the task description. (Show Details)Mar 1 2024, 10:16 PM

HNordeenWMF mentioned this in T355271: [Engineering Epic] iOS - Image Recommendations - Add an Image main flow and actions.Mar 2 2024, 12:02 AM

Mazevedo updated the task description. (Show Details)Mar 4 2024, 5:07 PM

Mazevedo closed subtask T358918: [M] Create view model - all the data handling for Image Recs as Declined.Mar 4 2024, 5:09 PM

Mazevedo mentioned this in T358918: [M] Create view model - all the data handling for Image Recs.

Mazevedo closed subtask T358919: [M] Update UI fro existing "Add image details" screen as Declined.

Mazevedo mentioned this in T358919: [M] Update UI fro existing "Add image details" screen.

Seddon moved this task from Tasks from Product Backlog to Needs Engineering Sync on the iOS Release FY2023-24 (Archive) board.Mar 5 2024, 2:40 PM

Mazevedo renamed this task from [L] Create "Add image details" screen for Image Recs to [L] Update "Add image details" screen for Image Recs.Mar 5 2024, 2:47 PM

JTannerWMF triaged this task as High priority.Mar 5 2024, 3:53 PM

Tsevener renamed this task from [L] Update "Add image details" screen for Image Recs to Update "Add image details" screen for Image Recs.Mar 5 2024, 4:55 PM

Tsevener renamed this task from Update "Add image details" screen for Image Recs to [S] Update "Add image details" screen for Image Recs.Mar 5 2024, 6:21 PM

Tsevener moved this task from Needs Engineering Sync to Ready for Development on the iOS Release FY2023-24 (Archive) board.Mar 5 2024, 6:33 PM

JTannerWMF moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.Mar 5 2024, 7:14 PM

Tsevener mentioned this in T359225: [S] Image Recommendation - Data transition to preview.Mar 5 2024, 11:03 PM

Seddon moved this task from Engineering Backlog to iOS Release FY2023-24 on the Wikipedia-iOS-App-Backlog board.Mar 8 2024, 10:45 AM

Seddon edited projects, added Wikipedia-iOS-App-Backlog (iOS Release FY2023-24); removed Wikipedia-iOS-App-Backlog.

Seddon moved this task from Tasks from Product Backlog to Ready for Development on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.Mar 8 2024, 11:05 AM

Mazevedo claimed this task.Mar 15 2024, 6:49 PM

Mazevedo moved this task from Ready for Development to Doing on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.

HNordeenWMF mentioned this in T360035: [S] Suppress VoiceOver support for Image Recs.Mar 18 2024, 10:38 PM

HNordeenWMF updated the task description. (Show Details)Mar 20 2024, 2:31 PM

HNordeenWMF updated the task description. (Show Details)Mar 20 2024, 2:35 PM

HNordeenWMF updated the task description. (Show Details)

HNordeenWMF updated the task description. (Show Details)Mar 20 2024, 2:42 PM

HNordeenWMF updated the task description. (Show Details)Mar 20 2024, 5:22 PM

Updated the task to remove the requirement of bringing over alt-text. For this feature we want to just maintain parity with Android and Growth

If it is possible to reuse the screen from the native editor when adding an image from commons feel free to do so the only change is Next being greyed out when a caption is not written (but still allow folks to move forward).

Hi @HNordeenWMF Do you have the links for the 'Learn More" buttons (caption and alt-text?) Also, would you prefer the links to be opened in-app or kick the user out to their browser?

PR https://github.com/wikimedia/wikipedia-ios/pull/4788

@Mazevedo Android links to : https://www.mediawiki.org/wiki/Help:Images, but that doesn't have information about Captions & Alt Text, so I would like it to link to the FAQ Page:

Link for Captions: https://www.mediawiki.org/wiki/Wikimedia_Apps/iOS_Suggested_edits#Image_captions
Link for Alt Text: https://www.mediawiki.org/wiki/Wikimedia_Apps/iOS_Suggested_edits#Tips_for_creating_alt-text
Opened in-app please (matching behavior of "Learn more about minor edits" link).

Mazevedo moved this task from Doing to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.Mar 25 2024, 6:31 PM

tonisevener closed https://github.com/wikimedia/wikipedia-ios/pull/4788

Tsevener removed Mazevedo as the assignee of this task.Mar 26 2024, 11:08 PM

Tsevener moved this task from Needs Code Review to Waiting for Build on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.

Tsevener updated the task description. (Show Details)Apr 16 2024, 2:13 PM

Tsevener moved this task from Waiting for Build to Needs QA on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.

Tsevener mentioned this in T358933: [M] Image Recommendations - Fetch images in WKData.Apr 16 2024, 2:17 PM

Tsevener updated the task description. (Show Details)Apr 26 2024, 3:19 PM

Appears to be ready on on 7.5.0 (3525)

Note for future selves that we did not implement the Nice-to-haves in this task, we'll revisit with Alt text experiment.

HNordeenWMF closed subtask T363944: Markdown shown in image description of "Add image details" as Unknown Status.May 7 2024, 3:42 PM

HNordeenWMF closed this task as Unknown Status.May 7 2024, 3:45 PM

HNordeenWMF claimed this task.

HNordeenWMF changed the task status from Unknown Status to Resolved.May 7 2024, 10:17 PM

HNordeenWMF changed the status of subtask T363944: Markdown shown in image description of "Add image details" from Unknown Status to Resolved.

HNordeenWMF mentioned this in T377887: [S] Add an image & native editor image flow help links should lead to translated MediaWiki page.Oct 22 2024, 7:08 PM

[S] Update "Add image details" screen for Image RecsClosed, ResolvedPublicActions