Once Image Recommendations is in Test Flight and available to beta testers, test and validate instrumentation.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T344258 [Main Epic] 2023-2024 Enhancements to Editing on the iOS app | |||
| Resolved | None | T355270 [Sub Epic] Image Recommendations - Add an Image on iOS | |||
| Resolved | HNordeenWMF | T359131 [M] Create schema docs and instrumentation plan for iOS Image Recs | |||
| Resolved | HNordeenWMF | T362723 Data Validation for iOS Image Recs |
Event Timeline
Comment Actions
Other external TestFlight beta builds: TestFlight 7.5.0 (3525) and TestFlight 7.5.0 (3511).
Comment Actions
Validating we are seeing almost all events, full action_data for successful edits and edit events tracked in editattemptstep
I am not seeing the following events yet:
| action | active_interface |
|---|---|
|view_edit_help| editsummary_dialog
|view_watchlist_help| editsummary_dialog
|impression|nosuggestions_dialog (I am seeing nosuggestions_back action, so this should be firing too)
Comment Actions
@SNowick_WMF Thanks! I made a PR to fix the missing impression event. I was able to trigger view_edit_help and view_watchlist_help, so maybe beta testers aren't tapping those buttons?
Comment Actions
Hi @SNowick_WMF , could you please plan to validate that Watchlist Toggle instrumentation change as well in this task? https://github.com/wikimedia/wikipedia-ios/pull/4840
Thanks!
Comment Actions
Validating we are seeing prior missing events from above:
| action | active_interface |
|---|---|
| view_edit_help | editsummary_dialog |
| view_watchlist_help | editsummary_dialog |
| impression | nosuggestions_dialog |
Comment Actions
@Tsevener I am re-opening this so we can investigate an issue I found in edit data while doing 15 Day Image Rec analysis - we can discuss in App Data meeting.
Details:
While querying for Image Rec edits I ran into 74 edits where we had revision_ids in our android_image_recommendation_event data that I couldn't match in data from my regular mediawiki_historyquery that looks for ios app edit in the revision_tags column.
I pulled the edit data by the revision_id from android_image_recommendation_event and found that for all of these edits there was no ios app edit value in the revision_tags - the column only showed ['mobile edit', 'mobile app edit'] - these were known iOS app edits (with Added image, etc. in event_comment for most of them) but for some reason they weren't properly attributed as ios app edit- this happened across multiple wikis:
| wiki | rev_id (Count Unique) |
|---|---|
| enwiki | 63 |
| dewiki | 5 |
| cawiki | 2 |
| frwiki | 2 |
| itwiki | 1 |
| trwiki | 1 |
Comment Actions
Change #1039302 had a related patch set uploaded (by Dbrant; author: Dbrant):
[mediawiki/extensions/MobileApp@master] Look for iPadOS in user-agent, in addition to iOS.
Comment Actions
Patch looks good, I tested with both iPhone and iPad user agents. I tried to test a Vision Pro user agent, but I could not get my Vision Pro simulator to appear for testing.
Comment Actions
Change #1039302 merged by jenkins-bot:
[mediawiki/extensions/MobileApp@master] Look for iPadOS in user-agent, in addition to iOS.
Comment Actions
Change #1043110 had a related patch set uploaded (by Dbrant; author: Dbrant):
[mediawiki/extensions/MobileApp@wmf/1.43.0-wmf.9] Look for iPadOS in user-agent, in addition to iOS.
Comment Actions
Change #1043110 merged by jenkins-bot:
[mediawiki/extensions/MobileApp@wmf/1.43.0-wmf.9] Look for iPadOS in user-agent, in addition to iOS.
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2024-06-13T21:01:43Z] <jsn@deploy1002> Started scap: Backport for [[gerrit:1043110|Look for iPadOS in user-agent, in addition to iOS. (T362723)]]
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2024-06-13T21:04:09Z] <jsn@deploy1002> dbrant, jsn: Backport for [[gerrit:1043110|Look for iPadOS in user-agent, in addition to iOS. (T362723)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2024-06-13T21:15:54Z] <jsn@deploy1002> Finished scap: Backport for [[gerrit:1043110|Look for iPadOS in user-agent, in addition to iOS. (T362723)]] (duration: 14m 11s)