Page MenuHomePhabricator
Create Task
Maniphest T357983

Mobile font size and line-height changes only applied to <p> elements
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
ovasileva
Authored By
Pcoombe
Feb 20 2024, 2:11 PM
Tags
Referenced Files
F42001976: en.m.wikipedia.org_wiki_Talk_Super_Bowl_LVIII(iPhone 12 Pro).png
Feb 20 2024, 2:11 PM
F42001968: en.m.wikipedia.org_wiki_Super_Bowl_LVIII(iPhone 12 Pro).png
Feb 20 2024, 2:11 PM
F42001961: en.m.wikipedia.org_wiki_Main_Page(iPhone 12 Pro).png
Feb 20 2024, 2:11 PM
Subscribers
Aklapper
CX_Zoom
Edtadros
EWilfong_WMF
Frostly
Jdlrobson
JScherer-WMF
View All 9 Subscribers

Description

Apologies if this has already been reported, but I think this is separate from the issues in T357724 and T357770. The line-height changes and mobile font size setting only seem to apply to <p> elements. This leads to inconsistent appearance, most noticeable if Font size is set to anything other than "Small". Some examples:

en.wikipedia Main Page: "Today's featured article" blurb is larger than "In the news" and other lists

en.m.wikipedia.org_wiki_Main_Page(iPhone 12 Pro).png (2×1 px, 712 KB)

Lists in articles (example from https://en.m.wikipedia.org/wiki/Super_Bowl_LVIII#International)

en.m.wikipedia.org_wiki_Super_Bowl_LVIII(iPhone 12 Pro).png (2×1 px, 506 KB)

Talk pages: Top level messages are larger than replies (example from https://en.m.wikipedia.org/wiki/Talk:Super_Bowl_LVIII)

en.m.wikipedia.org_wiki_Talk_Super_Bowl_LVIII(iPhone 12 Pro).png (2×1 px, 449 KB)

Note this isn't an issue for the desktop font size setting beta feature, is it possible to use that approach on mobile instead?

Details

SubjectRepoBranchLines +/-
Revert line height in "Standard" mode, apply to all content in othermediawiki/extensions/MobileFrontendmaster+8 -5
Customize query in gerrit

Related Objects

Event Timeline

Pcoombe created this task.Feb 20 2024, 2:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 20 2024, 2:11 PM
Jdlrobson added a project: Web-Team-Backlog (FY2023-24 Q3 Sprint 3).Feb 20 2024, 5:09 PM
ovasileva subscribed.Feb 20 2024, 5:43 PM
ovasileva triaged this task as High priority.Feb 20 2024, 5:46 PM
ovasileva added a project: FY2023-24-WE 2.1 Typography and palette customizations.
ovasileva assigned this task to JScherer-WMF.Feb 20 2024, 5:52 PM
Jdlrobson moved this task from Incoming to Doing on the Web-Team-Backlog (FY2023-24 Q3 Sprint 3) board.Feb 20 2024, 11:03 PM
CX_Zoom subscribed.Feb 21 2024, 4:45 AM
EWilfong_WMF subscribed.Feb 21 2024, 5:55 PM
JScherer-WMF moved this task from Doing to Ready for Development on the Web-Team-Backlog (FY2023-24 Q3 Sprint 3) board.Feb 22 2024, 5:26 PM
JScherer-WMF removed JScherer-WMF as the assignee of this task.Feb 22 2024, 5:48 PM
JScherer-WMF subscribed.

Thanks for reporting this @Pcoombe !

Font size should not change from the default font size for the elements. Line height params should be applied to lists as well as <p> elements.

Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 4); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 3).Feb 22 2024, 5:57 PM
Frostly subscribed.Feb 23 2024, 7:09 PM
Jdlrobson moved this task from Backlog to Night mode (mobile) on the FY2023-24-WE 2.1 Typography and palette customizations board.Feb 24 2024, 12:37 AM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 5); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 4).Feb 26 2024, 6:40 PM
Jdlrobson subscribed.

@JScherer-WMF I think this should be revidsed given T358498 ?

JScherer-WMF added a comment.Feb 26 2024, 6:52 PM
In T357983#9577674, @Jdlrobson wrote:

@JScherer-WMF I think this should be revidsed given T358498 ?

I don't think so. The bug still exists. Regardless of the line height, it should apply equally to <p> elements and <li>s, etc.

Jdlrobson added a comment.Feb 26 2024, 8:10 PM

The proposed fix in T358498 will apply the line-height to all content. It would be trivial for me to apply the 1.5 line height to all content in font size medium and large as part of this change if you like

gerritbot added a comment.Feb 26 2024, 8:14 PM

Change 1006580 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Revert line height in "Standard" mode, apply to all content in other

https://gerrit.wikimedia.org/r/1006580

gerritbot added a project: Patch-For-Review.Feb 26 2024, 8:14 PM
gerritbot added a comment.Feb 26 2024, 9:47 PM

Change 1006580 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Revert line height in "Standard" mode, apply to all content in other

https://gerrit.wikimedia.org/r/1006580

Maintenance_bot removed a project: Patch-For-Review.Feb 26 2024, 10:31 PM
Jdlrobson assigned this task to JScherer-WMF.Feb 29 2024, 4:32 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 4); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 5).

This should be resolved on the beta cluster. Do you want to take a look?

Jdlrobson moved this task from Incoming to Design Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 4) board.Feb 29 2024, 4:33 PM
JScherer-WMF removed JScherer-WMF as the assignee of this task.Feb 29 2024, 8:33 PM
JScherer-WMF moved this task from Design Review to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 4) board.
JScherer-WMF added a subscriber: Edtadros.

Looks good to me. Putting up for grabs and moving to QA in case @Edtadros wants to look at it as well before sign off.

ovasileva claimed this task.Mar 4 2024, 6:15 PM
ovasileva moved this task from QA to Ready for Signoff on the Web-Team-Backlog (FY2023-24 Q3 Sprint 4) board.
ovasileva closed this task as Resolved.Mar 8 2024, 1:59 PM

Signing off.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL