Page MenuHomePhabricator

Accessibility settings menu should default to open for all logged-in and logged-out users
Closed, ResolvedPublic2 Estimated Story Points

Description

Steps to reproduce

  1. Go to https://en.wikipedia.org/wiki/Main_Page?vectorclientpreferences=1 as a logged-out user

Expected results

  • Client preferences menu should default to unpinned for both logged-in and logged-out users

Actual results

  • Client preferences menu defaults to pinned (under the eyeglass logo at the top of the page)

Check any additional observations

NOTE: let's make sure we test defaults for both logged-in and logged-out before closing

Signoff criteria

  • Create spike on making the decision on whether we should load the menu on pageload

QA Results - Beta

ACStatusDetails
1T360099#9685791
2T360099#9685791

QA Results - Prod

ACStatusDetails
1T360099#9686775
2T360099#9686775

Event Timeline

ovasileva created this task.
ovasileva set the point value for this task to 2.Mar 14 2024, 5:40 PM

Change #1015453 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/Vector@master] Accessibility settings menu should default to open for all users

https://gerrit.wikimedia.org/r/1015453

Change #1015453 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Accessibility settings menu should default to open for all users

https://gerrit.wikimedia.org/r/1015453

I've reviewed the patch and can confirm it meets criteria set out in the descriptione. Noting that the menu's state does not persist which is consistent with the main menu but wanted to check @ovasileva and @JScherer-WMF are not expecting that?

Create spike on making the decision on whether we should load the menu on pageload

I believe this is already covered in T351562.

Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page?vectorclientpreferences=1 as a logged-out user

✅ AC1: Client preferences menu should default to unpinned for logged-out users

screenshot 162.png (826×1 px, 165 KB)

Go to https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page?vectorclientpreferences=1 as a logged-in user
✅ AC2: Client preferences menu should default to unpinned for both logged-in
//to validate this I used a user that I haven't used for a long time so the previous setting (pinned/unpinned) would not impact the test)

screenshot 163.png (826×1 px, 200 KB)

Test Result - Prod

Status: ✅ PASS
Environment: cawiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to https://ca.wikipedia.org/w/index.php?title=Portada&vectorclientpreferences=1 as a logged-out user

✅ AC1: Client preferences menu should default to unpinned for logged-out users

screenshot 177.png (967×1 px, 905 KB)

Go to https://ca.wikipedia.org/w/index.php?title=Portada&vectorclientpreferences=1 as a logged-in user
✅ AC2: Client preferences menu should default to unpinned for both logged-in
//to validate this I used a user that I haven't used for a long time so the previous setting (pinned/unpinned) would not impact the test)

screenshot 178.png (967×1 px, 698 KB)

bwang claimed this task.