Page MenuHomePhabricator
Create Task
Maniphest T362808

Rename "client preferences menu" to "appearances menu"
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
None
Authored By
bwang
Wed, Apr 17, 5:12 PM
Tags
Referenced Files
F49377472: screenshot 52.mov.gif
Tue, Apr 30, 2:46 AM
F49377448: screenshot 51.mov.gif
Tue, Apr 30, 2:46 AM
F49377422: screenshot 50.mov.gif
Tue, Apr 30, 2:46 AM
F49372115: screenshot 49.mov.gif
Tue, Apr 30, 2:46 AM
F49371077: screenshot 48.mov.gif
Tue, Apr 30, 2:46 AM
F49369395: screenshot 271.png
Tue, Apr 30, 2:46 AM
F49370005: screenshot 272.png
Tue, Apr 30, 2:46 AM
Subscribers
Aklapper
bwang
Edtadros
Jdlrobson
KSarabia-WMF
SToyofuku-WMF

Description

Description

Per Slack thread: https://wikimedia.slack.com/archives/G8QAPHCTT/p1712787742192229
The name is confusing when client prefs is the way we are saving preferences (similar to user preferences), and it is something that will be used for many things other than the "appearance" menu that contains theme, width, font size, etc. One example of this confusion is the vector-feature-client-prefs-pinned-clientpref-1 class

We want to change this before the release to anonymous users.

User story

No impact on end user. Improves developer experience and maintainability long term. Also aligns code with product naming convention

AC

  • Rename ClientPreference Feature flags and classes
  • Rename ClientPreferencePinned Feature flags and classes
  • Rename vector-client-prefs-pinned to vector-appearance-pinned

QA steps

On beta cluster (check the environment is ready with a developer before starting)

  • As logged in user, after disabling beta preference for Vector, I should not see the appearance menu in the UI
  • When beta feature is enabled the appearance menu should show.
  • check that you can pin the appearances menu. ON page refresh it should remain in the previous state you left it.
  • Refresh and confirm it is still pinned.
  • As anonymous user (using ?vectorappearance=1), check that you can pin the appearances menu. ON page refresh it should remain in the previous state you left it.
  • Unpin the menu and refresh.

Communication criteria - does this need an announcement or discussion?

no

QA Results - Beta

ACStatusDetails
1✅T362808#9756158
2✅T362808#9756158
3✅T362808#9756158
4✅T362808#9756158
5✅T362808#9756158
6✅T362808#9756158
7✅T362808#9756158

Details

SubjectRepoBranchLines +/-
Rename client preference menu to appearance menumediawiki/skins/Vectorwmf/1.42.0-wmf.2+1 K -3
Rename client preference menu to appearance menumediawiki/skins/Vectormaster+99 -108
Update wgVectorClientPrefs to wgVectorAppearanceoperations/mediawiki-configmaster+8 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

bwang created this task.Wed, Apr 17, 5:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Apr 17, 5:12 PM
ovasileva triaged this task as High priority.Thu, Apr 18, 11:22 AM
ovasileva added a project: FY2023-24-WE 2.1 Typography and palette customizations.
ovasileva added a parent task: T360097: [goal] Deploy reading accessibility settings menu and new typography defaults on desktop .
SToyofuku-WMF subscribed.Thu, Apr 18, 6:17 PM

@bwang to update task description to use new template

Jdlrobson updated the task description. (Show Details)Thu, Apr 18, 6:20 PM
gerritbot added a comment.Thu, Apr 18, 6:23 PM

Change #1019142 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Rename client preference menu to appearance menu

https://gerrit.wikimedia.org/r/1019142

gerritbot added a project: Patch-For-Review.Thu, Apr 18, 6:23 PM
SToyofuku-WMF set the point value for this task to 3.Thu, Apr 18, 6:24 PM
SToyofuku-WMF moved this task from Backlog to Ready for Development on the Web-Team-Backlog (FY2023-24 Q4 Sprint 2) board.
bwang moved this task from Ready for Development to Code Review on the Web-Team-Backlog (FY2023-24 Q4 Sprint 2) board.Mon, Apr 22, 5:26 PM
ovasileva moved this task from Code Review to Needs More Work on the Web-Team-Backlog (FY2023-24 Q4 Sprint 2) board.Tue, Apr 23, 4:55 PM
ovasileva moved this task from Needs More Work to Code Review on the Web-Team-Backlog (FY2023-24 Q4 Sprint 2) board.
Jdlrobson assigned this task to KSarabia-WMF.Tue, Apr 23, 5:29 PM
bwang updated the task description. (Show Details)Wed, Apr 24, 3:56 PM
bwang updated the task description. (Show Details)
gerritbot added a comment.Wed, Apr 24, 5:55 PM

Change #1023928 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[operations/mediawiki-config@master] Update wgVectorClientPrefs to wgVectorAppearance

https://gerrit.wikimedia.org/r/1023928

Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (FY2023-24 Q4 Sprint 2) board.Thu, Apr 25, 7:02 PM
bwang reassigned this task from KSarabia-WMF to Jdlrobson.Fri, Apr 26, 8:02 PM
bwang moved this task from Needs More Work to Code Review on the Web-Team-Backlog (FY2023-24 Q4 Sprint 2) board.
bwang added a subscriber: KSarabia-WMF.
Jdlrobson mentioned this in T362911: Exception handling for appearance settings (font-size and width) - Vector.Mon, Apr 29, 5:46 PM
Jdlrobson mentioned this in T362147: Deploy reading accessibility settings menu and new typography defaults to first set of wikis.
Jdlrobson updated the task description. (Show Details)Mon, Apr 29, 7:30 PM
Jdlrobson updated the task description. (Show Details)Mon, Apr 29, 7:32 PM
gerritbot added a comment.Mon, Apr 29, 8:41 PM

Change #1019142 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Rename client preference menu to appearance menu

https://gerrit.wikimedia.org/r/1019142

Jdlrobson reassigned this task from Jdlrobson to Edtadros.Mon, Apr 29, 8:44 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (FY2023-24 Q4 Sprint 2) board.
Jdlrobson subscribed.
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.3; 2024-04-30).Mon, Apr 29, 9:00 PM
gerritbot added a comment.Mon, Apr 29, 11:49 PM

Change #1025319 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/Vector@wmf/1.42.0-wmf.2] Rename client preference menu to appearance menu

https://gerrit.wikimedia.org/r/1025319

gerritbot added a comment.Mon, Apr 29, 11:49 PM

Change #1025319 abandoned by Jdlrobson:

[mediawiki/skins/Vector@wmf/1.42.0-wmf.2] Rename client preference menu to appearance menu

Reason:

https://gerrit.wikimedia.org/r/1025319

Edtadros removed Edtadros as the assignee of this task.Tue, Apr 30, 2:46 AM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog (FY2023-24 Q4 Sprint 2) board.
Edtadros subscribed.

@Jdlrobson / @bwang / @KSarabia-WMF This passes.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

Test Steps

On beta cluster (check the environment is ready with a developer before starting)

✅ AC1: As logged in user, after disabling beta preference for Vector, I should not see the appearance menu in the UI

screenshot 272.png (1×1 px, 194 KB)

✅ AC2: When beta feature is enabled the appearance menu should show.

screenshot 271.png (1×1 px, 200 KB)

✅ AC3: check that you can pin the appearances menu.

screenshot 48.mov.gif (1×1 px, 730 KB)

✅ AC4: ON page refresh it should remain in the previous state you left it. Refresh and confirm it is still pinned.

screenshot 49.mov.gif (1×1 px, 1 MB)

✅ AC5: As anonymous user (using ?vectorappearance=1), check that you can pin the appearances menu.

screenshot 50.mov.gif (486×1 px, 433 KB)

✅ AC6: ON page refresh it should remain in the previous state you left it.

screenshot 51.mov.gif (486×1 px, 560 KB)

✅ AC7: Unpin the menu and refresh.

screenshot 52.mov.gif (486×1 px, 477 KB)

Edtadros updated the task description. (Show Details)Tue, Apr 30, 2:47 AM
Edtadros updated the task description. (Show Details)
Jdlrobson closed this task as Resolved.Tue, Apr 30, 5:04 PM
Jdlrobson updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL