Page issues as rendered in article is not compatible with night mode
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Feb 9 2024, 9:19 PM

Description

Steps to replicate the issue (include links if applicable):

go to https://en.m.wikipedia.org/wiki/Gambling_in_the_United_States?minervanightmode=1

What happens?:
Light theme

What should have happened instead?:
Night theme

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Results - Beta

AC	Status	Details
1	✅	T357179#9552495

QA Results - Prod

AC	Status	Details
1	✅	T357179#9570871

Additional QA cases for production

https://en.m.wikipedia.org/wiki/YouTube?oldid=1209435813&minervanightmode=1#Moderation_and_offensive_content

Details

Other Assignee: bwang

	Subject	Repo	Branch	Lines +/-
	Flip page issue background color	mediawiki/skins/MinervaNeue	master	+2 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		Jdrewniak	T341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations
Open		Jdrewniak	T341632 [EPIC] Palette customizations and dark mode
Open		ovasileva	T354835 [epic] Release night mode as a beta feature on desktop and mobile
Resolved		Jdlrobson	T354836 [goal] Allow desktop and mobile page chrome to appear in night mode ahead of beta release
Open		ovasileva	T354843 [Night mode] Make all open-by-default global navigation appear in night mode on mobile
Resolved	BUG REPORT	ovasileva	T357179 Page issues as rendered in article is not compatible with night mode
Open		ovasileva	T358192 [Bug] Page issues icon disappearing on click

Event Timeline

Jdlrobson created this task.Feb 9 2024, 9:19 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptFeb 9 2024, 9:19 PM

ovasileva triaged this task as High priority.Feb 12 2024, 1:36 PM

ovasileva added a parent task: T354843: [Night mode] Make all open-by-default global navigation appear in night mode on mobile.

ovasileva subscribed.

Jdlrobson renamed this task from Page issues not compatible with night mode to Page issues as rendered in article is not compatible with night mode.Feb 12 2024, 6:39 PM

Jdlrobson set the point value for this task to 2.Feb 12 2024, 6:42 PM

Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (FY2023-24 Q3 Sprint 3) board.

bwang claimed this task.Feb 12 2024, 9:10 PM

bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (FY2023-24 Q3 Sprint 3) board.

@JScherer-WMF Looks like we need an inverted version of --background-color-interactive-subtle: #f8f9fa;. What do you recommend I use for now?

Edit: nevermind, jon pointed me towards https://phabricator.wikimedia.org/T356825

bwang moved this task from Doing to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 3) board.Feb 13 2024, 5:05 PM

Change 1003025 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/MinervaNeue@master] Flip page issue background color

https://gerrit.wikimedia.org/r/1003025

gerritbot added a project: Patch-For-Review.Feb 13 2024, 5:11 PM

bwang removed bwang as the assignee of this task.Feb 13 2024, 5:41 PM

bwang subscribed.

Jdlrobson claimed this task.Feb 13 2024, 5:41 PM

• Mabualruz updated Other Assignee, added: bwang.Feb 13 2024, 5:47 PM

Change 1003025 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Flip page issue background color

https://gerrit.wikimedia.org/r/1003025

Jdlrobson reassigned this task from Jdlrobson to Edtadros.Feb 13 2024, 9:47 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 3) board.

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.19; 2024-02-20).Feb 13 2024, 10:01 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 13 2024, 10:30 PM

Jdlrobson moved this task from Backlog to Night mode (mobile) on the FY2023-24-WE 2.1 Typography and palette customizations board.Feb 15 2024, 6:34 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to a page with a Page Issues notice using the ?minervanightmode=1 param. For example: https://en.m.wikipedia.beta.wmflabs.org/wiki/Amateur_geology?minervanightmode=1
✅ AC1: The page issues notice should be in night mode.

Edtadros updated the task description. (Show Details)Feb 16 2024, 11:48 PM

Experiencing something weird here. If I click on the notice, and then go back to the page, the icons become invisible. Is this expected? Also, perhaps we should test across a number of different page issues when we're doing the production testing. cc @Edtadros

@ovasileva appears to happen on master. Could you open a new bug for us to estimate on Thursday?

Jdlrobson updated the task description. (Show Details)Feb 21 2024, 11:14 PM

Jdlrobson merged a task: T357733: Color Contrast Issue in ambox.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a subscriber: KSarabia-WMF.

@ovasileva reminder to open a bug before tomorrow for estimation - please delegate if you don't have time!

ovasileva closed this task as Resolved.Feb 22 2024, 10:02 AM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to a page with a Page Issues notice using the ?minervanightmode=1 param.
✅ AC1: The page issues notice should be in night mode.
I was able to reproduce the disappearing icons.
https://en.m.wikipedia.org/wiki/Gambling_in_the_United_States?minervanightmode=1