| Jdlrobson | |
| Feb 9 2024, 9:19 PM |
| F42053595: screenshot 283.mov.gif | |
| Feb 23 2024, 2:00 AM |
| F42053573: screenshot 282.mov.gif | |
| Feb 23 2024, 2:00 AM |
| F41936330: screenshot 527.png | |
| Feb 16 2024, 11:48 PM |
Steps to replicate the issue (include links if applicable):
What happens?:
Light theme
What should have happened instead?:
Night theme
Software version (skip for WMF-hosted wikis like Wikipedia):
Other information (browser name/version, screenshots, etc.):
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T357179#9552495 |
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T357179#9570871 |
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Flip page issue background color | mediawiki/skins/MinervaNeue | master | +2 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | ovasileva | T341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations | |||
| Resolved | ovasileva | T341632 [EPIC] Palette customizations and dark mode | |||
| Resolved | ovasileva | T354835 [epic] Release night mode as a beta feature on desktop and mobile | |||
| Resolved | Jdlrobson | T354836 [goal] Allow desktop and mobile page chrome to appear in night mode ahead of beta release | |||
| Resolved | ovasileva | T354843 [Night mode] Make all open-by-default global navigation appear in night mode on mobile | |||
| Resolved | BUG REPORT | ovasileva | T357179 Page issues as rendered in article is not compatible with night mode |
@JScherer-WMF Looks like we need an inverted version of --background-color-interactive-subtle: #f8f9fa;. What do you recommend I use for now?
Edit: nevermind, jon pointed me towards https://phabricator.wikimedia.org/T356825
Change 1003025 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/skins/MinervaNeue@master] Flip page issue background color
Change 1003025 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Flip page issue background color
Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA
Test Artifact(s):
Go to a page with a Page Issues notice using the ?minervanightmode=1 param. For example: https://en.m.wikipedia.beta.wmflabs.org/wiki/Amateur_geology?minervanightmode=1
✅ AC1: The page issues notice should be in night mode.
Experiencing something weird here. If I click on the notice, and then go back to the page, the icons become invisible. Is this expected? Also, perhaps we should test across a number of different page issues when we're doing the production testing. cc @Edtadros
@ovasileva appears to happen on master. Could you open a new bug for us to estimate on Thursday?
@ovasileva reminder to open a bug before tomorrow for estimation - please delegate if you don't have time!
Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA
Test Artifact(s):
Go to a page with a Page Issues notice using the ?minervanightmode=1 param.
✅ AC1: The page issues notice should be in night mode.
I was able to reproduce the disappearing icons.
https://en.m.wikipedia.org/wiki/Gambling_in_the_United_States?minervanightmode=1
