Page MenuHomePhabricator

[Bug] Page issues icon disappearing on click
Closed, ResolvedPublic

Description

Steps to reproduce

  1. Go to https://en.m.wikipedia.org/wiki/YouTube?oldid=1209435813&minervanightmode=1#Moderation_and_offensive_content
  2. Click on page issue
  3. page issues overlay opens
  4. Close overlay

Expected results

  • Page issues icons should still appear

Actual results

  • Page issues icons disappear

Check any additional observations

Event Timeline

ovasileva triaged this task as Medium priority.Feb 22 2024, 10:02 AM
Jdlrobson renamed this task from [Bug] Page issues icon disappearing in night mode to [Bug] Page issues icon disappearing on click.Feb 23 2024, 10:30 PM
Jdlrobson subscribed.

Seems to occur in light mode too

Hi @ovasileva i have investigated the issue and found that iconElement DOM node is reused both in the page banner and in the overlay. and when the overlay opens, the icon is moved from .mbox-text to .cleanup, when the overlay closes, the overlay DOM is destroyed, causing the page icon to disappear, i have prepared a patch that clones the icon element for the overlay so the original remains on the page :)

Change #1302235 had a related patch set uploaded (by VoidRaven-18; author: VoidRaven-18):

[mediawiki/skins/MinervaNeue@master] fix page issues icon disappearing after closing overlay

https://gerrit.wikimedia.org/r/1302235

Change #1302235 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] fix page issues icon disappearing after closing overlay

https://gerrit.wikimedia.org/r/1302235

Etonkovidova subscribed.

Checked on beta

In production - check in wmf.8 (wmf.6 still show the issue) the following article can be checked, along with the link from the task description.