57 failures in https://pixel.wmcloud.org/reports/mobile/index.html
With the following code we expect to change the fill color of the icon to color-base
.cdx-mixin-css-icon( @cdx-icon-close, --color-base );
This generates
url("data:image/svg+xml;utf8,<svg xmlns=\"http://www.w3.org/2000/svg\" xmlns:xlink=\"http://www.w3.org/1999/xlink\" width=\"20\" height=\"20\" viewBox=\"0 0 20 20\" fill=\"var%28--color-subtle%29\"><path d=\"m4.34 2.93 12.73 12.73-1.41 1.41L2.93 4.35z\"/><path d=\"M17.07 4.34 4.34 17.07l-1.41-1.41L15.66 2.93z\"/></svg>")On the long term it looks like this will be addressed by T356540 but in the mean time we should look to fix this by reverting the related change.
QA steps
Check icons
- Visit https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=T352930
- Sign in
- the bell icon in the top right should not be pure black. It should be off-black.
- Confirm no visual regressions in https://pixel.wmcloud.org/reports/mobile/index.html
Check text color
- Visit https://en.m.wikipedia.org/wiki/Special:Nearby / https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Nearby
- Confirm "You can read interesting Beta Wikipedia pages about places around you" uses the color# 54595d
- Confirm no visual regressions relating to NearbyPages on https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Nearby
