Regression: Active link color is broken on mobile
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Dringsim
	Feb 13 2024, 8:48 AM

Description

Steps to replicate the issue (include links if applicable):

Visit https://m.mediawiki.org/wiki/MediaWiki
Touch/click on an internal link (e.g. "Download")
Touch/click on an external link (e.g. "Wikimedia Developer Portal")

What happens?:

The active internal link is black
The active external link is dark blue (#2a4b8d)

What should have happened instead?:

Active links should be yellow (#faa700) (as of wmf/1.42.0-wmf.16)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Results - Prod

AC	Status	Details
1	❌	T357381#9570859

Details

	Subject	Repo	Branch	Lines +/-
	Restore link active color	mediawiki/skins/MinervaNeue	master	+2 -0

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		Jdrewniak	T341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations
Open		Jdrewniak	T341632 [EPIC] Palette customizations and dark mode
Open		None	T354835 [epic] Release night mode as a beta feature on desktop and mobile
Open		None	T354836 [goal] Allow desktop and mobile page chrome to appear in night mode ahead of beta release
Open		None	T354843 [Night mode] Make all open-by-default global navigation appear in night mode on mobile
Resolved		Jdlrobson	T356074 Implement the dark mode color palette and switch LESS variables in Minerva to use it, degrade support for browsers that do not support CSS custom properties
Resolved	BUG REPORT	JScherer-WMF	T357381 Regression: Active link color is broken on mobile

Event Timeline

Dringsim created this task.Feb 13 2024, 8:48 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 13 2024, 8:48 AM

Dringsim renamed this task from Regression: active link color is broken on mobile to Regression: Active link color is broken on mobile.Feb 13 2024, 8:49 AM

Dringsim added a parent task: T356074: Implement the dark mode color palette and switch LESS variables in Minerva to use it, degrade support for browsers that do not support CSS custom properties.

Jdlrobson added projects: Web-Team-Backlog (FY2023-24 Q3 Sprint 3), Web Team Visual Regression Framework.Feb 13 2024, 4:04 PM

Jdlrobson removed a project: Web Team Visual Regression Framework.

Change 1003018 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Restore link active color

https://gerrit.wikimedia.org/r/1003018

gerritbot added a project: Patch-For-Review.Feb 13 2024, 4:32 PM

It looks like historically Minerva defined @color-link--active: as #faa700 (which is different from the Codex design token) and that was removed in https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/995065/16/resources/mediawiki.less/mediawiki.skin.variables.less#b33

Change 1003018 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Restore link active color

https://gerrit.wikimedia.org/r/1003018

Maintenance_bot removed a project: Patch-For-Review.Feb 13 2024, 5:30 PM

Mabualruz triaged this task as Medium priority.Feb 13 2024, 6:05 PM

Mabualruz set the point value for this task to 1.

Jdlrobson assigned this task to Edtadros.Feb 13 2024, 6:06 PM

Jdlrobson moved this task from Incoming to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 3) board.

Jdlrobson mentioned this in T356825: Implement the new night mode color palette in Minerva.Feb 13 2024, 8:29 PM

Right now the active link colour is yellow in night mode. It should be a shade of blue.

The active link colour is yellow right now. There's a variable called --color-link--active which is #FAA700. That's where the yellow clicked color is coming from. We spec'd color-progressive--active as #AFB6E9.

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.19; 2024-02-20).Feb 13 2024, 10:01 PM

I chatted to @JScherer-WMF and clarified that this bug is about the regression from yellow to black. We'll create a new ticket for changing the Minerva color to the standard Codex design token color (which will make it #FAA700)

@Jdlrobson, I'm unable to recreate this so I don't know how to validate the fix in Beta.

This was backported so can be QAed in production. I can confirm it's a pass :)

Jdlrobson lowered the priority of this task from Medium to Low.Feb 22 2024, 5:30 PM

Test Result - Prod

Status: ❌ FAIL
Environment: mediawiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://m.mediawiki.org/wiki/MediaWiki
Touch/click on an internal link (e.g. "Download")
Touch/click on an external link (e.g. "Wikimedia Developer Portal")
What happens?:

The active internal link is black
The active external link is dark blue (#2a4b8d)
What should have happened instead?:

❌ AC1: Active links should be yellow (#faa700) (as of wmf/1.42.0-wmf.16)
The active internal link shows as yellow, but the active external link does not.

Edtadros updated the task description. (Show Details)Feb 23 2024, 1:50 AM

I think that's expected (albeit weird). I believe @JScherer-WMF wanted to remove the yellow color. If so does a ticket yet exist? If not could you please create one?

Edtadros mentioned this in T357332: Verify 1.42.0-wmf.19 deployment.Feb 24 2024, 12:33 AM

Follow up ticket created in T358516.

Jdlrobson mentioned this in T358516: Active links on minerva should not be yellow.Mar 6 2024, 1:49 AM

	F42053426: screenshot 561.png
	Feb 23 2024, 1:50 AM

	F42053425: screenshot 560.png
	Feb 23 2024, 1:50 AM

Regression: Active link color is broken on mobileClosed, ResolvedPublic1 Estimated Story PointsBUG REPORTActions