Page MenuHomePhabricator

Color contrast issues with Template:Quote_box in Minerva Night Mode
Closed, ResolvedPublic

Assigned To
Authored By
KSarabia-WMF
Feb 15 2024, 11:18 PM
Referenced Files
F42605828: screenshot 701.png
Mar 13 2024, 10:09 PM
F42605831: screenshot 702.png
Mar 13 2024, 10:09 PM
F42605836: screenshot 704.png
Mar 13 2024, 10:09 PM
F42605834: screenshot 703.png
Mar 13 2024, 10:09 PM
F42449474: screenshot 641.png
Mar 7 2024, 9:44 PM
F42449473: screenshot 640.png
Mar 7 2024, 9:44 PM
F42449472: screenshot 639.png
Mar 7 2024, 9:44 PM
F41918881: Screenshot 2024-02-15 at 5.18.07 PM.png
Feb 15 2024, 11:18 PM

Description

Context:
Per the most recent color contrast checker run, there are about 20 color contrast violations in the top 100 wikipedia pages related to Template:Quote_box.

Issue Details:
Skin: Minerva (Night Mode)
Problem Area: Template:Quote_box.

Steps to Reproduce:
Go to this sample page

Paste below into DevTools to view an sample:

// Select the desired element
const targetElement = document.querySelector("div.mw-content-ltr.mw-parser-output > section.mf-section-2.collapsible-block > div.quotebox.pullquote.centered > blockquote.quotebox-quote.left-aligned > p");

// Check if the element is found
if (targetElement) {
  // Scroll to the element
  targetElement.scrollIntoView({ behavior: 'smooth' });

  // Apply red outline style after scrolling
  targetElement.style.outline = '2px solid red';
} else {
  console.error('Element not found');
}

Expected Result:
The text and background colors within the infobox should have a WCAG 2.0 level AA contrast ratio of at least 4.5:1 for normal text and 3:1 for large text.

Actual Result

Screenshots of color contrast issues.

Screenshot 2024-02-15 at 5.18.07 PM.png (450×2 px, 64 KB)

QA Results - Beta

ACStatusDetails
1T357735#9613573

QA Results - Prod

ACStatusDetails
1T357735#9628806

Event Timeline

KSarabia-WMF renamed this task from Color contrast issues with to Color contrast issues with Template:Quote_box in Minerva Night Mode.Feb 15 2024, 11:19 PM
Jdlrobson subscribed.

Jon to create common ticket for this and T357726

Test Result - Beta

Status: ❌ FAIL
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Find a quotebox object
❌ AC1: The text and background colors within the infobox should have a WCAG 2.0 level AA contrast ratio of at least 4.5:1 for normal text and 3:1 for large text.

https://en.m.wikipedia.beta.wmflabs.org/wiki/Chamber_music

screenshot 639.png (884×1 px, 395 KB)

screenshot 640.png (1×1 px, 469 KB)

screenshot 641.png (1×1 px, 502 KB)

Edtadros updated the task description. (Show Details)
Jdlrobson changed the task status from Open to Stalled.Mar 8 2024, 11:27 PM
Jdlrobson lowered the priority of this task from High to Medium.Mar 9 2024, 1:36 AM

Test Result - Prod

Status: ✅ Pass
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Find a quotebox object
✅ AC1: The text and background colors within the infobox quotebox should have a WCAG 2.0 level AA contrast ratio of at least 4.5:1 for normal text and 3:1 for large text.

https://en.m.wikipedia.org/wiki/UEFA_Champions_League?minervanightmode=1

standardlarge
screenshot 703.png (652×1 px, 354 KB)
screenshot 704.png (673×1 px, 332 KB)

https://en.m.wikipedia.org/wiki/Alfred_Hitchcock?minervanightmode=1

standardlarge
screenshot 702.png (562×1 px, 232 KB)
screenshot 701.png (568×1 px, 229 KB)