Page MenuHomePhabricator

Deploy initial version of night mode to pilot wikis on the mobile website for testing
Closed, ResolvedPublic2 Estimated Story Points

Assigned To
Authored By
ovasileva
Mar 5 2024, 10:53 AM
Referenced Files
F44364443: screenshot 160.png
Wed, Apr 3, 7:18 PM
F44364432: screenshot 159.png
Wed, Apr 3, 7:18 PM
F44364422: screenshot 158.png
Wed, Apr 3, 7:18 PM
F44364410: screenshot 157.png
Wed, Apr 3, 7:18 PM
F44364394: screenshot 156.png
Wed, Apr 3, 7:18 PM
F44364380: screenshot 155.png
Wed, Apr 3, 7:18 PM
F44364369: screenshot 154.png
Wed, Apr 3, 7:18 PM
F44364358: screenshot 153.png
Wed, Apr 3, 7:18 PM
Tokens
"Party Time" token, awarded by Lofhi.

Description

Background

We are now ready to deploy the first version of night mode to a limited set of pilot wikis. The purpose of this deployment is to test the initial implementation and to begin discussing and implementing fixes alongside communities

User story

  • As a template editor, I would like to have access to night mode on the mobile website, so that I can begin testing templates against it.

Requirements

  • Night mode has been disabled on pages where night mode is not ready (T359183)
  • Setting must appear ONLY when user is logged-in
  • Setting must appear ONLY when user has turned on advanced mode
  • Setting must appear in the menu
  • Setting must default to "day"

BDD

Feature: Conditional Display of Night Mode Setting

  Scenario: Night mode setting hidden for logged-out users
    When the user is not logged in
    Then the Night mode setting should not be visible in the menu

  Scenario: Night mode setting visible for logged-in users with advanced mode disabled
    Given the user is logged in
    And advanced mode is turned off
    Then the Night mode setting should not be visible in the menu

  Scenario: Night mode setting visible for logged-in users with advanced mode enabled
    Given the user is logged in
    And advanced mode is turned on
    Then the Night mode setting should be visible in the menu

  Scenario: Night mode setting defaults to "day"
    Given the user is logged in
    And advanced mode is turned on
    When the user accesses the Night mode setting for the first time
    Then the default selection should be "day"

Test Steps

  1. Verify Night Mode Setting Hidden for Logged-Out Users:
    • Navigate to Wikipedia without logging in.
    • AC1: Confirm the Night mode setting is not visible in the menu.
  1. Verify Night Mode Setting Visibility for Logged-In Users with Advanced Mode Disabled:
    • Log in to Wikipedia.
    • Ensure Advanced Mode is disabled in user preferences.
    • AC2: Confirm the Night mode setting is not visible in the menu.
  1. Verify Night Mode Setting Visibility for Logged-In Users with Advanced Mode Enabled:
    • Log in to Wikipedia.
    • Enable Advanced Mode in user preferences.
    • AC3: Confirm the Night mode setting is visible in the menu.
  1. Verify Night Mode Setting Defaults to "Day":
    • Following the steps to log in and enable Advanced Mode (if not already done),
    • Access the Night mode setting for the first time.
    • AC4: Confirm the default selection is "day".

Design

  • n/a

Acceptance criteria

NOTE: deployment date: Monday, March 18th
  • All requirements must be complete
  • Deploy the initial version of night mode to the following set of wikis:
  • Frwiki, eswiki, plwiki, srwiki, fawiki, trwiki, enwikivoyage, viwiki, shwiki
  • All subtasks must be completed
  • Any additional QA must be completed

Communication criteria - does this need an announcement or discussion?

  • Conversation with pilot communities
  • Pre-deploy announcement to relevant teams

QA Results - Prod

Related Objects

Event Timeline

Restricted Application added a subscriber: Huji. · View Herald TranscriptMar 6 2024, 4:39 PM
ovasileva updated the task description. (Show Details)
ovasileva updated the task description. (Show Details)
ovasileva renamed this task from Deploy initial version of night mode to pilot wikis on mobile for testing to Deploy initial version of night mode to pilot wikis on the mobile website for testing.Mar 7 2024, 6:25 PM
ovasileva set the point value for this task to 2.Mar 7 2024, 6:29 PM

The current plan is that we will deploy on Monday, March 18

Change 1012452 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable night mode on pilot wikis in AMC mode

https://gerrit.wikimedia.org/r/1012452

Change 1012452 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable night mode on pilot wikis in AMC mode

https://gerrit.wikimedia.org/r/1012452

Mentioned in SAL (#wikimedia-operations) [2024-03-19T20:42:59Z] <jdrewniak@deploy2002> Started scap: Backport for [[gerrit:1012452|Enable night mode on pilot wikis in AMC mode (T359152)]]

Mentioned in SAL (#wikimedia-operations) [2024-03-19T20:46:15Z] <jdrewniak@deploy2002> jdrewniak and jdlrobson: Backport for [[gerrit:1012452|Enable night mode on pilot wikis in AMC mode (T359152)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-03-19T20:59:45Z] <jdrewniak@deploy2002> Finished scap: Backport for [[gerrit:1012452|Enable night mode on pilot wikis in AMC mode (T359152)]] (duration: 16m 45s)

Change 1012755 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Make night theme available on shwiki

https://gerrit.wikimedia.org/r/1012755

Change 1012755 merged by jenkins-bot:

[operations/mediawiki-config@master] Make night theme available on shwiki, exclude additional actions

https://gerrit.wikimedia.org/r/1012755

Mentioned in SAL (#wikimedia-operations) [2024-03-20T21:22:37Z] <catrope@deploy2002> Started scap: Backport for [[gerrit:1012755|Make night theme available on shwiki, exclude additional actions (T359183 T359152)]]

Mentioned in SAL (#wikimedia-operations) [2024-03-20T21:25:04Z] <catrope@deploy2002> catrope and jdlrobson: Backport for [[gerrit:1012755|Make night theme available on shwiki, exclude additional actions (T359183 T359152)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-03-20T21:39:48Z] <catrope@deploy2002> Finished scap: Backport for [[gerrit:1012755|Make night theme available on shwiki, exclude additional actions (T359183 T359152)]] (duration: 17m 10s)

Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: Frwiki, eswiki, plwiki, srwiki, fawiki, trwiki, enwikivoyage, viwiki, shwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps
  1. Verify Night Mode Setting Hidden for Logged-Out Users:
    • Navigate to Wikipedia without logging in.
    • AC1: Confirm the Night mode setting is not visible in the menu.
Frwikieswikiplwikisrwikifawikitrwikienwikivoyageviwikishwiki
screenshot 134.png (826×1 px, 58 KB)
screenshot 135.png (826×1 px, 60 KB)
screenshot 136.png (826×1 px, 61 KB)
screenshot 137.png (826×1 px, 59 KB)
screenshot 138.png (826×1 px, 54 KB)
screenshot 139.png (826×1 px, 70 KB)
screenshot 140.png (826×1 px, 55 KB)
screenshot 141.png (826×1 px, 57 KB)
screenshot 142.png (826×1 px, 58 KB)
  1. Verify Night Mode Setting Visibility for Logged-In Users with Advanced Mode Disabled:
    • Log in to Wikipedia.
    • Ensure Advanced Mode is disabled in user preferences.
    • AC2: Confirm the Night mode setting is not visible in the menu.
Frwikieswikiplwikisrwikifawikitrwikienwikivoyageviwikishwiki
screenshot 143.png (826×1 px, 86 KB)
screenshot 144.png (826×1 px, 89 KB)
screenshot 145.png (826×1 px, 92 KB)
screenshot 146.png (826×1 px, 90 KB)
screenshot 147.png (826×1 px, 81 KB)
screenshot 148.png (826×1 px, 95 KB)
screenshot 149.png (826×1 px, 80 KB)
screenshot 150.png (826×1 px, 85 KB)
screenshot 151.png (826×1 px, 87 KB)
  1. Verify Night Mode Setting Visibility for Logged-In Users with Advanced Mode Enabled:
    • Log in to Wikipedia.
    • Enable Advanced Mode in user preferences.
    • AC3: Confirm the Night mode setting is visible in the menu.
Frwikieswikiplwikisrwikifawikitrwikienwikivoyageviwikishwiki
screenshot 152.png (826×1 px, 94 KB)
screenshot 153.png (826×1 px, 98 KB)
screenshot 154.png (826×1 px, 98 KB)
screenshot 155.png (826×1 px, 96 KB)
screenshot 156.png (826×1 px, 89 KB)
screenshot 157.png (826×1 px, 102 KB)
screenshot 158.png (826×1 px, 88 KB)
screenshot 159.png (826×1 px, 91 KB)
screenshot 160.png (826×1 px, 94 KB)
  1. Verify Night Mode Setting Defaults to "Day":
    • Following the steps to log in and enable Advanced Mode (if not already done),
    • Access the Night mode setting for the first time.
    • AC4: Confirm the default selection is "day".

see AC3