Page MenuHomePhabricator

Lofhi
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 22 2017, 3:37 PM (360 w, 2 d)
Availability
Available
IRC Nick
Lofhi
LDAP User
Lofhi
MediaWiki User
Lofhi [ Global Accounts ]

Recent Activity

Thu, Mar 14

Lofhi awarded T359152: Deploy initial version of night mode to pilot wikis on the mobile website for testing a Party Time token.
Thu, Mar 14, 9:03 PM · Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 5), FY2023-24-WE 2.1 Typography and palette customizations
Lofhi added a comment to T359983: Rename the skin night mode classes to something more sensible before they become widely used.

cough
https://fr.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=213342921

Thu, Mar 14, 7:27 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Patch-For-Review, Web-Team-Backlog (FY2023-24 Q3 Sprint 5), FY2023-24-WE 2.1 Typography and palette customizations
Lofhi added a comment to T359644: Work with communities to standardize infoboxes.

Does WMF have a position on frwiki's infobox header colors? At the very least, they need to be reworked for contrast, but would WMF argue that it would be better to adopt a consistent, global color for all of them?

Thu, Mar 14, 11:03 AM · FY2023-24-WE 2.1 Typography and palette customizations, Web-Team-Backlog

Wed, Mar 13

Lofhi created T360010: Future of OOUI and MediaWiki UI.
Wed, Mar 13, 9:14 AM · Design-System-Team, UI-Standardization, OOUI, Codex
Lofhi added a comment to T359644: Work with communities to standardize infoboxes.

Alright. I don't really know how do you want to enable the dark mode only for the technical editors but I can only wait.

Wed, Mar 13, 8:48 AM · FY2023-24-WE 2.1 Typography and palette customizations, Web-Team-Backlog

Tue, Mar 12

Lofhi added a comment to T359644: Work with communities to standardize infoboxes.

Let me rephrase: how do you expect us to notice compatibility problems with night mode if we have to constantly add ?vectornightmode=1 to the URL? By not blocking the beta feature rollout, you allow frwiki registered editors to use night mode as they choose, and to report problems as they read through our two million (almost three) articles.

Tue, Mar 12, 9:46 PM · FY2023-24-WE 2.1 Typography and palette customizations, Web-Team-Backlog
Lofhi added a comment to T357453: WCAG Color Contrast Violations in Infobox on Minerva Skin Night Mode.

I only see hacks.less getting bigger and this will surely complicate fixes in the long term. How easily should itwiki (and all projects) know that one of its CSS classes is hard-corrected in MediaWiki?

Tue, Mar 12, 4:59 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Web-Team-Backlog (FY2023-24 Q3 Sprint 4), FY2023-24-WE 2.1 Typography and palette customizations
Lofhi added a comment to T359644: Work with communities to standardize infoboxes.

How do you expect projects to correct their issues by making night mode inaccessible?

Tue, Mar 12, 4:45 PM · FY2023-24-WE 2.1 Typography and palette customizations, Web-Team-Backlog

Mon, Mar 11

Lofhi added a comment to T359644: Work with communities to standardize infoboxes.

Blocks deployment to French Wikipedia [...]

Mon, Mar 11, 12:00 AM · FY2023-24-WE 2.1 Typography and palette customizations, Web-Team-Backlog

Sun, Mar 10

Lofhi added a comment to T356344: [Night mode] Templates can be fixed by editors when necessary for night mode.

But the problem is, what do the technical contributors think? I will try to gather their feedback.

Sun, Mar 10, 9:30 PM · FY2023-24-WE 2.1 Typography and palette customizations, Web-Team-Backlog

Wed, Mar 6

Lofhi created T359431: Lack or limitations of concurrency .
Wed, Mar 6, 5:57 PM · superset.wmcloud.org
Lofhi updated the task description for T359314: Somehow a regression: base light inputs background are dark.
Wed, Mar 6, 11:45 AM · Regression, MinervaNeue
Lofhi created T359314: Somehow a regression: base light inputs background are dark.
Wed, Mar 6, 11:39 AM · Regression, MinervaNeue

Tue, Mar 5

Lofhi added a comment to T26070: [GOAL] Provide a dark / night mode skin or theme.

There is something I don't understand @Esanders. Why are you uninverting the CSS filter on images? I will ask a very dumb question: why not using the not CSS selector to exclude img? For old browsers support?

Tue, Mar 5, 8:34 PM · FY2023-24-WE 2.1 Typography and palette customizations, Community-Wishlist-Survey-2023, MediaWiki-extensions-DarkMode, MediaWiki-Core-Skin-Architecture, MediaWiki-User-Interface
Lofhi added a comment to T356344: [Night mode] Templates can be fixed by editors when necessary for night mode.

I believe the entire community would be willing to participate as pilots for the new night mode, given their constructive contributions when they participated as one of the few major wikis to test the new discussion tools early on.

Tue, Mar 5, 4:01 PM · FY2023-24-WE 2.1 Typography and palette customizations, Web-Team-Backlog

Mon, Mar 4

Lofhi added a comment to T357580: [Technical admins] Vector scripts/styles will no longer apply on Vector 2022 on some wikis.

I wanted to know the proportion of the active editors not using Vector (both versions).

Mon, Mar 4, 7:11 AM · User-notice

Sat, Mar 2

Lofhi added a comment to T356344: [Night mode] Templates can be fixed by editors when necessary for night mode.

[...] when necessary [...]

Sat, Mar 2, 1:39 PM · FY2023-24-WE 2.1 Typography and palette customizations, Web-Team-Backlog

Fri, Mar 1

Lofhi edited Description on Hitaden.
Fri, Mar 1, 12:19 PM
Lofhi added a comment to T353313: [docs] Create a tutorial on how to deploy a Node.js app using Build Service.

Since I've been kicking myself for the past two months with all these new services using a web service based on node, I may write a tutorial if the WMF doesn't mind. My memory is fresh enough to point out the blocking points.

Fri, Mar 1, 11:57 AM · Toolforge (Toolforge iteration 07), cloud-services-team (FY2023/2024-Q3-Q4)

Wed, Feb 28

Lofhi renamed Hitaden from Tool-hitaden to Hitaden.
Wed, Feb 28, 5:48 AM
Lofhi added a comment to T353752: Account pending approval banner shown on initial sign-in gives no context for how to proceed.

You were confirmed by the Tool-gitlab-account-approval bot because you were already a member of the Trusted-Contributors Phabricator group.

Wed, Feb 28, 12:44 AM · GitLab
Lofhi added a comment to T353752: Account pending approval banner shown on initial sign-in gives no context for how to proceed.

In my experience, I was confirmed after a brief wait. It appears to be the sole process within the WMF ecosystem that requires approval, but I believe it's acceptable. From what I remember, the only prerequisite for potentially using this type of service is when you are creating an account to create your first Toolforge tool.

Wed, Feb 28, 12:13 AM · GitLab

Mon, Feb 26

Lofhi added a comment to T26070: [GOAL] Provide a dark / night mode skin or theme.

We need stability for communication to communities: are we talking about a night mode, or a dark mode? I read MediaWiki-extensions-DarkMode. But the WMF wrote this page: recommendations for night mode compatibility on Wikimedia wikis, initially named recommendations for dark mode compatibility on Wikimedia wikis. Also, the WMF published the "Dark mode is coming" blog post 4 days before the recommandations page rename.

Mon, Feb 26, 6:39 AM · FY2023-24-WE 2.1 Typography and palette customizations, Community-Wishlist-Survey-2023, MediaWiki-extensions-DarkMode, MediaWiki-Core-Skin-Architecture, MediaWiki-User-Interface

Fri, Feb 23

Lofhi added a comment to T357580: [Technical admins] Vector scripts/styles will no longer apply on Vector 2022 on some wikis.

@Jdlrobson, could you please share the percent usage by skin? The SQL results for my user_properties view is heavily redacted for obvious reasons.

Fri, Feb 23, 8:24 PM · User-notice
Lofhi added a comment to T357580: [Technical admins] Vector scripts/styles will no longer apply on Vector 2022 on some wikis.

What would the WMF think about mass editing instead of using their "temporary" gadget based on individual actions? Currently, I see ~1 900 edits per minute, for all the projects. Adding 300 edits per minute to this average for 10 minutes in the middle of the night in Europe to process all the pages on frwiki would be an acceptable stress on the DBs? We have like ~ 1 000 pages.

Fri, Feb 23, 12:25 AM · User-notice

Thu, Feb 22

Lofhi added a comment to T357693: Show patrol link regardless of whether preview is shown (Was: Edits can't be patrolled on Commons by users who have the user preference "Do not show page content below diffs" enabled).

Finally found that DifferenceEngine was modified and then I found this task. T357213 caused some community noises on frwiki too and yes, the problem is only met by editors with "Do not show page content below diffs" enabled. Thanks for the reporting @Yann, and @Jdlrobson for the permanent fix.

Thu, Feb 22, 7:01 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Regression, MediaWiki-Patrolling, Commons

Tue, Feb 20

Lofhi added a comment to T356465: [Spike] Determine how to Codex should support different themes/modes.

I'm pretty convinced that we should not worry about this. Codex is the design system for Wikimedia, so I think it's okay to limit ourselves, especially given our limited resourcing, to the themes/modes for Wikimedia products.

Tue, Feb 20, 6:43 PM · Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex, Epic
Lofhi added a comment to T357835: Dark mode color palette.

To recap, a palette already exists and needs to be integrated into the tokens defined with Codex. So I've got the answer to my question. In addition, it's already planned to add "themes" to Codex components (Vue and only-CSS ones?). So it's more than I expected!

Tue, Feb 20, 6:34 PM · Design-System-Team, Codex

Mon, Feb 19

Lofhi added a comment to T340590: Update Vue to 3.3.x.

No misunderstanding: I was just asking the questions to find out what the WMF thought about it! I am not sure that volunteers patches to update external dependencies would be appreciated by the WMF staff ; it's a bit of an interference for my taste, and it seems even less trivial to touch mediawiki/core. Updating now to 3.4 seems a bad idea, but 3.3.13 should be good. Not sure about my capacity about sending patches, MediaWiki ecosystem is big and scary.

Mon, Feb 19, 11:10 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Design-System-Team (DST-Sprint-12 (2023-11-28 to 2023-12-08)), MediaWiki-Platform-Team (Radar), MediaWiki-ResourceLoader, Codex, Vue.js
Lofhi updated subscribers of T340590: Update Vue to 3.3.x.

Also, it seems that @egardner sees into the future. He had already planned interventions like mine. https://gerrit.wikimedia.org/r/c/design/codex/+/978712/1/packages/codex/package.json#86

Mon, Feb 19, 10:56 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Design-System-Team (DST-Sprint-12 (2023-11-28 to 2023-12-08)), MediaWiki-Platform-Team (Radar), MediaWiki-ResourceLoader, Codex, Vue.js
Lofhi added a comment to T340590: Update Vue to 3.3.x.

My bad for the last minor, I quoted the one just before the release of 3.4.0-beta.1.

Mon, Feb 19, 10:50 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Design-System-Team (DST-Sprint-12 (2023-11-28 to 2023-12-08)), MediaWiki-Platform-Team (Radar), MediaWiki-ResourceLoader, Codex, Vue.js
Lofhi added a comment to T340590: Update Vue to 3.3.x.

I'm uncertain where to seek clarification. Could you please share on a MediaWiki/Wikitech page the strategy for Vue, which serves for much of the client-side now with Codex? Found nothing on https://www.mediawiki.org/wiki/Vue.js

Mon, Feb 19, 10:30 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Design-System-Team (DST-Sprint-12 (2023-11-28 to 2023-12-08)), MediaWiki-Platform-Team (Radar), MediaWiki-ResourceLoader, Codex, Vue.js

Feb 16 2024

Lofhi added a comment to T357835: Dark mode color palette.

Meh, I just found T356537. Not sure if merging is needed, since T356537 is adding the support of custom properties (so be able to customize components I guess), without defining a dark mode color palette.

Feb 16 2024, 11:10 PM · Design-System-Team, Codex
Lofhi created T357835: Dark mode color palette.
Feb 16 2024, 11:03 PM · Design-System-Team, Codex

Feb 11 2024

Lofhi added a comment to T357243: The main user-dashboard is using a only-Webkit supported CSS rule value.

Thanks, will notify them. Good luck with the rest!

Feb 11 2024, 11:21 PM · Adiutor
Lofhi created T357243: The main user-dashboard is using a only-Webkit supported CSS rule value.
Feb 11 2024, 10:52 PM · Adiutor

Jan 31 2024

Lofhi added a comment to T356196: Auto triming of internal links is breaking anchors if the last character is a space.

The link work by itself. Now, try to paste it in visual mode, or add an internal link using the “add a link” button on source mode. The previewed generated link has no trailing _, the identifier is broken. Firefox 122, Windows 11.

Jan 31 2024, 2:28 AM · Patch-For-Review, VisualEditor, User-notice, Editing-team, DiscussionTools

Jan 30 2024

Lofhi updated the task description for T356196: Auto triming of internal links is breaking anchors if the last character is a space.
Jan 30 2024, 5:08 PM · Patch-For-Review, VisualEditor, User-notice, Editing-team, DiscussionTools
Lofhi updated the task description for T356196: Auto triming of internal links is breaking anchors if the last character is a space.
Jan 30 2024, 5:07 PM · Patch-For-Review, VisualEditor, User-notice, Editing-team, DiscussionTools
Lofhi added a parent task for T356196: Auto triming of internal links is breaking anchors if the last character is a space: T356063: Deploy talk page permalinks to all wikis except en.wiki.
Jan 30 2024, 5:02 PM · Patch-For-Review, VisualEditor, User-notice, Editing-team, DiscussionTools
Lofhi added a subtask for T356063: Deploy talk page permalinks to all wikis except en.wiki: T356196: Auto triming of internal links is breaking anchors if the last character is a space.
Jan 30 2024, 5:02 PM · Verified, Editing-team (Kanban Board), DiscussionTools
Lofhi updated the task description for T356196: Auto triming of internal links is breaking anchors if the last character is a space.
Jan 30 2024, 4:59 PM · Patch-For-Review, VisualEditor, User-notice, Editing-team, DiscussionTools
Lofhi updated the task description for T356196: Auto triming of internal links is breaking anchors if the last character is a space.
Jan 30 2024, 4:58 PM · Patch-For-Review, VisualEditor, User-notice, Editing-team, DiscussionTools
Lofhi added a comment to T356196: Auto triming of internal links is breaking anchors if the last character is a space.

Guess I still need some years with Phabricator. Sorry for the indirect spam.

Jan 30 2024, 4:51 PM · Patch-For-Review, VisualEditor, User-notice, Editing-team, DiscussionTools
Lofhi removed a parent task for T302011: [Release Ticket] Introduce permalinks on wikitext talk pages: T356196: Auto triming of internal links is breaking anchors if the last character is a space.
Jan 30 2024, 4:51 PM · User-notice, Editing-team, TPP-Scaling, DiscussionTools
Lofhi removed a subtask for T356196: Auto triming of internal links is breaking anchors if the last character is a space: T302011: [Release Ticket] Introduce permalinks on wikitext talk pages.
Jan 30 2024, 4:51 PM · Patch-For-Review, VisualEditor, User-notice, Editing-team, DiscussionTools
Lofhi added a parent task for T302011: [Release Ticket] Introduce permalinks on wikitext talk pages: T356196: Auto triming of internal links is breaking anchors if the last character is a space.
Jan 30 2024, 4:50 PM · User-notice, Editing-team, TPP-Scaling, DiscussionTools
Lofhi added a subtask for T356196: Auto triming of internal links is breaking anchors if the last character is a space: T302011: [Release Ticket] Introduce permalinks on wikitext talk pages.
Jan 30 2024, 4:50 PM · Patch-For-Review, VisualEditor, User-notice, Editing-team, DiscussionTools
Lofhi removed a subtask for T302011: [Release Ticket] Introduce permalinks on wikitext talk pages: T356196: Auto triming of internal links is breaking anchors if the last character is a space.
Jan 30 2024, 4:50 PM · User-notice, Editing-team, TPP-Scaling, DiscussionTools
Lofhi removed a parent task for T356196: Auto triming of internal links is breaking anchors if the last character is a space: T302011: [Release Ticket] Introduce permalinks on wikitext talk pages.
Jan 30 2024, 4:50 PM · Patch-For-Review, VisualEditor, User-notice, Editing-team, DiscussionTools
Lofhi added a subtask for T302011: [Release Ticket] Introduce permalinks on wikitext talk pages: T356196: Auto triming of internal links is breaking anchors if the last character is a space.
Jan 30 2024, 4:50 PM · User-notice, Editing-team, TPP-Scaling, DiscussionTools
Lofhi added a parent task for T356196: Auto triming of internal links is breaking anchors if the last character is a space: T302011: [Release Ticket] Introduce permalinks on wikitext talk pages.
Jan 30 2024, 4:50 PM · Patch-For-Review, VisualEditor, User-notice, Editing-team, DiscussionTools
Lofhi created T356196: Auto triming of internal links is breaking anchors if the last character is a space.
Jan 30 2024, 4:49 PM · Patch-For-Review, VisualEditor, User-notice, Editing-team, DiscussionTools

Jan 28 2024

Lofhi placed T356004: Help password managers to detect TOTP login input up for grabs.
Jan 28 2024, 3:16 AM · MediaWiki-extensions-OATHAuth
Lofhi added a comment to T356004: Help password managers to detect TOTP login input.

Nevermind, I was going to commit more HTML-validation attributes (inputmode="numeric" pattern="\d{6}" minlength="6" maxlength="6"), then I remembered that the same input is used for scratch tokens. Welp.

Jan 28 2024, 3:16 AM · MediaWiki-extensions-OATHAuth
Lofhi added a comment to T356004: Help password managers to detect TOTP login input.

Phabricator does not offer to add a blocking task, so linking T313058 that wants to disable this mechanism.

Jan 28 2024, 3:06 AM · MediaWiki-extensions-OATHAuth
Lofhi created T356004: Help password managers to detect TOTP login input.
Jan 28 2024, 3:04 AM · MediaWiki-extensions-OATHAuth

Jan 25 2024

Lofhi added a comment to T352134: Build reference reliability check MVP (mobile + desktop).

Alright, it seems a cool feature, but also a pretty big one. I took the time to read about EditCheck and wrote a bit on frwiki.

Jan 25 2024, 11:02 PM · Verified, Editing-team (Kanban Board), EditCheck, VisualEditor
Lofhi added a comment to T352134: Build reference reliability check MVP (mobile + desktop).

"URL adress", maybe? Also, I don't understand you later-examples... MediaWiki:BlockedExternalDomains.json is a list of blocked domains, no? They can't be added?

Jan 25 2024, 6:50 AM · Verified, Editing-team (Kanban Board), EditCheck, VisualEditor

Jan 24 2024

Lofhi added a comment to T355334: Icon: official support for the use of SVG-only.

Just putting T311099 here, cause maybe the work you are doing here or there will have an impact on the respective tasks.

Jan 24 2024, 11:50 PM · Codex, Design-System-Team
Lofhi added a comment to T355242: Determine a path forward for mediawiki.ui button styles in wikitext.

Thanks for the details, I guess we can just wait for things to progress for now.

Jan 24 2024, 11:35 PM · Design-System-Team
Lofhi added a comment to T355242: Determine a path forward for mediawiki.ui button styles in wikitext.

There's clearly something I don't understand. You build a whole palette and graphic guidelines, update skins, standardize nomenclatures between Codex mediawiki.skin.defaults.less; /mediawiki.skin.variables.less... Years of work. But it's impossible for communities to easily reuse classes when Codex has adopted a rather atomic approach to CSS rules? Neither we could hope to use generated Codex CSS components classes?

Jan 24 2024, 8:01 AM · Design-System-Team
Lofhi added a comment to T352134: Build reference reliability check MVP (mobile + desktop).

frwiki use MediaWiki:Spam-blacklist and MediaWiki:BlockedExternalDomains.json for general purposes: spams, block URL shorteners to prevent bypassing, sites used only by banned contributors, promotional sources. And when bypassing is carried out by experienced MediaWiki users, a private AbuseFilter is used. So, "unreliable" seems fine, but "source" doesn't seem totally representative. Maybe just "this website", "this link", "this domain name"?

Jan 24 2024, 12:20 AM · Verified, Editing-team (Kanban Board), EditCheck, VisualEditor

Jan 23 2024

Lofhi added a comment to T240360: Determine our approach for displaying date and time a comment was made, in a user's local timezone and preferred date format.

I was talking to a French-speaking Quebec contributor editing on frwiki. And they confirmed what I'd never really taken the time to study: discussions are indeed the space where dates are not localized, whereas the rest of the interface is. They told me they do conversions manually, mentally...

Jan 23 2024, 11:36 PM · DiscussionTools, Editing-team (Tracking), Editing Design
Lofhi added a comment to T26070: [GOAL] Provide a dark / night mode skin or theme.

Thanks for pointing it, I though I was the only one to think about just inverting colors. I really don't think they thought of this option, thanks for the hint. I tried on Google, Bing and DuckDuckGo and I confirm that searching "wikimedia foundation dark night mode invert" will not display a Dark mode is coming blog post.

Jan 23 2024, 7:42 AM · FY2023-24-WE 2.1 Typography and palette customizations, Community-Wishlist-Survey-2023, MediaWiki-extensions-DarkMode, MediaWiki-Core-Skin-Architecture, MediaWiki-User-Interface

Jan 22 2024

Lofhi added a comment to T355334: Icon: official support for the use of SVG-only.

And for the answering the main question, If the SVG approach is the chosen one, self-containing is the best? I think? Alternatives are doing the same, i.e. https://fonts.google.com/icons ; https://thenounproject.com/icons/

Jan 22 2024, 8:23 PM · Codex, Design-System-Team
Lofhi added a comment to T355334: Icon: official support for the use of SVG-only.

I didn't read the entire source code of Codex, so I don't really know the directions you've taken, but to better understand, it surprised me that .cdx-message__icon is a class with a SVG for the background-image (cases with success or error) within @wikimedia/codex/dist/codex.style.css, but you have to start using NPM and play with mixins to use any other icon.

Jan 22 2024, 8:06 PM · Codex, Design-System-Team
Lofhi added a comment to T275336: push-subscription-manager group is sometimes available at all wikis.

Still displayed.

Jan 22 2024, 7:08 PM · Growth-Team, Notifications, Wikimedia-Site-requests

Jan 18 2024

Lofhi updated the task description for T355334: Icon: official support for the use of SVG-only.
Jan 18 2024, 6:16 PM · Codex, Design-System-Team
Lofhi added a comment to T355334: Icon: official support for the use of SVG-only.

I think that my request goes a little against the spirit of the project since a class like cdx-icon--medium is not an independent token (with @wikimedia/codex-design-tokens), but a class linked to the components (with @wikimedia/codex). I guess this means that classes shouldn't be used directly? Even the documentation is ignoring them:

Use the third parameter of the .cdx-mixin-css-icon() mixin, @param-size-icon, to use one of the pre-defined size options (@size-icon-medium, @size-icon-small, or @size-icon-x-small) - https://doc.wikimedia.org/codex/latest/components/demos/icon.html#icon-sizes-1

Jan 18 2024, 6:16 PM · Codex, Design-System-Team
Lofhi renamed T355334: Icon: official support for the use of SVG-only from Official support for the use of SVG-only icons to Icon: official support for the use of SVG-only.
Jan 18 2024, 5:00 PM · Codex, Design-System-Team
Lofhi renamed T355334: Icon: official support for the use of SVG-only from Official support for the use of icons only with the SVG format to Official support for the use of SVG-only icons.
Jan 18 2024, 4:32 PM · Codex, Design-System-Team
Lofhi created T355334: Icon: official support for the use of SVG-only.
Jan 18 2024, 3:11 PM · Codex, Design-System-Team

Jan 7 2024

Lofhi added a comment to T353557: [buildservice,nodejs] nodejs buildpack does not take envvars into account.

So, I tried.

Jan 7 2024, 11:18 AM · Hitaden, Toolforge Build Service

Jan 6 2024

Lofhi added a comment to T353557: [buildservice,nodejs] nodejs buildpack does not take envvars into account.

Gonna try this weekend, thanks for the notice.

Jan 6 2024, 8:16 AM · Hitaden, Toolforge Build Service

Dec 16 2023

Lofhi added a project to T353116: Lookup: unconsistensy between "value" and "label" Vue props and usage of FormData interface on a form: Hitaden.
Dec 16 2023, 7:11 PM · Hitaden, Design-System-Team, Codex
Lofhi added a comment to T353557: [buildservice,nodejs] nodejs buildpack does not take envvars into account.

Successfully deployed the (broken) webservice from a built image: https://hitaden.toolforge.org/
So the envvars buildpack support removed is not truly problematic; at least for this project. Still waiting for the builder update with the pnpm support!

Dec 16 2023, 6:36 PM · Hitaden, Toolforge Build Service
Lofhi added a comment to T353557: [buildservice,nodejs] nodejs buildpack does not take envvars into account.

It seems that the documentation is just wrong and the YAML lockfile is indeed looked up. Running out of explanations on my side! https://github.com/heroku/buildpacks-nodejs/blob/ee76b7b620a59c1799ef09ddbc3b6435264b84f4/buildpacks/nodejs-pnpm-install/src/main.rs#L35C35-L35C35

Dec 16 2023, 3:12 PM · Hitaden, Toolforge Build Service
Lofhi added a comment to T353557: [buildservice,nodejs] nodejs buildpack does not take envvars into account.

This buildpack's bin/detect will only pass if a pnpm-lock.json exists in the project root. This is done to prevent the buildpack from providing indeterminate and unpredictable dependency trees.

Dec 16 2023, 3:10 PM · Hitaden, Toolforge Build Service
Lofhi added a comment to T353557: [buildservice,nodejs] nodejs buildpack does not take envvars into account.

Something I don't understand is: if the Build Service is already using Cloud Native Buildpacks with Builder:22, why using pnpm is not supported? Are we one version behind? https://github.com/heroku/buildpacks-nodejs/blob/main/buildpacks/nodejs-pnpm-install/README.md

Dec 16 2023, 3:04 PM · Hitaden, Toolforge Build Service
Lofhi added a comment to T353557: [buildservice,nodejs] nodejs buildpack does not take envvars into account.

It seems so complicated. The npm cli or npm install choice is only depending of the major version of npm.
https://github.com/heroku/buildpacks-nodejs/blob/ee76b7b620a59c1799ef09ddbc3b6435264b84f4/buildpacks/npm/lib/build.sh#L78

Dec 16 2023, 2:57 PM · Hitaden, Toolforge Build Service

Dec 15 2023

Lofhi added a comment to T353557: [buildservice,nodejs] nodejs buildpack does not take envvars into account.

A nice xmas-gift I see! Anyway, I can't go any further on the subject until next week, there's no hurry. Thanks for the expertise!

Dec 15 2023, 10:47 PM · Hitaden, Toolforge Build Service
Lofhi added a comment to T353557: [buildservice,nodejs] nodejs buildpack does not take envvars into account.

Here you go: P54485

Dec 15 2023, 9:28 PM · Hitaden, Toolforge Build Service
Lofhi renamed T353557: [buildservice,nodejs] nodejs buildpack does not take envvars into account from Toolforge Build Service doesn't pass envvars to the buildpack to [buildservice] Not passing envvars to buildpack (or atleast to the nodejs one).
Dec 15 2023, 9:23 PM · Hitaden, Toolforge Build Service
Lofhi added a comment to T353313: [docs] Create a tutorial on how to deploy a Node.js app using Build Service.

I don't know where to ask, but this is the new recommended way before deploying a web service on Toolforge? The node18 version is one year old on the Kubernetes cluster.

I think you ended up getting some answers from @dcaro on IRC, but broadly yes buildpacks are the latest generation technology for deploying tools in Toolforge. Buildpacks also in some (all?) cases allow installing and using newer language runtimes than are otherwise made available by Debian stable release cycles.

Dec 15 2023, 9:04 PM · Toolforge (Toolforge iteration 07), cloud-services-team (FY2023/2024-Q3-Q4)
Lofhi created T353557: [buildservice,nodejs] nodejs buildpack does not take envvars into account.
Dec 15 2023, 9:00 PM · Hitaden, Toolforge Build Service

Dec 14 2023

Lofhi added a comment to T353313: [docs] Create a tutorial on how to deploy a Node.js app using Build Service.

I don't know where to ask, but this is the new recommended way before deploying a web service on Toolforge? The node18 version is one year old on the Kubernetes cluster.

Dec 14 2023, 12:01 PM · Toolforge (Toolforge iteration 07), cloud-services-team (FY2023/2024-Q3-Q4)

Dec 12 2023

Lofhi added a comment to T353116: Lookup: unconsistensy between "value" and "label" Vue props and usage of FormData interface on a form.

Not sure to be frank... I think I am just lazy.

Dec 12 2023, 2:01 PM · Hitaden, Design-System-Team, Codex

Dec 10 2023

Lofhi updated the task description for T353116: Lookup: unconsistensy between "value" and "label" Vue props and usage of FormData interface on a form.
Dec 10 2023, 7:44 PM · Hitaden, Design-System-Team, Codex
Lofhi renamed T353116: Lookup: unconsistensy between "value" and "label" Vue props and usage of FormData interface on a form from Select: unconsistensy between "value" and "label" Vue props and usage of FormData interface on a form to Lookup: unconsistensy between "value" and "label" Vue props and usage of FormData interface on a form.
Dec 10 2023, 7:43 PM · Hitaden, Design-System-Team, Codex
Lofhi added a comment to T353116: Lookup: unconsistensy between "value" and "label" Vue props and usage of FormData interface on a form.

At least, I think that if it will not be changed a notice should be added on the documentation.

Dec 10 2023, 7:39 PM · Hitaden, Design-System-Team, Codex
Lofhi created T353116: Lookup: unconsistensy between "value" and "label" Vue props and usage of FormData interface on a form.
Dec 10 2023, 7:36 PM · Hitaden, Design-System-Team, Codex

Aug 2 2023

Lofhi closed T319853: Migrate lebot from Toolforge GridEngine to Toolforge Kubernetes as Resolved.

Easy-peasy.

Aug 2 2023, 1:58 PM · Grid-Engine-to-K8s-Migration

Mar 25 2023

Lofhi added a comment to T319853: Migrate lebot from Toolforge GridEngine to Toolforge Kubernetes.

I'll work on it in early April.

Mar 25 2023, 4:08 PM · Grid-Engine-to-K8s-Migration

Mar 26 2021

Lofhi added a comment to T273144: Language button appears on special pages and pages without languages.

I believe these changes are related to the disappearance of interlang and interwiki links when an article is edited ($action !== 'view') with the WikiEditor (2010). Can you confirm or disconfirm?

Mar 26 2021, 3:05 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), UniversalLanguageSelector, Web-Team-Backlog (Kanbanana-FY-2020-21), Vector (legacy skin)

Feb 3 2021

Lofhi added a comment to T273745: Some special pages on the mobile version are indexed by search engines even with noindex rule (because robots can't access the pages).

Ah, sorry, I'll think about it next time. Special pages should not be accessed by robots (robots.txt disallow it), and the expected result is that these pages are not referenced (<meta name="robots" content="noindex,nofollow">). So I think the problem is this: the pages can't be accessed and Google can't take the noindex into account. For some reason, these pages have been indexed before.

Feb 3 2021, 1:01 PM · WMF-General-or-Unknown
Lofhi created T273745: Some special pages on the mobile version are indexed by search engines even with noindex rule (because robots can't access the pages).
Feb 3 2021, 12:20 PM · WMF-General-or-Unknown

Jan 15 2021

Lofhi added a comment to T272075: Enable anniversary logo for fr.wikipedia - 20th birthday.

I just saw that the text was truncated because of me. I uploaded a new version on Commons. Sorry.

Jan 15 2021, 8:11 PM · User-Urbanecm, Wikimedia-Site-requests
Lofhi added a comment to T272075: Enable anniversary logo for fr.wikipedia - 20th birthday.

The "e" should not be removed since it's on the file. With the "e", it will be perfect (if the images are not blurred in the final result)!

Jan 15 2021, 4:11 PM · User-Urbanecm, Wikimedia-Site-requests
Jules78120 awarded T272075: Enable anniversary logo for fr.wikipedia - 20th birthday a Party Time token.
Jan 15 2021, 12:44 PM · User-Urbanecm, Wikimedia-Site-requests