Page MenuHomePhabricator

Lofhi
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 22 2017, 3:37 PM (365 w, 2 d)
Availability
Available
IRC Nick
Lofhi
LDAP User
Lofhi
MediaWiki User
Lofhi [ Global Accounts ]

Recent Activity

Yesterday

Lofhi changed the visibility for F48128020: editrecovery - delete button broken frwiki.mp4.
Mon, Apr 22, 5:49 PM
Lofhi attached a referenced file: F48128020: editrecovery - delete button broken frwiki.mp4.
Mon, Apr 22, 5:46 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Community-Tech (CommTech-Kanban), Patch-For-Review, Edit Recovery
Lofhi added a comment to T353996: Allow deleting data from Special:EditRecovery.

Reproductible on my side.

Mon, Apr 22, 5:24 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Community-Tech (CommTech-Kanban), Patch-For-Review, Edit Recovery
Lofhi renamed T363112: A subpage transcluded after a HTML-comment on the main page could causes an discussiontools-error-comment-is-transcluded from A subpage transcluded after a HTML-comment on the main page could causes an discussiontools-error-comment-is-transcluded error to A subpage transcluded after a HTML-comment on the main page could causes an discussiontools-error-comment-is-transcluded.
Mon, Apr 22, 4:44 PM · Regression, Parsoid, DiscussionTools
Lofhi added a comment to T363112: A subpage transcluded after a HTML-comment on the main page could causes an discussiontools-error-comment-is-transcluded.

Tried with "real" title of sections (i.e. == Test ==) and it didn't change anything. getThreadItemsHtml from the API put the HTML-comment in "othercontent" (which is good). So, somehow, this edge case fails within CommentParser.php in computeTranscludedFrom.

Mon, Apr 22, 4:40 PM · Regression, Parsoid, DiscussionTools
Lofhi renamed T363112: A subpage transcluded after a HTML-comment on the main page could causes an discussiontools-error-comment-is-transcluded from A subpage transcluded after a h1 title and a HTML-comment on the main page could cause an error when it shouldn't? to A subpage transcluded after a HTML-comment on the main page could causes an discussiontools-error-comment-is-transcluded error.
Mon, Apr 22, 4:25 PM · Regression, Parsoid, DiscussionTools
Lofhi updated the task description for T363112: A subpage transcluded after a HTML-comment on the main page could causes an discussiontools-error-comment-is-transcluded.
Mon, Apr 22, 3:59 PM · Regression, Parsoid, DiscussionTools
Lofhi created T363112: A subpage transcluded after a HTML-comment on the main page could causes an discussiontools-error-comment-is-transcluded.
Mon, Apr 22, 3:53 PM · Regression, Parsoid, DiscussionTools
Lofhi added a comment to T358003: [3hr] [FRENCH WIKIPEDIA] Color Contrast Issue in Minerva Night Mode - .alternance.

@Escargot_rouge, c'est bon.

Mon, Apr 22, 12:03 PM · Local-Wiki-Template-And-Gadget-Issues, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations

Sat, Apr 20

Lofhi added a comment to T356196: Auto triming of internal links is breaking anchors if the last character is a space.

Since I reported the problem, I've encountered it less than ten times. That's still 10 cases where the anchor is broken...

Sat, Apr 20, 12:45 PM · Patch-For-Review, VisualEditor, User-notice, Editing-team, DiscussionTools

Fri, Apr 19

Lofhi added a comment to T169306: Change tablecell style menu to take into account scope attribute.

I'm just discovering that scope are not added with the Visual Editor, nor that it's easily possible to add them without switching to the classic editor. On frwiki, the community relies on a gadget to detect this type of inaccessible table. The impact is quite significant: we continue to generate inaccessible tables that have to be corrected by hand.

Fri, Apr 19, 5:16 PM · VisualEditor-Tables, VisualEditor-EditingTools, Accessibility, VisualEditor
Lofhi created T362974: Support aliases for the special page.
Fri, Apr 19, 11:57 AM · I18n, Community-Tech, Edit Recovery

Thu, Apr 18

Lofhi added a comment to T359644: Work with communities to standardize infoboxes.

Anyway, thanks again for getting us to where we are now! It's definitely looking a lot more optimistic than it was a month ago so I want to make sure you know I appreciate your efforts in this space! I know consensus is hard to build!

So we haven't agreed on an approach yet but we have two options we are considering:

  1. we target .infobox---frwiki. The benefit of this is it targets French only, the downside is all projects would get unused CSS and it wouldn't help other projects e.g. say italian adding infobox--it.
  2. We target any class beginning with infobox-. The benefit is we could recommend other projects other than French follow suit, but on the downside code is less readable.
  3. We target any class beginning with infobox. The benefit is we can minimize CSS rules. Downside is it would match infobox_v2 and infobox_v3 here (but it sounds like they already have infobox--fr so maybe that's okay?)

Does that make sense?

Thu, Apr 18, 8:22 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 2), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations
Lofhi added a comment to T359644: Work with communities to standardize infoboxes.

French Wikipedia should still work towards adding the infobox class on all its projects. If that's not the goal we need to talk and make sure we're on the same page :-). If all projects standardize to have the infobox class it's better for bots, screen scrapers (and thus SEO), crawlers, APIs, MobileFrontend etc.. as it allows all these things to identify what the infobox in the page is.

My understanding was that the reason French Wikipedia doesn't use the infobox class is because:

  1. it dislikes the alteration of appearance that occurs via skins.minerva.content.styles/hacks.less
  2. It believes the infobox should be at the top of the page e.g. we should disable MoveLeadParagraph.
Thu, Apr 18, 7:39 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 2), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations
Lofhi added a comment to T359644: Work with communities to standardize infoboxes.

@Lofhi French can also now adopt the infobox class and disable the styles associated with infoboxes if they want to use their own using the approach outlined at https://www.mediawiki.org/wiki/Extension:WikimediaMessages#Disabling_styles - I'm not 100% sure what was the outcome of the discussion @Trizek-WMF was having with Od1n on https://fr.m.wikipedia.org/wiki/Wikip%C3%A9dia:Questions_techniques/semaine_10_2024 but if that's a possibility that would fix this much quicker (days rather than weeks).

Thu, Apr 18, 10:43 AM · Web-Team-Backlog (FY2023-24 Q4 Sprint 2), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations

Mon, Apr 15

Lofhi added a comment to T350436: Reading theme icon: Add reading theme icon to Codex and OOUI.

Hello, can you check if the file is filled properly on Commons? Thanks.
https://commons.wikimedia.org/wiki/File:OOjs_UI_icon_appearance.svg

Mon, Apr 15, 5:21 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Design-System-Team (DST-Sprint-12 (2023-11-28 to 2023-12-08)), Design, OOUI, Codex

Sun, Apr 14

Lofhi added a comment to T333017: Allow the ToC to be defined as collapsed or expanded.

Some discussions about removing or not the uses of __NOTOC__ on frwiki articles in the main namespace : https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Sondage/2024/Supprimer_tout_masquage_de_la_table_des_mati%C3%A8res_dans_les_articles

Sun, Apr 14, 8:22 PM · Web-Team-Backlog, Desktop Improvements (Vector 2022)

Sat, Apr 13

Lofhi added a comment to T359644: Work with communities to standardize infoboxes.

.infobox--frwiki is now used for every infobox (ref).

Sat, Apr 13, 12:32 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 2), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations

Thu, Apr 11

Lofhi added a comment to T361508: Broader color palette to facilitate wiki Codex adoption.

I like the spirit of this, but there are no specific WCAG compliant colors. Rather, it's the contrast between colors that make them compliant or not. This is why we lean on decision tokens, since they come built-in with guidelines on how they should be used together, to avoid accessibility concerns.

The idea is rather as follows: for a proposed text color, also propose a background color with an acceptable contrast ratio.

Thu, Apr 11, 4:12 PM · Design-System-Team, Codex
Lofhi edited projects for T362329: Unable to play ogg vorbis audio, added: Wikipedia-Android-App-Backlog; removed Wikipedia-Android-App-Backlog (Android Release - FY2023-24).
Thu, Apr 11, 1:58 PM · Wikipedia-Android-App-Backlog (Android Release - FY2023-24)
Lofhi closed T360805: Night mode filter seems applied on images leading to misinformation as Invalid.

No answer and the "image dimming" (not directly related of the initial report) is a official supported and customizable feature of the app, closing.

Thu, Apr 11, 1:55 PM · Wikipedia-Android-App-Backlog
Lofhi updated Other Assignee for T362329: Unable to play ogg vorbis audio, removed: Trizek-WMF.
Thu, Apr 11, 1:48 PM · Wikipedia-Android-App-Backlog (Android Release - FY2023-24)
Lofhi updated Other Assignee for T362329: Unable to play ogg vorbis audio, added: Trizek-WMF.
Thu, Apr 11, 1:48 PM · Wikipedia-Android-App-Backlog (Android Release - FY2023-24)
Lofhi created T362329: Unable to play ogg vorbis audio.
Thu, Apr 11, 1:48 PM · Wikipedia-Android-App-Backlog (Android Release - FY2023-24)
Lofhi added a comment to T359644: Work with communities to standardize infoboxes.

Request made, https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Demande_d%27intervention_sur_une_page_prot%C3%A9g%C3%A9e#c-Lofhi-20240411080200-Mod%C3%A8le:Classes_d%C3%A9but_infobox_(d_%C2%B7_h_%C2%B7_j_%C2%B7_%E2%86%B5)

Thu, Apr 11, 12:53 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 2), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations

Tue, Apr 9

Lofhi added a comment to T360562: CSS sanitizer should support using CSS variables (not setting/creating them) for use in color values in TemplateStyles.

@Xover what about just using Codex design tokens? See T355244.

Tue, Apr 9, 10:24 AM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations, TemplateStyles, css-sanitizer, Web-Team-Backlog (FY2023-24 Q3 Sprint 6)

Sat, Apr 6

Lofhi added a comment to T361508: Broader color palette to facilitate wiki Codex adoption.

It could improves accessibility by removing arbitrary color uses to be sure to have only WCAG 2.1 AA compliant colors, verified by the WMF, for example.

Sat, Apr 6, 2:35 AM · Design-System-Team, Codex
Lofhi added a comment to T361497: Are Codex Icons stable enough to import on Commons.

I like to point out that I communicate quite a bit about Codex on frwiki. This means that certain topics raised by the community can be covered by Codex.

Sat, Apr 6, 2:12 AM · Codex, Design-System-Team
Lofhi added a comment to T124168: Show Navbox templates in mobile skins.

I just discovered that mobileonly is only using CSS to hide elements on the mobile version, so it heavies them down. It is possible to totally remove them elements like the navboxes are removed?

Sat, Apr 6, 2:07 AM · Web-Team-Backlog, MobileFrontend (Tracking), Local-Wiki-Template-And-Gadget-Issues, Mobile

Thu, Apr 4

Lofhi awarded T360562: CSS sanitizer should support using CSS variables (not setting/creating them) for use in color values in TemplateStyles a Like token.
Thu, Apr 4, 7:58 AM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations, TemplateStyles, css-sanitizer, Web-Team-Backlog (FY2023-24 Q3 Sprint 6)
Lofhi added a comment to T355244: Support Codex design tokens in TemplateStyles.

I checked, and it seems that Codex tokens are available on every skin (with mediawiki.skin.defaults.less) ? Or have I misunderstood? I wouldn't mind a hint as to where the ResourceLoader comes in to load the tokens, and for the default autoloaded modules. I really need to dig the ResourceLoader, cause I'm lost about the chaining, don't know where to ask.

Thu, Apr 4, 7:54 AM · Design-System-Team, Codex, TemplateStyles
Lofhi added a comment to T355242: Determine a path forward for mediawiki.ui button styles in wikitext.

Does T356677 made Codex CSS-only components available by default on every request on Vector 2022 (see example)? It seems that skins.vector.search.codex.style is autoloaded. Anyway, if that's the case, it doesn't justify using the Codex components directly on a wiki, right?

Thu, Apr 4, 7:45 AM · Design-System-Team
Lofhi added a comment to T124168: Show Navbox templates in mobile skins.
Thu, Apr 4, 4:37 AM · Web-Team-Backlog, MobileFrontend (Tracking), Local-Wiki-Template-And-Gadget-Issues, Mobile
Lofhi added a comment to T359644: Work with communities to standardize infoboxes.

Moving back to tech prioritization until have some clarity if there is some wiggle room here with introducing a new class.

Thu, Apr 4, 2:18 AM · Web-Team-Backlog (FY2023-24 Q4 Sprint 2), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations
Lofhi added a comment to T124168: Show Navbox templates in mobile skins.

Thanks for the link. I get it. I was asking because some contributors are pushing (again) for them to be re-displayed on small screens (i.e. mobile) on frwiki. I think the only solution I've been able to find is to allow only one pallet per article, which would also have to respect a size limit. A considerable addition of limits that are unlikely to please.

Thu, Apr 4, 2:13 AM · Web-Team-Backlog, MobileFrontend (Tracking), Local-Wiki-Template-And-Gadget-Issues, Mobile
Lofhi added a comment to T360683: How should Template:Color work in night mode?.

I can only agree with @Izno. There is no simple solution. These types of template are also massively used, so they are also stuck behind edit protections. It's hard to do something without needing days of work for even small changes... without the role. I guess the only solution is for WMF to inform the communities directly that these inline color uses are to be avoided. But this has been common practice for 20 years... I don't know if the existing MediaWiki doc-page will suffice.

Thu, Apr 4, 2:03 AM · Wikimedia-Hackathon-2024, Web-Team-Backlog (Needs Prioritization (Tech)), Local-Wiki-Template-And-Gadget-Issues, FY2023-24-WE 2.1 Typography and palette customizations
Lofhi added a comment to T124168: Show Navbox templates in mobile skins.

I don't know how to put the question: would the use of grid or flexbox be enough to lighten these navboxes? Or is it crucial to also consider the size of the palette content (editorially)? Because while dewiki uses responsive navboxes, they still use tables, which are HTML markup heavy.

Thu, Apr 4, 1:50 AM · Web-Team-Backlog, MobileFrontend (Tracking), Local-Wiki-Template-And-Gadget-Issues, Mobile

Wed, Apr 3

Lofhi added a comment to T360856: MultimediaViewer in mobile should use patterned background as on desktop.

One example on frwiki with night mode (first image in the first section): https://fr.m.wikipedia.org/wiki/Portal_(jeu_vid%C3%A9o)

Wed, Apr 3, 4:38 AM · Wikimedia-Hackathon-2024, Web-Team-Backlog (FY2023-24 Q4 Sprint 2), MobileFrontend, FY2023-24-WE 2.1 Typography and palette customizations
Lofhi added a comment to T360384: [FYI] Site admins should be aware of change to how site and user scripts load on certain projects.

@Lofhi thank you for setting a fine example of how this can work. If you could share how you went about the MassMessage I think that could be helpful to others!

Wed, Apr 3, 4:33 AM · User-notice

Mon, Apr 1

Lofhi added a project to T361508: Broader color palette to facilitate wiki Codex adoption: Codex.
Mon, Apr 1, 6:22 PM · Design-System-Team, Codex
Lofhi updated the task description for T361508: Broader color palette to facilitate wiki Codex adoption.
Mon, Apr 1, 6:17 PM · Design-System-Team, Codex
Lofhi updated the task description for T361508: Broader color palette to facilitate wiki Codex adoption.
Mon, Apr 1, 6:17 PM · Design-System-Team, Codex
Lofhi created T361508: Broader color palette to facilitate wiki Codex adoption.
Mon, Apr 1, 6:13 PM · Design-System-Team, Codex
Lofhi created T361497: Are Codex Icons stable enough to import on Commons.
Mon, Apr 1, 5:39 PM · Codex, Design-System-Team

Fri, Mar 29

Lofhi awarded T360343: Tokens: Produce a "dark mode" build of Codex design tokens a Like token.
Fri, Mar 29, 4:33 PM · CSS, Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)), Codex

Wed, Mar 27

Lofhi added a comment to T26070: [GOAL] Provide a dark / night mode skin or theme.

Thanks for sharing @Gwern, and for you work. It's undeniably a high-quality tool that could be shared with communities.

Wed, Mar 27, 11:28 PM · FY2023-24-WE 2.1 Typography and palette customizations, Community-Wishlist-Survey-2023, MediaWiki-extensions-DarkMode, MediaWiki-Core-Skin-Architecture, MediaWiki-User-Interface
Lofhi added a comment to T360856: MultimediaViewer in mobile should use patterned background as on desktop.

With the types of images you are quoting, the .skin-invert class seems totally fine. But some may still need an adaptative background color (imagining we will have more than two themes in the future) like .media-with-transparency, no? The problem is also to find classes that are easy and short to understand. If they are 20 characters long, nobody will use them...

Wed, Mar 27, 4:23 PM · Wikimedia-Hackathon-2024, Web-Team-Backlog (FY2023-24 Q4 Sprint 2), MobileFrontend, FY2023-24-WE 2.1 Typography and palette customizations

Tue, Mar 26

Lofhi added a comment to T360805: Night mode filter seems applied on images leading to misinformation.

The used concerned is using the version 2.7.50479-r-2024-03-21. ROM is based on Android 11. The user sent me the details in private, so I am not sure they want me to quote the model here, any other channel maybe?

Tue, Mar 26, 6:16 PM · Wikipedia-Android-App-Backlog
Lofhi updated subscribers of T360856: MultimediaViewer in mobile should use patterned background as on desktop.

Hello @Jdlrobson, can you tell me if I've assigned the task to the right projects? I think the problem raised needs to be thought through early on before generalizing night mode.

Tue, Mar 26, 5:58 PM · Wikimedia-Hackathon-2024, Web-Team-Backlog (FY2023-24 Q4 Sprint 2), MobileFrontend, FY2023-24-WE 2.1 Typography and palette customizations
Lofhi added a comment to T360384: [FYI] Site admins should be aware of change to how site and user scripts load on certain projects.

The global changes required on frwiki have been completed. Actives users (since may 2023 ; Vector 2022 generalization) potentially affected (a few hundred and not less than 50 as mentioned in the main task) will be notified this week. We don't have the capacity to manually review each personal user script.

Tue, Mar 26, 5:51 PM · User-notice

Sun, Mar 24

Lofhi updated the task description for T360856: MultimediaViewer in mobile should use patterned background as on desktop.
Sun, Mar 24, 1:54 PM · Wikimedia-Hackathon-2024, Web-Team-Backlog (FY2023-24 Q4 Sprint 2), MobileFrontend, FY2023-24-WE 2.1 Typography and palette customizations
Lofhi created T360856: MultimediaViewer in mobile should use patterned background as on desktop.
Sun, Mar 24, 1:50 PM · Wikimedia-Hackathon-2024, Web-Team-Backlog (FY2023-24 Q4 Sprint 2), MobileFrontend, FY2023-24-WE 2.1 Typography and palette customizations

Mar 23 2024

Lofhi added a comment to T359644: Work with communities to standardize infoboxes.

I'd like to point out that frwiki has begun finalizing the transition of its V2 infoboxes, which has been going on for years, to V3 or Lua infoboxes. This will eventually enable the use of the standardized class, but it will take several weeks (months) since these changes are often held up by the need for consensus.

Mar 23 2024, 4:31 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 2), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations

Mar 22 2024

Lofhi set the alternate text for F43066396: Capture d’écran 2024-03-22 à 19.05.00.png to Screenshot of the Neymar footballer infobox when consulting directly Wikipedia website.
Mar 22 2024, 6:13 PM
Lofhi added a comment to T360805: Night mode filter seems applied on images leading to misinformation.

I got the same results than you. Still, the color are different (excluding the background) from the web version, no? It looks duller.
I will ask more details for their even weirder colors.

Mar 22 2024, 6:07 PM · Wikipedia-Android-App-Backlog
Lofhi created T360805: Night mode filter seems applied on images leading to misinformation.
Mar 22 2024, 5:23 PM · Wikipedia-Android-App-Backlog

Mar 21 2024

Lofhi added a comment to T359644: Work with communities to standardize infoboxes.
Mar 21 2024, 7:23 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 2), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations
Lofhi updated subscribers of T359644: Work with communities to standardize infoboxes.
Mar 21 2024, 6:40 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 2), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations
Lofhi added a comment to T359644: Work with communities to standardize infoboxes.

I meant https://en.wikipedia.org/wiki/Main_Page but am I interested in all templates on every page like you say. It is helpful to know that a broader color palette is wanted.

Mar 21 2024, 6:30 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 2), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations
Lofhi added a comment to T358031: Tokens: reorganize token files.

Does it mean we will have a official night mode color palette coming from Codex (see T357835)? Since the night mode is pushed on wikis and editors are starting to use their own colors... Edit: just found T360343, I think it covers my question.

Mar 21 2024, 5:03 PM · Patch-For-Review, Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)), Codex
Lofhi added a comment to T359644: Work with communities to standardize infoboxes.

This might be outside of this task, but I would be very interested in understanding any of the justification for the color and style/layout choices in templates, including the headings on the main page. @Jdlrobson Is there anywhere to see all of the different kinds of templates? Has such an audit been done, or might there be a page with most if not all of them? Though I've noticed even the same type of template doesn't mean it gets the same color or style treatment.

Mar 21 2024, 4:50 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 2), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations
Lofhi updated subscribers of T354789: Improve existing widgets with current functionality .

I'm a total stranger to your way of working for application development. It also seems that the teams are quite different for Android and IOS. However, I wanted to bring up a use case from a user (@Baidax). I happened to read their comments about how a 1x1 widget (image) broke with the improved versions of the widgets. Is it possible to support the 1x1 use case?

Mar 21 2024, 2:00 PM · Wikipedia-Android-App-Backlog (Android Release - FY2023-24)

Mar 14 2024

Lofhi awarded T359152: Deploy initial version of night mode to pilot wikis on the mobile website for testing a Party Time token.
Mar 14 2024, 9:03 PM · Web-Team-Backlog (FY2023-24 Q3 Sprint 6), FY2023-24-WE 2.1 Typography and palette customizations
Lofhi added a comment to T359983: Rename the skin night mode classes to something more sensible before they become widely used.

cough
https://fr.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=213342921

Mar 14 2024, 7:27 PM · Verified, Web-Team-Backlog (FY2023-24 Q3 Sprint 6), MW-1.42-notes (1.42.0-wmf.24; 2024-03-26), FY2023-24-WE 2.1 Typography and palette customizations
Lofhi added a comment to T359644: Work with communities to standardize infoboxes.

Does WMF have a position on frwiki's infobox header colors? At the very least, they need to be reworked for contrast, but would WMF argue that it would be better to adopt a consistent, global color for all of them?

Mar 14 2024, 11:03 AM · Web-Team-Backlog (FY2023-24 Q4 Sprint 2), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations

Mar 13 2024

Lofhi created T360010: Future of OOUI and MediaWiki UI.
Mar 13 2024, 9:14 AM · Design-System-Team, UI-Standardization, OOUI, Codex
Lofhi added a comment to T359644: Work with communities to standardize infoboxes.

Alright. I don't really know how do you want to enable the dark mode only for the technical editors but I can only wait.

Mar 13 2024, 8:48 AM · Web-Team-Backlog (FY2023-24 Q4 Sprint 2), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations

Mar 12 2024

Lofhi added a comment to T359644: Work with communities to standardize infoboxes.

Let me rephrase: how do you expect us to notice compatibility problems with night mode if we have to constantly add ?vectornightmode=1 to the URL? By not blocking the beta feature rollout, you allow frwiki registered editors to use night mode as they choose, and to report problems as they read through our two million (almost three) articles.

Mar 12 2024, 9:46 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 2), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations
Lofhi added a comment to T357453: WCAG Color Contrast Violations in Infobox on Minerva Skin Night Mode.

I only see hacks.less getting bigger and this will surely complicate fixes in the long term. How easily should itwiki (and all projects) know that one of its CSS classes is hard-corrected in MediaWiki?

Mar 12 2024, 4:59 PM · Accessibility, Verified, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Web-Team-Backlog (FY2023-24 Q3 Sprint 4), FY2023-24-WE 2.1 Typography and palette customizations
Lofhi added a comment to T359644: Work with communities to standardize infoboxes.

How do you expect projects to correct their issues by making night mode inaccessible?

Mar 12 2024, 4:45 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 2), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations

Mar 11 2024

Lofhi added a comment to T359644: Work with communities to standardize infoboxes.

Blocks deployment to French Wikipedia [...]

Mar 11 2024, 12:00 AM · Web-Team-Backlog (FY2023-24 Q4 Sprint 2), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations

Mar 10 2024

Lofhi added a comment to T356344: [Night mode] Templates can be fixed by editors when necessary for night mode.

But the problem is, what do the technical contributors think? I will try to gather their feedback.

Mar 10 2024, 9:30 PM · FY2023-24-WE 2.1 Typography and palette customizations, Web-Team-Backlog

Mar 6 2024

Lofhi created T359431: Lack or limitations of concurrency .
Mar 6 2024, 5:57 PM · superset.wmcloud.org
Lofhi updated the task description for T359314: Somehow a regression: base light inputs background are dark.
Mar 6 2024, 11:45 AM · Regression, MinervaNeue
Lofhi created T359314: Somehow a regression: base light inputs background are dark.
Mar 6 2024, 11:39 AM · Regression, MinervaNeue

Mar 5 2024

Lofhi added a comment to T26070: [GOAL] Provide a dark / night mode skin or theme.

There is something I don't understand @Esanders. Why are you uninverting the CSS filter on images? I will ask a very dumb question: why not using the not CSS selector to exclude img? For old browsers support?

Mar 5 2024, 8:34 PM · FY2023-24-WE 2.1 Typography and palette customizations, Community-Wishlist-Survey-2023, MediaWiki-extensions-DarkMode, MediaWiki-Core-Skin-Architecture, MediaWiki-User-Interface
Lofhi added a comment to T356344: [Night mode] Templates can be fixed by editors when necessary for night mode.

I believe the entire community would be willing to participate as pilots for the new night mode, given their constructive contributions when they participated as one of the few major wikis to test the new discussion tools early on.

Mar 5 2024, 4:01 PM · FY2023-24-WE 2.1 Typography and palette customizations, Web-Team-Backlog

Mar 4 2024

Lofhi added a comment to T357580: [Technical admins] Vector scripts/styles will no longer apply on Vector 2022 on some wikis.

I wanted to know the proportion of the active editors not using Vector (both versions).

Mar 4 2024, 7:11 AM · User-notice

Mar 2 2024

Lofhi added a comment to T356344: [Night mode] Templates can be fixed by editors when necessary for night mode.

[...] when necessary [...]

Mar 2 2024, 1:39 PM · FY2023-24-WE 2.1 Typography and palette customizations, Web-Team-Backlog

Mar 1 2024

Lofhi edited Description on Hitaden.
Mar 1 2024, 12:19 PM
Lofhi added a comment to T353313: [docs] Create a tutorial on how to deploy a Node.js app using Build Service.

Since I've been kicking myself for the past two months with all these new services using a web service based on node, I may write a tutorial if the WMF doesn't mind. My memory is fresh enough to point out the blocking points.

Mar 1 2024, 11:57 AM · Toolforge (Toolforge iteration 09), cloud-services-team (FY2023/2024-Q3-Q4)

Feb 28 2024

Lofhi renamed Hitaden from Tool-hitaden to Hitaden.
Feb 28 2024, 5:48 AM
Lofhi added a comment to T353752: Account pending approval banner shown on initial sign-in gives no context for how to proceed.

You were confirmed by the Tool-gitlab-account-approval bot because you were already a member of the Trusted-Contributors Phabricator group.

Feb 28 2024, 12:44 AM · GitLab
Lofhi added a comment to T353752: Account pending approval banner shown on initial sign-in gives no context for how to proceed.

In my experience, I was confirmed after a brief wait. It appears to be the sole process within the WMF ecosystem that requires approval, but I believe it's acceptable. From what I remember, the only prerequisite for potentially using this type of service is when you are creating an account to create your first Toolforge tool.

Feb 28 2024, 12:13 AM · GitLab

Feb 26 2024

Lofhi added a comment to T26070: [GOAL] Provide a dark / night mode skin or theme.

We need stability for communication to communities: are we talking about a night mode, or a dark mode? I read MediaWiki-extensions-DarkMode. But the WMF wrote this page: recommendations for night mode compatibility on Wikimedia wikis, initially named recommendations for dark mode compatibility on Wikimedia wikis. Also, the WMF published the "Dark mode is coming" blog post 4 days before the recommendations page rename.

Feb 26 2024, 6:39 AM · FY2023-24-WE 2.1 Typography and palette customizations, Community-Wishlist-Survey-2023, MediaWiki-extensions-DarkMode, MediaWiki-Core-Skin-Architecture, MediaWiki-User-Interface

Feb 23 2024

Lofhi added a comment to T357580: [Technical admins] Vector scripts/styles will no longer apply on Vector 2022 on some wikis.

@Jdlrobson, could you please share the percent usage by skin? The SQL results for my user_properties view is heavily redacted for obvious reasons.

Feb 23 2024, 8:24 PM · User-notice
Lofhi added a comment to T357580: [Technical admins] Vector scripts/styles will no longer apply on Vector 2022 on some wikis.

What would the WMF think about mass editing instead of using their "temporary" gadget based on individual actions? Currently, I see ~1 900 edits per minute, for all the projects. Adding 300 edits per minute to this average for 10 minutes in the middle of the night in Europe to process all the pages on frwiki would be an acceptable stress on the DBs? We have like ~ 1 000 pages, so *2.

Feb 23 2024, 12:25 AM · User-notice

Feb 22 2024

Lofhi added a comment to T357693: Show patrol link regardless of whether preview is shown (Was: Edits can't be patrolled on Commons by users who have the user preference "Do not show page content below diffs" enabled).

Finally found that DifferenceEngine was modified and then I found this task. T357213 caused some community noises on frwiki too and yes, the problem is only met by editors with "Do not show page content below diffs" enabled. Thanks for the reporting @Yann, and @Jdlrobson for the permanent fix.

Feb 22 2024, 7:01 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Regression, MediaWiki-Patrolling, Commons

Feb 20 2024

Lofhi added a comment to T356465: [Spike] Determine how to Codex should support different themes/modes.

I'm pretty convinced that we should not worry about this. Codex is the design system for Wikimedia, so I think it's okay to limit ourselves, especially given our limited resourcing, to the themes/modes for Wikimedia products.

Feb 20 2024, 6:43 PM · Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex, Epic
Lofhi added a comment to T357835: Dark mode color palette.

To recap, a palette already exists and needs to be integrated into the tokens defined with Codex. So I've got the answer to my question. In addition, it's already planned to add "themes" to Codex components (Vue and only-CSS ones?). So it's more than I expected!

Feb 20 2024, 6:34 PM · Design-System-Team, Codex

Feb 19 2024

Lofhi added a comment to T340590: Update Vue to 3.3.x.

No misunderstanding: I was just asking the questions to find out what the WMF thought about it! I am not sure that volunteers patches to update external dependencies would be appreciated by the WMF staff ; it's a bit of an interference for my taste, and it seems even less trivial to touch mediawiki/core. Updating now to 3.4 seems a bad idea, but 3.3.13 should be good. Not sure about my capacity about sending patches, MediaWiki ecosystem is big and scary.

Feb 19 2024, 11:10 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Design-System-Team (DST-Sprint-12 (2023-11-28 to 2023-12-08)), MediaWiki-Platform-Team (Radar), MediaWiki-ResourceLoader, Codex, Vue.js
Lofhi updated subscribers of T340590: Update Vue to 3.3.x.

Also, it seems that @egardner sees into the future. He had already planned interventions like mine. https://gerrit.wikimedia.org/r/c/design/codex/+/978712/1/packages/codex/package.json#86

Feb 19 2024, 10:56 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Design-System-Team (DST-Sprint-12 (2023-11-28 to 2023-12-08)), MediaWiki-Platform-Team (Radar), MediaWiki-ResourceLoader, Codex, Vue.js
Lofhi added a comment to T340590: Update Vue to 3.3.x.

My bad for the last minor, I quoted the one just before the release of 3.4.0-beta.1.

Feb 19 2024, 10:50 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Design-System-Team (DST-Sprint-12 (2023-11-28 to 2023-12-08)), MediaWiki-Platform-Team (Radar), MediaWiki-ResourceLoader, Codex, Vue.js
Lofhi added a comment to T340590: Update Vue to 3.3.x.

I'm uncertain where to seek clarification. Could you please share on a MediaWiki/Wikitech page the strategy for Vue, which serves for much of the client-side now with Codex? Found nothing on https://www.mediawiki.org/wiki/Vue.js

Feb 19 2024, 10:30 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Design-System-Team (DST-Sprint-12 (2023-11-28 to 2023-12-08)), MediaWiki-Platform-Team (Radar), MediaWiki-ResourceLoader, Codex, Vue.js

Feb 16 2024

Lofhi added a comment to T357835: Dark mode color palette.

Meh, I just found T356537. Not sure if merging is needed, since T356537 is adding the support of custom properties (so be able to customize components I guess), without defining a dark mode color palette.

Feb 16 2024, 11:10 PM · Design-System-Team, Codex
Lofhi created T357835: Dark mode color palette.
Feb 16 2024, 11:03 PM · Design-System-Team, Codex

Feb 11 2024

Lofhi added a comment to T357243: The main user-dashboard is using a only-Webkit supported CSS rule value.

Thanks, will notify them. Good luck with the rest!

Feb 11 2024, 11:21 PM · Adiutor
Lofhi created T357243: The main user-dashboard is using a only-Webkit supported CSS rule value.
Feb 11 2024, 10:52 PM · Adiutor

Jan 31 2024

Lofhi added a comment to T356196: Auto triming of internal links is breaking anchors if the last character is a space.

The link work by itself. Now, try to paste it in visual mode, or add an internal link using the “add a link” button on source mode. The previewed generated link has no trailing _, the identifier is broken. Firefox 122, Windows 11.

Jan 31 2024, 2:28 AM · Patch-For-Review, VisualEditor, User-notice, Editing-team, DiscussionTools

Jan 30 2024

Lofhi updated the task description for T356196: Auto triming of internal links is breaking anchors if the last character is a space.
Jan 30 2024, 5:08 PM · Patch-For-Review, VisualEditor, User-notice, Editing-team, DiscussionTools