Background
Some images have a transparent background, which is not a problem in day mode. Some images, however, have a transparent background that causes problems when night mode is activated, for example black signatures of living personalities.
Steps to reproduce
- visit https://en.wikipedia.beta.wmflabs.org/wiki/Lightbox_demo#mediaviewer/File:Copyleft.svg
- visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Lightbox_demo?minervanightmode=1#/media/File:Copyleft.svg
Expected results
The background should consist of patterns not be white on mobile as it is on desktop.
{F44249619}
Actual results
- Screenshot or description of the issue.
Environments observed
- Browser version:
- OS version:
- Device model:
- Device language:
Check any additional observations
- Observed on the beta cluster wiki
- Observed on a production wiki
- Observed while logged in
- Observed while not logged in (anonymous)
Stack trace
Notes about other solutions
Two solutions:
- invert image colors when night mode is active (not a global solution : hard to explain the cases to the communities),
- add a white background to images (possible global solution when the problem arises).
Problem: what can be done to make the image readable when clicked and viewed with the MultimediaViewer?
Should the projects locally play by overriding some CSS rules of the viewer? Should the MultimediaViewer apply the same classes applied on the thumb ([[File:ohno.png|thumb|class=pls-we-need-some-light]])? Etc.
Code base
https://gerrit.wikimedia.org/r/admin/repos/mediawiki/extensions/MobileFrontend,general
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/MobileFrontend/+/refs/heads/master/resources/mobile.mediaViewer/ImageCarousel.less
QA Results - Beta
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T360856#9779397 |
Task Description:
QA Results - PROD
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T360856#9807593 |
