Page MenuHomePhabricator

Huji (Huji Lee)
MediaWiki developer

Projects (12)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 25 2014, 1:21 PM (342 w, 2 d)
Availability
Available
IRC Nick
Huji
LDAP User
Huji
MediaWiki User
Huji [ Global Accounts ]

Recent Activity

Fri, May 14

Huji added a comment to T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".

@daniel the patch you proposed was merged on 5/4 so I assume it will hit production on Monday; is that correct? Just want to make sure when we can test it more broadly in production and (hopefully) close this task.

Fri, May 14, 6:14 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error

Thu, May 13

Huji added a comment to T282486: Enable ShortDescriptions on fawiki.

@DannyH with this understanding, should I schedule the patch for deployment again? If yes, I will ask @Urbanecm to remove the -2 as well.

Thu, May 13, 12:22 AM · Patch-For-Review, Wikimedia-Site-requests

Tue, May 11

Huji added a comment to T282486: Enable ShortDescriptions on fawiki.

@Zabe the reason for declining, as explained in T204136#4594847, has nothing to do with this case.

The reason I pinged was T204136#4584681

Tue, May 11, 12:36 PM · Patch-For-Review, Wikimedia-Site-requests
Huji added a comment to T282486: Enable ShortDescriptions on fawiki.

Yes, the scope of the consensus right now is only focused on the first. This way, if vandalism occurs on Wikidata, the local community has a very easy way to stop its impact (by adding local description); similarly, if an article is locally protected, its short description can be locally specified so that it would also be subject to the protection.

Tue, May 11, 11:10 AM · Patch-For-Review, Wikimedia-Site-requests
Huji created T282504: Reconsider the design of ShortDescription extension.
Tue, May 11, 12:47 AM · Wikidata

Mon, May 10

Huji added a comment to T282486: Enable ShortDescriptions on fawiki.

@DannyH: can you please provide me with the reasoning of why this was rejected back in 2018 at T204136#4584681 and clarify whether your 2021 comment at T279829#7034774 plus the fawiki community consensus linked above means this task should be proceeded with or not?

Mon, May 10, 11:31 PM · Patch-For-Review, Wikimedia-Site-requests
Huji added a comment to T282486: Enable ShortDescriptions on fawiki.

@Zabe the reason for declining, as explained in T204136#4594847, has nothing to do with this case.

Mon, May 10, 11:13 PM · Patch-For-Review, Wikimedia-Site-requests
Huji created T282486: Enable ShortDescriptions on fawiki.
Mon, May 10, 7:01 PM · Patch-For-Review, Wikimedia-Site-requests

Fri, Apr 30

Huji added a comment to T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".

I would make a separate task, because this is a completely separate workflow.

Fri, Apr 30, 7:52 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error

Thu, Apr 29

Huji created T281440: Add Arabic Hamza Above to Arabic extended character set.
Thu, Apr 29, 1:14 AM · Patch-For-Review, MediaWiki-Internationalization

Tue, Apr 27

Huji added a comment to T281286: Show actual join date for users in mobile view.

(Conveying the question back to the user and will update this with their response)

Tue, Apr 27, 9:28 PM · Readers-Web-Backlog (Tracking), MinervaNeue, MobileFrontend, Mobile
Huji added a project to T281286: Show actual join date for users in mobile view: MinervaNeue.

The message associate with this tagline mobile-frontend-user-page-member-since and here is where it gets populated.

Tue, Apr 27, 4:46 PM · Readers-Web-Backlog (Tracking), MinervaNeue, MobileFrontend, Mobile
Huji edited projects for T281286: Show actual join date for users in mobile view, added: MobileFrontend; removed MinervaNeue.
Tue, Apr 27, 4:45 PM · Readers-Web-Backlog (Tracking), MinervaNeue, MobileFrontend, Mobile
Huji renamed T281286: Show actual join date for users in mobile view from Show actual to Show actual join date for users in mobile view.
Tue, Apr 27, 4:44 PM · Readers-Web-Backlog (Tracking), MinervaNeue, MobileFrontend, Mobile
Huji created T281286: Show actual join date for users in mobile view.
Tue, Apr 27, 4:43 PM · Readers-Web-Backlog (Tracking), MinervaNeue, MobileFrontend, Mobile
Huji updated the task description for T279743: Assign a class to LI elements in Get Users to distinguish anonymous and registered users .
Tue, Apr 27, 2:02 AM · Patch-For-Review, CheckUser
Huji updated the task description for T279743: Assign a class to LI elements in Get Users to distinguish anonymous and registered users .
Tue, Apr 27, 2:02 AM · Patch-For-Review, CheckUser

Sun, Apr 25

Huji added a comment to T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".

I understand but:

  • it's still possible to test it in other wikis. Devs can see the list of fatals in logstash which are constantly happening.
Sun, Apr 25, 1:13 AM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error

Sat, Apr 24

Huji added a comment to T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".

Let me put it this way: if you can replicate this in another wiki, I am good with your modification to the template. Otherwise, your edit makes the issue non-testable and will significantly delay its fix, and also takes away useful features on wiki. Both of those are bad things.

Sat, Apr 24, 8:48 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error
Huji added a comment to T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".

@Ladsgroup we already knew that portion of the {{R from move}} template which you removed in your edit was the cause for this issue to manifest. But that is not the root cause.

Sat, Apr 24, 5:44 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error

Thu, Apr 22

Huji added a comment to T280929: SkinModule for Vector (new and legacy) is missing toc/print styles (outputs raw server path instead).

@Mainframe98 with respect, I also invite you to see the comments on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/681971 and make sure you review https://www.mediawiki.org/wiki/Manual:Coding_conventions/CSS#LESS on proper use of the @noflip declaration. It was not used correctly in rMW5e7076f21e83: Move legacy commonPrint styles to appropriate skin features

Thu, Apr 22, 9:06 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Readers-Web-Backlog (Kanbanana-FY-2020-21), MediaWiki-Core-Skin-Architecture, Performance-Team (Radar)
Huji created T280929: SkinModule for Vector (new and legacy) is missing toc/print styles (outputs raw server path instead).
Thu, Apr 22, 5:50 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Readers-Web-Backlog (Kanbanana-FY-2020-21), MediaWiki-Core-Skin-Architecture, Performance-Team (Radar)
Huji added a comment to T280428: @noflip is not working in toc related LESS file.

but also because of the second and more important issue still being unresolved, i.e. the internal server paths being sent to the client (T280428#7012326)

Let's make that a different task, as this one is an implicitly-UBN blocker to the RC.0 cut.

Thu, Apr 22, 5:32 PM · MW-1.36-notes, Performance-Team (Radar), MW-1.36-release, Readers-Web-Backlog (Kanbanana-FY-2020-21), MediaWiki-Interface, MediaWiki-ResourceLoader, Patch-For-Review, MediaWiki-Internationalization, CSS, RTL, I18n
Huji updated subscribers of T280428: @noflip is not working in toc related LESS file.

rMWb177d3f64a82 should resolve the issue originally reported above. However, I think this task should stay open, not only because backports to 1.36 are needed (@Jdforrester-WMF would you take care of that, or do you want me to do the cherrypicks?) but also because of the second and more important issue still being unresolved, i.e. the internal server paths being sent to the client (T280428#7012326)

Thu, Apr 22, 11:46 AM · MW-1.36-notes, Performance-Team (Radar), MW-1.36-release, Readers-Web-Backlog (Kanbanana-FY-2020-21), MediaWiki-Interface, MediaWiki-ResourceLoader, Patch-For-Review, MediaWiki-Internationalization, CSS, RTL, I18n
Huji added a comment to T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".

In above comments, we found some evidence that both the page being moved and its talk page played a role in this issue raising. We also found that users can work around this bug by moving the page and the talk page separately.

That is very interesting - do you have a way to reliably reproduce the error? Can you set up some "immovable" sandbox page that can be used to investigate this? We have so far been unable to reproduce the issue in a testing environment. Being able to reproduce it on the life wiki, somewhere were it's not bothering anyone, would perhaps allow us to find the issue.

Thu, Apr 22, 11:40 AM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error

Tue, Apr 20

Huji updated the task description for T280726: Create a tool that makes it easier to map IPs to ASN CIDRs.
Tue, Apr 20, 7:58 PM · Technical-Tool-Request
Huji updated the task description for T280726: Create a tool that makes it easier to map IPs to ASN CIDRs.
Tue, Apr 20, 7:57 PM · Technical-Tool-Request
Huji created T280726: Create a tool that makes it easier to map IPs to ASN CIDRs.
Tue, Apr 20, 7:45 PM · Technical-Tool-Request
Huji added a comment to T280428: @noflip is not working in toc related LESS file.

This is the git version in which the issue first occured: rMWc504f19f1faa6f59acda1ac50c24d74d3c92985e

Tue, Apr 20, 6:50 PM · MW-1.36-notes, Performance-Team (Radar), MW-1.36-release, Readers-Web-Backlog (Kanbanana-FY-2020-21), MediaWiki-Interface, MediaWiki-ResourceLoader, Patch-For-Review, MediaWiki-Internationalization, CSS, RTL, I18n
Huji added a comment to T280428: @noflip is not working in toc related LESS file.

@Jdlrobson yes.

Tue, Apr 20, 6:25 PM · MW-1.36-notes, Performance-Team (Radar), MW-1.36-release, Readers-Web-Backlog (Kanbanana-FY-2020-21), MediaWiki-Interface, MediaWiki-ResourceLoader, Patch-For-Review, MediaWiki-Internationalization, CSS, RTL, I18n

Mon, Apr 19

Huji added a comment to T280428: @noflip is not working in toc related LESS file.

@Krinkle good catch! Somehow I was blind to it.

Mon, Apr 19, 1:37 PM · MW-1.36-notes, Performance-Team (Radar), MW-1.36-release, Readers-Web-Backlog (Kanbanana-FY-2020-21), MediaWiki-Interface, MediaWiki-ResourceLoader, Patch-For-Review, MediaWiki-Internationalization, CSS, RTL, I18n
Huji added a comment to T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".

In above comments, we found some evidence that both the page being moved and its talk page played a role in this issue raising. We also found that users can work around this bug by moving the page and the talk page separately.

Mon, Apr 19, 1:13 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error

Sun, Apr 18

Huji added a comment to T280428: @noflip is not working in toc related LESS file.

After reviewing other LESS code in MediaWiki code base, I came to the conclusion that the appropriate way to use @noflip in nested contexts is to specify it before each directional statement. I amended the patch so that it would make this correction.

Sun, Apr 18, 2:11 AM · MW-1.36-notes, Performance-Team (Radar), MW-1.36-release, Readers-Web-Backlog (Kanbanana-FY-2020-21), MediaWiki-Interface, MediaWiki-ResourceLoader, Patch-For-Review, MediaWiki-Internationalization, CSS, RTL, I18n
Huji added a comment to T280428: @noflip is not working in toc related LESS file.

The above patch fixes the issue. However, the fact that this issue emerged recently while the LESS file in question had not been edited since 2020-12-09 is troubling. It seems like @noflip was formerly parsed if it was inside a nested LESS syntax but it has stopped working recently. Therefore, I propose *not* merging the patch, but identifying and fixing the root cause of the problem instead.

Sun, Apr 18, 2:01 AM · MW-1.36-notes, Performance-Team (Radar), MW-1.36-release, Readers-Web-Backlog (Kanbanana-FY-2020-21), MediaWiki-Interface, MediaWiki-ResourceLoader, Patch-For-Review, MediaWiki-Internationalization, CSS, RTL, I18n

Apr 17 2021

Huji added a comment to T280428: @noflip is not working in toc related LESS file.

As I look at the output of https://fa.wikipedia.org/w/load.php?lang=fa&only=styles&skin=vector&modules=skins.vector.icons%2Cstyles which I have pasted below after tidying I noticed that it contains to sets of rules for .mw-content-rtl .tocnumber, one for screen and one for print. Notably, the @noflip works correctly for the print version but not the screen version.

Apr 17 2021, 1:50 AM · MW-1.36-notes, Performance-Team (Radar), MW-1.36-release, Readers-Web-Backlog (Kanbanana-FY-2020-21), MediaWiki-Interface, MediaWiki-ResourceLoader, Patch-For-Review, MediaWiki-Internationalization, CSS, RTL, I18n
Huji updated the task description for T280428: @noflip is not working in toc related LESS file.
Apr 17 2021, 1:33 AM · MW-1.36-notes, Performance-Team (Radar), MW-1.36-release, Readers-Web-Backlog (Kanbanana-FY-2020-21), MediaWiki-Interface, MediaWiki-ResourceLoader, Patch-For-Review, MediaWiki-Internationalization, CSS, RTL, I18n
Huji updated the task description for T280428: @noflip is not working in toc related LESS file.
Apr 17 2021, 1:32 AM · MW-1.36-notes, Performance-Team (Radar), MW-1.36-release, Readers-Web-Backlog (Kanbanana-FY-2020-21), MediaWiki-Interface, MediaWiki-ResourceLoader, Patch-For-Review, MediaWiki-Internationalization, CSS, RTL, I18n
Huji added a project to T280428: @noflip is not working in toc related LESS file: MediaWiki-Internationalization.
Apr 17 2021, 1:31 AM · MW-1.36-notes, Performance-Team (Radar), MW-1.36-release, Readers-Web-Backlog (Kanbanana-FY-2020-21), MediaWiki-Interface, MediaWiki-ResourceLoader, Patch-For-Review, MediaWiki-Internationalization, CSS, RTL, I18n
Huji created T280428: @noflip is not working in toc related LESS file.
Apr 17 2021, 1:26 AM · MW-1.36-notes, Performance-Team (Radar), MW-1.36-release, Readers-Web-Backlog (Kanbanana-FY-2020-21), MediaWiki-Interface, MediaWiki-ResourceLoader, Patch-For-Review, MediaWiki-Internationalization, CSS, RTL, I18n

Apr 15 2021

Huji added a comment to T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".

It is hard to quantify the impact (only those with logstash access can quantify it really). But I can tell you that in the last few weeks, at least 6 or 7 users have reported it on fawiki for various pages. I can also tell you that in that same period, hundreds of pages have been successfully moved on fawiki. So your original assessment of "it only impacts some pages on some wikis" is correct, but because no solid workaround exists, I still prefer this to be UBN and attract more attention from the developer community and the WMF engineers.

Apr 15 2021, 10:38 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error

Apr 14 2021

Huji added a comment to T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".

I have not made any further progress on this, and I am still unable to replicate this on my local wiki.

Apr 14 2021, 10:20 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error

Apr 13 2021

Huji created T279974: Investigate making cas capable of handling case insensitive usernames.
Apr 13 2021, 12:15 AM · CAS-SSO

Apr 12 2021

Huji added a comment to T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".

... I just added Huji (in addition to huji) to the list of individually authorized users, hopefully that would fix it.

Apr 12 2021, 10:48 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error
Huji added a comment to T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".

For the record, https://people.wikimedia.org/~urbanecm/nda/XWikimediaDebug.log-20210411-first-move-redacted.gz [NDA-only link; @Huji should have access; my IP address/cookies redacted, as well as all logs following the error] should be full debug logs captured for my yesterday experiment. Maybe something else attracts your attention there.

Apr 12 2021, 9:41 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error
Huji added a comment to T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".

Having established that this has to do with the page AND the talk page, I copied the current contents of the page and the talk page to another page and talk page in the same namespace on fawiki. To my surprise, this new pair was possible to move without an error.

Apr 12 2021, 2:24 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error
Huji added a comment to T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".

Another piece of interesting information shared by a user on fawiki: the move they attempted failed, then they unchecked the "Move associated talk page" option and the move worked. They could subsequently move the talk page separate with success.

Apr 12 2021, 12:38 AM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error
Huji added a comment to T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".

Here is another observation. After going into Scribunto's code and coming out of it, the execution path described by the stack trace ends with this exception:

Apr 12 2021, 12:18 AM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error

Apr 11 2021

Huji added a comment to T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".

Okay that was really helpful. I did not know whether it is the page content of the "source" page or the "destination" page that is triggering the issue. Evidently, it is the content of the source page (which is autoreplaced with {{R from move}}). And that template does use a module (Module:Redirect). Let's see where I can go from here.

Apr 11 2021, 7:59 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error
Huji added a comment to T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".

@Urbanecm see my update on my last comment right above. Could we modify mwdebug1001 through a patch that would log the value of $text on line 2862 of Parser.php so we can look into it and see why Parser does not find it to have a length of zero?

Apr 11 2021, 6:51 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error
Huji added a comment to T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".

Stack trace for when I attempted to move the page while it was empty is shown below. I don't know the MW Parser well, but is surprising to me that PPTemplateFrame_Hash is instantiated when the page has absolutely no content.

Apr 11 2021, 6:22 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error
Huji added a comment to T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".

@Urbanecm and I just test this on mwdebug1001 with this page on fawiki: فهرست نامداران بابل. An attempt to move it to فهرست اهالی بابل failed on PROD, but succeeded on mwdebug1001 when Scribunto was disabled. The target page did not exist before the move.

Apr 11 2021, 5:56 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error
Huji added a comment to T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".

[...]
Fortunately, that's easy to test when there's a stable way to reproduce. I deactivated AbuseFilter on a debug server, and tried to move a page again, and it still didn't get moved.

Uninstalling Scribunto and ParserFunctions (two extensions listed in the stacktrace) helped.

Apr 11 2021, 5:45 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error
Huji added a comment to T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".

I deactivated AbuseFilter on a debug server, and tried to move a page again, and it still didn't get moved.

Apr 11 2021, 5:44 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error
Huji added a comment to T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".
...
  #15 {main}
2021-04-11 17:08:20 [b27894e2-1e49-42c6-bd43-f0f8df10f1d6] mw1333 mswiki 1.36.0-wmf.38 exception ERROR: [b27894e2-1e49-42c6-bd43-f0f8df10f1d6] /w/index.php?title=Khas:Pindah_laman&action=submit   InvalidArgumentException: The Title object yields no ID. Perhaps the page [[Perbincangan:Bones_(siri_TV)]] doesn't exist? {"exception_url":"/w/index.php?title=Khas:Pindah_laman&action=submit","reqId":"b27894e2-1e49-42c6-bd43-f0f8df10f1d6","caught_by":"other"}
[Exception InvalidArgumentException] (/srv/mediawiki/php-1.36.0-wmf.38/includes/deferred/LinksUpdate.php:140) The Title object yields no ID. Perhaps the page [[Perbincangan:Bones_(siri_TV)]] doesn't exist?
...
Apr 11 2021, 5:18 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error
Huji added a comment to T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?".

Can someone with access to logstash provide an update on which wikis are affected and since when? We know fawiki, dewiki and mswiki are affected but who else? Also, as far as fawiki, we know this was reported as early as April 9th (one day after 1.36.0-wmf.38 was deployed); do we have logs from before April 8th?

Apr 11 2021, 5:13 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error
Huji added a comment to T182546: Require indentation of CASE statements in PHP code.

So what is the next step? Revert the revert in https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/637062 ?

Apr 11 2021, 1:06 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MW-1.35-notes, Patch-For-Review, MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), MediaWiki-Codesniffer

Apr 10 2021

Huji triaged T279832: Some pages moves fail with "InvalidArgumentException: The Title object yields no ID. Perhaps the page doesn't exist?" as Unbreak Now! priority.

My uneducated guess: AbuseFilter is to blame.

Apr 10 2021, 5:54 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-extensions-Scribunto, Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-rename, Wikimedia-production-error
Huji added a comment to T182546: Require indentation of CASE statements in PHP code.

@Umherirrender what about what @DannyS712 said in T182546#6589546?

Apr 10 2021, 12:08 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MW-1.35-notes, Patch-For-Review, MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), MediaWiki-Codesniffer

Apr 9 2021

Huji created T279743: Assign a class to LI elements in Get Users to distinguish anonymous and registered users .
Apr 9 2021, 12:15 AM · Patch-For-Review, CheckUser

Apr 5 2021

Huji added a comment to T279305: WVUI search suggestion font size is too big.

The source code was easy to fine: https://gerrit.wikimedia.org/g/mediawiki/core/+/3a047b749b6cd3b8ccc4ea16673b795624b9c28b/resources/lib/wvui/wvui.css#275

Apr 5 2021, 4:47 PM · Desktop Improvements, WVUI
Huji created T279305: WVUI search suggestion font size is too big.
Apr 5 2021, 4:46 PM · Desktop Improvements, WVUI

Mar 27 2021

Huji created T278625: Italicize the page title for redirects in Nuke's page list.
Mar 27 2021, 5:09 PM · MediaWiki-extensions-Nuke

Mar 25 2021

Huji closed T276726: Add support for revision delete as Resolved.
Mar 25 2021, 3:56 PM · Pywikibot

Mar 23 2021

Huji added a comment to T277358: Add deleterevision right to botadmin group on fawiki.

[...]
What permission change do we need for the botadmin group to be able to see the archivename values?

I just tested it with my own accounts, and granting 'deletedtext' fixed this. You might want to also grant 'deletedhistory', since text without history is rarely useful.

Actually, I think I found it. https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/api/ApiQueryImageInfo.php uses userCanSeeRevDel() but the function currently does not honor deleterevision as a right that would allow user to get the so called "private" bits back. This is wrong; when I log in using that botadmin account and use the web interface, I do see the file history and delete/undelete revisions.

I will make a patch for it shortly.

I think the function is behaving correctly. deleterevision should be used as a right guarding revision deletion. If a wiki wants a particular group to view deleted stuff, deletedtext or deletedhistory makes much more sense to grant.

Mar 23 2021, 3:47 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Wikimedia-Site-requests
Huji added a comment to T277358: Add deleterevision right to botadmin group on fawiki.

Actually, I think I found it. https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/api/ApiQueryImageInfo.php uses userCanSeeRevDel() but the function currently does not honor deleterevision as a right that would allow user to get the so called "private" bits back. This is wrong; when I log in using that botadmin account and use the web interface, I do see the file history and delete/undelete revisions.

Mar 23 2021, 3:37 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Wikimedia-Site-requests
Huji added a comment to T277358: Add deleterevision right to botadmin group on fawiki.

@Urbanecm I was able to get to the bottom of this. What we need is for the botadmin group to have the ability to retrieve the archivename attribute of a file's deleted revisions. Currently, admins (i.e those in sysop group) get it but botadmins do not.

Mar 23 2021, 3:16 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Wikimedia-Site-requests

Mar 21 2021

Huji updated the task description for T278046: Convert epytext docstrings to reST (sphinx).
Mar 21 2021, 6:05 PM · Pywikibot, Pywikibot-Documentation
Huji added a comment to T278046: Convert epytext docstrings to reST (sphinx).

Thanks. Updating task accordingly.

Mar 21 2021, 6:01 PM · Pywikibot, Pywikibot-Documentation
Huji added a comment to T278046: Convert epytext docstrings to reST (sphinx).

@Xqt for my own education as well as improving the task definition for future reference, can you put some links that describe the history of epytext or indicate that it is not maintained (since when) and about the sphinx-epytext conversion?

Mar 21 2021, 3:38 PM · Pywikibot, Pywikibot-Documentation

Mar 17 2021

Huji closed T277419: Thumbnail is not being generated after a file version is undeleted as Resolved.

@AntiCompositeNumber thanks for the detailed explanation.

Mar 17 2021, 12:49 AM · Thumbor, Commons, MediaWiki-File-management

Mar 16 2021

Huji added a comment to T277419: Thumbnail is not being generated after a file version is undeleted.

@AntiCompositeNumber I guess I overwhelmed the thumbnail generation process.

Mar 16 2021, 9:39 PM · Thumbor, Commons, MediaWiki-File-management
Huji added a comment to T277396: Lint test to match function signature and documentation.

@Xqt does flake8 even have support for this? I know it supports finding unused arguments and it supports some checks on doc strings but I am not familiar enough with flake8 to know if it supports the propose idea of the current Task.

Mar 16 2021, 9:38 PM · Release-Engineering-Team (Seen), Pywikibot-tests, Pywikibot
Huji added a comment to T277426: Do not present the logo through an img tag.

Here is an example of the workaround we are using on fawiki to support both the current and legacy Vector:

Mar 16 2021, 4:56 PM · Vector, Desktop Improvements

Mar 15 2021

Huji updated subscribers of T277358: Add deleterevision right to botadmin group on fawiki.

Thanks @Urbanecm for merging the patch. I thought this would resolve our underlying issue but it did not. Somehow, the file information API query returns more values for a sysop than a botadmin. Lets keep this Task open as I will investigate it more.

Mar 15 2021, 6:44 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Wikimedia-Site-requests
Huji removed a project from T277358: Add deleterevision right to botadmin group on fawiki: Patch-For-Review.
Mar 15 2021, 6:44 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Wikimedia-Site-requests
Huji updated the task description for T277426: Do not present the logo through an img tag.
Mar 15 2021, 12:59 AM · Vector, Desktop Improvements
Huji created T277426: Do not present the logo through an img tag.
Mar 15 2021, 12:58 AM · Vector, Desktop Improvements

Mar 14 2021

Huji created T277419: Thumbnail is not being generated after a file version is undeleted.
Mar 14 2021, 7:34 PM · Thumbor, Commons, MediaWiki-File-management
Huji added a comment to T276726: Add support for revision delete.

Actually never mind, prop=imageinfo does it. For example: https://test.wikipedia.org/wiki/Special:ApiSandbox#action=query&format=json&prop=imageinfo&titles=File%3AT276726.png&iilimit=15

Mar 14 2021, 6:58 PM · Pywikibot
Huji updated subscribers of T276726: Add support for revision delete.

@Xqt I ran into a problem with unit testing this for files. For page revisions, it is straightforward and the unit test I added already does the job. But for files, action=query&prop=revisions does not reflect changes to the file history. For instance when I revdel'ed the user for the oldest version of https://test.wikipedia.org/wiki/File:T276726.png and checked https://test.wikipedia.org/wiki/Special:ApiSandbox#action=query&format=json&prop=revisions&titles=File%3AT276726.png&rvlimit=15 it return info on the page revisions not the file revisions:

Mar 14 2021, 6:57 PM · Pywikibot
Huji committed rPWBCb22ffa9d377e: Support deleting and undeleting specific file versions (authored by Huji).
Support deleting and undeleting specific file versions
Mar 14 2021, 11:42 AM

Mar 13 2021

Huji created T277396: Lint test to match function signature and documentation.
Mar 13 2021, 11:43 PM · Release-Engineering-Team (Seen), Pywikibot-tests, Pywikibot
Huji closed T277386: mw.config.get('debug') is not Boolean any more as Resolved.

Thanks for the quick response!

Mar 13 2021, 11:30 PM · MediaWiki-ResourceLoader, Performance-Team
Huji created T277386: mw.config.get('debug') is not Boolean any more.
Mar 13 2021, 5:59 PM · MediaWiki-ResourceLoader, Performance-Team
Huji claimed T277358: Add deleterevision right to botadmin group on fawiki.
Mar 13 2021, 3:29 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Wikimedia-Site-requests
Huji created T277358: Add deleterevision right to botadmin group on fawiki.
Mar 13 2021, 3:27 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Wikimedia-Site-requests
Huji claimed T276725: Add method to delete specific versions of files.
Mar 13 2021, 3:23 AM · Patch-For-Review, Pywikibot
Huji claimed T276726: Add support for revision delete.
Mar 13 2021, 3:23 AM · Pywikibot
Huji added a comment to T276726: Add support for revision delete.

Note to self: on fawiki, deleterevision is not among the rights held by sysop bots and needs to be added.

Mar 13 2021, 3:02 AM · Pywikibot

Mar 8 2021

Huji added a subtask for T60941: Missing unit tests for pywikibot library (tracking): T85310: Add unit tests for MediaWiki, Yahoo and Google SearchPageGenerator.
Mar 8 2021, 1:28 PM · Google-Code-in-2017, Google-Code-In-2016, Technical-Debt, Google-Code-In-2015, Pywikibot, Tracking-Neverending, Pywikibot-tests
Huji added a parent task for T85310: Add unit tests for MediaWiki, Yahoo and Google SearchPageGenerator: T60941: Missing unit tests for pywikibot library (tracking).
Mar 8 2021, 1:28 PM · Pywikibot, Google-Code-in-2014, Pywikibot-tests, Pywikibot-pagegenerators.py
Huji added a comment to T276725: Add method to delete specific versions of files.

By the way, where do we run the unit tests? Evidently, it is not test.wikipedia.org anymore. Is it in a dockerized installation of MediaWiki? Some other wiki? Do we not run them at all?

Mar 8 2021, 1:27 PM · Patch-For-Review, Pywikibot
Huji updated subscribers of T276725: Add method to delete specific versions of files.

@Xqt I think I got this figure out in https://gerrit.wikimedia.org/r/c/pywikibot/core/+/669584

Mar 8 2021, 3:31 AM · Patch-For-Review, Pywikibot

Mar 7 2021

Huji created T276726: Add support for revision delete.
Mar 7 2021, 9:37 PM · Pywikibot
Huji created T276725: Add method to delete specific versions of files.
Mar 7 2021, 9:35 PM · Patch-For-Review, Pywikibot

Mar 6 2021

Huji updated subscribers of T276354: Don't attempt to tally large encrypted elections via the TallyPage.

One of the major deficiencies of MediaWiki-extensions-SecurePoll is that it does not have an API interface. If it did, we could use it to submit some votes programmatically to an election on testwiki. We could even create a CI test like that which would empirically measure the efficiency of SecurePoll after each patch.

Thanks @Huji, sounds like this would be worth filing... I doubt AHT would get round to this before the end of March, but would be useful to consider next time work is done on SecurePoll. @Niharika What do you think?

Mar 6 2021, 5:40 PM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Mar 4 2021

Huji added a comment to T269494: Forcibly creating a local account creates an erroneous automatic creation log entry.

Great, thanks! Will do my best to review it :).

Mar 4 2021, 1:45 AM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), MediaWiki-User-login-and-signup, MediaWiki-extensions-CentralAuth

Mar 3 2021

Huji added a comment to T276354: Don't attempt to tally large encrypted elections via the TallyPage.

! In Task Description, @Tchanders wrote:
It's difficult to test on production given the limited availability of large elections.

Mar 3 2021, 10:27 PM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Feb 28 2021

Huji added a comment to T275979: Autocreate log generated by CreateLocalAccount should not be associated with the actor's IP.

I merged it as duplicate in favor of the idea proposed in T269494.

Feb 28 2021, 2:47 PM · CheckUser, MediaWiki-extensions-CentralAuth
Huji merged task T275979: Autocreate log generated by CreateLocalAccount should not be associated with the actor's IP into T269494: Forcibly creating a local account creates an erroneous automatic creation log entry.
Feb 28 2021, 2:47 PM · CheckUser, MediaWiki-extensions-CentralAuth