Page MenuHomePhabricator

Huji (Huji Lee)
MediaWiki developer

Projects (12)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 25 2014, 1:21 PM (243 w, 2 d)
Availability
Available
IRC Nick
Huji
LDAP User
Huji
MediaWiki User
Huji [ Global Accounts ]

Recent Activity

Wed, Jun 19

Huji merged T226065: rsync: failed to set times on "/cache/." into T226064: mwext-php70-phan-seccheck-docker blocking merges.
Wed, Jun 19, 12:39 AM · Patch-For-Review, Release-Engineering-Team (Kanban), Continuous-Integration-Config
Huji merged task T226065: rsync: failed to set times on "/cache/." into T226064: mwext-php70-phan-seccheck-docker blocking merges.
Wed, Jun 19, 12:39 AM · Continuous-Integration-Config

Tue, Jun 18

Huji created T226065: rsync: failed to set times on "/cache/.".
Tue, Jun 18, 11:14 PM · Continuous-Integration-Config

Sun, Jun 2

Huji updated the task description for T223406: Remove reference to fields replaced by the actor table from WMCS views.
Sun, Jun 2, 11:33 PM · Data-Services, Core Platform Team Backlog (Watching / External)
Huji created T224839: SQL Optimizer does not work.
Sun, Jun 2, 7:52 PM · Tools

May 25 2019

Huji added a comment to T224321: Run populateCategory.php.

I don't think you should run it everywhere. At least not until we either fully fix the problem, or fix it in a way that these drifts happen rarely (say, once a day, or once a week). Only in that setting it is useful to have this script executed, so we can identify those rare drifts quickly and try to figure how they happened.

May 25 2019, 6:20 PM · Wikimedia-maintenance-script-run, Wikimedia-Site-requests
Huji added a comment to T224321: Run populateCategory.php.

I compared the output of the two Quarry queries; there is very little overlap. Some of the overlapping cases (e.g. Category:خطای_CS1:_تاریخ ) are categories that I know are actively changing (I have a bot working on this one, for instance) so if I were to guess I would say that the script fixed these but they drifted again.

May 25 2019, 6:15 PM · Wikimedia-maintenance-script-run, Wikimedia-Site-requests
Huji added a comment to T221795: Refactor Category::refreshCounts logic to a job and simplify.

I moved T224321 in the hierarchy of tasks so that the current task would be its parent. @Superyetkin that is essentially what you are asking for. @Krinkle I think it would be nice to start over in a clean state; this can help with identifying the root causes of mismatches, whether before or after #3 is refactored.

May 25 2019, 1:54 PM · MediaWiki-Categories, Performance-Team
Huji edited parent tasks for T224321: Run populateCategory.php, added: T221795: Refactor Category::refreshCounts logic to a job and simplify; removed: T223944: PAGESINCATEGORY continues to show the wrong number.
May 25 2019, 1:52 PM · Wikimedia-maintenance-script-run, Wikimedia-Site-requests
Huji added a subtask for T221795: Refactor Category::refreshCounts logic to a job and simplify: T224321: Run populateCategory.php.
May 25 2019, 1:52 PM · MediaWiki-Categories, Performance-Team
Huji removed a subtask for T223944: PAGESINCATEGORY continues to show the wrong number: T224321: Run populateCategory.php.
May 25 2019, 1:52 PM · MediaWiki-Parser, MediaWiki-Cache
Huji added a comment to T223944: PAGESINCATEGORY continues to show the wrong number.

Sounds fair. Thanks!

May 25 2019, 1:48 PM · MediaWiki-Parser, MediaWiki-Cache

May 24 2019

Huji created T224321: Run populateCategory.php.
May 24 2019, 9:44 PM · Wikimedia-maintenance-script-run, Wikimedia-Site-requests

May 21 2019

Huji added a comment to T169468: Deploy InternetArchiveBot on the Persian Wikipedia (fawiki).

Please find it here

May 21 2019, 1:07 AM · InternetArchiveBot (v2.0)
Huji created T223944: PAGESINCATEGORY continues to show the wrong number.
May 21 2019, 12:09 AM · MediaWiki-Parser, MediaWiki-Cache

Apr 28 2019

Huji created T222045: Unable to sign up or log into discourse-mediawiki.wmflabs.org.
Apr 28 2019, 11:00 PM · Discourse

Apr 21 2019

Huji created T221522: sql-optimizer: Query error: Operand should contain 1 column(s).
Apr 21 2019, 2:53 PM · Tools

Apr 12 2019

Huji added a comment to T220165: When an IndexLayout is nested inside a continuous StackLayout, other panels overlap its content.

I think (though I am not sure) that this is happening because deep inside an IndexLayout, there exists a StackLayout which helps showing only one of the tabs at any given time. So when you put an indexLayout inside a StackLayout, you are essentially nesting StackLayouts, and the CSS model for StackLayouts does not support nesting at all.

Apr 12 2019, 1:30 PM · OOUI
Huji moved T220764: Expose more detailed diff information to the AbuseFilter from Backlog to Filtering features on the AbuseFilter board.
Apr 12 2019, 1:27 PM · Patch-For-Review, AbuseFilter
Huji triaged T220764: Expose more detailed diff information to the AbuseFilter as Normal priority.
Apr 12 2019, 1:27 PM · Patch-For-Review, AbuseFilter

Apr 11 2019

Huji updated the task description for T220764: Expose more detailed diff information to the AbuseFilter.
Apr 11 2019, 8:47 PM · Patch-For-Review, AbuseFilter
Huji created T220764: Expose more detailed diff information to the AbuseFilter.
Apr 11 2019, 8:44 PM · Patch-For-Review, AbuseFilter

Apr 6 2019

Huji closed T220253: Possile vandal account on Phabricator as Declined.

Got it. I just saw it today so I thought I should make sure it is noted.

Apr 6 2019, 1:26 AM · Phabricator
Huji added a comment to T220166: Add a property or method to OOUI which would show its version number.

It is a minor enhancement request; no big deal if the decision is to decline it.

Apr 6 2019, 1:06 AM · OOUI
Huji created T220253: Possile vandal account on Phabricator.
Apr 6 2019, 1:05 AM · Phabricator
Huji added a comment to T220166: Add a property or method to OOUI which would show its version number.

I came across this when I was trying to report a few issues, and I wanted to know which version of OOUI was in use where I saw those issues.

Apr 6 2019, 1:00 AM · OOUI

Apr 5 2019

Mill <mill@mail.com> committed rELGN06ed1e556077: 4!baaaaaaaaaaa (authored by Huji).
4!baaaaaaaaaaa
Apr 5 2019, 10:40 PM
Huji renamed T220166: Add a property or method to OOUI which would show its version number from Add a property or method to OOUI which would show its version numebr to Add a property or method to OOUI which would show its version number.
Apr 5 2019, 1:56 AM · OOUI
Huji created T220166: Add a property or method to OOUI which would show its version number.
Apr 5 2019, 1:50 AM · OOUI
Huji created T220165: When an IndexLayout is nested inside a continuous StackLayout, other panels overlap its content.
Apr 5 2019, 1:49 AM · OOUI
Huji created P8349 IndexLayout nested in a continuous StackLayout.
Apr 5 2019, 1:46 AM

Apr 4 2019

Huji added a comment to T213845: Change link colors in Vector.

One at a time! This is something that takes a lot of political will to happen for each skin.

Apr 4 2019, 2:29 AM · UI-Standardization, Vector
Huji removed a project from T219033: Syntax error in OOUI documentations: Africa-Wikimedia-Developers.
Apr 4 2019, 2:28 AM · OOUI (OOUI-0.31.3)
Huji closed T219033: Syntax error in OOUI documentations as Resolved.
Apr 4 2019, 2:28 AM · OOUI (OOUI-0.31.3)
Huji claimed T219033: Syntax error in OOUI documentations.

It bothers me a lot, so I'm posting a fix.

Apr 4 2019, 1:47 AM · OOUI (OOUI-0.31.3)

Mar 27 2019

Huji renamed T219009: Focusing on tabs should trigger the appropriate event of the first focusable element if autoFocus is true from Making a tab active will select an input against user's will to Focusing on tabs should trigger the appropriate event of the first focusable element if autoFocus is true.
Mar 27 2019, 9:30 PM · OOUI
Huji added a comment to T219009: Focusing on tabs should trigger the appropriate event of the first focusable element if autoFocus is true.

Thanks @Schnark that was helpful. I am updating the task accordingly.

Mar 27 2019, 9:27 PM · OOUI

Mar 25 2019

Huji closed T219106: Search bar for check rationale in CheckUser log as Declined.

@jcrespo understood.

Mar 25 2019, 6:42 PM · CheckUser
Huji updated subscribers of T219106: Search bar for check rationale in CheckUser log.

Keyword searching is generally very slow and cannot be made efficient. In technical terms, it is not possible to index a database column that contains strings (like the one that stores the check reasons) in such a way that you can efficiently look for a word appearing in the middle of the string.

Mar 25 2019, 2:23 AM · CheckUser

Mar 24 2019

Huji closed mock M280: UserMessages tool mockup.
Mar 24 2019, 3:12 AM

Mar 22 2019

Huji added a project to T219033: Syntax error in OOUI documentations: good first bug.

To fix it, you need to remove two semicolons. I have shown where it is below:

Mar 22 2019, 8:29 PM · OOUI (OOUI-0.31.3)
Huji created T219033: Syntax error in OOUI documentations.
Mar 22 2019, 8:27 PM · OOUI (OOUI-0.31.3)
Huji created T219026: Add a method for modifying the placeholder value for text inputs.
Mar 22 2019, 7:11 PM · OOUI
Huji added a comment to T219009: Focusing on tabs should trigger the appropriate event of the first focusable element if autoFocus is true.

The second part of the task would still apply.

Mar 22 2019, 5:03 PM · OOUI
Huji created M280: UserMessages tool mockup.
Mar 22 2019, 5:02 PM
Huji updated the task description for T219009: Focusing on tabs should trigger the appropriate event of the first focusable element if autoFocus is true.
Mar 22 2019, 4:46 PM · OOUI
Huji created T219011: Contents of a framed tab bleed out of the frame.
Mar 22 2019, 4:27 PM · OOUI
Huji created T219009: Focusing on tabs should trigger the appropriate event of the first focusable element if autoFocus is true.
Mar 22 2019, 4:13 PM · OOUI
Huji closed T212830: Fawiki article cannot be edited: "Service Temporarily Unavailable" timeout upon saving at API execution limit (200 seconds) as Resolved.

Thanks @Daimona! I am glad my hunch was right.

Mar 22 2019, 2:16 AM · Wikimedia-General-or-Unknown, MediaWiki-Page-editing

Mar 21 2019

Huji added a comment to T212830: Fawiki article cannot be edited: "Service Temporarily Unavailable" timeout upon saving at API execution limit (200 seconds).

Last: I cannot find a TypeError message in the browser console. Could it be that you are using a particular Gadget? Can you try with debug=true and point us to the script that causes the TypeError please?

Garr, sorry again (was doing too many things at the same time)! Default gadget settings; it's the line this.href = new mw.Uri(this.href).extend({ in https://fa.wikipedia.org/w/index.php?title=مدیاویکی:Common.js/edit.js

Mar 21 2019, 10:23 PM · Wikimedia-General-or-Unknown, MediaWiki-Page-editing
Huji updated subscribers of T212830: Fawiki article cannot be edited: "Service Temporarily Unavailable" timeout upon saving at API execution limit (200 seconds).

@Dalba my hunch is that when you blank the page, AbuseFilter will try to work on a massive diff, and that slows thing down to the point of crashing. Smaller changes produce smaller diffs, and let the page go through.

Mar 21 2019, 10:16 PM · Wikimedia-General-or-Unknown, MediaWiki-Page-editing

Mar 18 2019

Huji added a comment to T212830: Fawiki article cannot be edited: "Service Temporarily Unavailable" timeout upon saving at API execution limit (200 seconds).

@Aklapper first of all, I don't see any indication on that page's history that you successfully saved an edit. Please try with a dummy edit instead (with null edits, the issue doesn't reproduce itself).

Mar 18 2019, 11:50 PM · Wikimedia-General-or-Unknown, MediaWiki-Page-editing

Mar 12 2019

Huji added a comment to T218074: ip_in_range should accept explicit range notation.

Perhaps the IP class should have a method like rangeToCIDR()

Mar 12 2019, 11:07 PM · Patch-For-Review, User-Daimona, AbuseFilter
Huji added a comment to T144127: Add links on all Phabricator/Maniphest project pages to the corresponding source code pages in Diffusion.

For the record, I have been going around and adding such links whenever I run into a project in Phab that doesn't have a link to the corresponding Diffusion page. At this point, I think the best "solution", so to speak, is to make sure that whenever a new project is created on Phab, a checklist is followed (do we have one?) and linking the project to its Diffusion is an item on the checklist.

Mar 12 2019, 12:02 AM · Project-Admins, Phabricator
Huji removed a project from T217972: log_user_text is missing for some logs in fawiki: Cloud-Services.

Great. That means the view is not to blame.

Mar 12 2019, 12:00 AM · MediaWiki-Logging

Mar 10 2019

Huji created T217972: log_user_text is missing for some logs in fawiki.
Mar 10 2019, 2:57 AM · MediaWiki-Logging

Mar 8 2019

Huji added a comment to T217776: CodeEditor incorrectly shown for edit notices for CSS pages.

I am an admin so I did it. Thanks for the guidance!

Mar 8 2019, 11:24 PM · TemplateStyles, CodeEditor

Mar 6 2019

Huji created T217776: CodeEditor incorrectly shown for edit notices for CSS pages.
Mar 6 2019, 3:17 PM · TemplateStyles, CodeEditor
Huji created T217775: CodeEditor does not recognized the @counter-style rule.
Mar 6 2019, 3:11 PM · CodeEditor
Huji added a comment to T217713: Checkuser throws exception if looking up user with invalid name.

Guess what, it was a regression that I had introduced in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CheckUser/+/374851/ more than year ago!

Mar 6 2019, 3:27 AM · Patch-For-Review, Wikimedia-production-error, CheckUser
Huji claimed T217713: Checkuser throws exception if looking up user with invalid name.

I can confirm that ending the username with _ will cause an exception. Looking for the root cause now.

Mar 6 2019, 12:35 AM · Patch-For-Review, Wikimedia-production-error, CheckUser

Mar 2 2019

Huji added a comment to T217456: Logs for renaming users with username in Arabic script should show first number of change.

@Zoranzoki21 can you give me a link to that log? I am wondering if adding a <bdi> tag could fix this, and want to experiment on those examples.

Mar 2 2019, 2:51 PM · RTL, I18n, MediaWiki-extensions-Renameuser

Feb 28 2019

Huji awarded T216904: Upgrade AbuseFilter extension to use newer phan a Love token.
Feb 28 2019, 8:26 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), phan, AbuseFilter

Feb 27 2019

Huji created T217290: LoginNotify cannot notify for logins from unkonwn sources if 2FA is enabled.
Feb 27 2019, 9:18 PM · Community-Tech, MediaWiki-extensions-LoginNotify

Feb 19 2019

revi awarded T154430: Include the original sender name in the FROM field a Meh! token.
Feb 19 2019, 3:45 PM · MediaWiki-Email

Feb 18 2019

Huji added a comment to T146837: Add ability to search by user agent from CheckUser interface.

Please see my related comment in T147894#4962824 in which I explain why, at least for now, it is best to restrict the functionality to searching either by IP or by UA (so if both are provided, we would return an error and ask the user to remove one). It is possible (though I am not sure how likely) that allowing both the IP and the UA to be specified would translate to the need for a massive index on the database tables that would be unjustifiable given the few use cases for a joint search, so I would rather differ that to a later time in the interest of having the UA search in production in near term.

Feb 18 2019, 10:26 PM · Stewards-and-global-tools, CheckUser
Huji added a comment to T147894: Create index for cu_agents in cu_changes table.

@jcrespo The index you created in T212092#4934152 is exactly the one proposed in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CheckUser/+/414120/1/cu_changes.sql so I am a bit confused about what exactly you are asking for.

Feb 18 2019, 10:23 PM · DBA, Patch-For-Review, CheckUser

Feb 17 2019

Huji added a comment to T181024: AbuseFilter should not cast arrays into strings.

Anyway, in PHP arrays are always greater than numbers, and no cast is performed.

Feb 17 2019, 9:43 PM · Patch-For-Review, AbuseFilter
Huji awarded T213037: AbuseFilter should have an edit API a Love token.
Feb 17 2019, 4:55 PM · MediaWiki-API, AbuseFilter

Feb 16 2019

Huji closed T191173: Unneeded horizontal scrollbar in MediaWiki namespace in fawiki as Resolved.

To answer my own question, the rule is here: https://gerrit.wikimedia.org/g/mediawiki/skins/Vector/+/3a406ba1c1976de4e57563cadb3b0fe07c284507/print.less

Feb 16 2019, 10:30 PM · Vector, CSS

Feb 14 2019

Krinkle awarded T213778: Update link colors in Vector for improved UX (and consistency) a Orange Medal token.
Feb 14 2019, 7:25 PM · UI-Standardization, Vector
Huji triaged T216100: Add AbuseFilters to Watchlist as Lowest priority.

I think it is theoretically possible. The same mechanism that StructuredDiscussions uses to inject rows into the watchlist can be also used by AbuseFilter. We would have to figure out how much demand there is for this though. At this point, I categorize it as a "nice to have" feature, hence the Lowest priority.

Feb 14 2019, 2:52 AM · Growth-Team, User-DannyS712, AbuseFilter, MediaWiki-Watchlist

Feb 12 2019

jcrespo awarded T212092: Provide a strategy for testing the performance of queries needed to show the list of user-agents for each IP a Party Time token.
Feb 12 2019, 9:18 AM · DBA, CheckUser
Huji added a comment to T147894: Create index for cu_agents in cu_changes table.

@jcrespo Given the analysis you already did on T212092#4934152 would you recommend that we go ahead with creating this index? (If I understand your comment there, the index would be beneficial for a search only on agent and timestamp, with no restrictions on IP).

Feb 12 2019, 1:59 AM · DBA, Patch-For-Review, CheckUser
Huji closed T170508: The "show ip" action should also provide a distinct list of user-agents for each IP as Declined.

I am going to decline this Task, per the analysis done in T212092

Feb 12 2019, 1:56 AM · DBA, Patch-For-Review, CheckUser
Huji closed T212092: Provide a strategy for testing the performance of queries needed to show the list of user-agents for each IP, a subtask of T170508: The "show ip" action should also provide a distinct list of user-agents for each IP, as Resolved.
Feb 12 2019, 1:55 AM · DBA, Patch-For-Review, CheckUser
Huji closed T212092: Provide a strategy for testing the performance of queries needed to show the list of user-agents for each IP as Resolved.

Thanks @jcrespo

Feb 12 2019, 1:55 AM · DBA, CheckUser

Feb 10 2019

Huji updated subscribers of T157916: Delete tool hujibot.

@Zoranzoki21 since you help with Cleanup often, can you give this task some love too?

Feb 10 2019, 1:41 PM · Toolforge (Tools to be deleted), Cleanup

Feb 8 2019

Huji closed T210767: Create a unit test for $wgGroupBlockRestrictions as Declined.

Several people have described this as a config creep, so I am going to mark it as declined. Let's hope we never get to a day when an eliminator tries to block a sysop.

Feb 8 2019, 2:08 AM · Patch-For-Review, MediaWiki-User-management
Huji closed T210767: Create a unit test for $wgGroupBlockRestrictions, a subtask of T210642: Disallow eliminators to block sysops on fawiki, as Declined.
Feb 8 2019, 2:08 AM · Patch-For-Review, MediaWiki-User-management, Wikimedia-Site-requests

Feb 6 2019

Huji added a comment to T212092: Provide a strategy for testing the performance of queries needed to show the list of user-agents for each IP.

I don't like any of those three options; they are all too much cost (engineering cost, code review time cost, etc.) for little benefit. There exists a completely different solution: rewrite the CU tool such that once it loads the IP list, it uses the CU API to fetch detailed edits for each user or IP and parse out the UA frequencies in a JavaScript code run on the client side. It is much easier to engineer, it will shift the workload mostly to the client-side (though there will be tens or hundreds of CU queries over the API, but they will be queries that are already optimized), and its only negative side effect that I can think of is that it spams the CU log.

Feb 6 2019, 10:52 PM · DBA, CheckUser

Feb 5 2019

Huji added a comment to T212092: Provide a strategy for testing the performance of queries needed to show the list of user-agents for each IP.

I had a minor heart attack ;) *jk*

Feb 5 2019, 11:52 PM · DBA, CheckUser
Huji added a comment to T212092: Provide a strategy for testing the performance of queries needed to show the list of user-agents for each IP.

To confirm: is the cu_changes table 12TB for enwiki?

Feb 5 2019, 5:10 PM · DBA, CheckUser

Feb 4 2019

Huji added a comment to T215136: Disabling an AbuseFilter action does not remove that action from existing filters.
  1. "Our" actions. For them, we can just use the usual code, plus something to make clear that they can only be disabled. For instance, we could put them in a separate form section with a short explanation. Or even add a warningbox above each of them with such an explanation. At any rate, I believe we should add a warningbox to the top of the page.
Feb 4 2019, 7:56 PM · Patch-For-Review, AbuseFilter
Huji added a comment to T215136: Disabling an AbuseFilter action does not remove that action from existing filters.

Okay, I like that analysis.

Feb 4 2019, 4:27 PM · Patch-For-Review, AbuseFilter
Huji added a comment to T215136: Disabling an AbuseFilter action does not remove that action from existing filters.

@Daimona if we generalize this problem (which I did in the patch and in its commit message), the issue is not just with "disabled" actions, but also with "undefined" actions. Imagine that you expand the set of actions either through changes in AbuseFilter code, or via hooks and through other extensions; afterwards, imagine you remove those actions, or stop using said extensions. This will leave you with some filters that contain actions that do not exist anymore, which means you don't even have access to the appropriate messages, etc. to even show them in a "disabled" fashion on the filter edit form, to allow the users to uncheck the now-nonexistent actions.

Feb 4 2019, 2:50 PM · Patch-For-Review, AbuseFilter
Huji claimed T215136: Disabling an AbuseFilter action does not remove that action from existing filters.
Feb 4 2019, 1:46 AM · Patch-For-Review, AbuseFilter

Feb 3 2019

Huji added a comment to P7956 Filters which must be manually fixed in WMF wikis.

I managed to fix the ruwiktionary one using my global sysop rights.

Feb 3 2019, 6:06 PM · Chinese-Sites, AbuseFilter
Huji edited P7956 Filters which must be manually fixed in WMF wikis.
Feb 3 2019, 6:06 PM · Chinese-Sites, AbuseFilter

Feb 2 2019

Huji raised the priority of T208931: Warning: Invalid parameter for message "abusefilter-log-detailedentry-local" from Lowest to Needs Triage.
Feb 2 2019, 8:04 PM · Wikimedia-production-error, AbuseFilter, User-Daimona, Patch-For-Review
Huji raised the priority of T214196: BadMethodCallException: Call to a member function dumpAllVars() on a non-object (boolean) from Lowest to Needs Triage.
Feb 2 2019, 8:03 PM · AbuseFilter, Wikimedia-production-error, User-Daimona, Patch-For-Review
Huji removed Due Date on T144265: AbuseFilterFilterAction hook sometimes passes null instead of Title object.
Feb 2 2019, 7:59 PM · AbuseFilter, Wikimedia-production-error, User-Daimona, MW-1.33-notes (1.33.0-wmf.9; 2018-12-18)
Huji raised the priority of T214193: PHP Notice: Unable to unserialize in AbuseFilter.php from Lowest to Needs Triage.
Feb 2 2019, 7:56 PM · Wikimedia-production-error, AbuseFilter, User-Daimona, Patch-For-Review
Huji updated the task description for T214193: PHP Notice: Unable to unserialize in AbuseFilter.php.
Feb 2 2019, 7:55 PM · Wikimedia-production-error, AbuseFilter, User-Daimona, Patch-For-Review
Huji updated the task description for T214193: PHP Notice: Unable to unserialize in AbuseFilter.php.
Feb 2 2019, 7:55 PM · Wikimedia-production-error, AbuseFilter, User-Daimona, Patch-For-Review
Huji updated subscribers of T214193: PHP Notice: Unable to unserialize in AbuseFilter.php.
Feb 2 2019, 7:54 PM · Wikimedia-production-error, AbuseFilter, User-Daimona, Patch-For-Review
Huji added projects to T214193: PHP Notice: Unable to unserialize in AbuseFilter.php: Patch-For-Review, User-Daimona, AbuseFilter, Wikimedia-production-error.
Feb 2 2019, 7:54 PM · Wikimedia-production-error, AbuseFilter, User-Daimona, Patch-For-Review

Feb 1 2019

Huji added a comment to T147894: Create index for cu_agents in cu_changes table.

For doing a hash match, you need to store the hashed UA as a new column in the table, correct? There will be some space implications for it (I think CU tables on WMF production servers are in the 20GB range now, and the largest field in them is the UA field). That being said, I am okay with an interim solution that consists of adding a hashed UA field, indexing it, and allowing exact match searches. That will probably be easier to implement, and it will help us demonstrate several use cases of UA lookups, which would hopefully facilitate moving this task and its parent along.

Feb 1 2019, 4:16 PM · DBA, Patch-For-Review, CheckUser
Huji added a comment to T212092: Provide a strategy for testing the performance of queries needed to show the list of user-agents for each IP.

@jcrespo I created this while you aware away. Just making sure this has not gone unnoticed, and also making sure this is what you would want from me to complete DBA review for CheckUser related sign-offs.

Feb 1 2019, 4:14 AM · DBA, CheckUser

Jan 31 2019

Huji added a project to T215005: IP addresses should be shown LTR: I18n.
Jan 31 2019, 3:17 AM · I18n, Patch-For-Review, CheckUser