Huji (Huji Lee)
MediaWiki developer

Projects (12)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 25 2014, 1:21 PM (182 w, 5 d)
Availability
Available
IRC Nick
Huji
LDAP User
Huji
MediaWiki User
Huji

Recent Activity

Yesterday

Huji closed T189681: Actions are marked as red even if unchanged as Resolved.
Thu, Apr 26, 2:13 PM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Patch-For-Review, AbuseFilter
Huji closed T190180: Move AbuseFilter::buildEditBox static method to AbuseFilterView class as Resolved.
Thu, Apr 26, 1:35 PM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Technical-Debt, AbuseFilter
Huji closed T193109: Error messages about search should be shown in a new line as Resolved.
Thu, Apr 26, 1:34 PM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Design, AbuseFilter
Huji created T193109: Error messages about search should be shown in a new line.
Thu, Apr 26, 2:25 AM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Design, AbuseFilter
Huji closed T172617: [[MediaWiki:Apihelp-abusefiltercheckmatch-summary/es]] i18n issue as Resolved.
Thu, Apr 26, 1:54 AM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), AbuseFilter, I18n, User-MarcoAurelio

Tue, Apr 24

Huji added a project to T131207: Create a checkuser entry for global rename requests: User-Huji.
Tue, Apr 24, 3:36 PM · User-Huji, Anti-Harassment, MediaWiki-extensions-CentralAuth, CheckUser, GlobalRename, Stewards-and-global-tools
MarcoAurelio awarded T192325: Setup phan for AbuseFilter a Yellow Medal token.
Tue, Apr 24, 11:00 AM · Patch-For-Review, AbuseFilter

Mon, Apr 23

Huji created T192860: Error fetching remote repo 'origin'.
Mon, Apr 23, 11:45 PM · Continuous-Integration-Config
Huji removed a project from T189681: Actions are marked as red even if unchanged: Patch-For-Review.

Iaeae672dca66ffc745054daabd6f0eae7dfbc648 resolves the part of the issue that allows saving unchanged filters, but it doesn't address the issue of "Actions" being highlighted in pink even when it is not changed.

Mon, Apr 23, 10:50 PM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Patch-For-Review, AbuseFilter
Huji added a comment to T132284: Convert Special:AbuseFilter to OOUI.

@Daimona: In Special:AbuseFilter/history/1 on the top of the page there is a link that reads "Back to filter editor". I think that should be turned into a button (just like the "Create a new filter" link on Special:AbuseFilter which is now a OOUI button).

Mon, Apr 23, 10:48 PM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), User-notice, Patch-For-Review, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)), AbuseFilter, Epic, UI-Standardization
Huji closed T192241: Abuse filters cannot be edited without javascript as Resolved.
Mon, Apr 23, 10:44 PM · Patch-For-Review, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), CodeEditor, Regression, AbuseFilter
Huji closed T192241: Abuse filters cannot be edited without javascript, a subtask of T192336: Make AbuseFilter usable without JavaScript, as Resolved.
Mon, Apr 23, 10:44 PM · Epic, AbuseFilter
Jan_Dittrich awarded T189495: Usability review to become an integral part of MW/extension development a Love token.
Mon, Apr 23, 4:36 PM · Design-Research, MediaWiki-extensions-General, MediaWiki-General-or-Unknown

Fri, Apr 20

Huji updated subscribers of T178007: Remove coding standard rule exclusions in AbuseFilter and fix the coding standards .

@werdna that is something you had added in 2009. Do you have any insight as to when an API call won't come with a title?

Fri, Apr 20, 9:37 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), AbuseFilter
Huji updated subscribers of T178007: Remove coding standard rule exclusions in AbuseFilter and fix the coding standards .

@Daimona thanks for working on this. It seems like the only item left is the use of $wgTitle which only in the filterAction() function in AbuseFilter.php and I honestly don't understand why this is necessary.

Fri, Apr 20, 3:30 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), AbuseFilter
Huji triaged T178007: Remove coding standard rule exclusions in AbuseFilter and fix the coding standards as Low priority.
Fri, Apr 20, 3:22 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), AbuseFilter
Huji updated the task description for T178007: Remove coding standard rule exclusions in AbuseFilter and fix the coding standards .
Fri, Apr 20, 3:21 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), AbuseFilter

Thu, Apr 19

Huji added a comment to T176097: mediawiki-phpunit-php70-jessie job sometimes fails with MessageBlobStoreTest failure.

@Krinkle: I don't get the errors anymore.

Thu, Apr 19, 1:10 AM · Performance-Team, MediaWiki-ResourceLoader, Wikimedia-log-errors (Jenkins Failure)

Tue, Apr 17

Huji triaged T192389: Make external variables true booleans as Low priority.
Tue, Apr 17, 6:29 PM · Patch-For-Review, AbuseFilter
Huji added a comment to T192389: Make external variables true booleans.

Isn't it the case that true == 1 and false == 0 as far as AbuseFilter parser handles it? If so, then I don't think the use cases of user_blocked will be impacted because they effectively check if it is equal to 1 or not, and converting to either true/false or true/false/null will not change that (it will, if they use the "identical" operator, which you call "triple-compare", but you already have a bullet point for it).

Tue, Apr 17, 6:29 PM · Patch-For-Review, AbuseFilter
Huji added a comment to T69811: CheckUsers "Get users" output formatting is weird.

It will be easy to fix, but it is not worth spending time on. Right now, it is only an aesthetic issue; instead of spending time on it, we should overhaul CU completely.

Tue, Apr 17, 6:24 PM · Stewards-and-global-tools, CheckUser
Huji updated the task description for T192336: Make AbuseFilter usable without JavaScript.
Tue, Apr 17, 11:53 AM · Epic, AbuseFilter
Huji created T192325: Setup phan for AbuseFilter.
Tue, Apr 17, 12:30 AM · Patch-For-Review, AbuseFilter
Huji added a comment to T192322: Find cases where a function argument without a default is used after one with a default.

@Legoktm well then phan should have caught the example I gave, why didn't it?

Tue, Apr 17, 12:28 AM · MediaWiki-Codesniffer
Huji added a comment to T191699: AbuseLog entries associated with revdel'd revisions are hidden from administrators.

@MarcoAurelio That is not relevant. abusefilter-hidden-log and abusefilter-hide-log are about the abuse logs. This issue is about when a page (e.g. an article) has a revision that triggered a filter and then was revdel'ed.

Tue, Apr 17, 12:23 AM · AbuseFilter

Mon, Apr 16

Huji added a comment to T192241: Abuse filters cannot be edited without javascript.

I also think that Javascript is such an integral part to AbuseFilter (and MediaWiki as a whole) that supporting noscript is not the best idea. Some of the other existing functionality in AbuseFilter (such as the form that let's you debug code, the form that let's you re-add "autoconfirmed" status to a user, etc.) already rely on JS. So I am leaning towards declining this request altogether and officially stating that AbuseFilter requires JS.

Mon, Apr 16, 11:28 PM · Patch-For-Review, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), CodeEditor, Regression, AbuseFilter
Huji created T192322: Find cases where a function argument without a default is used after one with a default.
Mon, Apr 16, 11:20 PM · MediaWiki-Codesniffer
Huji added a comment to T185154: AbuseFilter (and dependencies): code stewardship review.

@dmaza we have a few patches that are more than minimal improvements, and we need someone more daring to +2 them, so I'm going to add you as reviewer on those in the next day or so.

Mon, Apr 16, 10:12 PM · Equivset, AntiSpoof, AbuseFilter, Code-Stewardship-Reviews

Sun, Apr 15

Huji triaged T192241: Abuse filters cannot be edited without javascript as High priority.

That is weird. AbuseFilter now uses CodeEditor, but CodeEditor is supposed to show you the textarea when JS is not enabled. Somehow, it doesn't (the textarea is there if you look at the page HTML, it is just not visible).

Sun, Apr 15, 10:50 PM · Patch-For-Review, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), CodeEditor, Regression, AbuseFilter

Sat, Apr 14

Huji updated subscribers of T44345: Blocks from AbuseFilter show up as performed from the target's IP address in Checkuser.

I think what @Krenair meant was "why not use/inject X-Forward-For to show both the IP that actually did the action (server's) and the IP of the user on whose behalf the server did the action (in this case I guess the blocked user?)

Sat, Apr 14, 2:40 PM · CheckUser, Patch-For-Review, AbuseFilter

Fri, Apr 13

Huji added a comment to T185154: AbuseFilter (and dependencies): code stewardship review.

And you all have been doing a fantastic job! Since both you and Matej have +2 rights, I'd consider you to be the de facto maintainers at this point. There's still value in having a "responsible WMF team", but I don't believe that should stop or hold you back from future improvements you'd like to make :)

Fri, Apr 13, 12:54 PM · Equivset, AntiSpoof, AbuseFilter, Code-Stewardship-Reviews
Huji renamed T164180: Equivset should normalize some diacriticals from Abuse Filter ccnorm should normalize some diacriticals to Equivset should normalize some diacriticals.
Fri, Apr 13, 12:52 PM · Equivset

Wed, Apr 11

Huji added a comment to T191173: Unneeded horizontal scrollbar in MediaWiki namespace in fawiki.

I am investigating. I just haven't been able to find the root cause so far. Once I find it, a patch will be submitted.

Wed, Apr 11, 7:42 PM · Vector, CSS
Huji triaged T191173: Unneeded horizontal scrollbar in MediaWiki namespace in fawiki as Normal priority.
Wed, Apr 11, 4:42 PM · Vector, CSS
Huji triaged T191978: Devise a process for finding and fixing filters that will be affected by changes in AbuseFilter as Normal priority.
Wed, Apr 11, 4:17 PM · AbuseFilter
Huji updated the task description for T191978: Devise a process for finding and fixing filters that will be affected by changes in AbuseFilter.
Wed, Apr 11, 4:17 PM · AbuseFilter
Huji updated subscribers of T191978: Devise a process for finding and fixing filters that will be affected by changes in AbuseFilter.

Good work! Of note, in T140791 @kaldari elects to post results in a private manner because some filters are private. I assume the results included more than just the filter ID?

Wed, Apr 11, 4:16 PM · AbuseFilter
Huji updated subscribers of T191978: Devise a process for finding and fixing filters that will be affected by changes in AbuseFilter.

Of note, @Krinkle has proposed in T187973#3994713 that we should use the tag #wikimedia-site-requests for the query task and he believes that "the task of a global sysop performing on-wiki changes is outside the scope for any Phabricator task" which leaves me unsure as to how to manage that step.

Wed, Apr 11, 2:36 PM · AbuseFilter
Daimona awarded T191978: Devise a process for finding and fixing filters that will be affected by changes in AbuseFilter a Love token.
Wed, Apr 11, 2:33 PM · AbuseFilter
Huji updated the task description for T191978: Devise a process for finding and fixing filters that will be affected by changes in AbuseFilter.
Wed, Apr 11, 2:30 PM · AbuseFilter
Huji created T191978: Devise a process for finding and fixing filters that will be affected by changes in AbuseFilter.
Wed, Apr 11, 2:30 PM · AbuseFilter
Huji updated subscribers of T191715: Clearly reserve system variables in VariableHolder.

That is what I asked of @Bawolff in one of the other tasks. He responded to my question partially and copied @APalmer_WMF from legal too. I think this whole discussion (of what is the proper way to ask for queries and to fix filters enmass) deserves a task of its own! I will copy all of you in a task I am about to create in a moment!

Wed, Apr 11, 2:15 PM · Patch-For-Review, AbuseFilter
Huji added a comment to T185154: AbuseFilter (and dependencies): code stewardship review.

In the meantine, @Daimona, @matej_suchanek and I have been actively working on AbuseFilter over the last 2-3 months with many patches created and merged. Most of our work is "patchwork" (as opposed to major overhaul) for now. It is best to postpone major overhaul to when either we have stewards or we become seasoned enough in this code to be the stewards,

Wed, Apr 11, 1:33 PM · Equivset, AntiSpoof, AbuseFilter, Code-Stewardship-Reviews
Huji closed T134124: Evaluator freeze/timeout on unclosed comment as Resolved.
Wed, Apr 11, 2:15 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), AbuseFilter

Tue, Apr 10

Huji moved T191688: Treat integers as such in performing arithmetics from To Triage to Announce in next Tech/News on the User-notice board.
Tue, Apr 10, 11:44 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), User-notice, AbuseFilter
Huji closed T191688: Treat integers as such in performing arithmetics as Resolved.
Tue, Apr 10, 11:42 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), User-notice, AbuseFilter
Huji closed T190602: Block durations may not default correctly as Resolved.
Tue, Apr 10, 11:42 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Technical-Debt, AbuseFilter
Huji added a comment to T191688: Treat integers as such in performing arithmetics.

I think the number of cases in which this may break a filter is so few that we should go ahead and merge this.

Tue, Apr 10, 11:22 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), User-notice, AbuseFilter
Huji added a comment to T191703: Add OAuth grants for AbuseFilter private information.

I think it is not a "basic" right per se, so moving there makes sense.

Tue, Apr 10, 11:12 PM · User-MarcoAurelio, MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), AbuseFilter
Huji added a comment to T174388: LoginNotify should inform users of the IP address of failed login attempts to their account.

@MaxSem please see T174388#4048541 in which I explained why that is not possible.

Tue, Apr 10, 11:10 PM · Patch-For-Review, Notifications, Collaboration-Team-Triage, User-Huji, Community-Tech, Privacy, WMF-Legal, MediaWiki-extensions-LoginNotify
Huji added a comment to T191688: Treat integers as such in performing arithmetics.

Agreed. So now, what is your plan for analysis of possible regressions?

Tue, Apr 10, 2:35 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), User-notice, AbuseFilter
Huji added a comment to T189943: Reveal email recipient's username in checkuser query results.

Unmerged.

Tue, Apr 10, 1:38 AM · Privacy, Security-Team, CheckUser, Stewards-and-global-tools
Huji reopened T117801: Checkuser should provide option to expose registered email address as "Open".

Reopening. These are two different tasks.

Tue, Apr 10, 1:38 AM · Stewards-and-global-tools, CheckUser

Mon, Apr 9

Huji added a comment to T189943: Reveal email recipient's username in checkuser query results.

The next step would be to attain approval from the Security Team. I am not part of that team.

Mon, Apr 9, 8:00 PM · Privacy, Security-Team, CheckUser, Stewards-and-global-tools
Huji added a comment to T191688: Treat integers as such in performing arithmetics.

You mean right now 5/2 = 3, right?

Mon, Apr 9, 1:59 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), User-notice, AbuseFilter
Huji updated subscribers of T190639: Fix string cast behaviour for lists.

@Bawolff since you have helped with other DB queries in the past, I am adding you here. What is the right approach though? Is there a project tag for DB requests like this? And also, should this be converted to a Security task since some of the filters that string() may not be public? And lastly, once we identify them, who are the group of (super)users who can modify these filters enmass?

Mon, Apr 9, 2:03 AM · Patch-For-Review, AbuseFilter
Huji changed the status of T191715: Clearly reserve system variables in VariableHolder from Open to Stalled.

We need a subtask for the search and modification of the existing filters with a "context" variable in WMF.

Mon, Apr 9, 1:14 AM · Patch-For-Review, AbuseFilter

Sat, Apr 7

Huji triaged T191709: Checkuser logs SUL attachings caused by page imports under importer's IP/UA as Normal priority.
Sat, Apr 7, 11:33 PM · CheckUser
Huji updated subscribers of T191709: Checkuser logs SUL attachings caused by page imports under importer's IP/UA.

This is related to T44345 in that in both cases, the IP that should be used should be an invalid IP (such as 127.0.0.1) indicating that this is something the server is doing, not something a user is doing.

Sat, Apr 7, 11:33 PM · CheckUser

Fri, Apr 6

Huji updated subscribers of T42478: AbuseFilter needs regression tests.

I think this needs a (much needed) overhaul of the way AbuseFilter is coded. Quoting @matej_suchanek from an email, the plan could be to split it to a new class (say, AbuseFilterRunner) and cover it with tests.

Fri, Apr 6, 9:55 PM · Test-Coverage, AbuseFilter
Huji added a comment to T174388: LoginNotify should inform users of the IP address of failed login attempts to their account.

@kaldari no. That job is only run when a notification is sent. Even though you might think it is safe to assume that there are so many notifications that the job will be called many times a minute, that is only correct for big projects (such as English Wikipedia). Smalller WMF projects (such as newly created wikis) may not have even a single notification for several days, and this makes is theoretically possible for us to retain data beyond the retention period.

Fri, Apr 6, 1:09 AM · Patch-For-Review, Notifications, Collaboration-Team-Triage, User-Huji, Community-Tech, Privacy, WMF-Legal, MediaWiki-extensions-LoginNotify

Thu, Apr 5

Huji added a comment to T191539: Internal error when searching within global rules.

I want to use this opportunity to complain that a clear, step-by-step process for replication WMF's wiki farm is not out there and no matter how much I try to replicate it I cannot do it closely enough.

Thu, Apr 5, 5:01 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Wikimedia-log-errors, AbuseFilter
Huji added projects to T191512: PHP fatal error: [] operator not supported for strings @ group0 and group1: Regression, Technical-Debt.
Thu, Apr 5, 2:57 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Technical-Debt, Regression, Patch-For-Review, Wikimedia-log-errors, AbuseFilter
Huji removed a project from T191468: Undefined variable: mode in extensions/AbuseFilter/includes/AbuseFilter.php on line 491: Patch-For-Review.
Thu, Apr 5, 2:08 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), AbuseFilter, Wikimedia-log-errors

Wed, Apr 4

Huji added a comment to T174388: LoginNotify should inform users of the IP address of failed login attempts to their account.

I'm happy to quickly modify my patch to put the IP in event_extra as soon as a 90-day purging script is made for Echo and enabled on WMF.

Wed, Apr 4, 8:30 PM · Patch-For-Review, Notifications, Collaboration-Team-Triage, User-Huji, Community-Tech, Privacy, WMF-Legal, MediaWiki-extensions-LoginNotify
Huji added a comment to T174553: Create a mechanism that allows fetching geolocation and subnet data for IP addresses.

We should also explore to see if there is a hacky way to get the data from MaxMind's free data set indirectly (for example does the City data have a subnet ID)?

Wed, Apr 4, 3:34 PM · Patch-For-Review, User-Huji, MediaWiki-extension-requests, Stewards-and-global-tools, MediaWiki-extensions-LoginNotify, CheckUser
Huji changed the status of T174553: Create a mechanism that allows fetching geolocation and subnet data for IP addresses, a subtask of T174388: LoginNotify should inform users of the IP address of failed login attempts to their account, from Open to Stalled.
Wed, Apr 4, 3:33 PM · Patch-For-Review, Notifications, Collaboration-Team-Triage, User-Huji, Community-Tech, Privacy, WMF-Legal, MediaWiki-extensions-LoginNotify
Huji changed the status of T174553: Create a mechanism that allows fetching geolocation and subnet data for IP addresses from Open to Stalled.

After several months of following up with MaxMind folks, I don't have any hope that they will incorporate subnet data into their free dataset. Marking it as stalled, until either MaxMind resolves it on their end or we find a different data source.

Wed, Apr 4, 3:33 PM · Patch-For-Review, User-Huji, MediaWiki-extension-requests, Stewards-and-global-tools, MediaWiki-extensions-LoginNotify, CheckUser
Huji changed the status of T174553: Create a mechanism that allows fetching geolocation and subnet data for IP addresses, a subtask of T152114: Show provider and country for IPs in Special:RangeContributions, from Open to Stalled.
Wed, Apr 4, 3:33 PM · MediaWiki-Special-pages
Huji changed the status of T174553: Create a mechanism that allows fetching geolocation and subnet data for IP addresses, a subtask of T175160: Identify the source of WHOIS data, the retrieval method, and update frequency, from Open to Stalled.
Wed, Apr 4, 3:33 PM · Security-Reviews
Huji changed the status of T174553: Create a mechanism that allows fetching geolocation and subnet data for IP addresses, a subtask of T179454: AbuseFilter range blocks should be smarter, from Open to Stalled.
Wed, Apr 4, 3:33 PM · AbuseFilter
Huji added a comment to T191420: Add an option to Special:Block to prevent non-CheckUsers from overriding CheckUser blocks.

I would like this feature to be exclusively coded in CheckUser through hooks. No change to the core.

Wed, Apr 4, 3:29 PM · User-Urbanecm, CheckUser, MediaWiki-User-management
Huji updated subscribers of T152850: Bring the CIDR calculator to MediaWiki core.

@Legoktm I like your idea of turning this into a widget. Can you please give me an example of another widget I can model it after?

Wed, Apr 4, 2:16 AM · Patch-For-Review, MediaWiki-Special-pages, MediaWiki-Interface, MediaWiki-User-management
Huji closed T191222: Pattern search feature shows snippet with wrong length as Resolved.
Wed, Apr 4, 2:08 AM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), AbuseFilter
Huji added a comment to T150079: Special:BotPasswords Visual indication between checkboxes and corresponding text should be clearer.

@Volker_E we have a fundamental problem here.

Wed, Apr 4, 1:48 AM · Patch-For-Review, Design, MediaWiki-Special-pages, Easy, MediaWiki-HTMLForm

Tue, Apr 3

Huji added a comment to T191038: Tags in Special:RecentChanges are misleading.

I don't know if the tag feature has any accessibility for those who are blind. For colorblindness, we can try to use colors that are distinguishable by most color-blind people, but I get your point and think that color should not be our primary choice.

Tue, Apr 3, 5:23 PM · Collaboration-Team-Triage, Edit-Review-Improvements-Integrated-Filters, Design, MediaWiki-Recent-changes
Huji added a comment to T189495: Usability review to become an integral part of MW/extension development.

@Tgr, correct, though perhaps we can start with an on-demand testing and start really small and grow from there only if we see that it is being effective and supported.

Tue, Apr 3, 5:21 PM · Design-Research, MediaWiki-extensions-General, MediaWiki-General-or-Unknown
Huji added a comment to T191176: Use the correct Persian Wikipedia logo on mobile site.

@Ladsgroup so, what happened?

Tue, Apr 3, 1:13 AM · Readers-Web-Backlog (Tracking), Patch-For-Review, User-Ladsgroup, Wikimedia-Site-requests, Mobile

Mon, Apr 2

Huji added a comment to T132284: Convert Special:AbuseFilter to OOUI.

Shouldn't be too hard. Let me take a look at it.

Mon, Apr 2, 3:16 PM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), User-notice, Patch-For-Review, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)), AbuseFilter, Epic, UI-Standardization
Huji added a comment to T191176: Use the correct Persian Wikipedia logo on mobile site.

@Aklapper I just copied the same tags form the task about Urdu sign, without thinking hard enough.

Mon, Apr 2, 3:13 PM · Readers-Web-Backlog (Tracking), Patch-For-Review, User-Ladsgroup, Wikimedia-Site-requests, Mobile
Huji added a comment to T191173: Unneeded horizontal scrollbar in MediaWiki namespace in fawiki.

The problem occurs with all MediaWiki pages, not just those containing CSS/JS; for instance https://fa.wikipedia.org/wiki/%D9%85%D8%AF%DB%8C%D8%A7%D9%88%DB%8C%DA%A9%DB%8C:Gadgets-definition

Mon, Apr 2, 3:11 PM · Vector, CSS
Huji added a comment to T191185: Support for RTL text in the Score extension.

Could you paste an example please? Would \override #'(text-direction . -1) work?

Mon, Apr 2, 3:03 PM · RTL, I18n, MediaWiki-extensions-Score
Huji added a comment to T132284: Convert Special:AbuseFilter to OOUI.

Can we modify the form such that flags are part of a MultiselectCheckbox?

Mon, Apr 2, 2:20 PM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), User-notice, Patch-For-Review, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)), AbuseFilter, Epic, UI-Standardization
Amire80 awarded T191185: Support for RTL text in the Score extension a Like token.
Mon, Apr 2, 7:19 AM · RTL, I18n, MediaWiki-extensions-Score
Huji created T191185: Support for RTL text in the Score extension.
Mon, Apr 2, 1:22 AM · RTL, I18n, MediaWiki-extensions-Score
Huji added a member for MediaWiki-extensions-Score: Huji.
Mon, Apr 2, 1:19 AM

Sun, Apr 1

Huji updated the task description for T191176: Use the correct Persian Wikipedia logo on mobile site.
Sun, Apr 1, 8:11 PM · Readers-Web-Backlog (Tracking), Patch-For-Review, User-Ladsgroup, Wikimedia-Site-requests, Mobile
Huji updated the task description for T191176: Use the correct Persian Wikipedia logo on mobile site.
Sun, Apr 1, 7:51 PM · Readers-Web-Backlog (Tracking), Patch-For-Review, User-Ladsgroup, Wikimedia-Site-requests, Mobile
Huji added a parent task for T191176: Use the correct Persian Wikipedia logo on mobile site: T54019: Vectorize all project logos.
Sun, Apr 1, 7:50 PM · Readers-Web-Backlog (Tracking), Patch-For-Review, User-Ladsgroup, Wikimedia-Site-requests, Mobile
Huji added a subtask for T54019: Vectorize all project logos: T191176: Use the correct Persian Wikipedia logo on mobile site.
Sun, Apr 1, 7:50 PM · Wikimedia-Site-requests
Huji created T191176: Use the correct Persian Wikipedia logo on mobile site.
Sun, Apr 1, 7:50 PM · Readers-Web-Backlog (Tracking), Patch-For-Review, User-Ladsgroup, Wikimedia-Site-requests, Mobile
Huji updated the task description for T191174: Update fawiki logo.
Sun, Apr 1, 7:27 PM · Patch-For-Review, Wikimedia-Site-requests
Huji created T191174: Update fawiki logo.
Sun, Apr 1, 7:27 PM · Patch-For-Review, Wikimedia-Site-requests
Huji created T191173: Unneeded horizontal scrollbar in MediaWiki namespace in fawiki.
Sun, Apr 1, 7:16 PM · Vector, CSS

Sat, Mar 31

Huji added a comment to T132284: Convert Special:AbuseFilter to OOUI.

@Daimona there is a little form at the end of Special:AbuseFilter/# which asks you for the reason to see the private details. That needs to be OOUIfied.

Sat, Mar 31, 12:16 AM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), User-notice, Patch-For-Review, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)), AbuseFilter, Epic, UI-Standardization
Huji updated the task description for T132284: Convert Special:AbuseFilter to OOUI.
Sat, Mar 31, 12:15 AM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), User-notice, Patch-For-Review, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)), AbuseFilter, Epic, UI-Standardization
Huji added a comment to T154749: AbuseFilter needs a better tag selection UI.

It is easy. Just specify the options parameter for the MenuTagMultiselectWidget (here is an example, search for options: finallList)

Sat, Mar 31, 12:13 AM · Patch-For-Review, AbuseFilter

Fri, Mar 30

Huji added a comment to T189495: Usability review to become an integral part of MW/extension development.

@Nikerabbit good question. My focus is MediaWiki core and it's most commonly used extensions (such as AbuseFilter, CheckUser, CodeEditor, etc.) and most commonly used skins (such as Vector and Monobook), but I am happy to even start more restrictive and only thing about MediaWiki core. And "we" refers to the community of developers that work on these.

Fri, Mar 30, 11:25 PM · Design-Research, MediaWiki-extensions-General, MediaWiki-General-or-Unknown
Huji updated the task description for T132284: Convert Special:AbuseFilter to OOUI.
Fri, Mar 30, 5:14 PM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), User-notice, Patch-For-Review, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)), AbuseFilter, Epic, UI-Standardization
Huji updated subscribers of T190653: Improve the way variables are dumped.

@matej_suchanek @MaxSem I added you as reviewers. Do you think it would be appropriate to break our years-old habit in how we see these variables (see T190653#4093632 for example)?

Fri, Mar 30, 4:12 PM · Patch-For-Review, AbuseFilter