Huji (Huji Lee)
MediaWiki developer

Projects (12)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 25 2014, 1:21 PM (215 w, 6 d)
Availability
Available
IRC Nick
Huji
LDAP User
Huji
MediaWiki User
Huji [ Global Accounts ]

Recent Activity

Yesterday

Huji added a comment to T204081: Color of visited links is difficult to distinguish from plain black text.

I highly support this proposal. The visited link color we use is too dark and very hard to distinguish from normal text. I think a brighter version of the same color would be ideal. I use RebeccaPurple in my vector.css on fawiki and find it very distniguishable.

Thu, Dec 13, 12:52 AM · Accessibility, UI-Standardization, UI-Standardization-Kanban, Readers-Web-Backlog (Design)
Huji added a comment to T211831: More safety codes for 2FA and ability to see which are used.

I think T131788 should create Notifications which can be displayed in wiki and/or sent to email (like any other notification).

Thu, Dec 13, 12:17 AM · Patch-For-Review, MediaWiki-extensions-OATHAuth

Wed, Dec 12

Huji added a comment to T211831: More safety codes for 2FA and ability to see which are used.

Additionally, it would be preferable if there was a way for the user to find out how many (and which if possible) codes are left.

How many has some use, but it's limited. Showing them again is a grey area

Looks like we should be able to do more scratch tokens without changing the field length (lots of spare space atm)

Wed, Dec 12, 11:38 PM · Patch-For-Review, MediaWiki-extensions-OATHAuth
Huji added a comment to T211746: [Proposed]Localising template parameter gadget.

In fawiki, 2 and 3 are most common (and we are gradually moving away from 2 and towards 3). As more templates become Lua-based, we are also moving away from all of the above, towards having a wrapper template (like 2) which calls an all-English template which then calls the Lua code, thereby not having to localize the Lua code at all.

Wed, Dec 12, 11:31 PM · Language-Team

Tue, Dec 4

Huji added a project to T211004: Differentiate private filters and private details in rights/methods/variables names: I18n.
Tue, Dec 4, 12:57 PM · I18n, User-Daimona, AbuseFilter
Huji added a comment to T211004: Differentiate private filters and private details in rights/methods/variables names.

I like your proposal. However, I think if we are doing this, then we should also rename the pertinent i18n message keys, and that means we should also move them on TranslateWiki using a bot, so people don't re-translate them under the new key. I'm sure there is a process for that, perhaps one of the TranslateWiki staff should be engaged early on?

Tue, Dec 4, 12:57 PM · I18n, User-Daimona, AbuseFilter
Huji added a comment to T210329: CheckUsers have unlogged access to IP addresses via the AbuseFilter API.

Thank you all for the great work!

Tue, Dec 4, 12:53 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Privacy, AbuseFilter, Security

Mon, Dec 3

Huji added a comment to T205972: Fixup Phan errors in SecurePoll.

This continues to be an issue. See https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/476439/ as a recent example.

Mon, Dec 3, 7:34 PM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Patch-For-Review, phan-taint-check-plugin, MediaWiki-extensions-SecurePoll

Sun, Dec 2

Huji awarded T210075: Send notification when 2FA is disabled a Like token.
Sun, Dec 2, 10:18 PM · Trust-and-Safety, MediaWiki-extensions-OATHAuth

Thu, Nov 29

Huji added a comment to T210767: Create a unit test for $wgGroupBlockRestrictions.

I am separating this because I will need some time to familiarize myself with the unit tests to devise an appropriate strategy for this. I don't want the implementation of the parent task and its other child to be delayed because of this.

Thu, Nov 29, 7:04 PM · Patch-For-Review, MediaWiki-Core-Tests, MediaWiki-User-management
Huji triaged T210767: Create a unit test for $wgGroupBlockRestrictions as Low priority.
Thu, Nov 29, 6:55 PM · Patch-For-Review, MediaWiki-Core-Tests, MediaWiki-User-management
Huji added a comment to T210642: Dissallow eliminators to block sysops on fawiki.

Test instructions for https://gerrit.wikimedia.org/r/476439

Thu, Nov 29, 6:53 PM · Patch-For-Review, MediaWiki-User-management, Wikimedia-Site-requests
Huji moved T210642: Dissallow eliminators to block sysops on fawiki from Backlog to Config - to process on the Wikimedia-Site-requests board.
Thu, Nov 29, 1:35 PM · Patch-For-Review, MediaWiki-User-management, Wikimedia-Site-requests
Huji moved T210642: Dissallow eliminators to block sysops on fawiki from Backlog to User blocking on the MediaWiki-User-management board.
Thu, Nov 29, 1:34 PM · Patch-For-Review, MediaWiki-User-management, Wikimedia-Site-requests
Huji claimed T210642: Dissallow eliminators to block sysops on fawiki.

Excellent idea! Patch coming shortly.

Thu, Nov 29, 1:40 AM · Patch-For-Review, MediaWiki-User-management, Wikimedia-Site-requests

Wed, Nov 28

Yamaha5 awarded T210642: Dissallow eliminators to block sysops on fawiki a Like token.
Wed, Nov 28, 8:04 PM · Patch-For-Review, MediaWiki-User-management, Wikimedia-Site-requests
Huji added a comment to T210642: Dissallow eliminators to block sysops on fawiki.

I am setting priority, as I will be working on it myself.

Wed, Nov 28, 6:35 PM · Patch-For-Review, MediaWiki-User-management, Wikimedia-Site-requests
Huji triaged T210642: Dissallow eliminators to block sysops on fawiki as Low priority.
Wed, Nov 28, 6:33 PM · Patch-For-Review, MediaWiki-User-management, Wikimedia-Site-requests
Huji added a subtask for T150826: Remove unblockself right on wikimedia wikis: T210642: Dissallow eliminators to block sysops on fawiki.
Wed, Nov 28, 6:33 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MediaWiki-User-management, User-notice, Patch-For-Review, Community-consensus-needed, Wikimedia-Site-requests
Huji added a parent task for T210642: Dissallow eliminators to block sysops on fawiki: T150826: Remove unblockself right on wikimedia wikis.
Wed, Nov 28, 6:33 PM · Patch-For-Review, MediaWiki-User-management, Wikimedia-Site-requests
Huji created T210642: Dissallow eliminators to block sysops on fawiki.
Wed, Nov 28, 6:33 PM · Patch-For-Review, MediaWiki-User-management, Wikimedia-Site-requests
Huji added a comment to T150826: Remove unblockself right on wikimedia wikis.

The mitigation can be defeated if the attacker can compromise two different admin accounts, and use only one of them for the blocks, but I don't think we can do much about that.

Wed, Nov 28, 1:35 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MediaWiki-User-management, User-notice, Patch-For-Review, Community-consensus-needed, Wikimedia-Site-requests
Huji added a comment to T210329: CheckUsers have unlogged access to IP addresses via the AbuseFilter API.

@Bawolff here you are!

Wed, Nov 28, 1:19 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Privacy, AbuseFilter, Security

Mon, Nov 26

Huji moved T210329: CheckUsers have unlogged access to IP addresses via the AbuseFilter API from Backlog to Doing on the Privacy board.
Mon, Nov 26, 3:22 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Privacy, AbuseFilter, Security
Huji moved T210329: CheckUsers have unlogged access to IP addresses via the AbuseFilter API from MediaWiki/Security Team/To triage to Patch pending deployment on the Security board.
Mon, Nov 26, 3:21 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Privacy, AbuseFilter, Security
Huji moved T210329: CheckUsers have unlogged access to IP addresses via the AbuseFilter API from Backlog to Logging on the AbuseFilter board.
Mon, Nov 26, 3:21 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Privacy, AbuseFilter, Security

Sun, Nov 25

Huji added a comment to T209590: API should return a helpful error message when URL is too long.

@Anomie: when I try https://fa.wikipedia.org/w/api.php?action=query&prop=coordinates&titles=File:Pandora Tomorrow box art.jpg&format=json with my browser, I get a valid API response (and HTTP status is obviously 200). But when I try longer links, I do not get a response. And when I replace the spaces with %20 I also do not get a response. This is with Firefox 63.0.3

Sun, Nov 25, 10:02 PM · MediaWiki-API
Huji awarded T169468: Deploy InternetArchiveBot on the Persian Wikipedia (fawiki) a Like token.
Sun, Nov 25, 9:38 PM · InternetArchiveBot (v2.0)
Huji added a comment to T210329: CheckUsers have unlogged access to IP addresses via the AbuseFilter API.

Fair comment, Daimona; I removed that line as well. New patch attached.

Sun, Nov 25, 9:07 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Privacy, AbuseFilter, Security
Huji added a comment to T210329: CheckUsers have unlogged access to IP addresses via the AbuseFilter API.

Uploading a new patch that would just remove the IP field from the results for now.

Sun, Nov 25, 1:19 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Privacy, AbuseFilter, Security
Huji added a comment to T210329: CheckUsers have unlogged access to IP addresses via the AbuseFilter API.

In terms of a long-term solution: how about we never show the IP in the GET request at all, but allow for a brand new POST-only query which would take the log ID and a reason, and return its private details?

Sun, Nov 25, 12:31 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Privacy, AbuseFilter, Security

Sat, Nov 24

Huji added a comment to T210329: CheckUsers have unlogged access to IP addresses via the AbuseFilter API.

I think this will do the job for now. Later, we should make sure the actual reason is a required field in the API call.

Sat, Nov 24, 7:53 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Privacy, AbuseFilter, Security
Huji added a comment to T210329: CheckUsers have unlogged access to IP addresses via the AbuseFilter API.

Which feature? The ability to see private details (through the web interface) was enabled after a loooooooong process. See T152934 and related tasks.

Sat, Nov 24, 7:32 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Privacy, AbuseFilter, Security
Huji raised the priority of T210329: CheckUsers have unlogged access to IP addresses via the AbuseFilter API from High to Unbreak Now!.

Thanks for pointing that out. Elevating to UBN.

Sat, Nov 24, 7:23 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Privacy, AbuseFilter, Security
Huji claimed T210329: CheckUsers have unlogged access to IP addresses via the AbuseFilter API.

Definitely a very high priority. Since an active threat is not identified and no CU account has been compromised, I am not yet marking it as UBN.

Sat, Nov 24, 6:42 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Privacy, AbuseFilter, Security

Thu, Nov 22

4nn1l2 awarded T117127: Add support for the Meek STV method in SecurePoll a Love token.
Thu, Nov 22, 7:42 AM · Elections, MediaWiki-extensions-SecurePoll

Mon, Nov 19

Huji added a comment to T209802: Cannot vote on votewiki.

I had a feeling it is related to FastCGI as well (just like the other two mentioned above). Sadly, I have no knowledge of FastCGI troubleshooting. I will quietly monitor this thread. Positively surprised that this did not happen during T207560.

Mon, Nov 19, 1:54 AM · Patch-For-Review, Operations, Wikimedia-production-error, MediaWiki-extensions-SecurePoll
Huji added a comment to T209802: Cannot vote on votewiki.

Server logs?

Mon, Nov 19, 12:15 AM · Patch-For-Review, Operations, Wikimedia-production-error, MediaWiki-extensions-SecurePoll

Fri, Nov 16

Huji updated the task description for T145415: Removing admins in SecurePoll sometimes has unintended effects.
Fri, Nov 16, 3:53 AM · MediaWiki-HTMLForm, MediaWiki-extensions-SecurePoll
Huji updated the task description for T145415: Removing admins in SecurePoll sometimes has unintended effects.
Fri, Nov 16, 3:53 AM · MediaWiki-HTMLForm, MediaWiki-extensions-SecurePoll
Huji added a project to T145415: Removing admins in SecurePoll sometimes has unintended effects: MediaWiki-HTMLForm.

Fun fact: if you press enter while you are in the "Question text" field, it will make the first of the Admins fields disappear. If you keep pressing Enter, the rows in the Admin section disappear one by one. And if you press enter again after all this, it will make a new empty input box appear in the Admins section!

Fri, Nov 16, 3:45 AM · MediaWiki-HTMLForm, MediaWiki-extensions-SecurePoll
Huji merged task T209658: Pressing return on any inputbox deletes the topmost election admin into T145415: Removing admins in SecurePoll sometimes has unintended effects.
Fri, Nov 16, 1:43 AM · goodfirstbug, MediaWiki-extensions-SecurePoll
Huji merged task T179446: Pressing enter/return in any inputbox will remove the topmost election admin into T145415: Removing admins in SecurePoll sometimes has unintended effects.
Fri, Nov 16, 1:43 AM · MediaWiki-extensions-SecurePoll
Huji merged tasks T179446: Pressing enter/return in any inputbox will remove the topmost election admin, T209658: Pressing return on any inputbox deletes the topmost election admin into T145415: Removing admins in SecurePoll sometimes has unintended effects.
Fri, Nov 16, 1:43 AM · MediaWiki-HTMLForm, MediaWiki-extensions-SecurePoll
Huji triaged T209665: Trying to construct an `edit` URL on votewiki times out as High priority.

This has to be related to T209656 so I am adding @Bawolff and setting the same priority (especially considering that ENWP Arb Com elections are only a few days away).

Fri, Nov 16, 1:41 AM · MediaWiki-extensions-SecurePoll
Huji added a comment to T209658: Pressing return on any inputbox deletes the topmost election admin.

Safe to say that T179446 is a duplicate of this?

Fri, Nov 16, 12:06 AM · goodfirstbug, MediaWiki-extensions-SecurePoll

Thu, Nov 15

Huji updated subscribers of T209656: Cannot create new poll on votewiki.

Brian has been tremendously helpful in situations like this. I am going to add him here, in case he has time to check the server logs.

Thu, Nov 15, 11:02 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, MediaWiki-extensions-SecurePoll
Huji added a comment to T209656: Cannot create new poll on votewiki.

Someone should look at the server logs and tell us what exactly is logged.

Thu, Nov 15, 11:01 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, MediaWiki-extensions-SecurePoll
Huji added a comment to T209585: Special:CheckUserLog is accessible while a user with checkuser-log right is blocked.

Melos, this patch looks good. Please post it publicly and I will +2 it. Like Brian, I think it is okay to work on this in public.

Thu, Nov 15, 10:31 PM · CheckUser, Security
Huji added a comment to T207560: Carry out the 2018 fawiki elections on votewiki.
Thu, Nov 15, 6:43 PM · Patch-For-Review, Trust-and-Safety, Wikimedia-Site-requests
Huji edited P7813 Exceptions caused by using $wgLBFactoryConf.
Thu, Nov 15, 4:58 PM
Huji edited P7808 LocalSettings.php file used with CentralAuth.
Thu, Nov 15, 4:58 PM
Huji created T209602: Check for mismatch in claimed and practical dependecies of extensions.
Thu, Nov 15, 4:50 PM · Continuous-Integration-Config
Huji edited P7808 LocalSettings.php file used with CentralAuth.
Thu, Nov 15, 4:38 PM
Huji created P7813 Exceptions caused by using $wgLBFactoryConf.
Thu, Nov 15, 4:35 PM
Huji added a comment to T208687: Convert SecurePoll to use OOUI.

Oh, you are right. That is a massive undertaking.

Thu, Nov 15, 4:06 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), User-Ladsgroup, MediaWiki-extensions-SecurePoll, UI-Standardization
Huji closed T208687: Convert SecurePoll to use OOUI as Resolved.
Thu, Nov 15, 4:03 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), User-Ladsgroup, MediaWiki-extensions-SecurePoll, UI-Standardization
Huji closed T208687: Convert SecurePoll to use OOUI, a subtask of T122014: Convert all extensions/skins to OOUI, as Resolved.
Thu, Nov 15, 4:03 PM · Goal, UI-Standardization
Huji created T209590: API should return a helpful error message when URL is too long.
Thu, Nov 15, 2:38 PM · MediaWiki-API
Huji created P7808 LocalSettings.php file used with CentralAuth.
Thu, Nov 15, 2:00 AM

Wed, Nov 14

Huji claimed T209518: Cookie Dups section is not properly labeled.
Wed, Nov 14, 5:55 PM · User-Huji, MediaWiki-extensions-SecurePoll
Huji created T209518: Cookie Dups section is not properly labeled.
Wed, Nov 14, 5:55 PM · User-Huji, MediaWiki-extensions-SecurePoll

Nov 14 2018

Huji added a comment to T207560: Carry out the 2018 fawiki elections on votewiki.

Huh! @Bawolff I think you just revealed a security issue; let me create a non-Public task for it.

Nov 14 2018, 12:15 AM · Patch-For-Review, Trust-and-Safety, Wikimedia-Site-requests

Nov 13 2018

Huji added a comment to T207560: Carry out the 2018 fawiki elections on votewiki.

@4nn1l2 there is no way for us to know if the election was encrypted or not (because our election admin access was removed, appropriately, prior to the election being finalized). But I assume that ALL elections are encrypted by Joe or James. Once the election is complete, they can run the tallies for us.

Nov 13 2018, 3:23 PM · Patch-For-Review, Trust-and-Safety, Wikimedia-Site-requests
Huji updated the task description for T207560: Carry out the 2018 fawiki elections on votewiki.
Nov 13 2018, 2:35 AM · Patch-For-Review, Trust-and-Safety, Wikimedia-Site-requests
Huji added a comment to T207560: Carry out the 2018 fawiki elections on votewiki.

@revi and @alanajjar the voting period ends in about 21.5 hours from when I am writing this (i.e. exactly at Nov 14, 00:00:00 UTC). At that point you have THREE DAYS to review the votes and look for potential socks. You can see the list of voters on the votewiki, and along with it, you can see their IP address and UA string. If necessary, we can also run additional CU queries for you (I am a local CU), or you can run it yourself (by promoting yourself as a temporary local CU).

Nov 13 2018, 2:34 AM · Patch-For-Review, Trust-and-Safety, Wikimedia-Site-requests

Nov 8 2018

Huji added a comment to T208842: Create a front end for making unit tests for filters.

@Daimona can I ask you to kindly rename the task as I suggest above, and create the parent task as well?

Nov 8 2018, 2:04 AM · User-Daimona, AbuseFilter

Nov 6 2018

Huji added a comment to T208842: Create a front end for making unit tests for filters.

There are two issues at hand:

Nov 6 2018, 10:17 PM · User-Daimona, AbuseFilter
Dalba awarded T186971: AbuseFilter should allow testing a filter against edits that are not in recent changes a Like token.
Nov 6 2018, 9:22 AM · AbuseFilter
Huji updated subscribers of T205972: Fixup Phan errors in SecurePoll.

As evident from https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/SecurePoll/+/471556/ and https://integration.wikimedia.org/ci/job/mwext-php70-phan-seccheck-docker/24376/console this issue is persisting. Also adding @Ladsgroup

Nov 6 2018, 7:11 AM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Patch-For-Review, phan-taint-check-plugin, MediaWiki-extensions-SecurePoll

Oct 31 2018

Huji added a comment to T207560: Carry out the 2018 fawiki elections on votewiki.

At this point, there is no reason for our accounts to be open either; please block them.

Oct 31 2018, 1:47 PM · Patch-For-Review, Trust-and-Safety, Wikimedia-Site-requests
Huji claimed T208419: "Must log in" message is never localized.
Oct 31 2018, 1:24 PM · I18n, User-Huji, MediaWiki-extensions-SecurePoll
Huji created T208419: "Must log in" message is never localized.
Oct 31 2018, 1:23 PM · I18n, User-Huji, MediaWiki-extensions-SecurePoll

Oct 30 2018

Huji added a comment to T207560: Carry out the 2018 fawiki elections on votewiki.

@jrbs At this point, you can remove me from the election admins. You can also remove 4nn1l2.

Oct 30 2018, 6:26 PM · Patch-For-Review, Trust-and-Safety, Wikimedia-Site-requests
Huji added a comment to T207560: Carry out the 2018 fawiki elections on votewiki.

I will say that it would be ideal to get more lead time in future for these elections, since we have to move things around to make time for it. :)

We will make sure to have at least one week for configuring the SecurePoll in the future.

I configured SecurePoll:689, added scrutineers to the list of admins, and imported the list of eligible voters as an include-list rather than a need-list. We had imported them as need-lists in previous years (2016 and 2017), and while they did work, include-list seems more sensible to me. Here are the definitions:

  • The Eligibility list [need-list] is a list of voters who are allowed to vote, if they also meet the basic requirements defined above. This list is often populated automatically.
  • The Override list [include-list] is a list of voters who are allowed to vote regardless of the basic requirements or the eligibility list. Since we have not defined any requirements, and instead have created the list by running a query, include-list seems more logical to me.

    @Huji, please check everything independently and critically.
Oct 30 2018, 6:25 PM · Patch-For-Review, Trust-and-Safety, Wikimedia-Site-requests
Huji added a comment to T170508: The "show ip" action should also provide a distinct list of user-agents for each IP.

I understand it better now. Let me update the patch and provide you with some queries.

Oct 30 2018, 12:23 AM · DBA, Patch-For-Review, CheckUser

Oct 29 2018

Huji added a comment to T207560: Carry out the 2018 fawiki elections on votewiki.

Sweet; I will submit a patch by the end of the day.

Oct 29 2018, 1:42 PM · Patch-For-Review, Trust-and-Safety, Wikimedia-Site-requests
Huji triaged T207560: Carry out the 2018 fawiki elections on votewiki as High priority.

I know it has been the weekend, but just to make sure this gets priority on Monday, I am setting it at High. Note that we only have Monday and Tuesday to configure this election (as well as change the config of votewiki, temporarily, to set the default language to Persian "fa").

Oct 29 2018, 12:27 AM · Patch-For-Review, Trust-and-Safety, Wikimedia-Site-requests

Oct 27 2018

Huji added a comment to T170508: The "show ip" action should also provide a distinct list of user-agents for each IP.

@jcrespo I think it is best to move directly to the final desired state (see updated task definition above). This means we would want to run a bunch of DISTINCT queries, and from a DBA perspective, this may mean we need a few new indexes.

Oct 27 2018, 2:42 PM · DBA, Patch-For-Review, CheckUser
Huji updated the task description for T170508: The "show ip" action should also provide a distinct list of user-agents for each IP.
Oct 27 2018, 2:40 PM · DBA, Patch-For-Review, CheckUser
Huji raised the priority of T170508: The "show ip" action should also provide a distinct list of user-agents for each IP from Low to High.

I am increasing the priority for this, because in some cases this functionality can truly impact the process and outcome of a CU. (For those who have access, see T207232 as an example)

Oct 27 2018, 2:11 PM · DBA, Patch-For-Review, CheckUser
Huji updated subscribers of T207344: Phan-taint-check-plugin not available for PHP 7.1.17.

@Reedy can I ask you to kindly take a look at this?

Oct 27 2018, 1:18 PM · phan-taint-check-plugin
Huji added a comment to T207344: Phan-taint-check-plugin not available for PHP 7.1.17.

I updated the git working copy of SecurePoll and reran the above and now I get this error message:

Oct 27 2018, 1:17 PM · phan-taint-check-plugin

Oct 26 2018

Huji added a comment to T207560: Carry out the 2018 fawiki elections on votewiki.

@jrbs can you please give me (and 4nn1l2) permission to edit the election?

Oct 26 2018, 10:31 PM · Patch-For-Review, Trust-and-Safety, Wikimedia-Site-requests
Huji added a comment to T207560: Carry out the 2018 fawiki elections on votewiki.

Please give updates on this thread about how the work is progressing. Note that the intent is to keep all of the communication publicly on this task.

Oct 26 2018, 6:43 PM · Patch-For-Review, Trust-and-Safety, Wikimedia-Site-requests

Oct 23 2018

Huji added a comment to T207085: Suppressed edits remain examinable in AbuseFilter.

I can only +1 it, as my +2 rights don't expand into the WMF branches.
Great work by the way!

Oct 23 2018, 11:48 PM · User-Rxy, Trust-and-Safety, Vuln-Infoleak, Security, MediaWiki-Revision-deletion, AbuseFilter
Huji added a comment to T207085: Suppressed edits remain examinable in AbuseFilter.

Not once merged, but once deployed.

Oct 23 2018, 5:22 PM · User-Rxy, Trust-and-Safety, Vuln-Infoleak, Security, MediaWiki-Revision-deletion, AbuseFilter

Oct 21 2018

alanajjar awarded T207560: Carry out the 2018 fawiki elections on votewiki a Like token.
Oct 21 2018, 6:38 PM · Patch-For-Review, Trust-and-Safety, Wikimedia-Site-requests

Oct 20 2018

Huji added a comment to T207560: Carry out the 2018 fawiki elections on votewiki.

Sounds good.

Oct 20 2018, 8:34 PM · Patch-For-Review, Trust-and-Safety, Wikimedia-Site-requests
Huji updated the task description for T207560: Carry out the 2018 fawiki elections on votewiki.
Oct 20 2018, 8:34 PM · Patch-For-Review, Trust-and-Safety, Wikimedia-Site-requests
Huji updated subscribers of T207560: Carry out the 2018 fawiki elections on votewiki.

Importing the list of eligible voters can be done right now. Sunfyre has run the query and I am attaching a clean version of the output.

Oct 20 2018, 5:54 PM · Patch-For-Review, Trust-and-Safety, Wikimedia-Site-requests
Huji updated the task description for T207560: Carry out the 2018 fawiki elections on votewiki.
Oct 20 2018, 5:52 PM · Patch-For-Review, Trust-and-Safety, Wikimedia-Site-requests
Huji created T207560: Carry out the 2018 fawiki elections on votewiki.
Oct 20 2018, 5:41 PM · Patch-For-Review, Trust-and-Safety, Wikimedia-Site-requests

Oct 18 2018

Huji added a comment to T207085: Suppressed edits remain examinable in AbuseFilter.

@Aklapper great direction, thank you!

Oct 18 2018, 12:27 AM · User-Rxy, Trust-and-Safety, Vuln-Infoleak, Security, MediaWiki-Revision-deletion, AbuseFilter

Oct 17 2018

Huji added a comment to T207085: Suppressed edits remain examinable in AbuseFilter.

I still need an answer as to how we merge a patch like this.

Oct 17 2018, 10:57 PM · User-Rxy, Trust-and-Safety, Vuln-Infoleak, Security, MediaWiki-Revision-deletion, AbuseFilter
Huji renamed T207344: Phan-taint-check-plugin not available for PHP 7.1.17 from Phan not available for PHP 7.1.17 to Phan-taint-check-plugin not available for PHP 7.1.17.
Oct 17 2018, 10:49 PM · phan-taint-check-plugin
Huji created T207344: Phan-taint-check-plugin not available for PHP 7.1.17.
Oct 17 2018, 10:49 PM · phan-taint-check-plugin
Huji created T207343: Phan failing on SecurePoll patches.
Oct 17 2018, 10:43 PM · MediaWiki-extensions-SecurePoll, phan-taint-check-plugin

Oct 16 2018

Huji added a comment to T207085: Suppressed edits remain examinable in AbuseFilter.

@Daimona: your patch checks out. But I also noticed a related issue:

Oct 16 2018, 11:18 PM · User-Rxy, Trust-and-Safety, Vuln-Infoleak, Security, MediaWiki-Revision-deletion, AbuseFilter
Huji added a comment to T207085: Suppressed edits remain examinable in AbuseFilter.

I like Daimona's patch better. I am going to test it momentarily; assuming that it checks out, what is our approach here? Do we have Daimona post it publicly, have me merge it within minutes, have Daimona create a cherry pick for WMF current build, have someone SWAT it ASAP, or do we try to minimize the amount of time things are public in some other way (e.g. I submit and merge the patch myself, or even, we have someone who can SWAT it submit and merge the patch in both places, based on my verbal approval here?)

Oct 16 2018, 10:04 PM · User-Rxy, Trust-and-Safety, Vuln-Infoleak, Security, MediaWiki-Revision-deletion, AbuseFilter