Fix "Fetching a token via "action=login" is deprecated" when authenticating via bot passwords
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Stang
	Jun 3 2022, 8:58 PM

Description

Currently when trying to login with botpassword, a warning message indicating "fetching a token via "action=login" is deprecated" will be shown, and an error message will be returned. The logic inside login_to_site function is to submit a login request (w/o "lgtoken" parameter) first, then perform a re-login. I thought probably we could move the code block of getting a login token to the position before submit a login request (inside that while True loop), which could fix such warning.

>>> import pywikibot
>>> site = pywikibot.Site('test', 'wikipedia', user='Crystal-bot')
>>> site.login()
WARNING: No user is logged in on site wikipedia:test
Logging in to wikipedia:test as Crystal-bot@botname
WARNING: API warning (main): Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/postorius/lists/mediawiki-api-announce.lists.wikimedia.org/> for notice of API deprecations and breaking changes. Use [[Special:ApiFeatureUsage]] to see usage of deprecated features by your application.
WARNING: API warning (login): Fetching a token via "action=login" is deprecated. Use "action=query&meta=tokens&type=login" instead.
ERROR: Received incorrect login token. Forcing re-login.
>>>

Details

	Subject	Repo	Branch	Lines +/-
	Pass login token when using action=login	pywikibot/core	master	+4 -2

Customize query in gerrit

Related Objects

Mentioned Here: T178061: Reduce (API) warning clutter in login.py after clean installation
T249526: Misleading warning raised by the login API: "Fetching a token via action=login is deprecated"
T137805: API action=login is deprecated

Event Timeline

Stang created this task.Jun 3 2022, 8:58 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJun 3 2022, 8:58 PM

Stang updated the task description. (Show Details)Jun 3 2022, 8:59 PM

See T137805 and T249526

After all of your shell commands,

>>> import pywikibot
>>> site = pywikibot.Site('test', 'wikipedia', user='Crystal-bot')
>>> site.login()
WARNING: No user is logged in on site wikipedia:test
Logging in to wikipedia:test as Crystal-bot@botname
WARNING: API warning (main): Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/postorius/lists/mediawiki-api-announce.lists.wikimedia.org/> for notice of API deprecations and breaking changes. Use [[Special:ApiFeatureUsage]] to see usage of deprecated features by your application.
WARNING: API warning (login): Fetching a token via "action=login" is deprecated. Use "action=query&meta=tokens&type=login" instead.
ERROR: Received incorrect login token. Forcing re-login.
>>>

what is the result of these statements?:

>>> site.username()
>>> site.user() or site.user() is None

In T309898#7982752, @Xqt wrote:
what is the result of these statements?:
>>> site.username()
>>> site.user() or site.user() is None

>>> site.username()
'Crystal-bot'
>>> site.user() or site.user() is None
'Crystal-bot'

In T309898#7982957, @Stang wrote:

>>> site.username()
'Crystal-bot'
>>> site.user() or site.user() is None
'Crystal-bot'

Thank you. That means your bot is logged in and there is only a warning thrown like in T137805. What is your

>>> site.version() ?

Thank you. That means your bot is logged in and there is only a warning thrown like in T137805. What is your

>>> site.version() ?

>>> site.version()
'1.39.0-wmf.14'

Same for Special:Version on testwiki.

Xqt lowered the priority of this task from High to Low.Jun 11 2022, 4:23 PM

Xqt closed this task as a duplicate of T178061: Reduce (API) warning clutter in login.py after clean installation.Jun 11 2022, 4:35 PM

Stang unsubscribed.Jun 11 2022, 4:37 PM

Seems this is for BotPassword and T178061 is for client login.

Stang subscribed.Jun 14 2022, 12:47 AM

Just a note that this warning is still happening:

Logging in to officewiki:officewiki as Officewikibot@toolforge
WARNING: API warning (main): Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/postorius/lists/mediawiki-api-announce.lists.wikimedia.org/> for notice of API deprecations and breaking changes. Use [[Special:ApiFeatureUsage]] to see usage of deprecated features by your application.
WARNING: API warning (login): Fetching a token via "action=login" is deprecated. Use "action=query&meta=tokens&type=login" instead.
ERROR: Received incorrect login token. Forcing re-login.

Runtime context:

$ webservice buildservice shell -- pwb --version
Pywikibot: [https] toolforge-repos-officewikibot-pywikibot (998aaa8, g1, 2023/11/17, 14:56:35, OUTDATED)
Release version: 8.5.1
setuptools version: 63.4.3
mwparserfromhell version: 0.6.5
wikitextparser version: n/a
requests version: 2.31.0
  cacerts: /app/.heroku/python/lib/python3.9/site-packages/certifi/cacert.pem
    certificate test: ok
Python: 3.9.18 (main, Aug 24 2023, 22:36:08)
[GCC 11.4.0]
PYWIKIBOT_DIR: Not set
PYWIKIBOT_DIR_PWB: /workspace/pywikibot/scripts
PYWIKIBOT_NO_USER_CONFIG: Not set
Config base dir: /workspace
Usernames for family 'officewiki':
        *: Officewikibot

bd808 renamed this task from Fix "Fetching a token via "action=login" is deprecated" to Fix "Fetching a token via "action=login" is deprecated" when authenticating via bot passwords.Nov 20 2023, 5:27 PM

Change 990720 had a related patch set uploaded (by Huji; author: Huji):

[pywikibot/core@master] Pass login token when using action=login

https://gerrit.wikimedia.org/r/990720

gerritbot added a project: Patch-For-Review.Jan 15 2024, 4:18 PM

Huji claimed this task.Jan 15 2024, 4:18 PM

Xqt closed this task as Resolved.Jan 23 2024, 4:13 PM

Xqt reopened this task as Open.Jan 24 2024, 5:34 PM

Change 990720 merged by jenkins-bot:

[pywikibot/core@master] Pass login token when using action=login

https://gerrit.wikimedia.org/r/990720

Xqt closed this task as Resolved.Jan 27 2024, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 27 2024, 6:30 PM