Page MenuHomePhabricator

Exclude list is not working for special page names
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
Appears in dark mode

What should have happened instead?:
Appears in light mode with an notification

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Sign off step

QA Results - Prod

ACStatusDetails
1T359958#9635161
2T359958#9635194

Event Timeline

Jdlrobson updated the task description. (Show Details)

Change 1010257 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/MinervaNeue@master] Fix Issue with localisation of special page titles in exclusion logic

https://gerrit.wikimedia.org/r/1010257

Change 1010697 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Fix Issue with localization of special page titles in exclusion logic

https://gerrit.wikimedia.org/r/1010697

Change 1010257 had a related patch set uploaded (by Jdlrobson; author: Mabualruz):

[mediawiki/skins/MinervaNeue@master] Fix Issue with localization of special page titles in exclusion logic

https://gerrit.wikimedia.org/r/1010257

Change 1010257 abandoned by Mabualruz:

[mediawiki/skins/MinervaNeue@master] Fix Issue with localization of special page titles in exclusion logic

Reason:

solution in 1010697

https://gerrit.wikimedia.org/r/1010257

Change 1010697 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fix Issue with localization of special page titles in exclusion logic

https://gerrit.wikimedia.org/r/1010697

Change 1010585 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@wmf/1.42.0-wmf.22] Fix Issue with localization of special page titles in exclusion logic

https://gerrit.wikimedia.org/r/1010585

Jan will backport this which should unblock our deployment.

Change 1010585 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@wmf/1.42.0-wmf.22] Fix Issue with localization of special page titles in exclusion logic

https://gerrit.wikimedia.org/r/1010585

Mentioned in SAL (#wikimedia-operations) [2024-03-13T20:22:28Z] <jdrewniak@deploy2002> Started scap: Backport for [[gerrit:1010585|Fix Issue with localization of special page titles in exclusion logic (T359958)]]

Mentioned in SAL (#wikimedia-operations) [2024-03-13T20:24:50Z] <jdrewniak@deploy2002> jdlrobson and jdrewniak: Backport for [[gerrit:1010585|Fix Issue with localization of special page titles in exclusion logic (T359958)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-03-13T20:39:17Z] <jdrewniak@deploy2002> Finished scap: Backport for [[gerrit:1010585|Fix Issue with localization of special page titles in exclusion logic (T359958)]] (duration: 16m 49s)

Test Result - Prod

Status: ❌ FAIL
Environment: frwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://fr.m.wikipedia.org/w/index.php?title=Sp%C3%A9cial:Modifications_r%C3%A9centes&days=30&enhanced=1&hideWikibase=1&hidebots=1&hidecategorization=1&limit=500&minervanightmode=1&safemode=1&urlversion=2

✅ AC1: Appears in light mode
❌ AC2: with an notification
There is no notification

screenshot.mov.gif (982×768 px, 916 KB)

@Edtadros the notifications cannot be tested on right now. We should repeat this test as part of the deployment Monday.

The screenshot also seems incorrect?

Test Result - Prod

Status: ❌ FAIL
Environment: frwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://fr.m.wikipedia.org/w/index.php?title=Sp%C3%A9cial:Modifications_r%C3%A9centes&days=30&enhanced=1&hideWikibase=1&hidebots=1&hidecategorization=1&limit=500&minervanightmode=1&safemode=1&urlversion=2

✅ AC1: Appears in light mode
❌ AC2: with an notification
There is no notification

screenshot.mov.gif (982×768 px, 916 KB)

The notification translates to:
Unfortunately, grouping results by page is not available on mobile. If you would like to use the page grouping feature, please visit the desktop site.

https://fr.m.wikipedia.org/w/index.php?title=Sp%C3%A9cial:Modifications_r%C3%A9centes&days=30&enhanced=1&hideWikibase=1&hidebots=1&hidecategorization=1&limit=500&safemode=1&urlversion=2 even without the night mode parameter added the notification persists

I do not think it relates to the ticket. @Jdlrobson please advise