Page MenuHomePhabricator

RHo (Rita Ho)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Mar 23 2016, 6:05 PM (245 w, 2 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
RHo (WMF) [ Global Accounts ]

Recent Activity

Wed, Dec 2

RHo added a comment to T268699: Image recommendation testing tool.

QuickView on commons Special:MediaSearch (e.g. https://commons.wikimedia.org/wiki/Special:MediaSearch?type=bitmap&q=Faustus+Cornelius+Sulla+) may provide some additional ideas on what (and how) to present for an img file card.

Wed, Dec 2, 9:32 AM · Patch-For-Review, Growth-Team (Current Sprint)

Tue, Dec 1

RHo added a comment to T75972: Loading indicators / Progress indicators are inconsistent. .

hi @Volker_E - here's an example on Growth of how we are using skeleton shimmer instead of the loading indicators due to the large area of content elements all being loaded at different times (Image, article title, extract, page views):

Tue, Dec 1, 4:33 PM · WMF-Design, Design, UI-Standardization, Contributors-Team
RHo added a comment to T266029: Add Dialogs to DSG.
Tue, Dec 1, 4:32 PM · Wikimedia Design Style Guide
RHo added a comment to T266029: Add Dialogs to DSG.

Thanks for the feedback @RHo! Here is an attempt to address your questions:

  1. What happens when there are multiple actions?

This is a tough one and I'm not totally sure the right path forward. Ideally we would find a way to keep all of the actions near each other like the changes we are making to desktop. I don't see multiple actions in the top bar fitting after we account for the title and various languages, so perhaps my previous post isn't the best path forward.

Currently any actions at the bottom of a dialog stayed fixed on top of the keyboard. Perhaps the main action could also live in this area (see screenshot below) This appears to be a functional answer but starts to leave very little room left in the viewport to work within. It also feels a bit counter to established iOS and Android patterns. Does anyone have any other potential solutions?

Tue, Dec 1, 1:08 PM · Wikimedia Design Style Guide
RHo moved T258017: Variant D: difficulty overlay in onboarding from Design Review to Needs More Work on the Growth-Team (Current Sprint) board.
Tue, Dec 1, 11:41 AM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Growth-Team (Current Sprint), GrowthExperiments

Mon, Nov 30

RHo moved T268998: External user testing of the image recommendation tool from 📗Backlog (Current sprint) to 💪In Progress on the Growth Design board.
Mon, Nov 30, 2:10 PM · Growth Design, Growth-Structured-Tasks, Growth-Team (Current Sprint)
RHo moved T268998: External user testing of the image recommendation tool from Incoming to Needs Design/Design Doing on the Growth-Team (Current Sprint) board.
Mon, Nov 30, 2:09 PM · Growth Design, Growth-Structured-Tasks, Growth-Team (Current Sprint)
RHo created T268998: External user testing of the image recommendation tool.
Mon, Nov 30, 2:09 PM · Growth Design, Growth-Structured-Tasks, Growth-Team (Current Sprint)
RHo added a comment to T268699: Image recommendation testing tool.

@RHo @MMiller_WMF please have a look at the demo on growthtasks.toolforge.org and let me know what if anything you'd like to have changed before it's used to score image assessments. (For one thing, do you want the direct link to the Commons file page to be available, e.g. https://commons.wikimedia.org/wiki/File:Rybina,_Most_kolejowy_-_obrotowy_-_fotopolska.eu_(330804).jpg, when reviewing an article?

Mon, Nov 30, 1:19 PM · Patch-For-Review, Growth-Team (Current Sprint)

Fri, Nov 27

RHo moved T258016: Variant C: onboarding from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

thanks @Etonkovidova, last item looks good

Fri, Nov 27, 12:47 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments

Thu, Nov 26

RHo added a comment to T268699: Image recommendation testing tool.

@RHo @MMiller_WMF my initial thought on this is to use our existing Special:Homepage + Suggested Edits module infrastructure and deploy this on a non-production wiki (I think we have https://growthtasks.toolforge.org/ as a placeholder for now).

So, it would be something like the following:

  • the suggested edits module would be configured to have an "Add an image" task type, and its queue would come from the file in T266271.
  • the card in the suggested edits module would show the proposed image, the article title, wikidata description, so basically the same as our current suggested edits cards. I'm not sure how fitting "description, caption, source, and depicts statements" would work there, though.
  • clicking on a card would take you to the article (we will import en masse the article titles from the dataset).
  • on the article, we'd hook into our existing guidance and show an OOUI dialog that lets the user assess with yes/no/skip/caption
  • instead of eventlogging, we would create a database table that would record the answers along with the user ID and the image being reviewed

Does that sound like it would work for phase 1? Or do you have in mind something else?

Thu, Nov 26, 2:15 PM · Patch-For-Review, Growth-Team (Current Sprint)
RHo added a comment to T266029: Add Dialogs to DSG.

Small mobile update:

I've been exploring how the designs in my previous post might differ on mobile web and iOS/Android. You can see the update starting on slide 18 here.

The quick summary:

  • Considering two different mobile options. A simple bulletin type dialog and a full screen dialog.
  • The full screen design will need to diverge from desktop by having the actions in the top bar in order to not cause issues with the keyboard coming up
  • Still exploring what the ui and chrome of the full screen could look like.
Thu, Nov 26, 12:44 PM · Wikimedia Design Style Guide

Wed, Nov 25

RHo updated the task description for T268708: Add a link: mobile navigation in suggested edits module.
Wed, Nov 25, 11:40 AM · GrowthExperiments, Add-Link, Growth-Structured-Tasks, Growth-Team
RHo updated the task description for T268709: Add a link: mobile swiping gesture in suggested edits feed (nice to have).
Wed, Nov 25, 11:39 AM · GrowthExperiments, Add-Link, Growth-Structured-Tasks, Growth-Team
RHo updated the task description for T268708: Add a link: mobile navigation in suggested edits module.
Wed, Nov 25, 11:38 AM · GrowthExperiments, Add-Link, Growth-Structured-Tasks, Growth-Team
RHo updated the task description for T268708: Add a link: mobile navigation in suggested edits module.
Wed, Nov 25, 11:37 AM · GrowthExperiments, Add-Link, Growth-Structured-Tasks, Growth-Team
RHo renamed T268709: Add a link: mobile swiping gesture in suggested edits feed (nice to have) from Add a link: mobile swiping in suggested edits feed (nice to have) to Add a link: mobile swiping gesture in suggested edits feed along with moving left and right arrows to footer (nice to have).
Wed, Nov 25, 11:36 AM · GrowthExperiments, Add-Link, Growth-Structured-Tasks, Growth-Team
RHo added a comment to T268709: Add a link: mobile swiping gesture in suggested edits feed (nice to have).

Does "animate" mean just that, or some kind of drag mechanics (where the card moves in sync with your finger so it feels like dragging paper)? The latter is common on mobile apps but probably more effort.

Wed, Nov 25, 11:36 AM · GrowthExperiments, Add-Link, Growth-Structured-Tasks, Growth-Team

Tue, Nov 24

RHo added a comment to T258017: Variant D: difficulty overlay in onboarding.

hi @Catrope and @Tgr - one suggestion I have is if we can incorporate the icon to the label element using teh ::before selector instead, as this makes it easier to control the positioning in reference to the text label.
This is what I did for the task types filter instead and it works on both mobile and desktop:

.mw-ge-homepage-taskTypeSelectionWidget-difficulty-level-easy h4.mw-ge-homepage-taskTypeSelectionWidget-difficulty-level-label:before {
  content: '';
  background-image: url(/w/load.php?modules=ext.growthExperiments.Homepage.icons&image=difficulty-easy&format=rasterized&lang=cs&skin=minerva&version=162dj);
  background-image: linear-gradient(transparent,transparent),url("data:image/svg+xml,%3Csvg xmlns=%22http://www.w3.org/2000/svg%22 width=%2224%22 height=%2224%22%3E %3Cpath d=%22M21 3v18h-5V3h5zm-6 6v12h-5V9h5zm-6 6v6H3v-6h6zM20 4h-3v16h3V4zm-6 6h-3v10h3V10z%22 fill=%22%2314866d%22/%3E %3C/svg%3E");
  background-position: left bottom;
  background-repeat: no-repeat;
  background-size: 20px 20px;
  padding-left: 1.5em;
}
Tue, Nov 24, 12:06 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Growth-Team (Current Sprint), GrowthExperiments
RHo added a comment to T268514: [Language switcher] Language switcher button design.

Strong +1 to @Amire80 's comment about not using flags for the reasons stated, plus another which is ideally we want an icon that is works in monochrome, and works well in small sizes.

Tue, Nov 24, 10:18 AM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements

Tue, Nov 10

RHo moved T267632: Add a link: Conduct a 2nd round of user testing on the revised *Desktop* designs for "Add a link" (testing sentence highlighting around a link) from Needs Design/Design Doing to Needs PM Review on the Growth-Team (Current Sprint) board.

See updated description with results summary (and link to full doc).

Tue, Nov 10, 4:52 PM · Growth-Structured-Tasks, Growth-Team (Current Sprint), Add-Link
RHo updated the task description for T267632: Add a link: Conduct a 2nd round of user testing on the revised *Desktop* designs for "Add a link" (testing sentence highlighting around a link).
Tue, Nov 10, 4:52 PM · Growth-Structured-Tasks, Growth-Team (Current Sprint), Add-Link
RHo updated the task description for T267632: Add a link: Conduct a 2nd round of user testing on the revised *Desktop* designs for "Add a link" (testing sentence highlighting around a link).
Tue, Nov 10, 4:50 PM · Growth-Structured-Tasks, Growth-Team (Current Sprint), Add-Link
RHo placed T267632: Add a link: Conduct a 2nd round of user testing on the revised *Desktop* designs for "Add a link" (testing sentence highlighting around a link) up for grabs.
Tue, Nov 10, 11:27 AM · Growth-Structured-Tasks, Growth-Team (Current Sprint), Add-Link
RHo claimed T267632: Add a link: Conduct a 2nd round of user testing on the revised *Desktop* designs for "Add a link" (testing sentence highlighting around a link).
Tue, Nov 10, 11:26 AM · Growth-Structured-Tasks, Growth-Team (Current Sprint), Add-Link
RHo moved T267632: Add a link: Conduct a 2nd round of user testing on the revised *Desktop* designs for "Add a link" (testing sentence highlighting around a link) from Incoming to Needs Design/Design Doing on the Growth-Team (Current Sprint) board.
Tue, Nov 10, 11:26 AM · Growth-Structured-Tasks, Growth-Team (Current Sprint), Add-Link
RHo added a subtask for T259822: Add a link: Design V1 of the structured tasks add links workflow : T267632: Add a link: Conduct a 2nd round of user testing on the revised *Desktop* designs for "Add a link" (testing sentence highlighting around a link).
Tue, Nov 10, 11:26 AM · Growth-Team (Current Sprint), Growth Design, Growth-Structured-Tasks
RHo added a parent task for T267632: Add a link: Conduct a 2nd round of user testing on the revised *Desktop* designs for "Add a link" (testing sentence highlighting around a link): T259822: Add a link: Design V1 of the structured tasks add links workflow .
Tue, Nov 10, 11:26 AM · Growth-Structured-Tasks, Growth-Team (Current Sprint), Add-Link
RHo edited projects for T267632: Add a link: Conduct a 2nd round of user testing on the revised *Desktop* designs for "Add a link" (testing sentence highlighting around a link), added: Growth-Team (Current Sprint), Growth-Structured-Tasks; removed Growth-Team.
Tue, Nov 10, 11:25 AM · Growth-Structured-Tasks, Growth-Team (Current Sprint), Add-Link
RHo created T267632: Add a link: Conduct a 2nd round of user testing on the revised *Desktop* designs for "Add a link" (testing sentence highlighting around a link).
Tue, Nov 10, 10:36 AM · Growth-Structured-Tasks, Growth-Team (Current Sprint), Add-Link

Mon, Nov 9

RHo moved T263040: [leftovers] Newcomer tasks: show skeleton of filter and article card UI elements *on load* from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Thanks all! Now that there is no more 'jumpiness' with the skeleton in place this looks good to me.

Mon, Nov 9, 10:12 PM · MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks Future Release , Growth-Team-Leftovers
RHo moved T258017: Variant D: difficulty overlay in onboarding from Design Review to Needs More Work on the Growth-Team (Current Sprint) board.

Checked again and only part of item (g) – the vertical alignment of the text to icon is not quite right.

Mon, Nov 9, 10:09 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Growth-Team (Current Sprint), GrowthExperiments
RHo moved T258016: Variant C: onboarding from Design Review to Needs More Work on the Growth-Team (Current Sprint) board.

Check once more and only 1 of the issues is not quite fixed.

Expected descriptionActual
Bottom padding in the desktop module intro area should only be 24px (not 35px) - and should include the bottom of the graphic
Mobile Image should only be 64x64px
The title is vertically centered with the graphic, the topic message text should be below the title and graphic.
{F33890525}Title is not quite vertically centered (I think this is caused by the margin-bottom:0.5em on the class .mw-ge-startediting-dialog-intro-topic-title
Level icon and text should be vertically centered
Mon, Nov 9, 9:52 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
RHo updated the task description for T267569: [BUG] [Visual] Newcomer tasks: Intro text in pre-initiated task should not wrap around the illustration..
Mon, Nov 9, 9:37 PM · Growth-Team, Growth-Team-Leftovers, GrowthExperiments-NewcomerTasks
RHo moved T265531: Add a link: Conduct user testing on the Desktop version of the updated "Add a link" design from Needs Design/Design Doing to Needs PM Review on the Growth-Team (Current Sprint) board.

Updated with results summary and link to deck.

Mon, Nov 9, 8:41 PM · Add-Link, Growth-Team (Current Sprint), Growth Design, Growth-Structured-Tasks
RHo updated the task description for T265531: Add a link: Conduct user testing on the Desktop version of the updated "Add a link" design.
Mon, Nov 9, 6:20 PM · Add-Link, Growth-Team (Current Sprint), Growth Design, Growth-Structured-Tasks
RHo moved T265538: Add a link: Conduct a 2nd round of user testing on the revised mobile design for "Add a link" from Needs Design/Design Doing to Needs PM Review on the Growth-Team (Current Sprint) board.

See updated description with top-line results.

Mon, Nov 9, 6:10 PM · Add-Link, Growth-Team (Current Sprint), Growth Design, Growth-Structured-Tasks
RHo updated the task description for T265538: Add a link: Conduct a 2nd round of user testing on the revised mobile design for "Add a link".
Mon, Nov 9, 6:10 PM · Add-Link, Growth-Team (Current Sprint), Growth Design, Growth-Structured-Tasks
RHo updated the task description for T265538: Add a link: Conduct a 2nd round of user testing on the revised mobile design for "Add a link".
Mon, Nov 9, 5:56 PM · Add-Link, Growth-Team (Current Sprint), Growth Design, Growth-Structured-Tasks
RHo created T267574: [BUG][Regression] Font size of the # tasks article footer text is larger than expected (mobile and desktop).
Mon, Nov 9, 4:08 PM · GrowthExperiments-NewcomerTasks, Growth-Team, Growth-Team-Leftovers
RHo moved T258019: Variant D (desktop): embed onboarding dialog into suggested edits module from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Thanks everyone, this looks much better! I am still seeing an issue with the intro text wrapping below the illustration though which I have filed as T267569.

Mon, Nov 9, 3:38 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
RHo created T267569: [BUG] [Visual] Newcomer tasks: Intro text in pre-initiated task should not wrap around the illustration..
Mon, Nov 9, 3:36 PM · Growth-Team, Growth-Team-Leftovers, GrowthExperiments-NewcomerTasks

Nov 4 2020

RHo added a comment to T236738: Newcomer tasks: server-side rendered version of suggested edits module.

Test wiki created on Patch Demo by KHarlan (WMF) using patch(es) linked to this task:

http://patchdemo.wmflabs.org/wikis/0f28ca3e302c5a3ddd0990e2fbb6e726/w/

This looks good on mobile and desktop (see https://imgur.com/a/lkYAxu5), however, one weird thing is that on Desktop the 1st suggestion's image takes a long time to load – in the Desktop example, "Danny Ferry" was taking so long (on 3G speed but still), that I stopped recording, but does definitely have an image. Another strange thing is that when I went to the second and third articles suggested, the images on those articles loaded but when going back to the first article the Danny Ferry image still had not finished loading.

That is probably from a network request timing out, it shouldn't be a side effect of anything introduced in this patch. This patch doesn't attempt any image rendering (since we don't know the image source yet), and once the client-side JavaScript knows the thumbnail to use, it will update the image placeholder. If the request to fetch the thumbnail fails, we don't currently attempt to retry.

Ah OK, but to clarify, the first image does eventually load, it just takes ages. Is that possible if the network request times out – does it just run do it again until the image is fetched?

Sorry I missed this comment @RHo . If it does eventually load, then that is just a slow network request. We don't 'have code to retry on failures as far as I recall. Have you seen also this in production or just in beta/patchdemo land?

Nov 4 2020, 10:56 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Growth-Team (Current Sprint), Growth-Team-Leftovers, NewcomerTasks 1.0
RHo awarded Blog Post: Exempla Docent - testing ORES 'articletopic' model a Manufacturing Defect? token.
Nov 4 2020, 9:27 AM

Oct 29 2020

RHo moved T264462: [Leftovers] Newcomer homepage: Visual design improvements to the homepage layout on Desktop from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Thanks all - in my biased opinion this works a lot better!

Oct 29 2020, 4:15 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Growth-Team-Leftovers, Growth-Team (Current Sprint), GrowthExperiments
RHo moved T264636: [Leftovers] Newcomer homepage: Visual design improvements to the Suggested edits module on Desktop from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Beautiful *chef's kiss*. Thanks all!

Oct 29 2020, 2:33 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth Design, Growth-Team-Leftovers, Growth-Team (Current Sprint), GrowthExperiments
RHo moved T263040: [leftovers] Newcomer tasks: show skeleton of filter and article card UI elements *on load* from Design Review to Needs More Work on the Growth-Team (Current Sprint) board.

For Design review - I marked with green exclamation points the specs that I think I did not see implemented (see my notes on those specs below).
The animated gif illustrates what happens immediately after clicking the submit button on the last intro overlay.
My notes:

  • rendering happens really fast
  • the only actual issue - there is kind of pre-initial title load when an article title will appear (and it will be changed to another article title when the card load is completed).
  • the card does shift a little bit

(click on the animated gif)

Thanks @Etonkovidova, for capturing this and I can see the slight "pre-initial" is causing the shift because the card, task pager, and task explanation skeleton is still not being shown on load. @kostajh can the space occupied by the pager, card and task explanation be incorporated into the pre-loaded state of the module so this jolt doesn't occur at all? Parts 5 and 6 of this task can also be considered ameliorated if the module can just be loaded without any shifting positions.

Oct 29 2020, 2:27 PM · MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks Future Release , Growth-Team-Leftovers

Oct 27 2020

RHo added a comment to T263511: [Language switcher] Determine placement of indicators, coordinates, help icon, etc..

hi @alexhollender - posting a comment for posterity based on a conversation we had about this today:
I agree with @ovasileva that moving the the icons to the right regardless of whether there is a tagline or not is good in terms of decoupling the decision about removing the tagline. A second benefit would also be the simplicity of always having the icons in the same position regardless of tag or no tagline (as I understand it, originally the idea was if the tagline stays, then wikis without tagline would have the icons on the opposite of the article title).

Oct 27 2020, 6:24 PM · Desktop Improvements, Readers-Web-Backlog (Design)

Oct 22 2020

RHo added a comment to T263040: [leftovers] Newcomer tasks: show skeleton of filter and article card UI elements *on load*.

What is implemented in the patch for this task is a little bit different than what the description says, because in the meantime we've done T236738: Newcomer tasks: server-side rendered version of suggested edits module. So, we can render all components of the suggested edits module on the server-side, but we add the skeleton styling for:

  • Article wikidata description
  • Article image
  • Pageview info

Given the above, maybe it makes sense to close this task in favor of T236738: Newcomer tasks: server-side rendered version of suggested edits module.

Agree that the new loading is much better when testing the patchdemo from T236738#6571595 here: https://imgur.com/a/lkYAxu5, most importantly that all elements in the task module are in place so there is no jarring shifting position.
However, one minor visual note is that the page views skeleton should be amended to the same length as the article description placeholder:

Ah, I think we forgot to update the width after the article card was adjusted in another task.

With updated patch:

Oct 22 2020, 5:29 PM · MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks Future Release , Growth-Team-Leftovers
RHo added a comment to T236738: Newcomer tasks: server-side rendered version of suggested edits module.

Test wiki created on Patch Demo by KHarlan (WMF) using patch(es) linked to this task:

http://patchdemo.wmflabs.org/wikis/0f28ca3e302c5a3ddd0990e2fbb6e726/w/

This looks good on mobile and desktop (see https://imgur.com/a/lkYAxu5), however, one weird thing is that on Desktop the 1st suggestion's image takes a long time to load – in the Desktop example, "Danny Ferry" was taking so long (on 3G speed but still), that I stopped recording, but does definitely have an image. Another strange thing is that when I went to the second and third articles suggested, the images on those articles loaded but when going back to the first article the Danny Ferry image still had not finished loading.

That is probably from a network request timing out, it shouldn't be a side effect of anything introduced in this patch. This patch doesn't attempt any image rendering (since we don't know the image source yet), and once the client-side JavaScript knows the thumbnail to use, it will update the image placeholder. If the request to fetch the thumbnail fails, we don't currently attempt to retry.

Oct 22 2020, 3:54 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Growth-Team (Current Sprint), Growth-Team-Leftovers, NewcomerTasks 1.0
RHo added a comment to T236738: Newcomer tasks: server-side rendered version of suggested edits module.

Test wiki created on Patch Demo by KHarlan (WMF) using patch(es) linked to this task:

http://patchdemo.wmflabs.org/wikis/0f28ca3e302c5a3ddd0990e2fbb6e726/w/

Oct 22 2020, 3:00 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Growth-Team (Current Sprint), Growth-Team-Leftovers, NewcomerTasks 1.0
RHo added a comment to T263040: [leftovers] Newcomer tasks: show skeleton of filter and article card UI elements *on load*.

What is implemented in the patch for this task is a little bit different than what the description says, because in the meantime we've done T236738: Newcomer tasks: server-side rendered version of suggested edits module. So, we can render all components of the suggested edits module on the server-side, but we add the skeleton styling for:

  • Article wikidata description
  • Article image
  • Pageview info
Oct 22 2020, 2:58 PM · MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks Future Release , Growth-Team-Leftovers
RHo moved T258021: Variant C/D: mobile preview for suggested edits module with first suggested edit from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Great, thanks @Etonkovidova. Double checked the behaviour when changing the filters on the SE module is correctly updating the article on the preview, and style tweaks also look good so over to PM review now.

Oct 22 2020, 12:31 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments

Oct 21 2020

RHo added a project to T265531: Add a link: Conduct user testing on the Desktop version of the updated "Add a link" design: Add-Link.
Oct 21 2020, 10:00 AM · Add-Link, Growth-Team (Current Sprint), Growth Design, Growth-Structured-Tasks
RHo added a project to T265538: Add a link: Conduct a 2nd round of user testing on the revised mobile design for "Add a link": Add-Link.
Oct 21 2020, 9:19 AM · Add-Link, Growth-Team (Current Sprint), Growth Design, Growth-Structured-Tasks

Oct 19 2020

RHo added a comment to T261448: Newcomer tasks: suggested edits module linebreaks.

Thanks for catching this @Etonkovidova, can we move the icon span to be nested under the task text so that it always wraps with the last word? I think this is what we did with the user avatar icon and user name in the welcome banners.

Not easily (unless I've missed something) because of HTML + JS needed to render the popup on click/hover over the icon.

A very easy fix is to swap the icon / label order:

That would also have the benefit of being consistent with how PopupButtonWidgets are rendered elsewhere in MediaWiki when configured with icon + visible label text (icon first, then label).

Oct 19 2020, 10:50 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Growth-Team (Current Sprint), Growth Design, I18n, Design, Russian-Sites
RHo added a comment to T258016: Variant C: onboarding.

Looking at var C only per this task, some items still to be fixed (or were maybe reverted at some point?):

All these screenshots are from variant A though (as you can tell by the presence of the start module in the background, and the topic filters below the intro section.

Sorry, I was going off of the screenshots from T258016#6544922 as var C. Incidentally it looks like the console commands to change the variant and initiated state are no longer working for me.

Oct 19 2020, 10:12 AM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
RHo moved T261448: Newcomer tasks: suggested edits module linebreaks from Design Review to Needs More Work on the Growth-Team (Current Sprint) board.

Thanks for catching this @Etonkovidova, can we move the icon span to be nested under the task text so that it always wraps with the last word? I think this is what we did with the user avatar icon and user name in the welcome banners.

Oct 19 2020, 8:51 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Growth-Team (Current Sprint), Growth Design, I18n, Design, Russian-Sites

Oct 16 2020

RHo updated the task description for T265538: Add a link: Conduct a 2nd round of user testing on the revised mobile design for "Add a link".
Oct 16 2020, 6:10 PM · Add-Link, Growth-Team (Current Sprint), Growth Design, Growth-Structured-Tasks

Oct 15 2020

RHo added a comment to T264636: [Leftovers] Newcomer homepage: Visual design improvements to the Suggested edits module on Desktop.

Change 634138 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits: Change image size, styling tweaks

https://gerrit.wikimedia.org/r/634138

This patch fixes issue A, with the following caveats:

(i) Update the card image dimensions to width:332px and height:188px (for close to the 16:9 aspect ratio)
(ii) This also means updating the total card width according, done by adjusting the class .suggested-edits-task-card-wrapper to have a width:332px.

Done, on desktop. But what should happen on mobile? Currently mobile uses 260x128 for the image dimensions, should that change to something else?

No, we are keeping mobile as is (since we haven't made the same layout changes to mobile where there is just the SE module).

(iii) The task explanation below the card also requires adjusting the class .suggested-edits-task-explanation-wrapper to have width:316px;

That's not what I see currently: task-explanation-wrapper has the same width as task-card-wrapper, and because it uses the same LESS variable, changing the image dimensions caused it to automatically adjust its width to 332px to match. For consistency, I'm going with that for now, unless you explicitly say that you want these widths to be different.

The important thing for me is that the text in the explanation wrapper aligns with the title and extract text in the article card, but we can achieve this by adding left and right padding instead of changing the width if that is better? I've updated the description to do this instead.

Oct 15 2020, 9:42 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth Design, Growth-Team-Leftovers, Growth-Team (Current Sprint), GrowthExperiments
RHo updated the task description for T264636: [Leftovers] Newcomer homepage: Visual design improvements to the Suggested edits module on Desktop.
Oct 15 2020, 9:39 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth Design, Growth-Team-Leftovers, Growth-Team (Current Sprint), GrowthExperiments
RHo moved T258016: Variant C: onboarding from Design Review to Needs More Work on the Growth-Team (Current Sprint) board.

Looking at var C only per this task, some items still to be fixed (or were maybe reverted at some point?):

Oct 15 2020, 9:29 AM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
RHo moved T265422: Help panel does not show progress indicator when posting a question from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Great, thanks for spotting this!

Oct 15 2020, 8:54 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth-Team (Current Sprint), GrowthExperiments-Help panel
RHo moved T258008: Variant C/D: smaller start module from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Thanks all, LGTM!

(1)

  • Icon larger than expected (should be 20x20px)

It was 20x20 on desktop, and larger on mobile proportional to the base font size. I've fixed it to be 20x20 on both.

Desktopoverall look
Mobileoverall look

(2)

  • Font-size is larger than expected – it's expected that this should use the OOUI 'tag' font style for smaller UI text, which on Desktop is font-size:13px, and on Mobile is font-size:14.8px

Fixed. It looks small though.

Note: It does look small, but it seems to be passing the accessibility test.

DesktopMobile
Oct 15 2020, 8:53 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments

Oct 14 2020

RHo added a project to T265542: Revise UI copy on all Growth Newcomer homepage and help panel features: NewcomerTasks Future Release .
Oct 14 2020, 8:26 PM · Growth-Team (Current Sprint), NewcomerTasks Future Release , Growth Design
RHo created T265542: Revise UI copy on all Growth Newcomer homepage and help panel features.
Oct 14 2020, 8:26 PM · Growth-Team (Current Sprint), NewcomerTasks Future Release , Growth Design
RHo moved T265538: Add a link: Conduct a 2nd round of user testing on the revised mobile design for "Add a link" from Incoming to Needs Design/Design Doing on the Growth-Team (Current Sprint) board.
Oct 14 2020, 7:53 PM · Add-Link, Growth-Team (Current Sprint), Growth Design, Growth-Structured-Tasks
RHo moved T265538: Add a link: Conduct a 2nd round of user testing on the revised mobile design for "Add a link" from 📗Backlog (Current sprint) to 💪In Progress on the Growth Design board.
Oct 14 2020, 7:53 PM · Add-Link, Growth-Team (Current Sprint), Growth Design, Growth-Structured-Tasks
RHo created T265538: Add a link: Conduct a 2nd round of user testing on the revised mobile design for "Add a link".
Oct 14 2020, 7:53 PM · Add-Link, Growth-Team (Current Sprint), Growth Design, Growth-Structured-Tasks
RHo moved T265531: Add a link: Conduct user testing on the Desktop version of the updated "Add a link" design from Incoming to Needs Design/Design Doing on the Growth-Team (Current Sprint) board.
Oct 14 2020, 7:41 PM · Add-Link, Growth-Team (Current Sprint), Growth Design, Growth-Structured-Tasks
RHo moved T265531: Add a link: Conduct user testing on the Desktop version of the updated "Add a link" design from 📗Backlog (Current sprint) to 💪In Progress on the Growth Design board.
Oct 14 2020, 7:41 PM · Add-Link, Growth-Team (Current Sprint), Growth Design, Growth-Structured-Tasks
RHo created T265531: Add a link: Conduct user testing on the Desktop version of the updated "Add a link" design.
Oct 14 2020, 7:40 PM · Add-Link, Growth-Team (Current Sprint), Growth Design, Growth-Structured-Tasks
RHo moved T253043: Newcomer tasks: Conduct usability testing of released guidance feature in local languages from Needs PM Review to Needs Design/Design Doing on the Growth-Team (Current Sprint) board.

Updated the wrong task – moved this back to TODO and added test result findings to T260534

Oct 14 2020, 7:30 PM · Growth Design, NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo updated the task description for T253043: Newcomer tasks: Conduct usability testing of released guidance feature in local languages.
Oct 14 2020, 7:29 PM · Growth Design, NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo renamed T260534: Structured tasks: Conduct user testing to compare two approaches to the Add links structured task from Structured tasks: Write user testing brief to compare two approaches to the Add links structured task to Structured tasks: Conduct user testing to compare two approaches to the Add links structured task.
Oct 14 2020, 7:29 PM · Growth Design, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo updated the task description for T260534: Structured tasks: Conduct user testing to compare two approaches to the Add links structured task.
Oct 14 2020, 7:28 PM · Growth Design, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo added a comment to T258020: Variant C: Info icon in suggested edits module.

hi @Etonkividova - I am testing on CS Betalabs today (12-Oct) and on my Pixel 4 device it looks fine, but on the web browser I am consistently getting the incorrect icon placement on Mobile:

Inspector showing icon cut-off
vs Left icon with inspector

Would you mind re-testing to see if you can reproduce? If not please move on to PM Review.

Yes, I saw the issue consistently when I was testing - did not report it since it was only in mobile browser emulator. The real device - iPhone 6s - did no display the issue. I checked again - the issue is present in Chrome and FF mobile browser emulators. Mobile emulator incorrectly display the info icon for all popular viewport widths (360-414).


@RHo If you saw it on a real device - it's a real issue. Can you please file it with specific detail about device/OS etc. ?

Thanks for checking again, I only saw this on the emulator, it looks fine in my Android device.

Also, I filed T265427: [mobile] variant C - make transition between overlays smoother.

Thank you! I left a comment on the task.

Oct 14 2020, 9:00 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
RHo added a comment to T265427: [mobile] variant C - make transition between overlays smoother.

Oh yeah, that's not great. @MMiller_WMF -can we squeeze this into the 'interlude' work?

Oct 14 2020, 8:58 AM · Growth-Team, GrowthExperiments-NewcomerTasks, GrowthExperiments-Homepage

Oct 13 2020

RHo added a comment to T265262: [BUG][Regression] Newcomer tasks: Blue pulsing dot on the tasks topics filters is no longer centered as expected.

This was implemented with right: 10% per T238611#5789718 and T238611#5790124, but I will make a patch to center it on desktop.

Oct 13 2020, 1:52 PM · Growth-Team (Current Sprint)

Oct 12 2020

RHo added a comment to T261448: Newcomer tasks: suggested edits module linebreaks.

Reviewed from patch:

Oct 12 2020, 7:25 PM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Growth-Team (Current Sprint), Growth Design, I18n, Design, Russian-Sites
RHo added a comment to T258016: Variant C: onboarding.

Left and right padding is fixed per patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/633186

Var CDesktop step 1
step 2
Mobile step 1
Mobile step 2
Var DDesktop step 1
step 2
Mobile step 1
Mobile step 2
Oct 12 2020, 6:26 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
RHo moved T258704: Variant C/D: homepage Suggested edits module changes - Desktop from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Thanks! Moving to PM review as the other items are covered in T264636

Oct 12 2020, 10:19 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
RHo moved T258020: Variant C: Info icon in suggested edits module from Design Review to QA on the Growth-Team (Current Sprint) board.
Oct 12 2020, 10:11 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
RHo moved T258019: Variant D (desktop): embed onboarding dialog into suggested edits module from Design Review to Needs More Work on the Growth-Team (Current Sprint) board.

Hi, moving back as a couple of padding issues remain on Desktop:

Oct 12 2020, 10:11 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
RHo added a comment to T258020: Variant C: Info icon in suggested edits module.

hi @Etonkividova - I am testing on CS Betalabs today (12-Oct) and on my Pixel 4 device it looks fine, but on the web browser I am consistently getting the incorrect icon placement on Mobile:

Inspector showing icon cut-off
vs Left icon with inspector
Oct 12 2020, 9:49 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
RHo moved T258005: Variant C/D: homepage layout changes from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Thanks @Etonkovidova - I filed a bug task for the blue dot (T265262). As for the other issues, I believe they are resolved by variant A being switched off, and by the layout leftovers task T264462

Oct 12 2020, 9:37 AM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
RHo renamed T265262: [BUG][Regression] Newcomer tasks: Blue pulsing dot on the tasks topics filters is no longer centered as expected from [BUG][Regression] Newcomer tasks to [BUG][Regression] Newcomer tasks: Blue pulsing dot on the tasks topics filters is no longer centered as expected.
Oct 12 2020, 9:33 AM · Growth-Team (Current Sprint)
RHo created T265262: [BUG][Regression] Newcomer tasks: Blue pulsing dot on the tasks topics filters is no longer centered as expected.
Oct 12 2020, 9:30 AM · Growth-Team (Current Sprint)

Oct 8 2020

RHo renamed T238279: Newcomer tasks: arrows are different distances from card on Mobile from Newcomer tasks: arrows are different distances from card to Newcomer tasks: arrows are different distances from card on Mobile.
Oct 8 2020, 5:30 PM · Growth-Team, MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), User-PPham, NewcomerTasks 1.0 , GrowthExperiments-Homepage
RHo added a comment to T238279: Newcomer tasks: arrows are different distances from card on Mobile.

@RHo -- do we still have this issue? If not, please resolve.

Oct 8 2020, 5:29 PM · Growth-Team, MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), User-PPham, NewcomerTasks 1.0 , GrowthExperiments-Homepage

Oct 7 2020

RHo added a comment to T258016: Variant C: onboarding.
  • The body text ("Wikipedia is built by..." and "Use topics to get...") should be small font size than the headers. It should use the 14.8px size that is from the style OOUI Mobile/Smaller UI text/Inline-help.

What we have now is that the headers ("Suggested edits to get started", "Filter by topic") are a larger font size (18.28px) and the body texts are the base font size (16px). I think we might have done that as part of your big font size overhaul. Is that OK, or should the body text still be 14.8px for a larger font size difference?

You're right, the body text for this is now 16px on Mobile after the font style overhaul.

Oct 7 2020, 9:00 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
RHo updated the task description for T264636: [Leftovers] Newcomer homepage: Visual design improvements to the Suggested edits module on Desktop.
Oct 7 2020, 3:50 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth Design, Growth-Team-Leftovers, Growth-Team (Current Sprint), GrowthExperiments
RHo added a comment to T264831: Variant tests: C vs. D analysis.

hi @MMiller_WMF - are we also able to track the following:

  • Interactions with onboarding and 'i" info help screens on var C vs var D – wondering if for example var D users tend to select more topics and task types because it is part of the onboarding?
  • Breakdown of different task types selected – again, to see if the awareness of filtering by task types (and therefore attempts at a greater variety of tasks) on var D might be higher due to it being more prominently part of onboarding?
Oct 7 2020, 1:52 PM · Growth-Team (Current Sprint), Product-Analytics (Kanban), GrowthExperiments
RHo updated the task description for T264636: [Leftovers] Newcomer homepage: Visual design improvements to the Suggested edits module on Desktop.
Oct 7 2020, 1:06 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth Design, Growth-Team-Leftovers, Growth-Team (Current Sprint), GrowthExperiments

Oct 6 2020

RHo moved T258020: Variant C: Info icon in suggested edits module from Design Review to Needs More Work on the Growth-Team (Current Sprint) board.
Oct 6 2020, 10:31 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
RHo added a comment to T258020: Variant C: Info icon in suggested edits module.

Also, it looks as thought the mobile info icon should be further to the RHS of the dialog header than the mock (should be the same distance as the "<" chevron from the LHS edge of the header. )

@RHo The default right margin for an OOUI icon as the action in a MobileFrontend overlay is 1em, see T218731: Regression: Mark all as read button in notifications overlay larger than header where this was introduced for the "mark all as read" icon used by Echo. We can override this and unset the margin but it will be inconsistent with the margin users see in the Echo overlay dialog:

Hi, I agree this is right for the mark all as read button on, but this is in a button, our "i" info icon should be like the frameless "X" icon on the LHS and be flush 1em (=16px) from the edge of the screen, as it is on the mobile header:

Oct 6 2020, 10:31 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
RHo updated the task description for T258704: Variant C/D: homepage Suggested edits module changes - Desktop.
Oct 6 2020, 10:26 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
RHo added a comment to T258704: Variant C/D: homepage Suggested edits module changes - Desktop.

Hi @Etonkovidova and @kostajh - I've just rechecked the Beta and the E and G are done in terms of the border removed from SE and footer made flush to the bottom of the SE module.
However, see my comment about the missing border around the help module:

[..]

Yes, this is still not completed. Also, perhaps relatedly, the idea is that the Suggested edits and start module on desktop doesn't have the border, but the other modules do. Sorry if this was an oversight on my part but can we remove the border from SE and add to the help module? Thanks!

Oct 6 2020, 10:26 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
RHo updated the task description for T264636: [Leftovers] Newcomer homepage: Visual design improvements to the Suggested edits module on Desktop.
Oct 6 2020, 10:18 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth Design, Growth-Team-Leftovers, Growth-Team (Current Sprint), GrowthExperiments
RHo updated the task description for T264636: [Leftovers] Newcomer homepage: Visual design improvements to the Suggested edits module on Desktop.
Oct 6 2020, 10:17 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Growth Design, Growth-Team-Leftovers, Growth-Team (Current Sprint), GrowthExperiments