LGTM on Nexus 5 (6.0.1) on Wikipedia v2.7.232-alpha-2018-04-23. Moving back to QA for testing on a few more devices.
Per planning mtg - let's test whether this is still the case and fix or close accordingly.
Sun, Apr 22
\o/ thanks! i had a sudden *ack* moment of a Sunday arvo...
Hey @Dbrant - actually was wondering if this task was pushed with sync release ?
Hi @Dbrant - just wondering if this got pushed with the sync release?
Fri, Apr 20
hey @cooltey - that's weird, maybe try again one more time?
Please refresh the prototype and try again, should be working properly now! But yes, your description is how it is meant to work right now (clicking on "Wikipedia languages" in Settings takes the user to the "Wikipedia languages" page)
Hi @cooltey - the next screen should be the Wikipedia languages screen as per the steps in the task description. Let me take a look perhaps the click target Invision is messed up. You can see the numbered steps in the Zeplin though
@cooltey - rearranging language order (step 3 screens) and deleting all languages (step 4 screens) are independent of Adding a language.
Thu, Apr 19
hi @cooltey - in the similar way that suggested languages list are de-duplicated, anything that is already an app language should not be shown in the Suggested languages section.
If there are no Suggested languages, then the entire list including the section header should be hidden.
nice one, thanks!
hey @Dbrant - is there any chance this could be included in Hot Pepper?
hi @Dbrant - that's a good catch, the separator lines starting from the article title was missed in the initial implementation. And yes, this display is for the footer menu list items only (basically applying this for when list items are on a full width card).
that's a good point @ABorbaWMF but think we are fine to not show since the icon is being used when we send users to an external browser link in menu items, which is useful for example when the user may be offline, as it helps save opening a no connection page. Users can be offline and tapping on the map icon will still open properly in the Maps app with the geocoordinates.
LGTM on Pixel 2 (8.1) v2.7.231-alpha-2018-04-12. Moving to QA to check on a few more devices
hi @cooltey - thanks for putting through the earlier tweaks, which are resolved now. However, just picked up a couple of minor things:
hey @Sharvaniharan - just missed the update on the third row of the table in the task description:
thanks for checking @ABorbaWMF - think the different messaging still works!
Wed, Apr 18
hi @Sharvaniharan - the two options to 'Sort by date created' by newest and oldest still needs to be swapped around – the newest created item is showing still last when 'sort by date created (newest)' is selected:
thanks @cmadeo ! Just put in my votes with emoji (leaving rows with only one option empty).
Tue, Apr 17
hi @bearND – the thinking is that in the case of the user changing or adding a new app language, the "Customize the feed" UI is able to show which correct cards available for that language. However, I defer to @Fjalapeno @Dbrant to comment on whether the alternative you've proposed could be the way to go.
@Dbrant - just updated the task description, please revise if any of it is goobledegook.
Just updated the name in Play store across all languages for which translations exist (removing 'mobile'), should show as updated in a day.