@MMiller_WMF - This seems OK to me since we will have the message about switching.
Looks good to me too
@MMiller_WMF - should we still keep T255389 open for future-proofing (if theres ever a task with 9 steps or more)?
hi @Tgr - I just noticed another minor thing missed in the update that was in the mocks but not specifically called out, which is that the panel header should be text left-aligned (for LTR languages) in this new design.
This is especially noticeable on the root screen as being a bit funky when using centre-aligned:
I also agree the behaviour right now is reasonable enough to move along.
Sorry this should actually be the thumbcaption style which is used on image captions on articles:
|Desktop example||Mobile version|
Tue, Jun 30
hi @Catrope - I've just added the animation details in the task description. Happy to separate out into a different subtask if you prefer.
Jotting down my understanding of the situation:
- Users of public shared components files are - WMF Designers, WMDE Designers, Unknown number of external public
- WMF Designers primarily currently use Sketch, whilst WMDE are pretty exclusively Figma folks
- Quality SVG exportability is important as final files to provide to FED, and presumed important for external folks (who may use free tools like Inkscape)
- Storybook integration is expected with future integration with the WVUI work.
There is currently no animation while closing the help panel.
Sorry @Catrope - let me add the animation for *both* opening and closing the panel shortly.
Mon, Jun 29
Thanks @Etonkovidova, moving to PM. Note for @MMiller_WMF the narrow case looks better since this was tested because the 360px width (T255719) will resolve the overflowing tabs, and the breaking difficulty label ribbon bug has also been fixed on T254524:
Thanks, double-checked on Desktop and Mobile and LGTM too.
Thu, Jun 25
Whilst most of the design review items from my comment T255254#623223 are fixed, I've just notice the close "x" button is still inconsistently place on the LHS of the root screen:
It is important that it is consistently in the same position in the header (always on the right hand side), esp. for mobile when it is covering the whole screen.
Wed, Jun 24
Yes, this is no longer valid since we got rid of this menu.
hi @MMiller_WMF - here's my first attempt at the updated copy, please update and prioritize as you see fit.
Tue, Jun 23
hi @PPham - would you mind confirming that you are still experiencing this bug, and providing the browser version where it is occurring? Also, to confirm: are you experiencing this in production version of Viwiki?
Mon, Jun 22
Thanks @kostajh - so the icon color would be using the same one as used in the inline warning message on OOUI, which is in color #fc3. If it helps, the direct link to the icon via the OOUI MessageWidget is alert-warning.svg (and here's the fallback PNG)
Fri, Jun 19
Moving back due as I noticed the following issues related to the addition of the the links in the root screen:
Thu, Jun 18
The function seems fine but there are a few design issues to be sorted. Given the train has left the station, I've filed them as separate sub-tasks and moving this to PM review for closing out.
Thanks @Etonkovidova - I'm moving to PM review and opening a few new tasks per your review.
This is indeed not up even AA compliant contrast, which appears to be due to an additional opacity:0.5 added on top of the expected `opacity: .87' on the #000 icon. Filed T255773
Yes, this should be addressed as part of T254527
Moving to PM review, and will also update the business rules on the parent task T245790 to reflect this change.
Wed, Jun 17
Hi @Tgr, can the panel height be reverted back to 528px? I think it's fine if there is some scrolling on the root screen sometimes rather than having the taller panel all the time.
Hi @kostajh - I noticed the task difficulty text hits the bottom of the header when the task type text goes over 2-3 lines:
Thanks @Etonkovidova - moving to PM review as I think your observation (1) makes sense but can be addressed separately as a new improvement to the guidence content and (2) is fine since the icons are more illustrative in that context.
- Defer to @MMiller_WMF - I'm 50/50 on whether adding the link is too detailed for this "quick tip", even though I agree it is an important concept that is not so clear. If we did want create a new task to add in this link, may I suggest also reviewing whether it also makes sense to link out to pages to better explain references to reliable/verifiable and Encyclopedic content?
Thanks @Etonkovidova - I can't replicate the double-scrollbar that is occurring in your second screenshot from my Chrome browser so wonder if it browser dependent? In any case, think this is minor enough (certain subset of browsers, only if the browser window height is <724px ) when this would occur that IMHO we can call it a pass.
Mon, Jun 15
@MMiller_WMF @Tgr - agree this is expected behaviour. However, maybe we can make the CTA "View more suggested edits" text say "Return to homepage" instead to more accurately convey the result of the action.
Perhaps having the word "more" in "View more suggested edits" without showing a suggested edit above it is causing confusion as well.
@MMiller_WMF - since this is an edge case, I think we should push for the same behaviour to occur as the minerva-tabs whereby tab that is over the width to result horizontal scroll like in the mobile site:
|Current prod mobile tabs|
|Use for proposed short term fix|
Yes, adding the close button to be accessible on the Get help with editing page reverts back to the previous interaction before suggested edits was added as a sub-screen option.
The bigger change to exposing the more links on the root screen means users are more likely to notice the ability to turn off help from the root screen, but this is balanced out by the options no longer being "globally accessible" on the ".." menu.
Moving back to fix so that all drop downs from the VE toolbar appear above the panel. See another example where the Bullet list is almost entirely obscured behind the help panel.
Fri, Jun 12
Hi @Etonkovidova - do you mean the scrollbar being visible? I think that is fine as it depends on the browser.
However, is the visual bug in the mp4 where there is a white background shown above and below the "Suggested edits" header still occurring on the iPhone?
If so, it should be logged as a separate bug please.
Links appear or do not appear as expected from design perspective depending on the existence of the links to additional information.
hi @MMiller_WMF - I've created some different visual treatments for the nudge to VE notice on the task description for discussion and decisions.
My preference is for visual treatment C as it is more likely to be noticed by the user than being in the footer, and it is also hierarchically makes more sense as a warning shown above the tips.
@MMiller_WMF - I created a sub-task T255074 for the proposal to add a notice to nudge users back to using VE, assuming this task will be to proceed with the short term solution to switch to VE by default across browsers.
Closing as this is no longer an issue.
|CS Betalabs||CS Prod|
Thu, Jun 11