Page MenuHomePhabricator

RHo (Rita Ho)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Mar 23 2016, 6:05 PM (223 w, 23 h)
Availability
Available
LDAP User
Unknown
MediaWiki User
RHo (WMF) [ Global Accounts ]

Recent Activity

Today

RHo added a comment to T255514: Newcomer tasks: switch to visual editor (desktop).

To summarize for @RHo :and @MMiller_WMF review:

  • there are four options for Editing mode in Special:Preferences and one stand-alone option (the issues for some options are summarized below in the table)
  • wikis might be two-tabs or single-tab wikis - which does not affect switching to VE specifically.
Editing options SE guidance panel link effect
Remember my last editor (seems to be a default option)does not interfere with the editing workflow but shows the pulsing dot on "Edit source"

@MMiller_WMF - This seems OK to me since we will have the message about switching.

Thu, Jul 2, 11:01 AM · NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo created T256955: [BUG] Newcomer tasks: Post-edit dialog unexpectedly appearing after users edit the talk page of newcomer task article.
Thu, Jul 2, 10:50 AM · Growth-Team (Current Sprint), Patch-For-Review, NewcomerTasks 1.2
RHo moved T255719: Newcomer tasks: Make the help panel a fixed width on Desktop from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Looks good to me too


@MMiller_WMF - should we still keep T255389 open for future-proofing (if theres ever a task with 9 steps or more)?

Thu, Jul 2, 10:35 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo moved T254418: Newcomer tasks: align copy in headers and buttons in help panel from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

LGTM

Thu, Jul 2, 10:34 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T256925: Minimized help panel displayed when a page loads.

@RHo -- is this desired? Or a bug?

Thu, Jul 2, 10:31 AM · Growth-Team (Current Sprint), GrowthExperiments
RHo added a comment to T255254: Newcomer tasks: Fix back-then-close issue when using guidance with editing.

hi @Tgr - I just noticed another minor thing missed in the update that was in the mocks but not specifically called out, which is that the panel header should be text left-aligned (for LTR languages) in this new design.
This is especially noticeable on the root screen as being a bit funky when using centre-aligned:

Expected
Current Betalabs
Thu, Jul 2, 10:26 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Patch-For-Review, GrowthExperiments-Help panel, NewcomerTasks 1.2, Growth-Team (Current Sprint)

Yesterday

RHo moved T253009: Newcomer tasks: automatically advance tips from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

I also agree the behaviour right now is reasonable enough to move along.

Wed, Jul 1, 10:42 AM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T255819: Newcomer tasks: UI fixes to the Image thumbnail in the Post-edit dialog.

[ii] Image container size on Desktop should always be 88x88px, and on Mobile 72x72px. even when there is no image.

For the placeholder that's easy enough to fix (I forgot that flex can override the constant width). What should happen when there is an image, and it is not square? Should we make it fill the box (ie. smaller dimension of the image equals box size) and center it? Fit the box? Something else?

Wed, Jul 1, 10:33 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T255825: Newcomer tasks: UI fixes to the text elements on the Post-edit dialog.

@RHo do you have an example of the hatnote style somewhere else on the site? I want to check if it is something reusable.

Sorry this should actually be the thumbcaption style which is used on image captions on articles:

Desktop example
Mobile version
Wed, Jul 1, 10:23 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo updated the task description for T255825: Newcomer tasks: UI fixes to the text elements on the Post-edit dialog.
Wed, Jul 1, 10:19 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), NewcomerTasks 1.2, Growth-Team (Current Sprint)

Tue, Jun 30

RHo added a comment to T255255: Newcomer tasks: Enable easier toggling to open and close Desktop help panel.

hi @Catrope - I've just added the animation details in the task description. Happy to separate out into a different subtask if you prefer.

Tue, Jun 30, 8:39 PM · Patch-For-Review, GrowthExperiments-Help panel, NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo updated the task description for T255255: Newcomer tasks: Enable easier toggling to open and close Desktop help panel.
Tue, Jun 30, 8:38 PM · Patch-For-Review, GrowthExperiments-Help panel, NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T255522: Evaluate use of Figma for public components and patterns source files.

Jotting down my understanding of the situation:

  • Users of public shared components files are - WMF Designers, WMDE Designers, Unknown number of external public
  • WMF Designers primarily currently use Sketch, whilst WMDE are pretty exclusively Figma folks
  • Quality SVG exportability is important as final files to provide to FED, and presumed important for external folks (who may use free tools like Inkscape)
  • Storybook integration is expected with future integration with the WVUI work.
Tue, Jun 30, 5:44 PM · Wikimedia Design Style Guide
RHo updated the task description for T256754: Structured tasks: Positive reinforcements design research.
Tue, Jun 30, 5:40 PM · Growth Design, Growth-Structured-Tasks, Growth-Team (Current Sprint)
schoenbaechler awarded T256754: Structured tasks: Positive reinforcements design research a Barnstar token.
Tue, Jun 30, 2:35 PM · Growth Design, Growth-Structured-Tasks, Growth-Team (Current Sprint)
RHo moved T256754: Structured tasks: Positive reinforcements design research from 📗Backlog (Current sprint) to 💪In Progress on the Growth Design board.
Tue, Jun 30, 12:36 PM · Growth Design, Growth-Structured-Tasks, Growth-Team (Current Sprint)
RHo added a project to T256754: Structured tasks: Positive reinforcements design research: Growth Design.
Tue, Jun 30, 12:36 PM · Growth Design, Growth-Structured-Tasks, Growth-Team (Current Sprint)
RHo moved T256754: Structured tasks: Positive reinforcements design research from Incoming to Needs Design/Design Doing on the Growth-Team (Current Sprint) board.
Tue, Jun 30, 12:36 PM · Growth Design, Growth-Structured-Tasks, Growth-Team (Current Sprint)
RHo created T256754: Structured tasks: Positive reinforcements design research.
Tue, Jun 30, 12:36 PM · Growth Design, Growth-Structured-Tasks, Growth-Team (Current Sprint)
RHo added a comment to T255255: Newcomer tasks: Enable easier toggling to open and close Desktop help panel.

The attached patch implements 1-3, but not 4 (the animation part), because there's not enough information in the task about what the animation would be (and there are no links to mocks or specs or anything that would tell me).

[...]

There is currently no animation while closing the help panel.

Sorry @Catrope - let me add the animation for *both* opening and closing the panel shortly.

Tue, Jun 30, 12:25 PM · Patch-For-Review, GrowthExperiments-Help panel, NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T255719: Newcomer tasks: Make the help panel a fixed width on Desktop.

@RHo did you want to preserve the ability for the help panel to be wider on larger screens (500px) or should we remove that (now inactive) code?

Tue, Jun 30, 12:23 PM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T232410: Newcomer tasks: add language question to welcome survey.

@MMiller_WMF @RHo I'm assuming we want to reuse the UniversalLanguageSelector widget in terms of what the user experience is like when inputting the language name (i.e. you can type any one of "el", "Ελληνικά", or "Greek" to switch to Greek language). Then we would place user selections inside a TagMultiselectWidget with a fixed item for current wiki language. Sounds about right?

Tue, Jun 30, 12:18 PM · Growth-Team (Current Sprint), NewcomerTasks Future Release , GrowthExperiments-Homepage
RHo moved T254526: Newcomer tasks: Header font-size on Suggested Edits screen should use OOUI fieldset header style from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Thanks, LGTM

Tue, Jun 30, 11:59 AM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo updated subscribers of T255327: [Epic] Evaluate which editing interface should be shown by default.
Tue, Jun 30, 11:57 AM · Editing-team (Tracking), VisualEditor

Mon, Jun 29

RHo moved T254529: Newcomer tasks: UI enhancement - add a drop-shadow under the header and footer when guidance contents scroll from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

LGTM, thanks!

Mon, Jun 29, 12:03 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo moved T255850: [BUG] Double vertical scrollbar appearing on every guidance panel screen in certain browsers from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Thanks @Etonkovidova, moving to PM. Note for @MMiller_WMF the narrow case looks better since this was tested because the 360px width (T255719) will resolve the overflowing tabs, and the breaking difficulty label ribbon bug has also been fixed on T254524:

Mon, Jun 29, 12:00 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Regression, Growth-Team (Current Sprint)
RHo moved T254524: [BUG] Newcomer tasks: Overflowing text on guidance screen panel header when difficulty label is too long from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Thanks, double-checked on Desktop and Mobile and LGTM too.

Mon, Jun 29, 11:53 AM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Growth-Team (Current Sprint)

Thu, Jun 25

RHo moved T255254: Newcomer tasks: Fix back-then-close issue when using guidance with editing from Design Review to Needs More Work on the Growth-Team (Current Sprint) board.

Whilst most of the design review items from my comment T255254#623223 are fixed, I've just notice the close "x" button is still inconsistently place on the LHS of the root screen:

Root screen

It is important that it is consistently in the same position in the header (always on the right hand side), esp. for mobile when it is covering the whole screen.

Thu, Jun 25, 8:53 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Patch-For-Review, GrowthExperiments-Help panel, NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo updated the task description for T256215: Newcomer task: Update mobile guidance panel copy reminding users about section editing.
Thu, Jun 25, 8:37 AM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Growth-Team (Current Sprint), NewcomerTasks 1.2
RHo added a comment to T256215: Newcomer task: Update mobile guidance panel copy reminding users about section editing.

@RHo -- since the sections on an article are collapsed by default, I'm concerned that the users won't see the pencil icons. How about: "Ready? Open the section you want to edit and tap the pencil icon"

Thu, Jun 25, 8:36 AM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Growth-Team (Current Sprint), NewcomerTasks 1.2

Wed, Jun 24

RHo closed T251250: Newcomer tasks: guidance and help panel header overflow menu should use ButtonMenuSelectWidget as Invalid.

Yes, this is no longer valid since we got rid of this menu.

Wed, Jun 24, 4:41 PM · NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T254526: Newcomer tasks: Header font-size on Suggested Edits screen should use OOUI fieldset header style.

The OOUI fieldset header style is for OOUI forms. I don't think there is a sane way to reuse it elsewhere. Ideally, WikimediaUI would provide a class for header styling, but it doesn't, and OOUI does not have a header component, and even if it did, it seems wasteful performance-wise to render every piece of text with an OOUI component. So we should probably just define our own header style which will hopefully be a close enough imitation of the OOUI style.

Wed, Jun 24, 1:54 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo updated the task description for T254526: Newcomer tasks: Header font-size on Suggested Edits screen should use OOUI fieldset header style.
Wed, Jun 24, 1:52 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo updated subscribers of T256215: Newcomer task: Update mobile guidance panel copy reminding users about section editing.

hi @MMiller_WMF - here's my first attempt at the updated copy, please update and prioritize as you see fit.

Wed, Jun 24, 9:58 AM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Growth-Team (Current Sprint), NewcomerTasks 1.2
RHo created T256215: Newcomer task: Update mobile guidance panel copy reminding users about section editing.
Wed, Jun 24, 9:57 AM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Growth-Team (Current Sprint), NewcomerTasks 1.2

Tue, Jun 23

RHo added a comment to T255850: [BUG] Double vertical scrollbar appearing on every guidance panel screen in certain browsers.

hi @PPham - would you mind confirming that you are still experiencing this bug, and providing the browser version where it is occurring? Also, to confirm: are you experiencing this in production version of Viwiki?

Tue, Jun 23, 2:17 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Regression, Growth-Team (Current Sprint)
RHo updated subscribers of T256081: Image suggestion proof-of-concept.
Tue, Jun 23, 8:11 AM · Research (FY2020-21-Research-July-September), Growth-Team, Wikipedia-Android-App-Backlog
RHo updated the task description for T256081: Image suggestion proof-of-concept.
Tue, Jun 23, 8:08 AM · Research (FY2020-21-Research-July-September), Growth-Team, Wikipedia-Android-App-Backlog

Mon, Jun 22

RHo updated the task description for T255255: Newcomer tasks: Enable easier toggling to open and close Desktop help panel.
Mon, Jun 22, 5:36 PM · Patch-For-Review, GrowthExperiments-Help panel, NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo updated the task description for T255255: Newcomer tasks: Enable easier toggling to open and close Desktop help panel.
Mon, Jun 22, 5:34 PM · Patch-For-Review, GrowthExperiments-Help panel, NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T255850: [BUG] Double vertical scrollbar appearing on every guidance panel screen in certain browsers.

absolute positioning of .oo-ui-window-head messes up some height calculation

That's not the main reason, actually. The relocation of the cog/ellipsis menu made the home panel scroll, and panel sizes are synchronized for the switching animation. So the help panel will always show a scroll bar because the home panel needs it, even when the home panel is not visible.

Some possible workarounds:

  • Put the scroll bar inside the home panel (ie. during the transition animation the scroll bar will animate too)
  • Put the footer outside the panels (so it won't animate during panel switching). Probably ugly because the panel does appear/disappear during panel switching.
  • Accept that the guidance panel will have a scroll bar for no obvious reason, and make sure the footer does not have empty space below it at least. Ugly + the footer will be invisible without scrolling.
  • Just make the panel taller so the home panel does not need to scroll. Kind of a hack (reverts if one of the menu options is long enough to take multiple lines, for example).
  • Hide the home panel after the animation has finished.

The last one seems like the sanest option to me. It does add complexity though.

Mon, Jun 22, 3:54 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Regression, Growth-Team (Current Sprint)
RHo added a comment to T255074: Newcomer tasks: notice to switch to VE within guidance.

Thanks @kostajh - so the icon color would be using the same one as used in the inline warning message on OOUI, which is in color #fc3. If it helps, the direct link to the icon via the OOUI MessageWidget is alert-warning.svg (and here's the fallback PNG)

Mon, Jun 22, 3:18 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Growth-Team (Current Sprint)

Fri, Jun 19

RHo created T255850: [BUG] Double vertical scrollbar appearing on every guidance panel screen in certain browsers.
Fri, Jun 19, 8:36 AM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Regression, Growth-Team (Current Sprint)
RHo moved T255254: Newcomer tasks: Fix back-then-close issue when using guidance with editing from QA to Needs More Work on the Growth-Team (Current Sprint) board.

Moving back due as I noticed the following issues related to the addition of the the links in the root screen:

Fri, Jun 19, 8:25 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Patch-For-Review, GrowthExperiments-Help panel, NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo triaged T255255: Newcomer tasks: Enable easier toggling to open and close Desktop help panel as Low priority.
Fri, Jun 19, 7:19 AM · Patch-For-Review, GrowthExperiments-Help panel, NewcomerTasks 1.2, Growth-Team (Current Sprint)

Thu, Jun 18

RHo moved T245790: Newcomer tasks: post-edit dialog from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

The function seems fine but there are a few design issues to be sorted. Given the train has left the station, I've filed them as separate sub-tasks and moving this to PM review for closing out.

Thu, Jun 18, 8:07 PM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo created T255825: Newcomer tasks: UI fixes to the text elements on the Post-edit dialog.
Thu, Jun 18, 8:06 PM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo created T255823: Newcomer tasks: Post-edit dialog suggested edit card is missing the wikidata description.
Thu, Jun 18, 7:57 PM · NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo created T255821: Newcomer tasks: UI fixes to the Mobile footer buttons in the Post-edit dialog.
Thu, Jun 18, 7:51 PM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo created T255820: Newcomer tasks: Fix bottom padding on the mobile success notification at the top of the Post-edit dialog.
Thu, Jun 18, 7:48 PM · NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo created T255819: Newcomer tasks: UI fixes to the Image thumbnail in the Post-edit dialog.
Thu, Jun 18, 7:38 PM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T244431: Newcomer tasks: guidance panel behavior.

I realize I'm kind of confused now about where we've landed (i.e. is "locked" mode still a desirable thing?), especially after the rules have changed a bit in T255254.

@RHo and @MMiller_WMF could you please review the help panel behavior in beta labs for 1) regular help panel, not part of any suggested edit session, 2) Special:Homepage, as seen when posting a question to your mentor, and 3) in the suggested edit guidance session -- and do that for both desktop and mobile -- and then let us know which changes you want to see in business rules?

Sorry to cause more work but I feel like it might be easier to start with fresh eyes now that we've added the close button.

Looking over it all again myself, I think the only business rule difference between my patch and what is in beta labs right now is that in beta, guidance opens as "Locked" but with my patch there is a back arrow in addition to the X in the top right. Do we want to keep locked mode for the suggested edits screen or get rid of the concept?
Everything else in my patch is shuffling code around to (hopefully) make things easier to update in the future.

Thu, Jun 18, 4:20 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo moved T244541: Newcomer tasks: suggested edit screen in guidance from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.
Thu, Jun 18, 4:13 PM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo moved T254514: Newcomer tasks: UI fixes to Suggested edit guidance screen panel header from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

LGTM

Thu, Jun 18, 4:10 PM · MW-1.35-notes (1.35.0-wmf.38; 2020-06-23), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T255774: [Bug] Newcomer tasks: Unexpected white space on the Mobile guidance header background (iPHone only).

Do you see this in an Android device as well?

Thu, Jun 18, 2:11 PM · Growth-Team (Current Sprint), NewcomerTasks 1.2
RHo renamed T255774: [Bug] Newcomer tasks: Unexpected white space on the Mobile guidance header background (iPHone only) from [Bug] Newcomer tasks: Unexpected white space on the Mobile guidance header bckground to [Bug] Newcomer tasks: Unexpected white space on the Mobile guidance header background (iPHone only).
Thu, Jun 18, 1:58 PM · Growth-Team (Current Sprint), NewcomerTasks 1.2
RHo added a comment to T244541: Newcomer tasks: suggested edit screen in guidance.

Thanks @Etonkovidova - I'm moving to PM review and opening a few new tasks per your review.

[...]
(2) The only concern is about accessibility (the contrast ratio) for

.oo-ui-buttonElement.oo-ui-widget-enabled > .oo-ui-buttonElement-button > .oo-ui-iconElement-icon:not(.oo-ui-image-invert), .oo-ui-buttonElement.oo-ui-widget-enabled > .oo-ui-buttonElement-button > .oo-ui-indicatorElement-indicator:not(.oo-ui-image-invert) {
    opacity: 0.87;

I couldn't obtain the Web tool Accessibility data for the contrast ratio (the tool doesn't work where there is background-image ) but comparing with the mockup, the 'x', three-dots, and the back arrow look paler in betalabs implementation:

mockupbetalabs

This is indeed not up even AA compliant contrast, which appears to be due to an additional opacity:0.5 added on top of the expected `opacity: .87' on the #000 icon. Filed T255773

Thu, Jun 18, 1:40 PM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo created T255774: [Bug] Newcomer tasks: Unexpected white space on the Mobile guidance header background (iPHone only).
Thu, Jun 18, 1:39 PM · Growth-Team (Current Sprint), NewcomerTasks 1.2
RHo renamed T255773: [Bug] Newcomer tasks: Help panel header icons should lacks sufficient AA color contrast from [Bug] Newcomer tasks: Help panel header icons should have lack sufficient AA color contrast to [Bug] Newcomer tasks: Help panel header icons should lacks sufficient AA color contrast.
Thu, Jun 18, 1:31 PM · NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo created T255773: [Bug] Newcomer tasks: Help panel header icons should lacks sufficient AA color contrast.
Thu, Jun 18, 1:30 PM · NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo created T255770: [regression] Newcomer tasks: Mobile help panel header text is no longer vertically centered. .
Thu, Jun 18, 1:21 PM · Growth-Team (Current Sprint), Regression, NewcomerTasks 1.2
RHo added a comment to T244541: Newcomer tasks: suggested edit screen in guidance.

@RHo @Etonkovidova -- something to note as you review, that I noticed. There is a line under the header of the help panel that is not present on this screen but is present on other panel screens:



Thu, Jun 18, 12:57 PM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T244541: Newcomer tasks: suggested edit screen in guidance.

@RHo -- another note is whether you think the layout of these little icons could be improved. This is tip 6 for adding references.

Yes, this should be addressed as part of T254527

Thu, Jun 18, 12:57 PM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo updated the task description for T255074: Newcomer tasks: notice to switch to VE within guidance.
Thu, Jun 18, 12:37 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo updated the task description for T245790: Newcomer tasks: post-edit dialog.
Thu, Jun 18, 12:31 PM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo moved T255388: Newcomer tasks: no post-edit suggestion if re-editing article from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Moving to PM review, and will also update the business rules on the parent task T245790 to reflect this change.

Thu, Jun 18, 12:23 PM · MW-1.35-notes (1.35.0-wmf.38; 2020-06-23), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T253009: Newcomer tasks: automatically advance tips.

Thanks @Etonkovidova - my comments inline below before @MMiller_WMF does his review:

Thu, Jun 18, 8:56 AM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Growth-Team (Current Sprint)

Wed, Jun 17

RHo updated subscribers of T255719: Newcomer tasks: Make the help panel a fixed width on Desktop.

hi @MMiller_WMF - please prioritize as you see fit. Applying a 360px fixed width also means we don't need to consider the more drastic changes to the quick tips tabs proposed on T255389.

Wed, Jun 17, 9:20 PM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo created T255719: Newcomer tasks: Make the help panel a fixed width on Desktop.
Wed, Jun 17, 9:17 PM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T255254: Newcomer tasks: Fix back-then-close issue when using guidance with editing.

Hi @Tgr, can the panel height be reverted back to 528px? I think it's fine if there is some scrolling on the root screen sometimes rather than having the taller panel all the time.

Wed, Jun 17, 9:05 PM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Patch-For-Review, GrowthExperiments-Help panel, NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo moved T254514: Newcomer tasks: UI fixes to Suggested edit guidance screen panel header from Design Review to Needs More Work on the Growth-Team (Current Sprint) board.

Hi @kostajh - I noticed the task difficulty text hits the bottom of the header when the task type text goes over 2-3 lines:

Wed, Jun 17, 11:57 AM · MW-1.35-notes (1.35.0-wmf.38; 2020-06-23), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo moved T245786: Newcomer tasks: guidance written content from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Thanks @Etonkovidova - moving to PM review as I think your observation (1) makes sense but can be addressed separately as a new improvement to the guidence content and (2) is fine since the icons are more illustrative in that context.

For @RHo and @MMiller_WMF review - the text on desktop and mobile is according to the spreadsheet; no issues were found.

Two observations:
(1) In two places there "neutral tone" and "content should be neutral" is mentioned ("Copy edit" tip number 4; "Expand" tip number 3) - it might be useful for a user to have it as a link to the relevant page, e.g. on enwiki - https://en.wikipedia.org/wiki/Wikipedia:Neutral_point_of_view. This is an important concept which is not that intuitive.

  • Defer to @MMiller_WMF - I'm 50/50 on whether adding the link is too detailed for this "quick tip", even though I agree it is an important concept that is not so clear. If we did want create a new task to add in this link, may I suggest also reviewing whether it also makes sense to link out to pages to better explain references to reliable/verifiable and Encyclopedic content?
Wed, Jun 17, 11:38 AM · NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo moved T250310: Newcomer tasks: Help panel height is shorter than expected from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Thanks @Etonkovidova - I can't replicate the double-scrollbar that is occurring in your second screenshot from my Chrome browser so wonder if it browser dependent? In any case, think this is minor enough (certain subset of browsers, only if the browser window height is <724px ) when this would occur that IMHO we can call it a pass.

Wed, Jun 17, 11:24 AM · MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), Growth-Team (Current Sprint), NewcomerTasks 1.2, GrowthExperiments-Help panel
RHo updated the task description for T255254: Newcomer tasks: Fix back-then-close issue when using guidance with editing.
Wed, Jun 17, 11:09 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Patch-For-Review, GrowthExperiments-Help panel, NewcomerTasks 1.2, Growth-Team (Current Sprint)

Mon, Jun 15

RHo added a comment to T255388: Newcomer tasks: no post-edit suggestion if re-editing article.

@MMiller_WMF @Tgr - agree this is expected behaviour. However, maybe we can make the CTA "View more suggested edits" text say "Return to homepage" instead to more accurately convey the result of the action.
Perhaps having the word "more" in "View more suggested edits" without showing a suggested edit above it is causing confusion as well.

Mon, Jun 15, 5:07 PM · MW-1.35-notes (1.35.0-wmf.38; 2020-06-23), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T255074: Newcomer tasks: notice to switch to VE within guidance.

@RHo -- could you please add a fourth visual treatment, one in which the banner is above the "Quick start tips" header? Then we can look at all of them together.

Mon, Jun 15, 3:52 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo updated the task description for T255074: Newcomer tasks: notice to switch to VE within guidance.
Mon, Jun 15, 3:48 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T255389: Newcomer tasks: tips wrap in narrow panel.

@MMiller_WMF - since this is an edge case, I think we should push for the same behaviour to occur as the minerva-tabs whereby tab that is over the width to result horizontal scroll like in the mobile site:

Current prod mobile tabs
Use for proposed short term fix
Mon, Jun 15, 2:42 PM · NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T255254: Newcomer tasks: Fix back-then-close issue when using guidance with editing.

@RHo -- does this design also work when the user is using the help panel outside of the context of suggested edits?

Yes, adding the close button to be accessible on the Get help with editing page reverts back to the previous interaction before suggested edits was added as a sub-screen option.
The bigger change to exposing the more links on the root screen means users are more likely to notice the ability to turn off help from the root screen, but this is balanced out by the options no longer being "globally accessible" on the ".." menu.

Mon, Jun 15, 11:58 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Patch-For-Review, GrowthExperiments-Help panel, NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo moved T254414: Newcomer tasks: panel should be behind other editing dialogs from Design Review to Needs More Work on the Growth-Team (Current Sprint) board.
Mon, Jun 15, 11:32 AM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T254414: Newcomer tasks: panel should be behind other editing dialogs.

[..]
For @RHo review
(1) VE tool bar stays in plays when a page is scrolled down, so some of the VE drop down menus might interfere with the Guidance/Help panel:

Moving back to fix so that all drop downs from the VE toolbar appear above the panel. See another example where the Bullet list is almost entirely obscured behind the help panel.

Mon, Jun 15, 11:32 AM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo created T255421: Newcomer tasks: Help panel shifts every time a dialog popup is opened from VE.
Mon, Jun 15, 11:31 AM · Growth-Team (Current Sprint), NewcomerTasks 1.2

Fri, Jun 12

RHo moved T253678: Help panel suggested edit screen: Allow scrolling contents from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Note: - @RHo - do you think it needs to be filed as a separate bug?

Hi @Etonkovidova - do you mean the scrollbar being visible? I think that is fine as it depends on the browser.
However, is the visual bug in the mp4 where there is a white background shown above and below the "Suggested edits" header still occurring on the iPhone?


If so, it should be logged as a separate bug please.

Fri, Jun 12, 7:45 PM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), GrowthExperiments-Homepage, NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo moved T254630: Newcomer tasks: link targets for quick tips from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Links appear or do not appear as expected from design perspective depending on the existence of the links to additional information.

Fri, Jun 12, 7:18 PM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo updated subscribers of T255074: Newcomer tasks: notice to switch to VE within guidance.

hi @MMiller_WMF - I've created some different visual treatments for the nudge to VE notice on the task description for discussion and decisions.
My preference is for visual treatment C as it is more likely to be noticed by the user than being in the footer, and it is also hierarchically makes more sense as a warning shown above the tips.

Fri, Jun 12, 6:28 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo updated the task description for T255074: Newcomer tasks: notice to switch to VE within guidance.
Fri, Jun 12, 6:24 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T254823: Newcomer tasks: switch to visual editor (mobile).

@MMiller_WMF - I created a sub-task T255074 for the proposal to add a notice to nudge users back to using VE, assuming this task will be to proceed with the short term solution to switch to VE by default across browsers.

Fri, Jun 12, 4:35 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo updated the task description for T255254: Newcomer tasks: Fix back-then-close issue when using guidance with editing.
Fri, Jun 12, 11:34 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Patch-For-Review, GrowthExperiments-Help panel, NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo created T255255: Newcomer tasks: Enable easier toggling to open and close Desktop help panel.
Fri, Jun 12, 11:33 AM · Patch-For-Review, GrowthExperiments-Help panel, NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo created T255254: Newcomer tasks: Fix back-then-close issue when using guidance with editing.
Fri, Jun 12, 11:24 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Patch-For-Review, GrowthExperiments-Help panel, NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo closed T242744: Newcomer tasks: adjust alignment of button labels, a subtask of T238608: [EPIC] Growth: Newcomer tasks 1.1.0 (topic matching), as Resolved.
Fri, Jun 12, 10:41 AM · NewcomerTasks 1.1, Growth-Team (Current Sprint)
RHo closed T242744: Newcomer tasks: adjust alignment of button labels as Resolved.

Closing as this is no longer an issue.

CS Betalabs
CS Prod
Fri, Jun 12, 10:41 AM · NewcomerTasks 1.1, Growth-Team
RHo added a comment to T253009: Newcomer tasks: automatically advance tips.

So does that mean in the above scenario (user goes back from Edit to Read mode without touching the default opened guidance panel) the tips should continue to auto-advance? I think that would be fine.

That scenario is not reachable from the business rules we landed on with T244431: Newcomer tasks: guidance panel behavior. If the user clicks on "Edit" without clicking on any of the tips, we take them to the root screen. Then on the root screen, if they click the button to go back to the guidance panel, the patch disables the auto advancing of the tips. Should we not disable auto advancing in that scenario?

Fri, Jun 12, 9:44 AM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Growth-Team (Current Sprint)

Thu, Jun 11

RHo updated the task description for T244555: [BUG] Newcomer tasks: arwiki "suggested-edits-icon" placement should be aligned with RHS of module header.
Thu, Jun 11, 11:30 AM · Growth-Team (Current Sprint), GrowthExperiments-Homepage
RHo moved T253043: Newcomer tasks: Conduct usability testing of released guidance feature in local languages from Incoming to Needs Design/Design Doing on the Growth-Team (Current Sprint) board.
Thu, Jun 11, 11:24 AM · NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo moved T253706: Suggested edits - low contrast issue for .suggested-edits-difficulty-indicator from Incoming to Needs Design/Design Doing on the Growth-Team (Current Sprint) board.
Thu, Jun 11, 11:24 AM · Growth-Team (Current Sprint), Growth Design, GrowthExperiments-Homepage
RHo edited projects for T253706: Suggested edits - low contrast issue for .suggested-edits-difficulty-indicator, added: Growth-Team (Current Sprint); removed Growth-Team.
Thu, Jun 11, 11:24 AM · Growth-Team (Current Sprint), Growth Design, GrowthExperiments-Homepage
RHo moved T244546: Newcomer tasks: guidance root screen from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

LGTM

Thu, Jun 11, 10:03 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Patch-For-Review, NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo updated the task description for T253009: Newcomer tasks: automatically advance tips.
Thu, Jun 11, 9:53 AM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T253009: Newcomer tasks: automatically advance tips.

If the user navigates from Edit *back* to another mode (eg., Edit Source or Read mode) or else refreshes the page from Edit in the same session, this 'counts' as an interaction that stops the auto-advancing action.

The behavior of the current patch does not follow this, because auto-advance relies on the rules from T244431: Newcomer tasks: guidance panel behavior for what counts as an interaction, and those rules are slightly different (or maybe just interpreted slighlty differently). I hope we can avoid having two different "interacted" flags, it adds mental and code complexity.

Thu, Jun 11, 9:52 AM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Growth-Team (Current Sprint)