Page MenuHomePhabricator

Set Minerva default to day mode
Closed, ResolvedPublic1 Estimated Story Points

Description

Background

To prepare for our initial roll out we want Minerva's theme to default to "day mode" rather than automatic.

User story

  • As a reader, I want to get the standard theme by default, so that I am not upset by unexpected changes to my appearance.

Requirement

In the Wikipedia Minerva skin, ensure the standard theme, Day Mode, is set as the default for all users to prevent unexpected appearance changes and maintain a consistent reading experience.

BDD Scenario

Feature: Set Day Mode as Default in Minerva Skin

  Scenario: Ensuring Day Mode is the default theme
    Given a user accesses Wikipedia with the Minerva skin
    When the user has not previously selected a theme
    Then Day Mode should be the active theme by default

Test Steps

  1. Access Wikipedia with the Minerva skin without any prior theme selection.
  2. Verify that Day Mode is the active theme.

Design

N/A

Acceptance criteria

  • When I go to an article I get day mode by default.

Sign off

  • Create a ticket for making the default different per wiki

QA Results - Beta

ACStatusDetails
1T358811#9616533

QA Results - Prod

ACStatusDetails
1T358811#9616534

Event Timeline

Change 1007710 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Default to day mode

https://gerrit.wikimedia.org/r/1007710

Change 1007383 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@wmf/1.42.0-wmf.20] Default to day mode

https://gerrit.wikimedia.org/r/1007383

Jdlrobson renamed this task from Web Task Creation FSet Minerva default to day mode to Set Minerva default to day mode.Feb 29 2024, 9:16 PM
Jdlrobson triaged this task as High priority.
Jdlrobson set the point value for this task to 0.

Change 1007383 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@wmf/1.42.0-wmf.20] Default to day mode

https://gerrit.wikimedia.org/r/1007383

Mentioned in SAL (#wikimedia-operations) [2024-02-29T21:51:28Z] <jdrewniak@deploy2002> Started scap: Backport for [[gerrit:1007383|Default to day mode (T358811)]]

Mentioned in SAL (#wikimedia-operations) [2024-02-29T21:52:51Z] <jdrewniak@deploy2002> jdlrobson and jdrewniak: Backport for [[gerrit:1007383|Default to day mode (T358811)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-02-29T22:02:09Z] <jdrewniak@deploy2002> Finished scap: Backport for [[gerrit:1007383|Default to day mode (T358811)]] (duration: 10m 40s)

Change 1007710 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Default to day mode

https://gerrit.wikimedia.org/r/1007710

Change 1007733 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/MinervaNeue@master] Remove color-scheme property from :root selector

https://gerrit.wikimedia.org/r/1007733

Jdlrobson changed the point value for this task from 0 to 1.Mar 1 2024, 1:28 AM

Looks good, resolving! @Jdlrobson - should we go back and test this somehow once we release?

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Access Wikipedia with the Minerva skin without any prior theme selection.
✅ AC1: Verify that Day Mode is the active theme.
I tried as anon, and as a user I haven't used previously with any night mode theme testing.

AnonLogged In
screenshot 690.png (932×432 px, 55 KB)
screenshot 691.png (933×427 px, 73 KB)

Test Result - Prod

Status: ✅ PASS
Environment: testwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Access Wikipedia with the Minerva skin without any prior theme selection.
✅ AC1: Verify that Day Mode is the active theme.
I tried as anon, and as a user I haven't used previously with any night mode theme testing.

AnonLogged In
screenshot 693.png (933×427 px, 59 KB)
screenshot 692.png (933×427 px, 78 KB)