Something we need to determine is if it is more important to have enough color contrast between the blue and the yellow to tell they are different colors (i.e. a 3:1+ contrast ratio) or if it is more important to see the background of the diff highlight on the background of the page. Since the color is not the main thing that is noting whether something has been added or removed, and a "+" or "-" is doing that, then I would opt for the the latter of prioritizing sufficient contrast ratios for the background of the highlight on the background of the page. This means having a 4.5:1 contrast ratio for the text and a 3:1 contrast ratio for the background. This ensures that the highlights can be seen clearly on their respective backgrounds, in both day and night modes. But this means a less than 3:1 contrast ratio between the blue and yellow. In my opinion, that is okay and it is more important to opt for more clearly seeing the highlight at all.

FYI -- I think this is sort of a duplicate of T333681, but with a focus on night mode.

With my comment above in mind, this is where I have landed on the diff colors.

This does two things:

1. Determines that the diff colors should be yellow/blue
2. Ensures sufficient color contrast between the text and background for both diffs on both light and dark modes. That being said there is not sufficient contrast between the yellow and blue themselves. However, I think this is less of a problem than ensuring the color can be clearly seen on the page background.

The colors for text only would be slightly different, but within the same realm to convey the same message. This would all be built into Codex decision tokens.

cc @JScherer-WMF

In T358406#9624928, @DTorsani-WMF wrote:

With my comment above in mind, this is where I have landed on the diff colors.

This does two things:

1. Determines that the diff colors should be yellow/blue
2. Ensures sufficient color contrast between the text and background for both diffs on both light and dark modes. That being said there is not sufficient contrast between the yellow and blue themselves. However, I think this is less of a problem than ensuring the color can be clearly seen on the page background.

The colors for text only would be slightly different, but within the same realm to convey the same message. This would all be built into Codex decision tokens.

cc @JScherer-WMF

Looks great!

What is our plan for the colors in recent changes {F42074129} ? Should we be thinking of them as different colors altogether?

@Jdlrobson can you link to the context you're referring to?

Link is in description for history: https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=T352930&action=history&minervanightmode=1 (all modes)
But this also applies to the following pages:

• https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:RecentChanges (AMC only)
• https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Watchlist?hidepreviousrevisions=1&hidecategorization=1&hideWikibase=1&limit=50&days=7&enhanced=1&urlversion=2 (AMC only)

In T358406#9638493, @Jdlrobson wrote:

Link is in description for history: https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=T352930&action=history&minervanightmode=1 (all modes)
But this also applies to the following pages:

• https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:RecentChanges (AMC only)
• https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Watchlist?hidepreviousrevisions=1&hidecategorization=1&hideWikibase=1&limit=50&days=7&enhanced=1&urlversion=2 (AMC only)

Ah I understand now. Thanks for that context @Jdlrobson!

Those would adopt the notification colours as in T358736 because they don't have a background highlighting to call them out from a body of text.

@DTorsani-WMF is the palette for those notification colours documented somewhere? If so, please point me there, and I can pull the right one out for the spec.

In T358406#9638424, @Jdlrobson wrote:

What is our plan for the colors in recent changes {F42074129} ? Should we be thinking of them as different colors altogether?

Is there a ticket somewhere to address the recent changes pages?

So there seems to be a couple things we are landing on:

1. For diff colors across all instances of modified content, we will use yellow (not red) for removed and blue (not green) for added.
2. The values for these colors will be the following:

For your information, we have added in these option tokens into Codex, and are currently working on adding these in as new decision tokens. If you are using the hex values for now, those are also included in the table above.

moving to sign off assuming the design portion of this ticket is sufficient. @Jdlrobson feel free to move back to doing or design review if this is not the case. Needs implementation tickets for sign-off.

I can set up some tickets.
@JScherer-WMF I'm a little confused on how to use T358406#9639324 - could you add some mocks?
I'm still a little confused about what we're doing for recent changes etc which seems to be the more pressing concern here! T358406#9638914 seems to be focused on usage on the diffs themselves or am I misunderstanding how it applies to the other pages?

I'm still a little confused about what we're doing for recent changes

I see the confusion here. The designs focus on content diffs as in the screenshot below

Those "diffs" have a background color, but the designs don't fully address the +/- bytes colors in the Recent Changes page. e.g. screenshot below:

These numbers are red/green and don't have a background color, but they also represent diffs in the sense that it's bytes added/removed.

@JScherer-WMF To review and provide clarity on design and Recent Changes list, etc.

Spoke to @DTorsani-WMF yesterday. I will make mocks for this this morning and unblock it.