Maniphest T362861

Add decision tokens for diff colors into Codex
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DTorsani-WMF
	Thu, Apr 18, 9:50 AM

Tags

Referenced Files

	F44340721: image.png
	Thu, Apr 18, 9:50 AM

	F44340696: image.png
	Thu, Apr 18, 9:50 AM

	F44340624: image.png
	Thu, Apr 18, 9:50 AM

Subscribers

Description

Context

As discussed in DST design sync, we decided we want to add in decision tokens for added and removed content in MediaWiki. This was originally discussed in Phab on T361717.

Naming

We have decided to name these tokens -content-added and -content-removed.

Designs

added	light mode	dark mode
text	`@color-blue-600` `#3366cc`	`@color-blue-400` `#6d8af2`
background	`@color-blue-400` `#6d8af2`	`@color-blue-600` `#3366cc`
border	`@color-blue-400` `#6d8af2`	`@color-blue-600` `#3366cc`

removed	light mode	dark mode
text	`@color-yellow-700` `#a66200`	`@color-yellow-650` `#ad822b`
background	`@color-yellow-650` `#ad822b`	`@color-yellow-700` `#a66200`
border	`@color-yellow-650` `#ad822b`	`@color-yellow-700` `#a66200`

image.png (1×2 px, 263 KB)

image.png (1×2 px, 265 KB)

Figma dev mode link

Acceptance criteria

Figma "content" tokens are renamed to "text"
Figma decision tokens have been added
Decision tokens have been added to code

Details

	Subject	Repo	Branch	Lines +/-
	Update Codex from v1.4.0 to v1.5.0	mediawiki/core	master	+519 -4 K
	tokens: Add decision tokens for content added and removed	design/codex	main	+36 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		Jdrewniak	T341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations
		Open		Jdrewniak	T341632 [EPIC] Palette customizations and dark mode
		Open		None	T354835 [epic] Release night mode as a beta feature on desktop and mobile
		Open		None	T356434 [Night Mode] All pages and overlays that can be accessed within 2 clicks by a logged in user (AMC disabled) appear in night mode on mobile
		In Progress		DTorsani-WMF	T355147 [EPIC] Dark Mode
		Resolved	BUG REPORT	Jdlrobson	T358406 [Design needed] Bytes added on history, contribute, watchlist and recent changes have color contrast issues and is inconsistent with colors on diff pages
		Open		Jdrewniak	T361717 Make diffs and change lists text accessible in both day and night modes
		Resolved		DTorsani-WMF	T362861 Add decision tokens for diff colors into Codex

Event Timeline

DTorsani-WMF created this task.Thu, Apr 18, 9:50 AM

Restricted Application edited projects, added Design-System-Team; removed Design-System-Team (DST-Sprint-21 (2024-04-15 to 2024-04-26)). · View Herald TranscriptThu, Apr 18, 9:50 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

DTorsani-WMF updated the task description. (Show Details)Thu, Apr 18, 9:53 AM

DTorsani-WMF renamed this task from Add in decision tokens for diff colors to Add decision tokens for diff colors into Codex.Thu, Apr 18, 9:57 AM

DTorsani-WMF moved this task from Inbox to DST-Sprint-21 (2024-04-15 to 2024-04-26) on the Design-System-Team board.Thu, Apr 18, 10:04 AM

DTorsani-WMF edited projects, added Design-System-Team (DST-Sprint-21 (2024-04-15 to 2024-04-26)); removed Design-System-Team.

DTorsani-WMF added a parent task: T361717: Make diffs and change lists text accessible in both day and night modes.Thu, Apr 18, 2:15 PM

DTorsani-WMF updated the task description. (Show Details)Tue, Apr 23, 1:46 PM

DTorsani-WMF updated the task description. (Show Details)Tue, Apr 23, 1:50 PM

Change #1023434 had a related patch set uploaded (by Dtorsani; author: Dtorsani):

[design/codex@main] tokens: Add decision tokens for content added and removed

https://gerrit.wikimedia.org/r/1023434

gerritbot added a project: Patch-For-Review.Tue, Apr 23, 2:13 PM

DTorsani-WMF updated the task description. (Show Details)Tue, Apr 23, 2:14 PM

Change #1023434 merged by jenkins-bot:

[design/codex@main] tokens: Add decision tokens for content added and removed

https://gerrit.wikimedia.org/r/1023434

egardner moved this task from In Progress to Pending Release on the Design-System-Team (DST-Sprint-21 (2024-04-15 to 2024-04-26)) board.Tue, Apr 23, 9:14 PM

Volker_E removed a project: Patch-For-Review.Wed, Apr 24, 2:17 AM

RHo attached a referenced file: F44340721: image.png. (Show Details)Fri, Apr 26, 10:03 PM

RHo attached a referenced file: F44340696: image.png. (Show Details)

RHo attached a referenced file: F44340624: image.png. (Show Details)

@DTorsani-WMF cc @mwilliams - think this should link to the overarching need to unify diff and "highlight text" colours across products as captured in T333681: Establish consistent guidelines on how to visualize diffs across desktop, mobile web, and mobile apps on the DST backlog.

DTorsani-WMF updated the task description. (Show Details)Mon, Apr 29, 1:09 PM

Thanks @RHo! It can certainly help influence that task.

Change #1025849 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/core@master] Update Codex from v1.4.0 to v1.5.0

https://gerrit.wikimedia.org/r/1025849

gerritbot added a project: Patch-For-Review.Tue, Apr 30, 8:14 PM

Test wiki created on Patch demo by Lwatson7 using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/3f8e64b675/wiki/Main Page

Change #1025849 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.4.0 to v1.5.0

https://gerrit.wikimedia.org/r/1025849

Maintenance_bot removed a project: Patch-For-Review.Wed, May 1, 12:30 AM

lwatson closed this task as Resolved.Wed, May 1, 12:47 PM

Jdlrobson mentioned this in T361717: Make diffs and change lists text accessible in both day and night modes.Wed, May 1, 1:10 PM