Maniphest T362270

Add new spacing token of 40rem
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DTorsani-WMF
	Apr 10 2024, 5:31 PM

Tags

Referenced Files

None

Subscribers

Description

Context

As noted in this task and previous documentation, we want to add a new spacing token that is more appropriate for a max-width on certain forms. After discussion, we have agreed that this new spacing token should be 40rem (or 640px in our default Codex theme).

Acceptance criteria

New spacing token has been added in code
New spacing token has been added in Figma
Docs site and Figma spec have been updated to reflect the change
Form guidelines (including images) have been updated in Figma and on the docs site

Details

	Subject	Repo	Branch	Lines +/-
	Update Codex from 1.3.6 to 1.4.0	mediawiki/core	master	+190 -114
	tokens: Add `40rem` sizing token	design/codex	main	+19 -13

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		In Progress		bmartinezcalvo	T355148 [EPIC] Multiblocks
		Resolved		Volker_E	T361783 CodexHTMLForm should feature a max-width for Codex components
		Resolved		DTorsani-WMF	T362270 Add new spacing token of 40rem

Event Timeline

DTorsani-WMF created this task.Apr 10 2024, 5:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 10 2024, 5:31 PM

Change #1019055 had a related patch set uploaded (by Dtorsani; author: Dtorsani):

[design/codex@main] tokens: Add 40rem sizing token

https://gerrit.wikimedia.org/r/1019055

gerritbot added a project: Patch-For-Review.Apr 11 2024, 2:25 PM

CCiufo-WMF added a parent task: T361783: CodexHTMLForm should feature a max-width for Codex components.Apr 11 2024, 3:06 PM

Volker_E updated the task description. (Show Details)Apr 11 2024, 4:05 PM

Change #1019055 merged by jenkins-bot:

[design/codex@main] tokens: Add `40rem` sizing token

https://gerrit.wikimedia.org/r/1019055

Volker_E mentioned this in T361783: CodexHTMLForm should feature a max-width for Codex components.Apr 11 2024, 5:18 PM

DTorsani-WMF updated the task description. (Show Details)Apr 11 2024, 7:29 PM

egardner moved this task from In Progress to Pending Release on the Design-System-Team (DST-Sprint-20 (2024-04-01 to 2024-04-12)) board.Apr 12 2024, 6:39 PM

Volker_E removed a project: Patch-For-Review.Apr 15 2024, 9:02 PM

Volker_E added a project: CSS.Tue, Apr 16, 5:58 PM

Change #1020918 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/core@master] Update Codex from 1.3.6 to 1.4.0

https://gerrit.wikimedia.org/r/1020918

gerritbot added a project: Patch-For-Review.Wed, Apr 17, 8:40 PM

Change #1020918 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from 1.3.6 to 1.4.0

https://gerrit.wikimedia.org/r/1020918

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.2; 2024-04-23).Wed, Apr 17, 10:00 PM

egardner closed this task as Resolved.Wed, Apr 17, 10:26 PM

Volker_E removed a project: Patch-For-Review.Wed, Apr 17, 10:48 PM