[S] Add target language interface and email translations for Add an Image
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	HNordeenWMF
	May 1 2024, 5:12 PM

Description

Background

The Target Quant Regions and Languages for the Add an Image feature are

Spanish, French and Portuguese speakers in the Americas (North, South and Central) and Caribbean
Chinese speakers in North America.

Because we will be announcing this feature's release specifically to these wikis, and audiences, we want to ensure the feature's interface has been fully translated, ideally before the week of 12 May.

Tasks:

Add Interface translations into translate wiki for zh, fr, es, and pt
Add support email translations

Related Objects
Search...

Status	Assigned	Task
Open	None	T344258 [Main Epic] 2023-2024 Enhancements to Editing on the iOS app
Open	None	T355270 [Sub Epic] Image Recommendations - Add an Image on iOS
Resolved	HNordeenWMF	T363925 [S] Add target language interface and email translations for Add an Image

Event Timeline

HNordeenWMF created this task.May 1 2024, 5:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 1 2024, 5:13 PM

HNordeenWMF moved this task from Tasks from Product Backlog to Needs Engineering Sync on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.May 1 2024, 5:13 PM

HNordeenWMF mentioned this in T358902: [M] Create overflow menu for Image Recs.

Tsevener renamed this task from Add target language interface and email translations for Add an Image to [S] Add target language interface and email translations for Add an Image.May 1 2024, 9:55 PM

Tsevener claimed this task.

Tsevener moved this task from Needs Engineering Sync to Doing on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.

tonisevener opened https://github.com/wikimedia/wikipedia-ios/pull/4835

Tsevener moved this task from Doing to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.May 2 2024, 12:15 AM

mazevedofs closed https://github.com/wikimedia/wikipedia-ios/pull/4835

mazevedofs opened https://github.com/wikimedia/wikipedia-ios/pull/4838

tonisevener closed https://github.com/wikimedia/wikipedia-ios/pull/4838

Tsevener removed Tsevener as the assignee of this task.May 2 2024, 4:29 PM

Tsevener moved this task from Needs Code Review to Waiting for Build on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.

Tsevener updated the task description. (Show Details)

Tsevener subscribed.

Can be tested in TestFlight 7.5.0 (3550).

Looks good so far on 7.5.0 (3550). I did notice a couple small issues. However, everything else appears to have been translated.

Tested by setting the device language to any of the above languages with english as the secondary language. Installed the app and changed the app primary language to English in order for Image Recs to appear on explore feed.

On iPad, the onboarding popup does not expand and the button is often cutoff. Appears to work ok on Chinese. I did not see this issue on iPhone.

On the 'Save Changes' page, text does not appear to be fully translated, but this could be due to the app language settings. Some parts are translated (watch this page section).

mazevedofs opened https://github.com/wikimedia/wikipedia-ios/pull/4842

tonisevener closed https://github.com/wikimedia/wikipedia-ios/pull/4842

It would be nice to also add the translations for Portuguese Brazil. Portuguese speakers in the Americas most likely have their phone set to Portuguese (Brazil), but this can be done after release.
The translation files were missing the strings for the Edit summary chips: "Added image" and "Added image and caption", so we do not have those at this point.

tonisevener opened https://github.com/wikimedia/wikipedia-ios/pull/4843

These recent PRs address https://phabricator.wikimedia.org/T363925#9765667, but not https://phabricator.wikimedia.org/T363925#9768083.

Tsevener moved this task from Ready for Release to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.May 3 2024, 4:20 PM

@ABorbaWMF TestFlight 7.5.0 (3561) should improve the watchlist toggle translations that you mention in https://phabricator.wikimedia.org/T363925#9765667, if you want to test that. We can make the popover sizing bug a separate cleanup task for after release.

thanks @Tsevener. Adding pt-br translations, and addressing popover sizing bug are now in separate tasks, here T364157: [Sub Epic] Clean up tasks for Image Recs V2

mazevedofs closed https://github.com/wikimedia/wikipedia-ios/pull/4843

Looks good on 3.5.0 (3561)

HNordeenWMF moved this task from Ready for PM Signoff to Ready for Release on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.May 3 2024, 6:27 PM

HNordeenWMF closed this task as Unknown Status.May 7 2024, 3:44 PM

HNordeenWMF claimed this task.

HNordeenWMF changed the task status from Unknown Status to Resolved.May 7 2024, 10:18 PM

	F49881873: IMG_5998.PNG
	May 2 2024, 11:25 PM

	F49881495: IMG_0631.PNG
	May 2 2024, 11:25 PM

	F49881494: IMG_0634.PNG
	May 2 2024, 11:25 PM

	F49881493: IMG_0633.PNG
	May 2 2024, 11:25 PM

[S] Add target language interface and email translations for Add an ImageClosed, ResolvedPublicActions