Maniphest T364088

Remove custom Legalpad API downstream changes
Open, LowPublic
Actions

Assigned To

None

Authored By

	Aklapper
	Fri, May 3, 9:29 AM

Tags

Referenced Files

None

Subscribers

Description

Both from https://phabricator.wikimedia.org/rPHAB4e9fe6e8a314ceb2be1e74dd448fe91bc5f78182 for T253265 very likely unneeded now due to T349595 (followup: T363009), and if at all should be upstreamed anyway, but that's already superseded by https://we.phorge.it/rPa4948ec800e9e385ecb519d86b40c5f13719fb53

Compare:

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Aklapper	T341799 Remove custom WMF Phab downstream hacks superseded by upstream Phorge changes
		Open		None	T364088 Remove custom Legalpad API downstream changes

Event Timeline

Aklapper triaged this task as Low priority.Fri, May 3, 9:29 AM

Aklapper created this task.

Aklapper added a parent task: T341799: Remove custom WMF Phab downstream hacks superseded by upstream Phorge changes.

Aklapper mentioned this in T341799: Remove custom WMF Phab downstream hacks superseded by upstream Phorge changes.

@sguebo_WMF, @jrbs: Would you know if our custom Phabricator API from non-public T253265 is still used in some ways (e.g. for https://meta.wikimedia.org/wiki/Access_to_nonpublic_personal_data_policy/Noticeboard or such) nowadays, and where its code is located?
That code would pull data from Phabricator by calling legalpad.search and/or legalpad.signature.search. Thanks in advance!

I'd like to deprecate and remove https://phabricator.wikimedia.org/conduit/method/legalpad.search/ and https://phabricator.wikimedia.org/conduit/method/legalpad.signature.search/ in favor of upstream https://phabricator.wikimedia.org/conduit/method/legalpad.document.search/ and https://phabricator.wikimedia.org/conduit/method/legalpad.signature.search (the latter is probably the same code anyway).

Aklapper updated the task description. (Show Details)Fri, May 17, 2:56 PM

Aklapper mentioned this in T607: Check easily who has signed Legalpad documents by their Wikimedia username.Mon, May 20, 12:54 PM