Page MenuHomePhabricator

Dialog: Ensure focus is on triggering element or previous section heading after closing
Open, MediumPublic

Description

Background

From DST's evaluating engagement with our partner AFB, we've been provided with a number of answers and tips to possible shortcomings/improvements on several of our components

In the case of the Dialog, we were very uncertain about the focus being in the right place after the dialog is opened working in a predictable way? Putting dialogs before end body tag) .

The feedback received was:

The focus is appropriately set when the dialog is opened. However, upon dismissing or closing the dialog, the focus is shifted to the heading level 1. It should instead be maintained on the element that triggered the dialog or the previous section heading where the dialog was opened.

Goal

Put focus on triggering element or previous section heading after closing

Acceptance criteria

  • Implement focus handler on Dialog exit