Vector dark-mode should support bulleted lists
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdrewniak
	Tue, May 14, 2:08 PM

Description

Steps to reproduce

Visit a page with bulleted lists on beta, e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Betafedf
Turn on dark mode from the appearance menu


light mode	dark mode

Expected results

A bullet should be visible beside each list item

Actual results

A bullet is not visible beside each list item.

Check any additional observations

Observed on the beta cluster wiki
Observed on a production wiki
Observed on Vector desktop skin
Observed on MinervaNeue responsive skin
Observed while logged in
Observed while not logged in (anonymous)

QA Results - Beta

AC	Status	Details
1	✅	T364865#9823527

QA Results - PROD

AC	Status	Details
1	✅	T364865#9844167

Details

	Subject	Repo	Branch	Lines +/-
	Override default sublist styles	mediawiki/skins/Vector	master	+6 -0
	Remove list-style-image used by ul elements	mediawiki/skins/Vector	master	+0 -10

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	BUG REPORT	Jdlrobson	T364865 Vector dark-mode should support bulleted lists
		Resolved	Feature	None	T301887 Vector should use list-style: disc before its list-style-image declaration to support browsers with images disabled

Event Timeline

Jdrewniak triaged this task as High priority.Tue, May 14, 2:08 PM

Jdrewniak created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, May 14, 2:08 PM

Jdlrobson moved this task from Incoming to Groomed on the Web-Team-Backlog board.Tue, May 14, 6:19 PM

Looks like we can either invert or use a different SVG when the night theme classes are on the HTML element. However we are curious if we can remove the image altogether as we don't understand fully why it is there... @Volker_E may know?

Jdlrobson moved this task from Backlog to Ready for Development on the Web-Team-Backlog (FY2023-24 Q4 Sprint 3) board.Tue, May 14, 6:24 PM

bwang claimed this task.Tue, May 14, 11:26 PM

Jdlrobson moved this task from Ready for Development to Blocked on Others on the Web-Team-Backlog (FY2023-24 Q4 Sprint 3) board.Wed, May 15, 12:15 AM

Jdlrobson moved this task from Blocked on Others to Doing on the Web-Team-Backlog (FY2023-24 Q4 Sprint 3) board.

Change #1031950 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Remove list-style-image used by ul elements

https://gerrit.wikimedia.org/r/1031950

gerritbot added a project: Patch-For-Review.Wed, May 15, 3:01 PM

bwang removed bwang as the assignee of this task.Wed, May 15, 3:02 PM

bwang moved this task from Doing to Ready for Signoff on the Web-Team-Backlog (FY2023-24 Q4 Sprint 3) board.

bwang moved this task from Ready for Signoff to Code Review on the Web-Team-Backlog (FY2023-24 Q4 Sprint 3) board.

bwang subscribed.

Jdrewniak claimed this task.Wed, May 15, 4:26 PM

Change #1031950 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove list-style-image used by ul elements

https://gerrit.wikimedia.org/r/1031950

Jdlrobson reassigned this task from Jdrewniak to Edtadros.Wed, May 15, 6:59 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (FY2023-24 Q4 Sprint 3) board.

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).Wed, May 15, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Wed, May 15, 7:31 PM

Removing this SVG in light mode (and likely dark mode flipped) causes

Which is a good change in that having sublists appropriately indicated as sublists is good and has been one of my major twitch factors in Vector.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

Test Steps

Visit a page with bulleted lists on beta, e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Betafedf
Turn on dark mode from the appearance menu
✅ AC1: A bullet should be visible beside each list item

Edtadros updated the task description. (Show Details)Wed, May 15, 11:56 PM

Removing this styling entirely instead of replacing it with list-style: disc will make it worse to read the bullets in sublists, e. g.:

Please fix this patch as soon as possible so this weird list styling doesn’t make the lists worse to read.

Lofhi subscribed.Thu, May 16, 8:42 AM

@Izno I'm on team "Distinguishable sublists" but unfortunately this change was unintentional and goes beyond the scope of this specific task.
As @stjn points out, it has implications beyond content pages (for example, lists are widely used as discussion threads on ruwiki talk pages) so although I personally don't mind this change, I don't think it should be undertaken without broader community consultation (and should at least have it's own phab task).
For now, we'll add list-style: disc; back into the styles.

Change #1032826 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Override default sublist styles

https://gerrit.wikimedia.org/r/1032826

gerritbot added a project: Patch-For-Review.Fri, May 17, 3:46 PM

matmarex added a subtask: T301887: Vector should use list-style: disc before its list-style-image declaration to support browsers with images disabled.Fri, May 17, 6:04 PM

matmarex subscribed.

Change #1032826 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Override default sublist styles

https://gerrit.wikimedia.org/r/1032826

Maintenance_bot removed a project: Patch-For-Review.Fri, May 17, 9:30 PM

ovasileva moved this task from Ready for Signoff to Needs More Work on the Web-Team-Backlog (FY2023-24 Q4 Sprint 3) board.Mon, May 20, 9:41 AM

Jdlrobson assigned this task to Edtadros.Mon, May 20, 5:14 PM

Jdlrobson moved this task from Needs More Work to QA on the Web-Team-Backlog (FY2023-24 Q4 Sprint 3) board.

Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q4 Sprint 4); removed Web-Team-Backlog (FY2023-24 Q4 Sprint 3).Mon, May 20, 5:29 PM

Jdlrobson moved this task from Needs analysis to QA on the Web-Team-Backlog (FY2023-24 Q4 Sprint 4) board.Mon, May 20, 5:29 PM

Observed at euwiki

Theklan updated the task description. (Show Details)Tue, May 21, 3:35 PM

Jdlrobson moved this task from Backlog to Night mode (desktop) on the FY2023-24-WE 2.1 Typography and palette customizations board.Tue, May 21, 5:25 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

Test Steps

Visit a page with bulleted lists on beta, e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Betafedf
Turn on dark mode from the appearance menu
✅ AC1: A bullet should be visible beside each list item

Edtadros updated the task description. (Show Details)Wed, May 22, 9:32 PM

Jdrewniak closed subtask T301887: Vector should use list-style: disc before its list-style-image declaration to support browsers with images disabled as Resolved.Mon, May 27, 4:18 PM

Jdrewniak mentioned this in T301887: Vector should use list-style: disc before its list-style-image declaration to support browsers with images disabled.

Edtadros mentioned this in T365385: Verify 1.43.0-wmf.6 deployment.Tue, May 28, 10:05 PM

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 125
Device: MBA
Emulated Device:NA

Test Artifact(s):

Test Steps

Visit a page with bulleted lists on beta, e.g. https://en.wikipedia.org/wiki/Bullet_Points_(comics)
Turn on dark mode from the appearance menu
✅ AC1: A bullet should be visible beside each list item

2024-05-29_13-49-30.png (1×2 px, 422 KB)

GMikesell-WMF updated the task description. (Show Details)Wed, May 29, 8:52 PM

GMikesell-WMF added a project: Verified.Thu, May 30, 9:22 PM

Jdlrobson closed this task as Resolved.Fri, May 31, 1:18 AM

Jdlrobson claimed this task.

	F53196032: Screenshot 2024-05-14 at 10.04.30 AM.png
	Tue, May 14, 2:08 PM

	F53196018: Screenshot 2024-05-14 at 10.04.45 AM.png
	Tue, May 14, 2:08 PM

	F54160612: screenshot 368.png
	Wed, May 22, 9:32 PM

	F53402829: image.png
	Wed, May 15, 11:56 PM

	F53402601: screenshot 347.png
	Wed, May 15, 11:54 PM

	F53402473: image.png
	Wed, May 15, 11:54 PM

Vector dark-mode should support bulleted listsClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions

Description

Steps to reproduce

Expected results

Actual results

Check any additional observations

QA Results - Beta

QA Results - PROD

Details

Related ObjectsSearch...

Event Timeline

Test Result - Beta

Test Steps

Test Result - Beta

Test Steps

Test Result - PROD

Test Steps

Vector dark-mode should support bulleted lists
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Related Objects
Search...