Page MenuHomePhabricator
Create Task
Maniphest T365363

Table: Sort buttons overflow due to labels not wrapping
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:

Long sort button labels make the buttons overflow and cause the sort icon to be hidden. In <th>s with end alignment, the problem is more accentuated (see top screenshot) due to an unwanted white space being added to the end of the cell.

Screenshot 2024-05-17 at 15.44.05.png (668×2 px, 242 KB)
Screenshot 2024-05-17 at 15.45.21.png (1×2 px, 426 KB)

What should have happened instead?:

The text should wrap like non-sortable column headings

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia): Codex 1.6.0

Details

SubjectRepoBranchLines +/-
Update Codex from v1.6.0 to v1.6.1mediawiki/coremaster+739 -1 K
Table: Improve multiline sortable column headingsdesign/codexmain+1 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

AnneT created this task.Mon, May 20, 1:40 PM
Restricted Application edited projects, added Design-System-Team; removed Design-System-Team (DST-Sprint-23 (2024-05-13 to 2024-05-24)). · View Herald TranscriptMon, May 20, 1:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
AnneT mentioned this in T364636: Table: Design verification fixes.Mon, May 20, 1:42 PM
AnneT moved this task from Inbox to DST-Sprint-23 (2024-05-13 to 2024-05-24) on the Design-System-Team board.Mon, May 20, 4:05 PM
AnneT edited projects, added Design-System-Team (DST-Sprint-23 (2024-05-13 to 2024-05-24)); removed Design-System-Team.
AnneT changed the task status from Open to In Progress.Mon, May 20, 4:15 PM
AnneT claimed this task.
gerritbot added a comment.Mon, May 20, 4:41 PM

Change #1034120 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[design/codex@main] Table: Improve multiline sortable column headings

https://gerrit.wikimedia.org/r/1034120

gerritbot added a project: Patch-For-Review.Mon, May 20, 4:41 PM
AnneT moved this task from Committed to Code Review on the Design-System-Team (DST-Sprint-23 (2024-05-13 to 2024-05-24)) board.Mon, May 20, 4:43 PM
gerritbot added a comment.Tue, May 21, 3:00 AM

Change #1034120 merged by jenkins-bot:

[design/codex@main] Table: Improve multiline sortable column headings

https://gerrit.wikimedia.org/r/1034120

Maintenance_bot removed a project: Patch-For-Review.Tue, May 21, 3:31 AM
AnneT moved this task from Code Review to Design Sign-Off on the Design-System-Team (DST-Sprint-23 (2024-05-13 to 2024-05-24)) board.Tue, May 21, 12:28 PM

@Sarai-WMDE Ready for your review! I removed the nowrap style so that text within a sortable column heading will wrap just like any other column heading. This does mean that if you have a very long word, the column width will expand to accommodate it. I think we have to accept this - otherwise, if we break column heading text, you could end up with breaks in unexpected places like this:

image.png (566×1 px, 74 KB)

Sarai-WMDE added a comment.Tue, May 21, 1:23 PM

Thanks for the fix!

This does mean that if you have a very long word, the column width will expand to accommodate it.

That sounds good and reasonable. As long as all headings behave consistently, then it's all good! And, as far as I can tell based on the tests, that's the case 👍🏻 I didn't detect any follow-up issues.

(Changes were reviewed using the Netlify build on Chrome 125, Firefox 126 and Safari 17.3. OS: macOS Sonoma 14.3.)

AnneT moved this task from Design Sign-Off to Pending Release on the Design-System-Team (DST-Sprint-23 (2024-05-13 to 2024-05-24)) board.Tue, May 21, 6:02 PM
gerritbot added a comment.Wed, May 29, 3:40 PM

Change #1037103 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update Codex from v1.6.0 to v1.6.1

https://gerrit.wikimedia.org/r/1037103

gerritbot added a project: Patch-For-Review.Wed, May 29, 3:40 PM
PatchDemoBot added a comment.Wed, May 29, 5:35 PM

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/ce0a74a0e6/w

gerritbot added a comment.Wed, May 29, 6:43 PM

Change #1037103 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.6.0 to v1.6.1

https://gerrit.wikimedia.org/r/1037103

Maintenance_bot removed a project: Patch-For-Review.Wed, May 29, 7:31 PM
AnneT closed this task as Resolved.Wed, May 29, 8:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL