Add hook before changing of userrights
Open, LowPublic
Actions

Assigned To

None

Authored By

	• bzimport
	Apr 17 2013, 8:46 PM

Description

Author: trollingstone

Description:
I can do it with following code in includes/specials/SpecialUserrights.php:

    global $wgUserrightsProtectedUsers;
    if( in_array( User::getCanonicalName( $this->mTarget ), $wgUserrightsProtectedUsers ) ) {
        $out = $this->getOutput();
        $out->setPageTitle( 'Forbidden' );
        $out->addHTML('In the name of Holy Federal Security Service, you can't modify groups of this user.');
        return true;
}

More cleanly do it with hook.

good first task: The hook now exists but can't be aborted. Add that functionality in order to fully address the original request.

Details

Reference: bz47338

	Subject	Repo	Branch	Lines +/-
	Allow aborting changing userrights using `ChangeUserGroups` hook	mediawiki/core	master	+6 -2
	Add a 'ChangeUserGroups' hook in Special:Userrights	mediawiki/core	master	+8 -0

Customize query in gerrit

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:15 AM

• bzimport added a project: MediaWiki-Special-pages.

• bzimport set Reference to bz47338.

• bzimport added a subscriber: Unknown Object (MLST).

• bzimport created this task.Apr 17 2013, 8:46 PM

• Reguyla moved this task from To triage to User/User rights on the MediaWiki-Special-pages board.May 26 2015, 11:57 AM

Florian subscribed.Oct 9 2015, 9:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2015, 9:54 PM

Change 329727 had a related patch set uploaded (by MtDu):
Add a 'ChangeUserGroups' hook in Special:Userrights

https://gerrit.wikimedia.org/r/329727

gerritbot added a project: Patch-For-Review.Dec 31 2016, 2:45 AM

Patch has been merged here. https://gerrit.wikimedia.org/r/#/c/329727/ Hence closing as resolved.
Thanks!

Change 329727 merged by jenkins-bot:
Add a 'ChangeUserGroups' hook in Special:Userrights

https://gerrit.wikimedia.org/r/329727

This isn't done yet... we still need to add the possibility to allow the hook to abort the process if it wants to. I'll do this after the user rights expiration stuff is sorted out

ReleaseTaggerBot added projects: MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), MW-1.29-release-notes.Dec 31 2016, 4:00 AM

matej_suchanek removed MtDu as the assignee of this task.Dec 31 2016, 10:29 AM

matej_suchanek removed a project: Patch-For-Review.

matej_suchanek updated the task description. (Show Details)

matej_suchanek removed a subscriber: • wikibugs-l-list.

TTO added a project: good first task.Apr 27 2017, 2:27 AM

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 27 2017, 2:27 AM

TTO updated the task description. (Show Details)Apr 27 2017, 2:28 AM

My exams end on May 12, Can take a look then. Feel free to if you're up to it. @TTO

Krinkle edited projects, added MediaWiki-User-management; removed MediaWiki-Special-pages.May 8 2017, 12:00 AM

Krinkle moved this task from Backlog to User rights on the MediaWiki-User-management board.May 8 2017, 12:01 AM

Krinkle removed projects: MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)).May 25 2017, 2:00 PM

DannyS712 claimed this task.Sep 22 2019, 2:35 AM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptSep 22 2019, 2:35 AM

DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.Sep 22 2019, 2:35 AM

Change 542662 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Allow aborting changing userrights using ChangeUserGroups hook

https://gerrit.wikimedia.org/r/542662

gerritbot added a project: Patch-For-Review.Oct 12 2019, 8:02 AM

Tagging Contributors-Team for review, per https://www.mediawiki.org/wiki/Developers/Maintainers

Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Feb 3 2022, 4:25 PM

Removing task assignee due to inactivity, as this open task has been assigned for more than two years. See the email sent to the task assignee on February 06th 2022 (and T295729).

Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome.

If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".

Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.

Add hook before changing of userrightsOpen, LowPublicActions

Description

Details

Event Timeline

Add hook before changing of userrights
Open, LowPublic
Actions