Page MenuHomePhabricator

DanielFriesen (dantman)
Daniel Friesen

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Dec 10 2014, 4:42 AM (489 w, 4 d)
Availability
Available
IRC Nick
Dantman
LDAP User
Daniel Friesen
MediaWiki User
Dantman [ Global Accounts ]

Daniel Friesen is also known as Dantman and Nadir Seen Fire.

https://www.mediawiki.org/wiki/User:Dantman

Recent Activity

Nov 14 2023

Bugreporter2 awarded T34620: Support for root /Foo style pretty urls a Like token.
Nov 14 2023, 4:12 AM · MediaWiki-General

May 25 2023

DanielFriesen committed rENBU42e019461b71: Update the NoBogusUserpages extension to use proper i18n files and ditch the….
Update the NoBogusUserpages extension to use proper i18n files and ditch the…
May 25 2023, 6:54 PM
DanielFriesen committed rENBU9e0813ea0f0a: Commit my old NoBogusUserpages extension as-is..
Commit my old NoBogusUserpages extension as-is.
May 25 2023, 6:54 PM
DanielFriesen committed rENBUbc33a3ebe3fc: Add right- i18n..
Add right- i18n.
May 25 2023, 6:54 PM

Jan 11 2023

Bugreporter2 awarded T40048: Root article paths allow creating local-like links to external sites (bypass nofollow, attacks Special:Random) a Heartbreak token.
Jan 11 2023, 9:13 AM · MediaWiki-Parser

May 5 2022

DanielFriesen created T307721: Archive/delete tool extensionservice.
May 5 2022, 4:15 PM · Projects-Cleanup, Tools, Toolforge (Tools to be deleted)

Apr 10 2019

DanielFriesen added a comment to T220432: Clean up "easter egg" short URLs before extension goes live.

I like the idea of using two-letter codes for language projects though you obviously run into the issue of only being able to link to one project in that language that way (e.g. w.wiki/de would presumably go to de.wikipedia.org, not de.wiktionary.org, etc).

Apr 10 2019, 8:19 AM · MediaWiki-extensions-UrlShortener

Nov 11 2018

Liuxinyu970226 awarded T66731: Support dark skins (tracking) a Like token.
Nov 11 2018, 12:53 PM · Other-skins, Accessibility, Tracking-Neverending, MediaWiki-User-Interface

Oct 11 2017

DanielFriesen added a comment to T177949: Extension:Sudo cannot "return to your account" for a blocked account.

Not sure if @DanielFriesen still maintains this codebase?

Oct 11 2017, 7:33 PM · Patch-For-Review, MediaWiki-extensions-Sudo

Jul 17 2017

Volker_E awarded T43296: Footer does not have an assistive header a Like token.
Jul 17 2017, 7:13 PM · Vector (legacy skin), Accessibility, MediaWiki-User-Interface

Nov 18 2016

DanielFriesen added a comment to T18435: New extension to enforce minimum password strength..

@Verdy_p Hand rolling our own algorithm doesn't sound very great. IMHO a better idea, which is also easier, would just be to use zxcvbn.

Nov 18 2016, 12:05 AM · MediaWiki-extension-requests

Oct 17 2016

DanielFriesen added a comment to T147817: Update.php should allow for a wiki parameter.

I'm not sure how $wgConf works.

Oct 17 2016, 12:51 AM · Patch-For-Review, MediaWiki-Maintenance-system
DanielFriesen added a comment to T147817: Update.php should allow for a wiki parameter.

Not all wiki families are separated by domain; some use paths instead and this pattern will break for that.

Oct 17 2016, 12:36 AM · Patch-For-Review, MediaWiki-Maintenance-system

May 7 2016

DanielFriesen added a comment to T132104: Consider moving policy.wikimedia.org away from WordPress.com .

@ashley They just want to use MW to host the policy pages rather than use it like an actual wiki. So omitting things like content_actions and just switching to Vector for logged in users should be fine.

May 7 2016, 12:14 AM · Privacy Engineering, WMF-Legal, SRE, Privacy

May 6 2016

DanielFriesen added a comment to T40417: MediaWiki's anonymous edit token leaves wiki installations (incl. Wikipedia) open to mass anonymous spam we can't block.

@brion Also some privacy software / virus suites / intermediate proxies supposedly strip out the Referer header as well.

May 6 2016, 8:47 AM · Patch-Needs-Improvement, Security, MediaWiki-Core-AuthManager, TechCom-RFC

May 4 2016

DanielFriesen added a comment to T40417: MediaWiki's anonymous edit token leaves wiki installations (incl. Wikipedia) open to mass anonymous spam we can't block.

We can potentially avoid session inflation by creating the session separately from creating the edit html (which would indeed allow session inflation if an attacker requests edit urls repeatedly without cookies enabled). For example, we could start the session from JavaScript on the edit page in a background request (AJAX).

I don't understand how that would help the session inflation problem. The problem (if it still is a problem) is too many users have cookies on the client side, bypassing varnish. Using too much space in redis/whatever to store sessions on the server side, is not the problem (as far as I am aware). Creating sessions with javascript should not make a difference in that context

May 4 2016, 10:43 PM · Patch-Needs-Improvement, Security, MediaWiki-Core-AuthManager, TechCom-RFC
DanielFriesen added a comment to T40417: MediaWiki's anonymous edit token leaves wiki installations (incl. Wikipedia) open to mass anonymous spam we can't block.

@Krinkle Javascript! Thanks, I just noticed a factor I wasn't taking into account this whole time.

May 4 2016, 1:24 PM · Patch-Needs-Improvement, Security, MediaWiki-Core-AuthManager, TechCom-RFC

Mar 18 2016

DanielFriesen added a comment to T130040: Remove $wgAllowMicrodataAttributes and $wgAllowRdfaAttributes settings.

Somewhat relevant old RFC; for which code was completed but simply halted because no-one would review it.
https://www.mediawiki.org/wiki/Requests_for_comment/Update_our_code_to_use_RDFa_1.1_instead_of_RDFa_1.0

Mar 18 2016, 3:55 AM · MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-03-22_(1.27.0-wmf.18)), Patch-For-Review, MediaWiki-Parser

Jan 13 2016

DanielFriesen added a comment to T118932: RfC: Raise MediaWiki's PHP version requirement to 5.5 and update coding standards.

Practically speaking, there is a huge difference: Ubuntu 14.04 LTS comes with PHP 5.5 and will be supported until 2019. You can't get anything like that for PHP 5.3.

How is that a practical difference? PHP 5.5 stops getting security fixes six months from now. (link) Is Ubuntu going to write/backport security fixes themselves?

Jan 13 2016, 7:53 PM · TechCom-RFC (TechCom-RFC-Closed), Proposal, MW-1.27-release

Dec 3 2015

DanielFriesen added a comment to T118932: RfC: Raise MediaWiki's PHP version requirement to 5.5 and update coding standards.

I think that 1.27 should ship with 5.3 or 5.4, and then move to 5.6 after the LTS, Given how difficult it is to get third party hosting providers to update php we shouldn't use our LTS to move to a cutting edge version. Lets use 1.28 for that.

Dec 3 2015, 3:12 AM · TechCom-RFC (TechCom-RFC-Closed), Proposal, MW-1.27-release

Nov 6 2015

DanielFriesen added a comment to T107561: MediaWiki support for Composer equivalent for JavaScript packages.

Daniel Friesen mentioned browserify as a major contributor to the move of client-side libraries to npm, although he warned that there were essential conflicts between "server side" and "client side" users of npm which would lead to confusion and delay as more client-side packages migrated. He also made some ResourceLoader-specific points which I don't feel confident recapping accurately.

Nov 6 2015, 6:07 PM · MediaWiki-Platform-Team, MediaWiki-ResourceLoader, Developer-Wishlist (2017), TechCom-RFC, Front-end-Standards-Group

Oct 5 2015

DanielFriesen added a comment to T30085: RFC: Allow user login with email address in addition to username.

@Tgr Then keeping old email addresses as same as now and only saving new email addresses as lowercase would be ideal?

Oct 5 2015, 4:46 AM · I18n, MediaWiki-User-login-and-signup

Oct 4 2015

DanielFriesen added a comment to T113826: nodejs jobs fail with a v8 fatal error.

You're right. I also tested with 500MB before, but it looks like Node.js requires 1GB of ram even for something as simple as this script:

console.log('...');
Oct 4 2015, 4:24 PM · Toolforge, Cloud-Services

Oct 2 2015

DanielFriesen added a comment to T114432: [RFC] Heredoc arguments for templates (aka "hygienic" or "long" arguments).

While the intention is to try and make things easier. This change basically adds a brand new unintuitive piece of syntax that now everyone has to learn.

Oct 2 2015, 3:03 AM · MediaWiki-Templates, Patch-Needs-Improvement, TechCom-RFC (TechCom-RFC-Closed), Parsing-Team--ARCHIVED, Wikimedia-Developer-Summit-2016

Oct 1 2015

DanielFriesen added a comment to T30085: RFC: Allow user login with email address in addition to username.
In T30085#1691937, @Tgr wrote:

where 1 has poor usability (why does my password not work?)

"We cannot log you in because this email address is being claimed by more than one Wikimedia account. You can log in using your username, and you can change your email address in your Preferences."

Oct 1 2015, 2:03 PM · I18n, MediaWiki-User-login-and-signup

Sep 26 2015

DanielFriesen created T113826: nodejs jobs fail with a v8 fatal error.
Sep 26 2015, 12:10 AM · Toolforge, Cloud-Services

Sep 25 2015

DanielFriesen added a comment to T113210: How should Wikimedia software support non-Wikimedia deployments of its software?.

At least DigitalOcean has small $5/mo servers.

Sep 25 2015, 7:59 PM · Wikimedia-Developer-Summit-2016

Sep 24 2015

DanielFriesen added a comment to T113210: How should Wikimedia software support non-Wikimedia deployments of its software?.

Packages often do weird things with dependencies, so if you plan to install apache+php+mediawiki on one server, and mysql on other server, but the package marks a database server as required, you will end installing mysqlserver on the webserver where you don't want it, or else it won't install. This is something to consider.

Sep 24 2015, 7:59 PM · Wikimedia-Developer-Summit-2016

Jul 30 2015

DanielFriesen closed T35422: Credit card form should not be replaced if we're already on the correct type of credit card form as Resolved.

The issue doesn't appear to exist anymore. Either the donation form changed or LastPass made some improvements.

Jul 30 2015, 10:29 PM · Wikimedia-Fundraising

Jul 24 2015

Vedmaka awarded T57475: Make MediaWiki run on Google's App Engine a Like token.
Jul 24 2015, 11:24 AM · MediaWiki-extension-requests

May 27 2015

Ricordisamoa awarded T37045: Use history.replaceState to rewrite redirect urls a Dislike token.
May 27 2015, 4:32 PM · MediaWiki-Redirects, MW-1.24-release

Apr 9 2015

DanielFriesen moved T14619: Use article path URLs for editing, previewing skins, etc. from Approved to Under discussion on the TechCom-RFC board.
Apr 9 2015, 10:46 PM · Proposal, TechCom-RFC (TechCom-RFC-Closed), OKR-Work, WMF-General-or-Unknown
DanielFriesen added a comment to T95625: craft robots.txt to intelligently exclude dynamic pages with cleaner URLs.

I also brought up currently existing bugs and flaws:
The possibility we might actually want Allpages to be reasonably indexable (potentially helpful to smaller wiki).

Apr 9 2015, 10:45 PM · Wikimedia-Apache-configuration, WMF-General-or-Unknown
DanielFriesen added a comment to T14619: Use article path URLs for editing, previewing skins, etc..

Why was the RFC simply accepted with absolutely no discussion over the negative effects of blacklisting /wiki/*? which I brought up on wikitech-l and on the RFC's talkpage:

Apr 9 2015, 2:06 AM · Proposal, TechCom-RFC (TechCom-RFC-Closed), OKR-Work, WMF-General-or-Unknown

Mar 11 2015

Gerrit Code Review <gerrit@wikimedia.org> committed rMEXTd87d92ebf742: Updated mediawiki/extensions Project: mediawiki/extensions/Negref… (authored by DanielFriesen).
Updated mediawiki/extensions Project: mediawiki/extensions/Negref…
Mar 11 2015, 5:43 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXTe8409db389c1: Updated mediawiki/extensions Project: mediawiki/extensions/OpenGraphMeta… (authored by DanielFriesen).
Updated mediawiki/extensions Project: mediawiki/extensions/OpenGraphMeta…
Mar 11 2015, 5:43 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXT28ff64c55972: Updated mediawiki/extensions Project… (authored by DanielFriesen).
Updated mediawiki/extensions Project…
Mar 11 2015, 5:43 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXT044aa16209eb: Updated mediawiki/extensions Project: mediawiki/extensions/Sudo… (authored by DanielFriesen).
Updated mediawiki/extensions Project: mediawiki/extensions/Sudo…
Mar 11 2015, 5:43 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXT9c7db73e6c38: Updated mediawiki/extensions Project: mediawiki/extensions/NamespacePaths… (authored by DanielFriesen).
Updated mediawiki/extensions Project: mediawiki/extensions/NamespacePaths…
Mar 11 2015, 5:43 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXTdcbfceb3f205: Updated mediawiki/extensions Project: mediawiki/extensions/ReplaceSet… (authored by DanielFriesen).
Updated mediawiki/extensions Project: mediawiki/extensions/ReplaceSet…
Mar 11 2015, 5:43 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXTe2961d57abe4: Updated mediawiki/extensions Project: mediawiki/extensions/Description2… (authored by DanielFriesen).
Updated mediawiki/extensions Project: mediawiki/extensions/Description2…
Mar 11 2015, 5:43 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXTf2ba314ac8a4: Updated mediawiki/extensions Project: mediawiki/extensions/ThemeDesigner… (authored by DanielFriesen).
Updated mediawiki/extensions Project: mediawiki/extensions/ThemeDesigner…
Mar 11 2015, 5:43 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXT66fca0aee238: Updated mediawiki/extensions Project: mediawiki/extensions/SwarmExport… (authored by DanielFriesen).
Updated mediawiki/extensions Project: mediawiki/extensions/SwarmExport…
Mar 11 2015, 5:43 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXT755567011551: Updated mediawiki/extensions Project: mediawiki/extensions/StarterWiki… (authored by DanielFriesen).
Updated mediawiki/extensions Project: mediawiki/extensions/StarterWiki…
Mar 11 2015, 5:43 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXTe755e1aa9c45: Updated mediawiki/extensions Project: mediawiki/extensions/SidebarDonateBox… (authored by DanielFriesen).
Updated mediawiki/extensions Project: mediawiki/extensions/SidebarDonateBox…
Mar 11 2015, 5:43 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXTaa932428ae7a: Updated mediawiki/extensions Project: mediawiki/extensions/Math… (authored by DanielFriesen).
Updated mediawiki/extensions Project: mediawiki/extensions/Math…
Mar 11 2015, 5:21 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXT1d98c8a36ad1: Updated mediawiki/extensions Project: mediawiki/extensions/ReplaceSet… (authored by DanielFriesen).
Updated mediawiki/extensions Project: mediawiki/extensions/ReplaceSet…
Mar 11 2015, 5:03 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXT8b5554f191f9: Updated mediawiki/extensions Project: mediawiki/extensions/ReplaceSet… (authored by DanielFriesen).
Updated mediawiki/extensions Project: mediawiki/extensions/ReplaceSet…
Mar 11 2015, 5:03 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXT81d6fe9e8c5f: Updated mediawiki/extensions Project: mediawiki/extensions/ReplaceSet… (authored by DanielFriesen).
Updated mediawiki/extensions Project: mediawiki/extensions/ReplaceSet…
Mar 11 2015, 5:03 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXT6c213375ab6e: Updated mediawiki/extensions Project: mediawiki/extensions/SemanticMediaWiki… (authored by DanielFriesen).
Updated mediawiki/extensions Project: mediawiki/extensions/SemanticMediaWiki…
Mar 11 2015, 4:57 AM

Mar 3 2015

DanielFriesen committed rOMWC726737d9308b: Use $wgHiddenPrefs to hide real name..
Use $wgHiddenPrefs to hide real name.
Mar 3 2015, 8:48 PM

Mar 1 2015

DanielFriesen created T91183: Make MobileFrontend add a mobile rel=alternative to the desktop version instead of noindexing mobile pages.
Mar 1 2015, 3:24 AM · MobileFrontend, Web-Team-Backlog

Feb 28 2015

DanielFriesen added a comment to T89456: Merge new fields in extension.json into Composer's composer.json.

Note that in the case of licenses our license-name may need an upgrade.

What do you mean? Both 'schemas' use SPDX codes:

Feb 28 2015, 2:42 AM · Composer, MediaWiki-extensions-General

Feb 27 2015

DanielFriesen added a comment to T89456: Merge new fields in extension.json into Composer's composer.json.

Of course they can't be deduplicated right now, but some of them (except for name and description, as @DanielFriesen pointed out) are actually redundant between the two .json files.

Feb 27 2015, 3:49 PM · Composer, MediaWiki-extensions-General

Feb 23 2015

DanielFriesen added a comment to T89456: Merge new fields in extension.json into Composer's composer.json.

Another note on something I noticed,
https://getcomposer.org/doc/02-libraries.md#specifying-the-version

Feb 23 2015, 8:51 PM · Composer, MediaWiki-extensions-General

Feb 21 2015

DanielFriesen added a comment to T89456: Merge new fields in extension.json into Composer's composer.json.

I think you did a good job of this. Thanks, especially, for identifying
why description might not work. I suggest that we talk to the SMW devs
about that one.
...
I agree with the caveat that I think there may be a way to compromise on
description.

Feb 21 2015, 6:35 PM · Composer, MediaWiki-extensions-General

Feb 20 2015

DanielFriesen added a comment to T89456: Merge new fields in extension.json into Composer's composer.json.

There was some discussion during the meeting about being able to refer to composer.json from extension.json if it contains the information already in order to reduce duplication.

I would suggest that we fall back to reading composer.json if it exists and an extension.json does not exist. This would allow us to gather basic author and name information for display on Special:Version.

Feb 20 2015, 8:29 PM · Composer, MediaWiki-extensions-General

Feb 17 2015

DanielFriesen added a comment to T18691: RFC: Section header "share" link.

From what I can see in Resources.php, loading only the (default) skinning/elements.css and not content.css or interface.css.

So, why is this CSS not in skinning/elements.css? That's where headers and links are styled for all skins.

Feb 17 2015, 2:41 PM · Tech Ambassadors & Translators, User-Jdlrobson, Platform Team Workboards (Clinic Duty Team), TechCom-RFC, Design, MediaWiki-User-Interface
DanielFriesen added a comment to T89456: Merge new fields in extension.json into Composer's composer.json.

I came to the conclusion that for the repositories I'm involved extension.json brings no benefit nor does maintaining information in two files (composer.json and extension.json) is time well spent. For us composer.json has functional relevance but extension.json has not therefore I can't see any motivation to actually maintain such a file.

Feb 17 2015, 12:45 PM · Composer, MediaWiki-extensions-General

Feb 16 2015

DanielFriesen added a comment to T89456: Merge new fields in extension.json into Composer's composer.json.

At least: name, description, homepage, author and license should not be duplicated between the two.

Feb 16 2015, 7:33 PM · Composer, MediaWiki-extensions-General

Jan 10 2015

DanielFriesen added a comment to T22553: User "Default Skin" preference.

@Paladox this is about allowing users to explicitly pick a skin that happens to be the default (and won't change if the default is changed) or explicitly pick the site default skin (so it will change when the default changes). So it is not done.

Jan 10 2015, 4:28 AM · MediaWiki-Core-Preferences

Jan 6 2015

Addshore awarded T57475: Make MediaWiki run on Google's App Engine a Mountain of Wealth token.
Jan 6 2015, 2:08 PM · MediaWiki-extension-requests

Jan 2 2015

DanielFriesen added a comment to T33874: Preferences and lang codes should distinguish "English" from "American English"/"U.S. English".

en is already en-US, there's no point confusing people by having them both in preferences.

Jan 2 2015, 3:58 PM · User-notice, Patch-For-Review, MediaWiki-Internationalization
DanielFriesen added a comment to T33874: Preferences and lang codes should distinguish "English" from "American English"/"U.S. English".

We shouldn't be so quick to throw away "en". There is such a thing as International English, after all, so "en" doesn't necessarily have to refer to American English. Also, if we only have en-US, en-GB and en-CA, it doesn't leave any other category for other Englishes, of which there are quite a few. I imagine quite a few Australians may prefer "en" over "en-GB", for example, even though the spelling may be closer in the latter. Also, we shouldn't forget dialects like Indian English and Singlish. Perhaps English speakers of those dialects could get by with en-GB, but perhaps not; more investigation is needed, I think.

Jan 2 2015, 3:07 PM · User-notice, Patch-For-Review, MediaWiki-Internationalization