Page MenuHomePhabricator
Create Task
Maniphest T54037

Strip annotations (e.g. bold, italics, link) from terminal whitespace
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Author: robindinse

Description:
VisualEdtior often produces garbage like this:

  • non-bold''' bold'''.
  • italic'' ''whitespace.

Version: unspecified
Severity: enhancement

Details

Reference
bz52037
SubjectRepoBranchLines +/-
Trim leading and trailing whitespace from annotationsVisualEditor/VisualEditormaster+90 -10
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 1:47 AM
• bzimport added a project: VisualEditor-DataModel.
• bzimport set Reference to bz52037.
• bzimport created this task.Jul 25 2013, 4:42 PM
Jdforrester-WMF added a comment.Jul 25 2013, 5:16 PM

On saving, we should remove newly-added annotations from terminal whitespace (so that:

<b data-parsoid="…"> <i>Foo bar</b> </i>

turns into

<b data-parsoid="…"> <i>Foo bar</i></b>

This would fix bug 37835, too.

Jdforrester-WMF added a comment.Nov 6 2013, 7:52 PM
  • Bug 54270 has been marked as a duplicate of this bug. ***
Jdforrester-WMF added a comment.Mar 11 2014, 1:36 AM
  • Bug 58605 has been marked as a duplicate of this bug. ***
Jdforrester-WMF added a comment.Oct 3 2014, 7:53 PM
  • Bug 71620 has been marked as a duplicate of this bug. ***
• Whatamidoing-WMF added a comment.Oct 3 2014, 8:24 PM

Bug 71620 has instructions on how to replicate this for wikilinks.

Jdforrester-WMF added a project: VisualEditor.Nov 23 2014, 10:47 PM
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Nov 24 2014, 1:28 AM
Jdforrester-WMF lowered the priority of this task from High to Medium.Jan 9 2015, 10:55 PM
gpaumier set Security to None.Mar 12 2015, 4:31 PM
gpaumier added subscribers: gpaumier, Eloquence.
gpaumier added a project: VisualEditor 2014/15 Q3 blockers.Mar 31 2015, 5:40 PM
Jdforrester-WMF edited projects, added VisualEditor 2014/15 Q4 blockers; removed VisualEditor 2014/15 Q3 blockers.Apr 1 2015, 12:18 AM
Jdforrester-WMF moved this task from Nominated to Backlog on the VisualEditor 2014/15 Q4 blockers board.Apr 1 2015, 6:30 PM
Jdforrester-WMF edited a custom field.Apr 1 2015, 7:00 PM
Catrope edited a custom field.Apr 2 2015, 8:48 PM
gerritbot subscribed.Apr 2 2015, 8:49 PM

Change 201583 had a related patch set uploaded (by Catrope):
Trim leading and trailing whitespace from annotations

https://gerrit.wikimedia.org/r/201583

gerritbot added a project: Patch-For-Review.Apr 2 2015, 8:49 PM
Jdforrester-WMF moved this task from Backlog to Doing on the VisualEditor 2014/15 Q4 blockers board.Apr 2 2015, 10:26 PM
gpaumier mentioned this in T94767: Perform a weekly review of edits made with VisualEditor.Apr 3 2015, 5:47 PM
Esanders subscribed.Apr 7 2015, 7:36 PM

This should fall under Parsoid's HTML sanitisation run, along with empty headings, as this problem is not unique to VE.

Jdforrester-WMF added a comment.Apr 8 2015, 7:45 AM
In T54037#1187185, @Esanders wrote:

This should fall under Parsoid's HTML sanitisation run, along with empty headings, as this problem is not unique to VE.

I disagree. This is about creating nicer HTML, and isn't specific to VE-MW.

Jdforrester-WMF renamed this task from VisualEditor: Strip annotations (e.g. bold, italics, link) from terminal whitespace to Strip annotations (e.g. bold, italics, link) from terminal whitespace.Apr 16 2015, 5:20 PM
Jdforrester-WMF closed this task as Resolved.
Jdforrester-WMF edited projects, added WMF-deploy-2015-04-22_(1.26wmf3); removed Patch-For-Review.
Jdforrester-WMF moved this task from Doing to Done on the VisualEditor 2014/15 Q4 blockers board.
gerritbot added a comment.Apr 16 2015, 5:22 PM

Change 201583 merged by jenkins-bot:
Trim leading and trailing whitespace from annotations

https://gerrit.wikimedia.org/r/201583

Catrope mentioned this in rGVED8dc8b266761d: Trim leading and trailing whitespace from annotations.Apr 16 2015, 5:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL