Page MenuHomePhabricator
Create Task
Maniphest T77916

ButtonSelectWidget active item should not have hover or click effects.
Closed, ResolvedPublic
Actions

Description

Currently on https://en.m.wikipedia.org/wiki/Special:EditWatchlist the active (blue) items has a hover and click behavior, which is confusing.

T77916 ButtonOptionWidget active state default or pointer screencast 2016-04-20.mp41 MBDownload

In OOjs UI the ButtonSelectWidget active item carries a pointer as cursor, which it shouldn't.

Details

SubjectRepoBranchLines +/-
Allow ButtonGroupWidget/SelectWidget buttons to spill on to new linesoojs/uimaster+26 -22
ButtonOptionWidget active state should carry default cursoroojs/uimaster+4 -0
mediawiki.ui: Button group active buttons unchanged on user interactionmediawiki/coremaster+22 -15
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Jaredzimmerman-WMF created this task.Dec 8 2014, 9:12 PM
• Jaredzimmerman-WMF raised the priority of this task from to Needs Triage.
• Jaredzimmerman-WMF updated the task description. (Show Details)
• Jaredzimmerman-WMF added a project: UI-Standardization.
• Jaredzimmerman-WMF changed Security from none to None.
• Jaredzimmerman-WMF added subscribers: • Jaredzimmerman-WMF, • Prtksxna.
• Spage subscribed.EditedDec 8 2014, 10:25 PM

But sometimes the user should be able to reload the active item, e.g. to refresh it. Mobile adds class mw-ui-progressive to the active button to make it blue, which encourages the user to click it, and it does reload. If the button clicking should do nothing then that's a bug in the mobile implementation.

If clicking a button should do nothing then it should have attribute disabled, but that tends to mute the button (except it has no effect in a mw-ui-button-group).
Mobile also adds class active to the active button but that seems to have no styling associated with it; mediawiki.ui doesn't have any styling for active or selected.

I think we're conflating the "active" button in a button group with its progressive/constructive/destructive semantics, and with whether it's disabled or not. Button groups in the style guide seems too bare-bones.

Volker_E moved this task from Unsorted to Current Quarterly Goals on the UI-Standardization board.Oct 1 2015, 9:38 PM
• violetto added a parent task: T113560: Standardize MediaWiki components (tracking).Oct 2 2015, 9:28 PM
Volker_E renamed this task from Button group active item should not have hover or click effects. to ButtonGroup/-Select/ToggleButtonWidget active item should not have hover or click effects..Oct 10 2015, 9:04 AM
Volker_E updated the task description. (Show Details)
Volker_E added a project: OOUI.
Volker_E subscribed.

This doesn't only affect (older) mediawiki-ui, but also OOjs UI

Volker_E added a comment.Oct 10 2015, 10:04 AM

Err, ButtonGroupWidgets are not affected.

Volker_E renamed this task from ButtonGroup/-Select/ToggleButtonWidget active item should not have hover or click effects. to ButtonSelect/ToggleButtonWidget active item should not have hover or click effects..Oct 13 2015, 2:31 AM
Volker_E added a comment.Oct 28 2015, 10:41 PM

ToggleButtonWidget shouldn't be changed as well, as ToggleButtonWidget has a click function when in -active state.

Volker_E renamed this task from ButtonSelect/ToggleButtonWidget active item should not have hover or click effects. to ButtonSelectWidget active item should not have hover or click effects..Oct 28 2015, 10:41 PM
gerritbot subscribed.Oct 29 2015, 1:51 AM

Change 249295 had a related patch set uploaded (by VolkerE):
Allow ButtonGroupWidget/SelectWidget buttons to spill on to new lines

https://gerrit.wikimedia.org/r/249295

gerritbot added a project: Patch-For-Review.Oct 29 2015, 1:51 AM
Jdforrester-WMF triaged this task as Low priority.Nov 17 2015, 1:37 AM
Jdforrester-WMF moved this task from Backlog to Doing on the OOUI board.
gerritbot added a comment.Jan 6 2016, 7:37 PM

Change 249295 abandoned by Jdlrobson:
Allow ButtonGroupWidget/SelectWidget buttons to spill on to new lines

Reason:
I have no plans to work on this anymore. Feel free to reassign author to someone else.

https://gerrit.wikimedia.org/r/249295

gerritbot added a comment.Feb 23 2016, 3:45 AM

Change 272663 had a related patch set uploaded (by VolkerE):
ButtonOptionWidget active state should carry default cursor

https://gerrit.wikimedia.org/r/272663

gerritbot added a comment.Feb 23 2016, 8:30 AM

Change 272681 had a related patch set uploaded (by VolkerE):
mediawiki.ui: Button group active buttons unchanged on user interaction

https://gerrit.wikimedia.org/r/272681

• ggellerman edited projects, added UI-Standardization-Kanban; removed UI-Standardization.Feb 23 2016, 7:25 PM
• ggellerman moved this task from Backlog to Current Goals (tracking) on the UI-Standardization-Kanban board.Feb 23 2016, 7:27 PM
Jdforrester-WMF moved this task from Doing to Backlog on the OOUI board.Mar 2 2016, 1:59 AM
Volker_E moved this task from Current Goals (tracking) to Doing… on the UI-Standardization-Kanban board.Mar 3 2016, 3:24 AM
gerritbot added a comment.Mar 3 2016, 8:39 PM

Change 272681 merged by jenkins-bot:
mediawiki.ui: Button group active buttons unchanged on user interaction

https://gerrit.wikimedia.org/r/272681

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-03-08_(1.27.0-wmf.16)).Mar 3 2016, 9:00 PM
Majr subscribed.Mar 4 2016, 6:54 AM

is-on seems like a far too generic classname to me. Should be something like mw-ui-button-active.

Volker_E moved this task from Doing… to Review on the UI-Standardization-Kanban board.Mar 7 2016, 11:06 PM
Jdforrester-WMF moved this task from Backlog to Next-up on the OOUI board.Mar 8 2016, 11:18 PM
Volker_E updated the task description. (Show Details)Apr 20 2016, 9:27 PM
Volker_E updated the task description. (Show Details)Apr 20 2016, 11:07 PM
Danny_B added a project: UI-Standardization.May 23 2016, 6:26 AM
Danny_B moved this task from Current Quarterly Goals to OOUI on the UI-Standardization board.May 23 2016, 6:47 AM
Jdforrester-WMF moved this task from Next-up to Reviewing on the OOUI board.May 30 2016, 5:29 PM
Jdforrester-WMF closed this task as Resolved.Sep 10 2016, 1:06 AM
Jdforrester-WMF assigned this task to Volker_E.
Jdforrester-WMF moved this task from Reviewing to OOjs-UI-0.17.9 on the OOUI board.
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.17.9); removed OOUI.
gerritbot added a comment.Sep 10 2016, 1:12 AM

Change 272663 merged by jenkins-bot:
ButtonOptionWidget active state should carry default cursor

https://gerrit.wikimedia.org/r/272663

Volker_E removed a project: Patch-For-Review.Sep 10 2016, 6:05 PM
Volker_E moved this task from Review to Done on the UI-Standardization-Kanban board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL