Page MenuHomePhabricator
Create Task
Maniphest T86715

Regression: No longer able to insert characters using CharInsert gadget based on extension after 1.25wmf14 roll-out.
Closed, ResolvedPublic
Actions

Description

CONFIRMED - Same thing happens on www.mediawiki.org as it did on en.wikisource.org

Open any page to edit mode and try to insert any character from the CharInsert bar to the textarea.

The character selected is not inserted and it seems the "focus" goes to the top of the page instead. Here's what IE's F12 reports upon insertion attempt.

function anonymous(evt) {
mw.toolbar.insertTags('₡', '', ''); evt.preventDefault(); return false;
}

SCRIPT5007: Unable to get property 'insertTags' of undefined or null reference
File: Function code (722), Line: 2, Column: 1

SCRIPT5009: 'insertTags' is undefined
File: index.php, Line: 138, Column: 13

Details

SubjectRepoBranchLines +/-
Re-add mediawiki.toolbar as a dependency of mediawiki.action.editmediawiki/corewmf/1.25wmf14+1 -0
Customize query in gerrit

Related Objects

Event Timeline

GOIII created this task.Jan 13 2015, 10:56 PM
GOIII raised the priority of this task from to Needs Triage.
GOIII triaged this task as Unbreak Now! priority.
GOIII updated the task description. (Show Details)
GOIII added a project: CharInsert.
GOIII set Security to None.
GOIII subscribed.
GOIII added a subscriber: • brion.Jan 13 2015, 11:28 PM
GOIII added a project: WMF-deploy-2015-01-07_(1.25wmf14).Jan 14 2015, 12:03 AM
AuFCL subscribed.Jan 14 2015, 3:00 AM

No fault apparent using Firefox 34.0 (& 35.0 - browser auto-updated during trial; unexpected two-for-one result) under GNU/Linux; both logged-out and in.

No loss of focus observed either.

Could the choice of browser/referrer-id be the sensitive issue here?

GOIII added a comment.EditedJan 14 2015, 3:32 AM

Londonjackbooks reported the issue but I don't know what browser she's running.

Are you sure you're all caught up cache-wise to today's 1.25wmf14 roll-out?

GOIII added a comment.EditedJan 14 2015, 3:37 AM

Fwiw... this page describes the message I get under CodeEditor @ test.wikipedia.org when checking the core CharInsert .js .

TTO subscribed.Jan 14 2015, 3:48 AM

Probably caused by 1dd14dcec0dfb69a8e9763b380e2b151e0da9634.

The gadget needs to be made dependent on mediawiki.toolbar in the gadgets definition:

charinsert-core[ResourceLoader|hidden|rights=hidden|dependencies=mediawiki.action.edit,mediawiki.toolbar,jquery.textSelection,user]|charinsert-core.js|charinsert-core.css
GOIII updated the task description. (Show Details)Jan 14 2015, 3:52 AM
GOIII added a comment.Jan 14 2015, 4:03 AM
In T86715#975167, @TTO wrote:

Probably caused by 1dd14dcec0dfb69a8e9763b380e2b151e0da9634.
( Optimise loading of mediawiki.toolbar module )
The gadget needs to be made dependent on mediawiki.toolbar in the gadgets definition:

charinsert-core[ResourceLoader|hidden|rights=hidden|dependencies=mediawiki.action.edit,mediawiki.toolbar,jquery.textSelection,user]|charinsert-core.js|charinsert-core.css

Bingo! Adding that dependency rectified the problem on en.wikisource.org. Thank You very much.

I don't have that level of access for any other of the affected projects however.

TTO closed this task as Resolved.Jan 14 2015, 4:03 AM
TTO claimed this task.

I'll ask a shell user to check which other projects are affected.

GOIII reopened this task as Open.Jan 14 2015, 4:03 AM
GOIII closed this task as Resolved.
GOIII claimed this task.
GOIII lowered the priority of this task from Unbreak Now! to Medium.
GOIII added a comment.Jan 14 2015, 4:05 AM

Reminder that all the Wikipedia's get the 1.25wmf14 roll-out tomorrow. The issue won't present itself until then

GOIII reassigned this task from GOIII to TTO.Jan 14 2015, 4:06 AM
GOIII removed a project: WMF-deploy-2015-01-07_(1.25wmf14).Jan 14 2015, 4:12 AM
gerritbot added a project: Patch-For-Review.Jan 14 2015, 4:37 AM

Change 184836 had a related patch set uploaded (by TTO):
Re-add mediawiki.toolbar as a dependency of mediawiki.action.edit

https://gerrit.wikimedia.org/r/184836

Patch-For-Review

gerritbot subscribed.Jan 14 2015, 5:43 PM

Change 184836 merged by jenkins-bot:
Re-add mediawiki.toolbar as a dependency of mediawiki.action.edit

https://gerrit.wikimedia.org/r/184836

Reedy mentioned this in rMW46a9591097be: Re-add mediawiki.toolbar as a dependency of mediawiki.action.edit.Jan 14 2015, 5:43 PM
He7d3r mentioned this in T88887: Module for the Charinsert gadget sometimes doesn't load.Feb 9 2015, 12:09 AM
Aschroet mentioned this in T137955: CharInsert does not work anymore on dewikisource.Jun 16 2016, 11:08 AM
AuFCL unsubscribed.Nov 21 2016, 7:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL