Page MenuHomePhabricator
Create Task
Maniphest T87915

Convert FlaggedRevs to use extension registration
Closed, ResolvedPublic
Actions

Description

The FlaggedRevs extension needs to be converted to use the new extension registration system. More details are available on T87875.

Details

SubjectRepoBranchLines +/-
extension-list: Load FlaggedRevs via extension.jsonoperations/mediawiki-configmaster+2 -2
Some more extension registrationmediawiki/extensions/FlaggedRevsmaster+24 -36
Partial conversion to extension.jsonmediawiki/extensions/FlaggedRevsmaster+532 -581
Convert FlaggedRevs to extension registrationmediawiki/extensions/FlaggedRevsmaster+578 -672
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedReedyT148340 Stop conditionally registering hooks in FlaggedRevs
ResolvedNoneT87875 Convert all Wikimedia-deployed extensions and skins to use extension registration
ResolvedReedyT87915 Convert FlaggedRevs to use extension registration
OpenNoneT142663 ExtensionRegistry does not allow complete override of config variables e.g. flat arrays
· · ·

Event Timeline

Legoktm added a project: MediaWiki-extensions-FlaggedRevs.Jan 29 2015, 7:32 PM
Legoktm subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 29 2015, 7:32 PM
Legoktm added a parent task: T87875: Convert all Wikimedia-deployed extensions and skins to use extension registration.Jan 29 2015, 7:37 PM
Liuxinyu970226 subscribed.Feb 2 2015, 3:58 AM
Liuxinyu970226 updated the task description. (Show Details)Sep 6 2015, 11:15 PM
Liuxinyu970226 set Security to None.
Liuxinyu970226 added a subscriber: aaron.Dec 18 2015, 10:45 AM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptDec 18 2015, 10:45 AM
gerritbot subscribed.Oct 15 2016, 11:05 PM

Change 316201 had a related patch set uploaded (by Reedy):
Convert FlaggedRevs to extension registration

https://gerrit.wikimedia.org/r/316201

gerritbot added a project: Patch-For-Review.Oct 15 2016, 11:05 PM
Reedy mentioned this in T148340: Stop conditionally registering hooks in FlaggedRevs.Oct 16 2016, 6:34 PM
Reedy added a parent task: T148340: Stop conditionally registering hooks in FlaggedRevs.
Reedy added a subtask: T142663: ExtensionRegistry does not allow complete override of config variables e.g. flat arrays.Oct 20 2016, 1:53 PM
gerritbot added a comment.Nov 25 2016, 3:22 PM

Change 316201 abandoned by Reedy:
Convert FlaggedRevs to extension registration

Reason:
Not worth continuing to rebase until stuff in master is done

https://gerrit.wikimedia.org/r/316201

Reedy removed a project: Patch-For-Review.Nov 25 2016, 3:29 PM
Reedy triaged this task as Medium priority.Nov 27 2016, 10:42 PM
MacFan4000 subscribed.Jul 23 2017, 12:36 PM
EddieGP closed subtask T142663: ExtensionRegistry does not allow complete override of config variables e.g. flat arrays as Declined.Sep 24 2017, 10:25 AM
MarcoAurelio mentioned this in T87875: Convert all Wikimedia-deployed extensions and skins to use extension registration.Nov 18 2017, 6:15 PM
Jdforrester-WMF mentioned this in T142121: Remove UnitTestsList hook subscribers, move tests to be autodiscovered for WMF extensions that have been converted to extension registration.Jan 19 2018, 6:16 PM
Liuxinyu970226 added a comment.Feb 17 2018, 2:28 PM

Why not Lowest priority? This extension is under T185664 review, so it would be possible to sunset maintaining in one day.

MGChecker subscribed.Apr 8 2018, 11:43 AM
Izno mentioned this in T140852: Load all Wikimedia-deployed extensions and skins via extension registration.Sep 11 2018, 7:52 PM
Krinkle edited parent tasks, added: T140852: Load all Wikimedia-deployed extensions and skins via extension registration; removed: T87875: Convert all Wikimedia-deployed extensions and skins to use extension registration.Sep 11 2018, 9:32 PM
Krinkle added a parent task: T87875: Convert all Wikimedia-deployed extensions and skins to use extension registration.Sep 12 2018, 6:29 AM
Krinkle removed a parent task: T140852: Load all Wikimedia-deployed extensions and skins via extension registration.
Liuxinyu970226 unsubscribed.Sep 12 2018, 10:26 AM
gerritbot added a comment.May 18 2019, 12:15 PM

Change 511021 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/FlaggedRevs@master] Partial conversion to extension.json

https://gerrit.wikimedia.org/r/511021

gerritbot added a project: Patch-For-Review.May 18 2019, 12:15 PM
gerritbot added a comment.May 18 2019, 2:19 PM

Change 511034 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/FlaggedRevs@master] Some more extension registration

https://gerrit.wikimedia.org/r/511034

gerritbot added a comment.May 18 2019, 2:37 PM

Change 511021 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Partial conversion to extension.json

https://gerrit.wikimedia.org/r/511021

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.6; 2019-05-21).May 18 2019, 3:00 PM
gerritbot added a comment.May 18 2019, 3:29 PM

Change 511034 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Some more extension registration

https://gerrit.wikimedia.org/r/511034

Reedy closed this task as Resolved.Jun 25 2019, 1:16 AM
Reedy claimed this task.
Reedy removed a project: Patch-For-Review.
Lucas_Werkmeister_WMDE subscribed.Oct 15 2019, 5:32 PM

Note: the migration was finished in https://gerrit.wikimedia.org/r/514508, which was not attached to this task. (Also, the PHP entry point is still used in production, but I figure it’s not worth reopening this task for that.)

gerritbot added a comment.Oct 15 2019, 5:34 PM

Change 543180 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[operations/mediawiki-config@master] extension-list: Load FlaggedRevs via extension.json

https://gerrit.wikimedia.org/r/543180

gerritbot added a project: Patch-For-Review.Oct 15 2019, 5:34 PM
Jdforrester-WMF mentioned this in T234743: User rights validation is sometimes malfunctioning (with FlaggedRevs only?).Oct 15 2019, 8:00 PM
gerritbot added a comment.Oct 16 2019, 11:18 AM

Change 543180 merged by jenkins-bot:
[operations/mediawiki-config@master] extension-list: Load FlaggedRevs via extension.json

https://gerrit.wikimedia.org/r/543180

Stashbot added a comment.Oct 16 2019, 11:26 AM

Mentioned in SAL (#wikimedia-operations) [2019-10-16T11:26:51Z] <lucaswerkmeister-wmde@deploy1001> Synchronized wmf-config/: SWAT: [[gerrit:543180|extension-list: Load FlaggedRevs via extension.json (T87915, T139800, T140852)]] (duration: 01m 05s)

Stashbot mentioned this in T139800: Update wmf-config/extension-list to use extension.json where available.Oct 16 2019, 11:26 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 16 2019, 12:10 PM
tstarling reopened subtask T142663: ExtensionRegistry does not allow complete override of config variables e.g. flat arrays as Open.May 4 2021, 4:40 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL