Maniphest T88635

ObjectCacheSessionHandler should avoid pointless writes in write()
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	aaron
	Feb 5 2015, 12:39 AM

Tags

Referenced Files

None

Subscribers

Ciencia_Al_Poder

Description

Until PHP 5.6, write() is called regardless of whether anything changed. We should detect changes and no-op if there's nothing to do. This is useful for multi-DC sessions to cut writes down to a trickle (nearly all in the hot DC).

Details

	Subject	Repo	Branch	Lines +/-
	Avoiding writing sessions for no reason	mediawiki/core	master	+27 -7

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		aaron	T88445 MediaWiki active/active datacenter investigation and work (tracking)
		Resolved		aaron	T88635 ObjectCacheSessionHandler should avoid pointless writes in write()

Event Timeline

aaron created this task.Feb 5 2015, 12:39 AM

aaron claimed this task.

aaron raised the priority of this task from to Medium.

aaron updated the task description. (Show Details)

aaron added projects: Patch-For-Review, Epic, MediaWiki-Core-Team.

aaron added subscribers: PleaseStand, gerritbot, bd808 and 2 others.

Change 188721 had a related patch set uploaded (by Aaron Schulz):
Avoiding writing sessions for no reason

https://gerrit.wikimedia.org/r/188721

Patch-For-Review

aaron moved this task from Backlog to Needs Review/Feedback on the MediaWiki-Core-Team board.Feb 5 2015, 1:12 AM

Legoktm removed a project: Epic.Feb 10 2015, 6:14 PM

Legoktm set Security to None.

Change 188721 merged by jenkins-bot:
Avoiding writing sessions for no reason

https://gerrit.wikimedia.org/r/188721

Legoktm mentioned this in rMW532ef7851c69: Avoiding writing sessions for no reason.Feb 10 2015, 6:20 PM

aaron moved this task from Needs Review/Feedback to Done on the MediaWiki-Core-Team board.Feb 10 2015, 7:55 PM

Umherirrender closed this task as Resolved.Feb 17 2015, 7:58 PM

Umherirrender subscribed.

bd808 moved this task from Done to Archive on the MediaWiki-Core-Team board.Feb 17 2015, 11:44 PM

Changes reverted due to T102199: Reports of a high number of edits being rejected due to loss of session data

Legoktm reopened this task as Open.Aug 3 2015, 4:29 PM

Legoktm subscribed.

Umherirrender unsubscribed.Aug 3 2015, 7:01 PM

Should be fixed in 08039b2df44a2e83974d77fccba337a5d86cd854 (and monitored).

aaron closed this task as Resolved.Aug 24 2015, 10:44 AM