Page MenuHomePhabricator
Create Task
Maniphest T89164

Flow in low width, terms of use message is squashed
Closed, ResolvedPublic
Actions

Description

In the mobilefrontend, the Terms of Use message appears very squashed, and even overlaps the "Cancel" button.

Screenshot_from_2015-02-10_11:35:34.png (854×382 px, 81 KB)

(also a problem in desktop view, at reduced widths, eg. increasingly at less than ~700px)

Details

SubjectRepoBranchLines +/-
Fix scrunching of TOS on low-width windowsmediawiki/extensions/Flowmaster+8 -1
Customize query in gerrit

Related Objects

Event Timeline

Quiddity created this task.Feb 10 2015, 8:31 PM
Quiddity raised the priority of this task from to Needs Triage.
Quiddity updated the task description. (Show Details)
Quiddity added a project: StructuredDiscussions.
Quiddity subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 10 2015, 8:31 PM
Quiddity mentioned this in T72787: Tooltip notifications not implemented with mobile in mind.Feb 10 2015, 8:35 PM
Aklapper added a project: Mobile.Feb 11 2015, 1:58 AM
Aklapper set Security to None.
• Mattflaschen-WMF renamed this task from Flow in mobilefrontend, terms of use message is squashed to Flow in low width, terms of use message is squashed.Feb 11 2015, 2:07 AM
• Mattflaschen-WMF claimed this task.
gerritbot added a project: Patch-For-Review.Feb 11 2015, 2:27 AM
gerritbot subscribed.

Change 189890 had a related patch set uploaded (by Mattflaschen):
Fix scrunching of TOS on low-width windows

https://gerrit.wikimedia.org/r/189890

Patch-For-Review

• Mattflaschen-WMF added a comment.Feb 11 2015, 2:31 AM

^ That's the easy solution, if it's okay to have the TOS after the buttons.

Screenshot (desktop remains the same):

TOS_Immediately_After_Button_Row.png (535×407 px, 28 KB)

EBernhardson triaged this task as Medium priority.Feb 12 2015, 6:40 PM
EBernhardson subscribed.
gerritbot added a comment.Feb 13 2015, 1:37 AM

Change 189890 merged by jenkins-bot:
Fix scrunching of TOS on low-width windows

https://gerrit.wikimedia.org/r/189890

• Mattflaschen-WMF mentioned this in rEFLW3498920af7b0: Fix scrunching of TOS on low-width windows.Feb 13 2015, 1:38 AM
• Mattflaschen-WMF closed this task as Resolved.Feb 14 2015, 4:59 AM
Diffusion mentioned this in rMEXT36ee337cf987: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Mar 11 2015, 6:26 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL