Description
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Scrub table cells starting with escapable prefixes | mediawiki/services/parsoid | master | +81 -0 |
Related Objects
- Mentioned In
- T167637: Parsoid/VisualEditor sometimes inserts `|<nowiki>-</nowiki>` instead of `| -` into tables
rGPARe64a835b6440: Run normalization after dom-diff to handle edited content
rGPAR14f47cba0e6a: Scrub table cells starting with escapable prefixes
T94767: Perform a weekly review of edits made with VisualEditor - Mentioned Here
- T107774: Title with just nowiki tag
T88318: Entering a single '-' character in a table results in a new row
Event Timeline
As per this analysis, this is one of the bigger sources of nowiki insertions right now.
Change 229186 had a related patch set uploaded (by Arlolra):
Scrub table cells starting with dashes
Change 229186 merged by jenkins-bot:
Scrub table cells starting with escapable prefixes
This should be fixed for new nodes. As with T107774, we need to come up with a more general solution for modified content, which may mean doing normalizations after dom diff'ing.
Yes. This will likely be deployed today. However, this will not yet solve all the nowiki issues in this context. Edited content will still see nowikis. I am going to try and tackle that separately in a more general fashion.
I agree that scrubWikitext is probably not the right place for this; we need a more general mechanism to specify possible wikitext escapes other than just throwing <nowiki> around.
With the deployment today that allows normalization of edited content, i think we can call this done. There are a couple minor tweaks to be done to this, but the nowiki part of this should itself be resolved. Please reopen if this shows up again.