Page MenuHomePhabricator
Create Task
Maniphest T93290

ButtonElements with no label, icon and indicator should still have consistent height
Closed, ResolvedPublic
Actions

Description

Although it's unlikely that a button without a label, icon or indicator would be presented to the user, not having a uniform height when a button is not yet configured to have one of these properties can cause calculations during setup processes to yield unexpected results. This essentially creates a hard to detect trap that developers will fall into on occasion.

Details

SubjectRepoBranchLines +/-
WikimediaUI theme: Set ButtonElement's height per defaultoojs/uimaster+2 -0
Revert 032fb292, a97eacd0mediawiki/extensions/VisualEditormaster+4 -4
Remove dialog height hack tagged against resolved bugmediawiki/extensions/VisualEditormaster+1 -4
MediaWiki theme: Alter buttons' padding and position icons absolutelyoojs/uimaster+35 -36
Customize query in gerrit

Related Objects
Search...

Event Timeline

• TrevorParscal created this task.Mar 19 2015, 10:44 PM
• TrevorParscal assigned this task to • Prtksxna.
• TrevorParscal raised the priority of this task from to Needs Triage.
• TrevorParscal updated the task description. (Show Details)
• TrevorParscal added a project: OOUI.
• TrevorParscal added subscribers: • TrevorParscal, • Nirzar, matmarex.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2015, 10:44 PM
Jdforrester-WMF mentioned this in rEVED8fc1e2dea083: TransclusionDialog: Initialize label mode button.Mar 23 2015, 3:54 PM
• Prtksxna added a comment.Mar 24 2015, 11:04 AM

Do we just want to set the button height?
https://gerrit.wikimedia.org/r/199246 (adds test cases to demo page)

Jdforrester-WMF reopened this task as Open.Mar 25 2015, 9:12 PM
Jdforrester-WMF closed this task as a duplicate of T92986: [Regression pre-wmf22] Template dialog has footer line crossing through button.
Jdforrester-WMF subscribed.

Drat, wrong one.

matmarex renamed this task from ButtonElements should be uniform height with any combination of label, icon and indicator - including none of them to ButtonElements with no label, icon and indicator should still have consistent height.Mar 30 2015, 9:13 PM
matmarex set Security to None.
matmarex mentioned this in T94750: In MediaWiki theme, button height should be controlled only by 'padding' and label 'line-height'.Apr 1 2015, 8:26 PM

@Nirzar proposed T94750: In MediaWiki theme, button height should be controlled only by 'padding' and label 'line-height', which would also solve this issue.

matmarex added a subtask: T94750: In MediaWiki theme, button height should be controlled only by 'padding' and label 'line-height'.Apr 29 2015, 10:45 PM
• Nirzar added a parent task: T91473: OOjs UI and MediaWiki UI buttons are different sizes.Jun 4 2015, 6:02 PM
gerritbot subscribed.Jul 22 2015, 6:07 PM

Change 216864 had a related patch set uploaded (by Jforrester):
MediaWiki theme: Alter buttons' padding and position icons absolutely

https://gerrit.wikimedia.org/r/216864

gerritbot added a project: Patch-For-Review.Jul 22 2015, 6:07 PM
Jdforrester-WMF moved this task from Backlog to Doing on the OOUI board.Jul 30 2015, 12:49 AM
• Prtksxna reassigned this task from • Prtksxna to • Nirzar.Aug 13 2015, 10:54 AM
gerritbot added a comment.Sep 18 2015, 11:10 AM

Change 216864 merged by jenkins-bot:
MediaWiki theme: Alter buttons' padding and position icons absolutely

https://gerrit.wikimedia.org/r/216864

matmarex mentioned this in rGOJUfdca4fb908eb: MediaWiki theme: Alter buttons' padding and position icons absolutely.Sep 18 2015, 11:11 AM
Jdforrester-WMF closed this task as Resolved.Sep 18 2015, 3:22 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF edited projects, added OOjs-UI-next-release; removed Patch-For-Review.
Jdforrester-WMF closed subtask T94750: In MediaWiki theme, button height should be controlled only by 'padding' and label 'line-height' as Resolved.
Jdforrester-WMF moved this task from Doing to Reviewing on the OOUI board.
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.12.9), MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)); removed OOjs-UI-next-release.Sep 22 2015, 8:19 PM
gerritbot added a comment.May 23 2017, 4:48 PM

Change 355247 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Remove dialog height hack tagged against resolved bug

https://gerrit.wikimedia.org/r/355247

gerritbot edited projects, added Patch-For-Review; removed OOUI (OOjs-UI-0.12.9).May 23 2017, 4:48 PM
gerritbot added a comment.May 24 2017, 6:54 AM

Change 355247 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Remove dialog height hack tagged against resolved bug

https://gerrit.wikimedia.org/r/355247

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-30_(1.30.0-wmf.3)).May 24 2017, 7:00 AM
matmarex edited projects, added OOUI (OOjs-UI-0.12.9); removed MW-1.30-release-notes (WMF-deploy-2017-05-30_(1.30.0-wmf.3)), Patch-For-Review, OOUI.May 24 2017, 3:11 PM
matmarex reopened this task as Open.Jun 14 2017, 6:40 PM
matmarex mentioned this in T167483: [Regression wmf.4] Dialog footer broken for templates.

This was never fixed or has regressed. The VE change above caused T167483.

gerritbot added a comment.Jun 14 2017, 6:40 PM

Change 359010 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Revert 032fb292, a97eacd0

https://gerrit.wikimedia.org/r/359010

gerritbot added a project: Patch-For-Review.Jun 14 2017, 6:40 PM
gerritbot added a comment.Jun 14 2017, 7:04 PM

Change 359010 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Revert 032fb292, a97eacd0

https://gerrit.wikimedia.org/r/359010

Aklapper edited projects, added OOUI; removed Patch-For-Review, OOUI (OOjs-UI-0.12.9).Jun 26 2017, 5:08 AM
Volker_E subscribed.Jun 26 2017, 9:44 PM

We've removed min-height for framed buttons in rGOJU1dcc221214b1.
We could probably integrate a default padding-top for non-labelled buttons, which is then overridden by .oo-ui-labelElement styles.

gerritbot added a comment.Jun 26 2017, 11:17 PM

Change 361596 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] WikimediaUI theme: Set ButtonElement's height per default

https://gerrit.wikimedia.org/r/361596

gerritbot added a project: Patch-For-Review.Jun 26 2017, 11:17 PM
• Prtksxna mentioned this in T94749: Provide labels for label-less buttons.Jun 27 2017, 7:26 AM
Volker_E closed this task as Resolved.Jul 13 2017, 5:54 PM
Volker_E claimed this task.
Volker_E moved this task from Reviewing to OOjs-UI-0.22.4 on the OOUI board.
Volker_E edited projects, added OOUI (OOjs-UI-0.22.4); removed OOUI.
Volker_E removed a project: Patch-For-Review.
Volker_E removed a subscriber: gerritbot.
gerritbot added a comment.Jul 13 2017, 6:00 PM

Change 361596 merged by jenkins-bot:
[oojs/ui@master] WikimediaUI theme: Set ButtonElement's height per default

https://gerrit.wikimedia.org/r/361596

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL