Page MenuHomePhabricator
Create Task
Maniphest T94030

Avoid opening master db connection on special pages (e.g. Special:NewItem) when not needed
Closed, ResolvedPublic
Actions

Description

Not quite sure what is going on here, from the logs:

2015-03-26 14:24:44 mw1032 wikidatawiki: Expectation (masterConns <= 0) by MediaWiki::main not met:
[connect to 10.64.32.28 (wikidatawiki)]
TransactionProfiler.php line 254 calls wfBacktrace()
TransactionProfiler.php line 112 calls TransactionProfiler->reportExpectationViolated()
LoadBalancer.php line 517 calls TransactionProfiler->recordConnection()
GlobalFunctions.php line 3641 calls LoadBalancer->getConnection()
SqlStore.php line 460 calls wfGetDB()
SqlStore.php line 542 calls Wikibase\SqlStore->newIdGenerator()
SqlStore.php line 531 calls Wikibase\SqlStore->newEntityStore()
WikibaseRepo.php line 316 calls Wikibase\SqlStore->getEntityStore()
SpecialWikibaseRepoPage.php line 83 calls Wikibase\Repo\WikibaseRepo->getEntityStore()
SpecialNewEntity.php line 64 calls Wikibase\Repo\Specials\SpecialWikibaseRepoPage->construct()
SpecialNewItem.php line 34 calls Wikibase\Repo\Specials\SpecialNewEntity->construct()
SpecialPageFactory.php line 409 calls Wikibase\Repo\Specials\SpecialNewItem->__construct()
SpecialPageFactory.php line 537 calls SpecialPageFactory::getPage()
MediaWiki.php line 268 calls SpecialPageFactory::executePath()
MediaWiki.php line 571 calls MediaWiki->performRequest()
MediaWiki.php line 422 calls MediaWiki->main()
index.php line 46 calls MediaWiki->run()
index.php line 3 calls include()

Details

SubjectRepoBranchLines +/-
Lazy initialize db connection in SqlIdGeneratormediawiki/extensions/Wikibasemaster+30 -33
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
OpenNoneT92357 Fix database master queries from HTTP GET/HEAD before active-active multi-dc
OpenNoneT96040 Wikibase special pages (tracking)
ResolvedaudeT94030 Avoid opening master db connection on special pages (e.g. Special:NewItem) when not needed
· · ·

Event Timeline

aaron created this task.Mar 26 2015, 2:46 PM
aaron claimed this task.
aaron removed aaron as the assignee of this task.
aaron raised the priority of this task from to Medium.
aaron updated the task description. (Show Details)
aaron added projects: Patch-For-Review, MediaWiki-Core-Team.
aaron set Security to None.
aaron added subscribers: aaron, Aklapper, bd808 and 5 others.
aude added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.Mar 26 2015, 2:56 PM

is there a patch for review?

aaron removed a project: Patch-For-Review.Mar 26 2015, 3:01 PM

No, that's just phab carrying over parent tags.

Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Mar 30 2015, 12:55 PM
Lydia_Pintscher added subscribers: JanZerebecki, hoo.
• Gilles edited projects, added Sustainability; removed MediaWiki-Core-Team.Apr 7 2015, 7:30 AM
aude claimed this task.Apr 7 2015, 10:20 AM
aude added a project: Wikidata-Sprint-2015-04-07.Apr 7 2015, 11:54 AM
aude moved this task from Backlog to Doing on the Wikidata-Sprint-2015-04-07 board.
aude renamed this task from SpecialNewEntity needing the master on GET/HEAD? to Avoid opening master db connection on special pages (e.g. Special:NewItem) when not needed.Apr 7 2015, 1:23 PM
aude added a comment.Apr 7 2015, 1:26 PM

this happens not just on Special:NewEntity, but as well Special:NewProperty, SetLabel, etc.

the fix will apply to all these cases and generally for anything that uses SqlIdGenerator.

Options include:

  • extend DBAccess in core, which allows to lazy initialize. (though would prefer to have DBAccess as a constructor param / member variable that we can mock)
  • put LoadBalancer param in the constructor instead of DatabaseBase, which allows to lazy initialize
  • have some other DBAccess object that is non-abstract that we can put in the constructor.
aaron added a comment.Apr 7 2015, 5:33 PM

getLazyConnectionRef() might be useful, though it can through off type-hinting/IDEs for the moment

aude mentioned this in rEWBA9af87ffc45cb: Add test case for SqlIdGeneratorTest and inject setting.Apr 7 2015, 7:38 PM
Diffusion mentioned this in rMEXTae1841a24ed8: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Apr 7 2015, 7:38 PM
gerritbot added a comment.Apr 10 2015, 3:37 PM

Change 203353 had a related patch set uploaded (by Aude):
Lazy initialize db connection in SqlIdGenerator

https://gerrit.wikimedia.org/r/203353

gerritbot added a project: Patch-For-Review.Apr 10 2015, 3:37 PM
aude moved this task from Doing to Review on the Wikidata-Sprint-2015-04-07 board.Apr 14 2015, 6:31 AM
gerritbot added a comment.Apr 14 2015, 3:15 PM

Change 203353 merged by jenkins-bot:
Lazy initialize db connection in SqlIdGenerator

https://gerrit.wikimedia.org/r/203353

aude mentioned this in rEWBA9e459775e8c6: Lazy initialize db connection in SqlIdGenerator.Apr 14 2015, 3:15 PM
Diffusion mentioned this in rMEXT4b0b0db757fb: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Apr 14 2015, 3:15 PM
aude added a parent task: T96040: Wikibase special pages (tracking).Apr 14 2015, 4:37 PM
aude closed this task as Resolved.Apr 15 2015, 7:52 AM
aude moved this task from Review to Done on the Wikidata-Sprint-2015-04-07 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL