Maniphest T98877

Alert styles should be conditionally loaded
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	May 12 2015, 3:00 PM

Tags

Referenced Files

None

Subscribers

Description

alert, errorbox and warningbox classes are loaded on every page load.
They are only used in these places:

selected special pages
when viewing an old revision (note duplicate code in SkinMinerva and SkinMinervaBeta)

We should thus move these styles into a module that is loaded on special pages and conditionally load it when viewing an old revision.

Details

	Subject	Repo	Branch	Lines +/-
	Load message box styles only when needed	mediawiki/extensions/MobileFrontend	master	+40 -30

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Duplicate		• Jhernandez	T104432 [EPIC]: Improve mobile site performance
		Resolved		Jdlrobson	T98986 [EPIC] Improve the status quo of mobile web performance
		Duplicate		None	T98397 Main menu and notification css should be loaded via JavaScript
		Duplicate		None	T98987 Epic: Make mobile web more performant
		Resolved		Jdlrobson	T97289 Trim down CSS loaded in the head for anonymous users on mobile
		Resolved		Jdlrobson	T98877 Alert styles should be conditionally loaded

Event Timeline

Jdlrobson created this task.May 12 2015, 3:00 PM

Jdlrobson assigned this task to • Gilles.

Jdlrobson raised the priority of this task from to Medium.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added projects: Performance-Team, Web-Team-Backlog, MobileFrontend.

Jdlrobson added subscribers: Florian, Jdlrobson, gerritbot and 3 others.

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.May 12 2015, 3:37 PM

Jdlrobson claimed this task.May 28 2015, 7:49 AM

Change 214365 had a related patch set uploaded (by Jdlrobson):
Load message box styles only when needed

https://gerrit.wikimedia.org/r/214365

gerritbot added a project: Patch-For-Review.May 28 2015, 3:29 PM

Change 214365 merged by jenkins-bot:
Load message box styles only when needed

https://gerrit.wikimedia.org/r/214365

Jdlrobson mentioned this in rMEXTe113cab227f1: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Jun 3 2015, 10:59 PM

• bmansurov mentioned this in rEMFRe067b43bdabd: Load message box styles only when needed.Jun 3 2015, 11:00 PM

Jdlrobson closed this task as Resolved.Jun 4 2015, 4:38 PM

Krinkle edited projects, added Performance Issue; removed Performance-Team.Jun 23 2015, 5:27 AM

Krinkle set Security to None.

• Phabricator_maintenance moved this task from Needs Prioritization to 2014-15 Q4 on the Web-Team-Backlog board.Mar 7 2018, 1:32 AM