Page MenuHomePhabricator

OAuth authorization dialogs should have a plain (skinless) version so that they can be shown in popup windows.
Closed, DuplicatePublic

Description

A possible design:

oauth-version2.png (1×2 px, 87 KB)

oauth-mobile-2.png (1×640 px, 50 KB)

Event Timeline

Tgr raised the priority of this task from to Needs Triage.
Tgr updated the task description. (Show Details)
Tgr subscribed.

T71246 is a poor man's version of this.

This is the current OAuth flow:

  • the user visits the application's home page
  • they click on a 'Login' link
  • they are redirected to the authorization screen at mediawiki.org
  • they click on the 'Allow' button
  • they get redirected to the application

Using popups, there would be almost no way for the apps to know in real time that they've been authorized.
Not mentioning that, at least in a desktop environment, popups are very annoying and might be blocked even without the user noticing...

Tgr triaged this task as Medium priority.Jun 29 2015, 7:15 PM

The OIDC spec has a standardized way of requesting the popup version, display=popup.

Change #1031627 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/OAuth@master] SpecialMWOAuth: Support &display=popup

https://gerrit.wikimedia.org/r/1031627

matmarex subscribed.

Oops, that patch was supposed to go on T71246, but I wanted to say here that the difference between that task and this one is not really clear to me.

Originally that task proposed just making the dialog full-width (so that the skin is hidden beneath it), and this one proposed getting rid of the skin entirely. But yeah, probably wasn't much point in having those as separate tasks.