Page MenuHomePhabricator
Feed Advanced Search

Wed, May 15

ashley committed rEMWC2dd2139da087: Add phan.
Add phan
Wed, May 15, 8:51 PM

Mon, May 13

ashley committed rEARAfd5bb4e2f070: Finally shut up WMF CI "errors" about wfGetDB + bump extension version +….
Finally shut up WMF CI "errors" about wfGetDB + bump extension version +…
Mon, May 13, 6:33 AM
ashley committed rEARA810662af4aef: Add phan.
Add phan
Mon, May 13, 5:50 AM

Sun, May 12

ashley closed T146550: Register the /me command in MediaWikiChat private messaging as Resolved.

Now implemented.

Sun, May 12, 4:01 PM · Social-Tools, Brickimedia, MediaWikiChat
ashley committed rEMWC44904c3cb990: Implement support for the /me command in private messages when $wgChatMeCommand….
Implement support for the /me command in private messages when $wgChatMeCommand…
Sun, May 12, 3:58 PM
ashley committed rEARAa0c524704591: Add missing "use MediaWiki\MediaWikiServices;" statement.
Add missing "use MediaWiki\MediaWikiServices;" statement
Sun, May 12, 8:49 AM
ashley committed rEARAedf361f84264: Drop pre-1.34 backwards compatibility code, extension.json requires MW 1.35+.
Drop pre-1.34 backwards compatibility code, extension.json requires MW 1.35+
Sun, May 12, 8:47 AM

Sat, May 11

ashley committed rEARAfa78d60415ed: Improve message documentation (qqq).
Improve message documentation (qqq)
Sat, May 11, 5:52 AM
ashley removed a project from T279390: Use of BaseTemplate::getToolbox was deprecated in MediaWiki 1.35. will be removed in ??: Brickimedia.
Sat, May 11, 5:47 AM · BlueSpice, MediaWiki-Core-Skin-Architecture, Patch-For-Review
ashley moved T157240: Archive the GlobalContribs extension from Backlog to GlobalContribs on the Brickimedia board.
Sat, May 11, 5:46 AM · Diffusion-Repository-Administrators, Projects-Cleanup, Technical-Debt, Brickimedia, GlobalContribs
ashley moved T154852: Merge GlobalContribs into GlobalContributions from Backlog to GlobalContribs on the Brickimedia board.
Sat, May 11, 5:45 AM · Technical-Debt, Brickimedia, GlobalContribs
ashley moved T156223: MediaWikiChat - convert checkbox, inputs and mwchat-options to OOUI from Backlog to MediaWikiChat on the Brickimedia board.
Sat, May 11, 5:45 AM · Design, UI-Standardization, good first task, Social-Tools, Brickimedia, MediaWikiChat
ashley moved T155939: MediaWikiChat behaves oddly when having multiple chat sessions open up at the same time from Backlog to MediaWikiChat on the Brickimedia board.
Sat, May 11, 5:44 AM · Social-Tools, Brickimedia, MediaWikiChat
ashley moved T155936: MediaWikiChat should show an OOUI alert dialog when the user opens up a second chat session from Backlog to MediaWikiChat on the Brickimedia board.
Sat, May 11, 5:44 AM · Social-Tools, Brickimedia, MediaWikiChat
ashley moved T364669: Rename Special:MassRatings to something like Special:ListRatings or whatever from Backlog to ArticleRatings (ARE) on the Brickimedia board.
Sat, May 11, 5:44 AM · I18n, Brickimedia, ArticleRatings
ashley moved T364669: Rename Special:MassRatings to something like Special:ListRatings or whatever from Backlog to i18n on the ArticleRatings board.
Sat, May 11, 5:44 AM · I18n, Brickimedia, ArticleRatings
ashley triaged T364669: Rename Special:MassRatings to something like Special:ListRatings or whatever as Low priority.
Sat, May 11, 5:43 AM · I18n, Brickimedia, ArticleRatings
ashley created T364669: Rename Special:MassRatings to something like Special:ListRatings or whatever.
Sat, May 11, 5:43 AM · I18n, Brickimedia, ArticleRatings
ashley committed rEARA50d8eba6eda9: i18n cleanup: remove unused "are-rating-for-page" message.
i18n cleanup: remove unused "are-rating-for-page" message
Sat, May 11, 5:35 AM
ashley closed T146554: ArticleRatings should use mw.hook.postEdit as Declined.

I'm gonna be bold here and decline this request. Partially because I'm biased against postEdit altogether, but also because it's mostly just JavaScript for the sake of having JavaScript instead of the JS-fulness providing any meaningful benefit. If you disagree, please feel free to reopen this task with sufficient reasoning for doing so and we can then continue the conversation from there.

Sat, May 11, 5:13 AM · good first task, Technical-Debt, Brickimedia, ArticleRatings
ashley removed projects from T266480: Extension should not create LogPager, use LogEventsList::showLogExtract or custom select query instead: Patch-For-Review, ArticleRatings.
Sat, May 11, 5:05 AM · MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), Growth-Team, MediaWiki-extensions-Approved-Revs, GrowthExperiments, MediaWiki-Logevents
ashley committed rEARA93c27e84aca8: SpecialChangeRating: Use showLogExtract() instead of LogPager.
SpecialChangeRating: Use showLogExtract() instead of LogPager
Sat, May 11, 5:04 AM

Tue, May 7

ashley committed rEARA9a1c6b40cf28: Rename the AreHooks class to ArticleRatingsHooks.
Rename the AreHooks class to ArticleRatingsHooks
Tue, May 7, 3:43 AM

Mon, May 6

ashley closed T146552: Create an API for ArticleRatings as Resolved.
Mon, May 6, 7:07 PM · Brickimedia, ArticleRatings
ashley committed rEARA9f21ee7e9579: API module for changing an article's rating status.
API module for changing an article's rating status
Mon, May 6, 7:07 PM

Sat, May 4

ashley committed rESPRdfc72977250f: Allow passing [ 'raw' => true ] as the parameter to wAvatar#getAvatarURL to get….
Allow passing [ 'raw' => true ] as the parameter to wAvatar#getAvatarURL to get…
Sat, May 4, 6:08 PM
ashley committed rEARA45e195a0dc2b: Validate the two-character rating codename, in case if someone tried tampering….
Validate the two-character rating codename, in case if someone tried tampering…
Sat, May 4, 6:06 PM
ashley committed rEARAcc7f196a9dab: Make the "rating changed successfully" message a bit more colorful and easier….
Make the "rating changed successfully" message a bit more colorful and easier…
Sat, May 4, 6:03 PM
ashley committed rEARA3db5c9c4ced5: Don't bother making no-op DB operations if the user doesn't change the rating….
Don't bother making no-op DB operations if the user doesn't change the rating…
Sat, May 4, 5:53 PM
ashley committed rEARA79d7168858d2: Make the "back to <page name>" message less prominent on Special:ChangeRating.
Make the "back to <page name>" message less prominent on Special:ChangeRating
Sat, May 4, 5:45 PM
ashley committed rEARAd2cdca528159: In preparation for creating an API (T146552), modularize and split up some of….
In preparation for creating an API (T146552), modularize and split up some of…
Sat, May 4, 5:40 PM

Fri, May 3

ashley committed rEARA86e6756257a0: Rating needs to be seeded with a (string) codename, not with a Rating object.
Rating needs to be seeded with a (string) codename, not with a Rating object
Fri, May 3, 10:58 AM

Wed, May 1

ashley closed T363884: Special:ChangeRating is vulnerable to CSRF as Resolved.
Wed, May 1, 10:49 PM · SecTeam-Processed, Vuln-CSRF, ArticleRatings, Security
ashley committed rEARAc4cb89b5e65c: [SECURITY] Fix CSRF in Special:ChangeRating.
[SECURITY] Fix CSRF in Special:ChangeRating
Wed, May 1, 10:44 PM
ashley closed T347215: ArticleFeedbackv5-SpamRegex interoperability as Resolved.
Wed, May 1, 2:12 PM · SpamRegex, ArticleFeedbackv5
ashley moved T363884: Special:ChangeRating is vulnerable to CSRF from Backlog to Bugs on the ArticleRatings board.
Wed, May 1, 1:52 PM · SecTeam-Processed, Vuln-CSRF, ArticleRatings, Security
ashley removed a project from T287643: Update third-party extensions to not use BaseTemplateToolbox hook: ArticleRatings.
Wed, May 1, 1:50 PM · Technical-Debt, BlueSpice
ashley committed rEARAa92aec0abf51: Use SidebarBeforeOutput hook instead of BaseTemplateToolbox to ensure that the….
Use SidebarBeforeOutput hook instead of BaseTemplateToolbox to ensure that the…
Wed, May 1, 1:24 PM
ashley committed rEARAd44ca763fc65: Gotta INSERT before you can UPDATE.
Gotta INSERT before you can UPDATE
Wed, May 1, 1:20 PM
ashley committed rEARA3f3b203ba91f: Finnish (fi) i18n and special page aliases.
Finnish (fi) i18n and special page aliases
Wed, May 1, 1:11 PM
ashley committed rEARAc81c2ea9aec6: Add a form for searching an article to Special:ChangeRating instead of throwing….
Add a form for searching an article to Special:ChangeRating instead of throwing…
Wed, May 1, 12:53 PM
ashley committed rEARA74431e3483b0: Mark Special:ChangeRating as doing write queries, since that's precisely what….
Mark Special:ChangeRating as doing write queries, since that's precisely what…
Wed, May 1, 12:53 PM
ashley committed rEARA3fcf71ce3bab: Fix grammar in the reviewer user group i18n messages.
Fix grammar in the reviewer user group i18n messages
Wed, May 1, 12:53 PM
ashley committed rEARAc718aa5dc358: Document the $wgARE* config variables in extension.json.
Document the $wgARE* config variables in extension.json
Wed, May 1, 12:53 PM
ashley committed rEARAdf2f61311f20: Bugfix for Special:MassRating when user's UI language is not site's content….
Bugfix for Special:MassRating when user's UI language is not site's content…
Wed, May 1, 12:53 PM
ashley committed rEARAb62f6550f852: Remove references to the Revision class, it's gone; use….
Remove references to the Revision class, it's gone; use…
Wed, May 1, 12:53 PM
ashley closed T164233: ArticleRatings: Special:ChangeRating should allow to look up an article to change a rating instead of giving an error on direct access as Resolved.

Now fixed in master.

Wed, May 1, 12:41 PM · Technical-Debt, Design, Brickimedia, ArticleRatings
ashley claimed T363884: Special:ChangeRating is vulnerable to CSRF.
Wed, May 1, 1:03 AM · SecTeam-Processed, Vuln-CSRF, ArticleRatings, Security
ashley created T363884: Special:ChangeRating is vulnerable to CSRF.
Wed, May 1, 1:02 AM · SecTeam-Processed, Vuln-CSRF, ArticleRatings, Security

Mon, Apr 29

ashley closed T363178: SpecialUndeleteWithVideoSupport: Error: Undefined class constant 'READ_NORMAL' as Resolved.

With the linked patch merged, this should now hopefully be fixed.

Mon, Apr 29, 1:40 PM · ci-test-error, Social-Tools, Video extension
ashley moved T363178: SpecialUndeleteWithVideoSupport: Error: Undefined class constant 'READ_NORMAL' from Backlog to Video on the Social-Tools board.
Mon, Apr 29, 1:39 PM · ci-test-error, Social-Tools, Video extension
ashley moved T363693: Birthday formatter code is an i18n nightmare from Backlog to SocialProfile on the Social-Tools board.
Mon, Apr 29, 1:39 PM · Social-Tools, Technical-Debt, I18n, SocialProfile
ashley moved T363693: Birthday formatter code is an i18n nightmare from Backlog to Bugs on the SocialProfile board.
Mon, Apr 29, 1:16 PM · Social-Tools, Technical-Debt, I18n, SocialProfile
ashley created T363693: Birthday formatter code is an i18n nightmare.
Mon, Apr 29, 12:32 PM · Social-Tools, Technical-Debt, I18n, SocialProfile

Sun, Apr 28

ashley committed rEPGA124c695c11c6: Fix up clickjacking code for MediaWiki 1.41+.
Fix up clickjacking code for MediaWiki 1.41+
Sun, Apr 28, 12:53 PM
ashley awarded T363632: WikiData user interface should have native fallbacks for en language labels when other English variants exist a Like token.
Sun, Apr 28, 12:19 PM · Wikidata

Sat, Apr 27

ashley committed rEMWC233e3cd4720d: Technically speaking it's not using wfGetDB anymore.
Technically speaking it's not using wfGetDB anymore
Sat, Apr 27, 5:12 PM
ashley committed rEMWC04a018775cc7: Fix up the $wgActionFilteredLogs definition in extension.json (to make CI happy).
Fix up the $wgActionFilteredLogs definition in extension.json (to make CI happy)
Sat, Apr 27, 1:53 PM
ashley committed rEMWC969b5b1b2b0d: Change a few (nowadays deprecated) wfGetDB( DB_REPLICA ) calls in API….
Change a few (nowadays deprecated) wfGetDB( DB_REPLICA ) calls in API…
Sat, Apr 27, 12:43 PM
ashley committed rEMWCfe3a6db2d9cb: "Fix" escaping in extension.json to make CI slightly less grumpy.
"Fix" escaping in extension.json to make CI slightly less grumpy
Sat, Apr 27, 12:41 PM
ashley committed rEMWC538466624958: Documentation and tiny coding style tweaks for MediaWikiChat.js.
Documentation and tiny coding style tweaks for MediaWikiChat.js
Sat, Apr 27, 12:32 PM
ashley added a comment to T363037: Error when extension HelpPages is installed when creating the listing which includes a Help page.

Change #1024859 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/extensions/HelpPages@master] Looks like a Title is passed to HelpPages#helpPageExists when called from SkinTemplateNavigationUniversal hook handler

https://gerrit.wikimedia.org/r/1024859

Sat, Apr 27, 12:18 PM · MediaWiki-extensions-Other, MediaWiki-extensions-Approved-Revs

Fri, Apr 26

ashley added a member for MediaWiki-extensions-GlobalUserrights: ashley.
Fri, Apr 26, 10:56 PM
ashley added a comment to T361920: The SQL files of GlobalUserrights are not compatible with PostgresQL.

Indeed.

Fri, Apr 26, 5:01 PM · MediaWiki-extensions-GlobalUserrights, PostgreSQL
ashley committed rEMWCb6fce7d48201: Convert extension.json to manifest_version 2 to be able to document the custom….
Convert extension.json to manifest_version 2 to be able to document the custom…
Fri, Apr 26, 3:51 PM
ashley committed rEMWCd27b32080d93: Use relative positioning on #mwchat-content to mitigate abuse occurring from….
Use relative positioning on #mwchat-content to mitigate abuse occurring from…
Fri, Apr 26, 2:11 PM
ashley closed T170479: Absolute CSS positions stops the chat being selectable as Resolved.

Many thanks to @Ciencia_Al_Poder for helping me out with this!

Fri, Apr 26, 2:10 PM · MediaWikiChat
ashley added a comment to T144658: Feature request: Have MediaWikiChat display a "-" rather than a "+" in the tab/window title when users leave the chat.

It seems like all that has happened is that - has replaced +, as when a user joins/leaves, - is displayed regardless.

Indeed. Something I failed to understand back in 2016 was that the appropriately named MediaWikiChat.flashJoinLeave method is called for both cases: when someone joins AND also when someone leaves the chat. Its internals do not change depending on the action type, it always performs the same logic.

Fri, Apr 26, 1:46 PM · MediaWikiChat, Brickimedia
ashley closed T145312: Implement a chat kick log for MediaWikiChat as Resolved.
Fri, Apr 26, 1:29 PM · MediaWikiChat, Brickimedia
ashley committed rEMWC9c8e4bad388f: Allow filtering Special:Log/chat to show only user kicks.
Allow filtering Special:Log/chat to show only user kicks
Fri, Apr 26, 1:27 PM
ashley edited Description on Brickimedia.
Fri, Apr 26, 5:25 AM

Thu, Apr 25

ashley committed rEMWC986d8d3750a6: No-JS adjustments.
No-JS adjustments
Thu, Apr 25, 1:53 PM

Wed, Apr 24

ashley committed rEMWCb6d4ecc005cd: Escaping adjustments in MediaWikiChat.js: .text() (allows HTML) -> .escaped()….
Escaping adjustments in MediaWikiChat.js: .text() (allows HTML) -> .escaped()…
Wed, Apr 24, 11:17 AM
ashley committed rEMWCcc1a5e57f4d0: Explicitly specify mw.message() output type in showUnblockMessage().
Explicitly specify mw.message() output type in showUnblockMessage()
Wed, Apr 24, 11:08 AM
ashley committed rEMWC8c9e7d8a8ec4: Unify chat mod image handling and create a getter for it.
Unify chat mod image handling and create a getter for it
Wed, Apr 24, 11:07 AM
ashley closed T145181: MediaWikiChat should not call Parser::doMagicLinks() directly as Resolved.

@Paladox seems to have taken care of this in be12f3c79e57116dd75049c2979ca26e05fba1ca (thanks!).

Wed, Apr 24, 12:16 AM · Brickimedia, Technical-Debt, MediaWikiChat
ashley closed T209024: Don't load assets from external sites as Resolved.
Wed, Apr 24, 12:11 AM · MediaWikiChat
ashley committed rEMWCc43e27e83317: Fix up the chat moderator indicator image stuff to have a sane default.
Fix up the chat moderator indicator image stuff to have a sane default
Wed, Apr 24, 12:11 AM

Tue, Apr 23

ashley committed rEMWC833e83ce7a23: Remove call to (deprecated) ParserOptions#setAllowExternalImages.
Remove call to (deprecated) ParserOptions#setAllowExternalImages
Tue, Apr 23, 11:51 PM
ashley committed rEMWC414b71268056: Fix up the "display online users in the sidebar when $wgChatSidebarPortlet =….
Fix up the "display online users in the sidebar when $wgChatSidebarPortlet =…
Tue, Apr 23, 9:46 PM
ashley committed rEMWC2ef6607765ff: Change output format from plain to escaped for a bunch of Special:Chat UI….
Change output format from plain to escaped for a bunch of Special:Chat UI…
Tue, Apr 23, 9:43 PM
ashley closed T362588: Classic CSRF in MediaWikiChat's API modules as Resolved.

MWC is hosted on WMF gerrit, it hasn't been hosted on GitHub since 2017 or so.

Tue, Apr 23, 8:33 PM · security-bug, SecTeam-Processed, Vuln-CSRF, MediaWikiChat, Security
ashley committed rEMWC1d0784ece6cc: [SECURITY] Avoid classic CSRF in API modules.
[SECURITY] Avoid classic CSRF in API modules
Tue, Apr 23, 8:29 PM
ashley committed rEMWC3ed752603a54: Fix variable name.
Fix variable name
Tue, Apr 23, 1:36 AM

Mon, Apr 22

ashley renamed T363084: Remove usage of MediaWiki's JsonBodyValidator from Wikibase REST API from Remove usege of Mediawiki's JsonBodyValidator from Wikibase REST API to Remove usage of MediaWiki's JsonBodyValidator from Wikibase REST API.
Mon, Apr 22, 8:08 PM · Patch-For-Review, Wikibase Product Platform Team WPP

Fri, Apr 19

ashley committed rEMWCf2c44d796013: Use namespaced CheckUser hook class + different "is CheckUser installed?" test.
Use namespaced CheckUser hook class + different "is CheckUser installed?" test
Fri, Apr 19, 1:48 PM
ashley committed rEMWC478cdcda8462: Fix message parsing for the /me command when $wgChatMeCommand is set to true.
Fix message parsing for the /me command when $wgChatMeCommand is set to true
Fri, Apr 19, 1:38 PM
ashley closed T189417: /me command doesn't work as Resolved.

Now fixed in master.

Fri, Apr 19, 1:38 PM · MediaWikiChat

Apr 16 2024

ashley closed T53296: Add a machine-readable output format to articlefeedbackv5-view-feedback API as Resolved.

Only a bit over a decade later, this is now finally fixed. :)

Apr 16 2024, 8:56 AM · ArticleFeedbackv5
ashley moved T362588: Classic CSRF in MediaWikiChat's API modules from Backlog to Bugs on the MediaWikiChat board.
Apr 16 2024, 12:21 AM · security-bug, SecTeam-Processed, Vuln-CSRF, MediaWikiChat, Security
ashley claimed T362588: Classic CSRF in MediaWikiChat's API modules.
Apr 16 2024, 12:20 AM · security-bug, SecTeam-Processed, Vuln-CSRF, MediaWikiChat, Security
ashley created T362588: Classic CSRF in MediaWikiChat's API modules.
Apr 16 2024, 12:20 AM · security-bug, SecTeam-Processed, Vuln-CSRF, MediaWikiChat, Security

Apr 14 2024

ashley committed rEMWC6c5a368c2fe2: Random cleanup.
Random cleanup
Apr 14 2024, 5:55 AM
ashley committed rESPR4f1981dd3a7e: Make phan happy again?.
Make phan happy again?
Apr 14 2024, 5:08 AM

Apr 3 2024

ashley committed rSGMDd83c0a04e676: SECURITY: avoid stored XSS via MediaWiki:Sidebar.
SECURITY: avoid stored XSS via MediaWiki:Sidebar
Apr 3 2024, 9:24 PM

Apr 1 2024

ashley created T361476: E_NOTICE & E_WARNING when MediaWiki:Sidebar does not contain an entry titled "navigation".
Apr 1 2024, 3:34 PM · Patch-For-Review, Poncho

Mar 31 2024

ashley updated subscribers of T361452: Foreground skin: stored XSS via MediaWiki:Sidebar.

CC'ing @Samwilson since you've recently committed to this repository with significant contributions.

Mar 31 2024, 9:27 PM · security-bug, SecTeam-Processed, MediaWiki-skins-Foreground, Vuln-XSS, Security
ashley added projects to T361452: Foreground skin: stored XSS via MediaWiki:Sidebar: Vuln-XSS, MediaWiki-skins-Foreground.
Mar 31 2024, 9:25 PM · security-bug, SecTeam-Processed, MediaWiki-skins-Foreground, Vuln-XSS, Security
ashley created T361452: Foreground skin: stored XSS via MediaWiki:Sidebar.
Mar 31 2024, 9:25 PM · security-bug, SecTeam-Processed, MediaWiki-skins-Foreground, Vuln-XSS, Security
ashley edited Description on Other-skins.
Mar 31 2024, 9:12 PM