That could also work :D

From your description: on pageview 1 a cookie would be set that defined what banner content should be served on pageview 2.

There are a number of technical issues here whereby using cookies is going to be problematic for privacy sensitive users (theoretically they might never see a community banner) or on mobile where cookie setting is known to be problematic for us where we could see real impacts on campaigns like Wiki Loves Monuments which is heavily skewed towards mobile or in non-european countries where the majority of our traffic is mobile.

The rest of my comment about inequitably treating community campaigns is the main point but advocacy campaigns include blackout campaigns where full screen banners are used. That's only possible when banner impressions are delivered on all page views.

@AndyRussG your proposed solution is not ideal. It could seriously hamper non fundraising campaigns which are generally run by the community. There are a number of other types of campaign that would need to be excluded including maintenance and advocacy campaigns.

Is it possible to get some details on how to replicate the error?

@mwilliams awesome. I'll finalise the patch and get it ready for review.

I'm fairly sure the errors are cause by this banner campaign which is contemporaneous with the errors occurring.

The closest equivalent is https://doc.wikimedia.org/oojs-ui/master/demos/?page=icons&theme=wikimediaui&direction=ltr&platform=desktop#demo-section-editing-citation

Whilst doing this ticket, I also fixed hover and focus behavior

Is the solution to this: stop supporting IE11?

@mwilliams - Whilst I'm doing this, would you like the :focus and hover behavior of the icon and box to mirror that of special:search?

@mwilliams just to confirm as well as 16px and base20 grey, font-weight from bold -> normal as well?

Notes:

• https://codesearch.wmcloud.org/search/?q=wbmi-media-search-no-results__tips&i=nope&files=&excludeFiles=&repos=
• https://codesearch.wmcloud.org/search/?q=wikibasemediainfo-special-mediasearch-end-of-results-tips&i=nope&files=&excludeFiles=&repos=

@mwilliams just to clarify. Is it just on "EndOfResults" you want this removed or so you want this extra message removed from "NoResults" as well ?

@mwilliams Just taken a gander at this. At the moment there is 12-17 px of white space with padding associated with the filters and 16 px of whitespace associated with the search results from a margin.

1. @media screen and (min-width: 720px) .wbmi-select__content:
   1. padding: 6px 36px 6px 12px;
      1. .wbmi-select__content:
   2. padding: 11px 36px 11px 12px;
      1. .wbmi-media-search-filters
   3. min-height: 2.5em
   4. padding: 6px 0px
      1. .wbmi-media-search-results
   5. margin: 16px 0

I've resolved this task since they are now working. Lets create a seperate task for performance with the WDQS.

That'll do! Good with me.

On the 12th January, I left the following comment on irc:

I've temporarily added