Page MenuHomePhabricator

ContentTranslation should not validate single sections against abuse filters intended for full pages
Open, MediumPublic

Description

This causes false warnings for users (and confusion for AbuseFilter maintainers, given T134678).

According to a comment, ContentTranslation's code:

Don't validate sections that are too short. The validations happen while editing is going on.

If I read it right, CT submits the text of a single section to the filters as if it were the content of the whole page! Obviously, this will cause false positives with filters which check for things in the whole page (e.g.: are there references in the page? [not in a specific section]).

This must be what causes the problem described by MisterSanderson on MediaWiki.org.

Event Timeline

Amire80 triaged this task as Medium priority.May 19 2016, 4:30 PM
Amire80 added a project: Essential-Work.
Amire80 moved this task from Needs Triage to Bugs on the ContentTranslation board.

Sending the full page every time would be too slow and would not allow identifying which section is causing the warning. We are trying to find a middle ground here. The main issue is that AbuseFilter is being used more and more to enforce rules that are not about abuse, and AbuseFilter is not well suited for that from our point of view.

Pginer-WMF subscribed.

There seems to be activity to explore more real-time guidance in T265163: Create a system to encode best practices into editing experiences
Once a system with real-time checks on content is available, we can avoid using edit filters for this, which is not ideal.