We could create a "mysql" container that has mysql, mysqldump, etc. on top of the standalone image.

In T254636#7910464, @Legoktm wrote:

We could create a "mysql" container that has mysql, mysqldump, etc. on top of the standalone image.

@MusikAnimal, would a solution like this, basically making an image mostly for doing mysqldump actions, work for the set of tools you have indicated are blocked on this task?

In T254636#8314736, @bd808 wrote:

We could create a "mysql" container that has mysql, mysqldump, etc. on top of the standalone image.

@MusikAnimal, would a solution like this, basically making an image mostly for doing mysqldump actions, work for the set of tools you have indicated are blocked on this task?

Yes, I think so. The remaining grid engine jobs for musikbot and grantmetrics are only mysql backup scripts written in bash. commtech-commons has one script that needs Python 3, but at quick review it seems I should be able to migrate that one (I'm not sure why I didn't already). The other cron job is a cleanup script that uses the sql local command, but if that shortcut is not available we can use the longer-form mysql equivalent. That script also uses logrotate, if that matters.

In T254636#8314790, @MusikAnimal wrote:

The other cron job is a cleanup script that uses the sql local command, but if that shortcut is not available we can use the longer-form mysql equivalent.

sql comes from our local "misctools" deb package. That package also includes the become, take and the oge-crontab script. become and oge-crontab don't make a lot of sense from inside a Kubernetes container, but they are tiny and wouldn't really hurt anything.

That script also uses logrotate, if that matters.

That seems like a reasonable package to add to the same image too.

Change 842993 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[operations/docker-images/toollabs-images@master] mysql: new image for mysql backups

https://gerrit.wikimedia.org/r/842993

Change 842993 merged by jenkins-bot:

[operations/docker-images/toollabs-images@master] mariadb: new image for mariadb/mysql backups

https://gerrit.wikimedia.org/r/842993

Mentioned in SAL (#wikimedia-cloud) [2023-02-17T10:25:01Z] <arturo> build and push mariadb-sssd/base docker image for Toolforge (T320178, T254636)

aborrero opened https://gitlab.wikimedia.org/repos/cloud/toolforge/image-config/-/merge_requests/4

data.yaml: introduce mariadb image for jobs-framework

aborrero merged https://gitlab.wikimedia.org/repos/cloud/toolforge/image-config/-/merge_requests/4

data.yaml: introduce mariadb image for jobs-framework

Mentioned in SAL (#wikimedia-cloud-feed) [2023-02-17T11:17:06Z] <wm-bot2> deployed kubernetes component https://gitlab.wikimedia.org/repos/cloud/toolforge/image-config (7729b18) (T254636) - cookbook ran by arturo@endurance

Mentioned in SAL (#wikimedia-cloud-feed) [2023-02-17T11:31:37Z] <wm-bot2> deployed kubernetes component https://gitlab.wikimedia.org/repos/cloud/toolforge/image-config (7729b18) (T254636) - cookbook ran by arturo@endurance

Hi! I tried using this but ran into some problems (T319779#9278315):

tools.grantmetrics@tools-sgebastion-10:~$ toolforge-jobs run backup --command ./var/backups/backup.sh --image mariadb
tools.grantmetrics@tools-sgebastion-10:~$ cat backup.err 
mysqldump: Got error: 2002: "Can't connect to local server through socket '/run/mysqld/mysqld.sock' (2)" when trying to connect
ERROR 2002 (HY000): Can't connect to local server through socket '/run/mysqld/mysqld.sock' (2)

The relevant part of the script:

GMDIR=/data/project/grantmetrics
DATE=$(date +%Y-%m-%d)

# Dump and compress whole database.
mysqldump --defaults-extra-file=$GMDIR/replica.my.cnf \
  --single-transaction s53550__grantmetrics \
  | gzip -c > $GMDIR/var/backups/grantmetrics_$DATE.sql.gz

I thought maybe the directory was simply wrong in the context of the k8s container, but I printed $PWD and saw it's still the right path. So something else is preventing it from connecting to the tools-db.

@MusikAnimal Surely the mysqldump command needs a --host argument? The error message indicates it's trying to connect to the local mysql socket, but there's no mariadb/mysql running on the container itself, so it errors out.

Surely the mysqldump command needs a --host argument? The error message indicates it's trying to connect to the local mysql socket, but there's no mariadb/mysql running on the container itself, so it errors out.

Thanks! I had tried that the other day and got the same error. Your comment however prompted me to look again, only to find there was simply a second mysql command that was missing the host :face_palm:

Sorry for the noise!

For anyone who lands here via search, the docs have a cleaner recommendation for backups than the script at T254636#9385420.