Page MenuHomePhabricator
Create Task
Maniphest T258856

Links to variants titles in Parsoid are still marked as red links
Open, MediumPublic
Actions

Description

This is the parser test "Multiple links to pages in language variants".

The alternate links should not be redlinks, but Parsoid doesn't do variant conversion before it does redlink processing.

Details

SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to 0.20.0-a5mediawiki/vendormaster+639 -370
Disable Chinese language conversion for variant link resolutionmediawiki/services/parsoidmaster+25 -8
Implement basic variant link resolutionmediawiki/services/parsoidmaster+264 -26
Customize query in gerrit

Related Objects
Search...

Event Timeline

cscott created this task.Jul 25 2020, 4:15 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 25 2020, 4:15 AM
Arlolra subscribed.Jul 27 2020, 7:06 PM

Redlink processing is the last step though and Parsoid's parserTests pretty much considers all links as known when it's doing redlink processing,
https://github.com/wikimedia/parsoid/blob/master/src/Config/Api/DataAccess.php#L144-L146

cscott added a comment.Jul 27 2020, 7:13 PM

Not after https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/616132 (in integrated mode parsertests returns accurate known/missing info).

Arlolra added a comment.Jul 27 2020, 7:18 PM

But even there redlinks is the last pass to run, no?

cscott added a comment.Jul 27 2020, 7:24 PM

Well, I think we need to re-run red link processing after language conversion. And I'm not sure that title normalization on links is implemented yet either.

ssastry triaged this task as Medium priority.Aug 5 2020, 9:45 PM
ssastry moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.
ssastry added a project: Parsoid-Rendering.
ssastry moved this task from Bugs & Crashers to Following Quarter on the Parsoid board.Nov 19 2020, 7:16 PM
Arlolra moved this task from Following Quarter to Bugs & Crashers on the Parsoid board.Sep 14 2021, 9:33 PM
gerritbot added a comment.Nov 10 2021, 10:22 PM

Change 738019 had a related patch set uploaded (by TK-999; author: TK-999):

[mediawiki/services/parsoid@master] Implement basic variant link resolution

https://gerrit.wikimedia.org/r/738019

gerritbot added a project: Patch-For-Review.Nov 10 2021, 10:22 PM
ssastry added a project: Parsoid-Read-Views.May 11 2022, 9:44 PM
TK-999 subscribed.Jul 5 2022, 4:44 PM
• JMcLeod_WMF moved this task from Uncategorized to Phase 2 - testwiki Main namespace support on the Parsoid-Read-Views board.Jul 28 2022, 2:15 PM
• JMcLeod_WMF edited projects, added Parsoid-Read-Views (Phase 2 - testwiki Main namespace support); removed Parsoid-Read-Views.
TK-999 added a comment.Oct 9 2023, 11:03 PM

Rebased this since it got a question about its status, just wanted to note per earlier discussions on the patch that T296023 probably needs to be resolved first to unblock this.

matmarex added a subtask: T53587: Parsoid needs to run findVariantLink or some equivalent thing.Nov 30 2023, 7:27 PM
matmarex subscribed.
gerritbot added a comment.Sun, May 5, 8:52 AM

Change #738019 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Implement basic variant link resolution

https://gerrit.wikimedia.org/r/738019

Maintenance_bot removed a project: Patch-For-Review.Sun, May 5, 9:30 AM
Arlolra added a project: Content-Transform-Team-WIP.Sun, May 5, 9:31 AM
Arlolra moved this task from Backlog to To Deploy on the Content-Transform-Team-WIP board.
ssastry mentioned this in T358193: Investigate and fix the behaviour of Language Converter around redlinks and self-links in Parsoid.Mon, May 13, 12:39 PM
cscott claimed this task.Mon, May 13, 3:08 PM
cscott moved this task from To Deploy to Code Review on the Content-Transform-Team-WIP board.
gerritbot added a comment.Fri, May 17, 9:29 AM

Change #1032723 had a related patch set uploaded (by TK-999; author: TK-999):

[mediawiki/services/parsoid@master] Disable Chinese language conversion for variant link resolution

https://gerrit.wikimedia.org/r/1032723

gerritbot added a project: Patch-For-Review.Fri, May 17, 9:29 AM
gerritbot added a comment.Sun, May 19, 12:18 PM

Change #1032723 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Disable Chinese language conversion for variant link resolution

https://gerrit.wikimedia.org/r/1032723

Maintenance_bot removed a project: Patch-For-Review.Sun, May 19, 12:30 PM
gerritbot added a comment.Mon, May 20, 5:26 PM

Change #1034127 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a5

https://gerrit.wikimedia.org/r/1034127

gerritbot added a project: Patch-For-Review.Mon, May 20, 5:26 PM
gerritbot added a comment.Mon, May 20, 5:55 PM

Change #1034127 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a5

https://gerrit.wikimedia.org/r/1034127

Maintenance_bot removed a project: Patch-For-Review.Mon, May 20, 6:32 PM
ssastry moved this task from Code Review to To Deploy on the Content-Transform-Team-WIP board.Tue, May 21, 2:28 PM
ssastry moved this task from To Deploy to To Verify on the Content-Transform-Team-WIP board.Wed, May 29, 9:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL