Page MenuHomePhabricator
Create Task
Maniphest T269264

URL Shortener sometimes appears "string" header
Closed, ResolvedPublic
Actions

Description

Hello,

Sometimes Special:UrlShortener appears "string" header on the browser (See the image)

capture-20201202-191040.png (625×1 px, 61 KB)

Reproduce

  • Happened through Google Chrome; 87.0.4280.66
  • There's no specific things that make it happened, but usually if I click on "Shorten" and the page still opening.

Is that normal to happen?

Details

SubjectRepoBranchLines +/-
Remove var_dump() left by mistakemediawiki/extensions/UrlShortenerwmf/1.36.0-wmf.20+0 -1
Remove var_dump() left by mistakemediawiki/extensions/UrlShortenermaster+0 -1
Customize query in gerrit

Event Timeline

alaa created this task.Dec 2 2020, 5:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 2 2020, 5:18 PM
Daimona added subscribers: Ladsgroup, Esanders, Daimona.Dec 2 2020, 5:22 PM

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UrlShortener/+/619300/2/includes/UrlShortenerUtils.php#277 ouch.

DannyS712 subscribed.Dec 2 2020, 5:37 PM
gerritbot added a comment.Dec 2 2020, 5:48 PM

Change 644879 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/UrlShortener@master] Remove var_dump() left by mistake

https://gerrit.wikimedia.org/r/644879

gerritbot added a project: Patch-For-Review.Dec 2 2020, 5:48 PM
gerritbot added a comment.Dec 2 2020, 5:51 PM

Change 644814 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/UrlShortener@wmf/1.36.0-wmf.20] Remove var_dump() left by mistake

https://gerrit.wikimedia.org/r/644814

gerritbot added a comment.Dec 2 2020, 5:55 PM

Change 644879 merged by jenkins-bot:
[mediawiki/extensions/UrlShortener@master] Remove var_dump() left by mistake

https://gerrit.wikimedia.org/r/644879

gerritbot added a comment.Dec 2 2020, 5:57 PM

Change 644814 merged by jenkins-bot:
[mediawiki/extensions/UrlShortener@wmf/1.36.0-wmf.20] Remove var_dump() left by mistake

https://gerrit.wikimedia.org/r/644814

Esanders added a comment.Dec 2 2020, 6:00 PM

Oops.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.21; 2020-12-08).Dec 2 2020, 6:00 PM
Ladsgroup closed this task as Resolved.Dec 2 2020, 6:03 PM
Ladsgroup claimed this task.

This should never happen again. Re-open if it does. Thanks for reporting! There is a phpcs rule to avoid such cases, we should enable it for most extensions.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptDec 2 2020, 6:03 PM
alaa awarded a token.Dec 2 2020, 6:08 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 2 2020, 6:10 PM
Maintenance_bot moved this task from Incoming to Done on the User-Ladsgroup board.Dec 2 2020, 6:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL