Page MenuHomePhabricator

Ladsgroup (Amir Sarabadani)
Shah of Bugs, Emir of database architecture, World-renowned rubber duckAdministrator

Projects (36)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 9:53 PM (502 w, 18 h)
Roles
Administrator
Availability
Available
IRC Nick
Amir1
LDAP User
Ladsgroup
MediaWiki User
Ladsgroup [ Global Accounts ]

Staff Database Architect in SRE data persistence team in WMF. Used to be Wikidata software engineer at WMDE

I'm also open source enthusiast, mediawiki volunteer developer, and long-term Wikipedian.

All edits on tickets about databases are in my work capacity and anything else is in my volunteer capacity unless mentioned otherwise.

Babel: fa-N, en-4, de-2, tr-1, hu-1

Recent Activity

Today

Ladsgroup added a comment to T365497: bldrwnsch update is broken – Unknown column 'pagelinks.pl_title'.

That query is wrong, JOIN pagelinks ON pagelinks.pl_target_id = page.page_id won't work. pl_target_id is not FK to page_id, pl_from is but it depends on your usecase.

Tue, May 21, 4:04 PM · Wikimedia-production-error
Ladsgroup added a comment to T362646: Enable more nuanced targeting and sampling on Quicksurveys.

We could not find a way to fo "left" using Wikimedia ORM and we used "SUBSTR" instead. Is that ok? or can you suggest a better method to use

Tue, May 21, 10:26 AM · Patch-For-Review, WMF-Safety-Survey
Ladsgroup added a comment to T362646: Enable more nuanced targeting and sampling on Quicksurveys.

Hi, I responded in the patch. hope that'd be useful for you.

Tue, May 21, 10:22 AM · Patch-For-Review, WMF-Safety-Survey
Ladsgroup committed rSCHCHf19a0c11cc71: change_gb_timestamp_T307501.py: Schema change (authored by Marostegui).
change_gb_timestamp_T307501.py: Schema change
Tue, May 21, 9:26 AM
Ladsgroup committed rSCHCH4181929fd977: Merge branch 'T307501' into 'main'.
Merge branch 'T307501' into 'main'
Tue, May 21, 9:26 AM
Ladsgroup added a comment to T275319: Raise limit of $wgMaxArticleSize for Hebrew Wikisource.

Honestly, I think this should be declined as this is a x/y problem. I understand you need to see content of the whole law in one place, but that doesn't mean size of page should increase. A proper solution here is to have a way to see a full book or set of pages in one place. Think of google docs or a PDF file. That is doable but needs to resourced and prioritized and implemented. That can be useful in many other areas too (being able to read a large book in a way of "infinite scroll" on the wiki)

Tue, May 21, 9:22 AM · Language-Technical Support, serviceops, SRE, Wikimedia-Site-requests
Ladsgroup added a comment to T365327: Consider preferring TLS_AES_128_GCM_SHA256 over TLS_AES_256_GCM_SHA384.

Does reducing the key sizes (from 256 to 128 for AES and 386 to 256 for SHA) sound good to people? We can deploy it temporarily and measure the impact.

Tue, May 21, 9:11 AM · Traffic

Yesterday

Ladsgroup added a comment to T364347: Popups: Make use of conditional user defaults.

Awesome thank you!

Mon, May 20, 10:42 PM · Patch-For-Review, Web-Team-Backlog (FY2023-24 Q4 Sprint 4), Web Team Essential Work 2024, Page-Previews
Ladsgroup added a comment to T275319: Raise limit of $wgMaxArticleSize for Hebrew Wikisource.

While non-Latin characters take twice as space, since Arabic and Hebrew scripts don't write short vowels (unless for children or disambiguation), the average letter per word is much lower than Latin scripts. In other words, even if you translate it to English, it'll just go above the threshold.

Mon, May 20, 6:33 PM · Language-Technical Support, serviceops, SRE, Wikimedia-Site-requests
Ladsgroup added a comment to T275319: Raise limit of $wgMaxArticleSize for Hebrew Wikisource.

I wish to avoid the discussion what "should be" the limit of the page length, in characters.

Mon, May 20, 5:57 PM · Language-Technical Support, serviceops, SRE, Wikimedia-Site-requests
Ladsgroup added a comment to T352010: Gradually drop old pagelinks columns.

Yes. s5 wikireplica needs to actually get the alter (will be over in an hour) and then a run of maintain views. Be patient. It will be resolved soon.

Mon, May 20, 5:02 PM · Schema-change-in-production, DBA, MediaWiki-Page-derived-data
Ladsgroup updated the task description for T352010: Gradually drop old pagelinks columns.
Mon, May 20, 4:42 PM · Schema-change-in-production, DBA, MediaWiki-Page-derived-data
Ladsgroup added a watcher for Huma: Ladsgroup.
Mon, May 20, 3:03 PM
Ladsgroup updated the task description for T352010: Gradually drop old pagelinks columns.
Mon, May 20, 1:45 PM · Schema-change-in-production, DBA, MediaWiki-Page-derived-data
Ladsgroup edited Description on Huma.
Mon, May 20, 1:26 PM
Ladsgroup created Huma.
Mon, May 20, 1:26 PM

Sun, May 19

Ladsgroup created T365335: Unify various wikidata description consumption.
Sun, May 19, 10:20 PM · Wikipedia-iOS-App-Backlog, Wikidata, iOS-app-feature-Performance, MobileFrontend, MediaWiki-extensions-WikibaseClient
Ladsgroup added a comment to T364404: Wikimedia\Rdbms\DBTransactionSizeError: Transaction spent {time}s in writes, exceeding the 3s limit.

A possible solution to this problem is this: T365303: Move update of category members count to CategoryMembershipChangeJob

Sun, May 19, 10:01 PM · Wikimedia-production-error
Ladsgroup added a comment to T365303: Move update of category members count to CategoryMembershipChangeJob.

Yeah, this would fix that bug automatically but maybe it's not a good solution. Depending on what mediawiki team thinks about this.

Sun, May 19, 9:59 PM · MediaWiki-Core-DeferredUpdates
Ladsgroup created T365329: [GOAL] Make History page show in dark mode.
Sun, May 19, 4:45 PM · FY2023-24-WE 2.1 Typography and palette customizations, Web-Team-Backlog
Ladsgroup renamed T365327: Consider preferring TLS_AES_128_GCM_SHA256 over TLS_AES_256_GCM_SHA384 from Consider using TLS_AES_128_GCM_SHA256 instead of TLS_AES_256_GCM_SHA384 to Consider preferring TLS_AES_128_GCM_SHA256 over TLS_AES_256_GCM_SHA384.
Sun, May 19, 1:48 PM · Traffic
Ladsgroup added a comment to T365327: Consider preferring TLS_AES_128_GCM_SHA256 over TLS_AES_256_GCM_SHA384.

Okay cool. Thanks for checking.

Sun, May 19, 1:44 PM · Traffic
Ladsgroup added a comment to T365327: Consider preferring TLS_AES_128_GCM_SHA256 over TLS_AES_256_GCM_SHA384.

Chacha20 is faster than AES when both are running without hardware acceleration. If AES-NI is present, AES is faster. This is also considered by clients to choose their ciphersuite suite to be sent to the server as part of the ClientHello

Sun, May 19, 1:38 PM · Traffic
Ladsgroup added a comment to T365327: Consider preferring TLS_AES_128_GCM_SHA256 over TLS_AES_256_GCM_SHA384.

Stupid note: In my phone, it still prefers AES256. Maybe my client for whatever reason doesn't support ChaCha20 or it thinks it's strong enough to just go with AES instead. But I will try to confirm SSL_OP_PRIORITIZE_CHACHA is working.

Sun, May 19, 1:35 PM · Traffic
Ladsgroup added a comment to T365327: Consider preferring TLS_AES_128_GCM_SHA256 over TLS_AES_256_GCM_SHA384.

Just to make it clearer, ChaCha20 is still that's not my preference. I prefer simply reducing the key size for AES and SHA instead.

Sun, May 19, 1:26 PM · Traffic
Ladsgroup added a comment to T365327: Consider preferring TLS_AES_128_GCM_SHA256 over TLS_AES_256_GCM_SHA384.

I should have been clearer, Meta prefers it everywhere including desktop. It's the top of ciphersuite by default including where it's not the top of client's cipher suite too. Maybe because fb/instagram is heavily targeted for mobile users.

Sun, May 19, 1:24 PM · Traffic
Ladsgroup added a comment to T365327: Consider preferring TLS_AES_128_GCM_SHA256 over TLS_AES_256_GCM_SHA384.

We can also consider preferring ChaCha20 everywhere as well like Meta websites.

Sun, May 19, 12:22 PM · Traffic
Ladsgroup updated the task description for T365327: Consider preferring TLS_AES_128_GCM_SHA256 over TLS_AES_256_GCM_SHA384.
Sun, May 19, 12:14 PM · Traffic
Ladsgroup created T365327: Consider preferring TLS_AES_128_GCM_SHA256 over TLS_AES_256_GCM_SHA384.
Sun, May 19, 12:13 PM · Traffic

Fri, May 17

Ladsgroup added a comment to T365055: [REPO][SW] DatabaseTermStoreWriterBase::acquireAndInsertTerms() shouldn't lock all rows for the item.

Also noting that I'm talking about the lock in ::acquireAndInsertTerms() and not the one on ::deleteTermsWithoutClean() as the latter happens much less frequently and doesn't lock contention from what I'm seeing.

Fri, May 17, 10:19 PM · Wikidata Dev Team, wmde-wikidata-tech, Wikidata, MediaWiki-extensions-WikibaseRepository
Ladsgroup created T365303: Move update of category members count to CategoryMembershipChangeJob.
Fri, May 17, 10:10 PM · MediaWiki-Core-DeferredUpdates
Ladsgroup added a comment to T365055: [REPO][SW] DatabaseTermStoreWriterBase::acquireAndInsertTerms() shouldn't lock all rows for the item.

I agree that the pruning part needs to be rethought and revamped but I'm failing to see how it's connected to this problem. This is explicitly about locking the rows in wbt_item_terms which is the head. Let's say for Q1234 you have this:

+------------+--------------+----------------------+
| wbit_id    | wbit_item_id | wbit_term_in_lang_id |
+------------+--------------+----------------------+
|  767752395 |     1234 |                    5 |
| 6682347558 |    1234 |                  172 |
|   95594787 |      1234 |                  192 |
|   34102141 |       1234 |                  237 |
|  561818268 |     1234 |                  274 |
+------------+--------------+----------------------+
Fri, May 17, 9:51 PM · Wikidata Dev Team, wmde-wikidata-tech, Wikidata, MediaWiki-extensions-WikibaseRepository

Thu, May 16

Ladsgroup updated the task description for T352010: Gradually drop old pagelinks columns.
Thu, May 16, 7:32 PM · Schema-change-in-production, DBA, MediaWiki-Page-derived-data
Ladsgroup updated the task description for T352010: Gradually drop old pagelinks columns.
Thu, May 16, 5:45 PM · Schema-change-in-production, DBA, MediaWiki-Page-derived-data
Ladsgroup added a subtask for T352010: Gradually drop old pagelinks columns: T364541: Switchover s8 master (db1209 -> db1192).
Thu, May 16, 2:18 PM · Schema-change-in-production, DBA, MediaWiki-Page-derived-data
Ladsgroup added a parent task for T364541: Switchover s8 master (db1209 -> db1192): T352010: Gradually drop old pagelinks columns.
Thu, May 16, 2:18 PM · Patch-For-Review, DBA
Ladsgroup updated the task description for T352010: Gradually drop old pagelinks columns.
Thu, May 16, 1:51 PM · Schema-change-in-production, DBA, MediaWiki-Page-derived-data
Ladsgroup closed T365140: PHP Warning: Invalid argument supplied for foreach() as Resolved.
Thu, May 16, 1:35 PM · DBA, Wikimedia-production-error
Ladsgroup added a comment to T365140: PHP Warning: Invalid argument supplied for foreach().

It deals with depools and repools but not new clusters which is rare. Sigh.

Thu, May 16, 1:34 PM · DBA, Wikimedia-production-error
Ladsgroup added a comment to T365140: PHP Warning: Invalid argument supplied for foreach().

oh lovely
let me restart some scripts

Thu, May 16, 1:31 PM · DBA, Wikimedia-production-error
Ladsgroup added a comment to T365140: PHP Warning: Invalid argument supplied for foreach().

I thought it might have not been deployed, but it is: https://phabricator.wikimedia.org/T362786#9794065

Thu, May 16, 1:30 PM · DBA, Wikimedia-production-error
Ladsgroup added a comment to T365140: PHP Warning: Invalid argument supplied for foreach().
if ( substr( $dbctlCluster, 0, 2 ) === 'pc' ) {
        continue;
}
Thu, May 16, 1:24 PM · DBA, Wikimedia-production-error
Ladsgroup claimed T365140: PHP Warning: Invalid argument supplied for foreach().

in etcd, they should have been ignored
let me check

Thu, May 16, 1:24 PM · DBA, Wikimedia-production-error
Ladsgroup added a comment to T363407: Proper service names in trace data.

Looks so cool already!

Thu, May 16, 11:10 AM · Patch-For-Review, Observability-Tracing
Ladsgroup updated the task description for T365055: [REPO][SW] DatabaseTermStoreWriterBase::acquireAndInsertTerms() shouldn't lock all rows for the item.
Thu, May 16, 10:30 AM · Wikidata Dev Team, wmde-wikidata-tech, Wikidata, MediaWiki-extensions-WikibaseRepository

Wed, May 15

Ladsgroup created T365055: [REPO][SW] DatabaseTermStoreWriterBase::acquireAndInsertTerms() shouldn't lock all rows for the item.
Wed, May 15, 6:37 PM · Wikidata Dev Team, wmde-wikidata-tech, Wikidata, MediaWiki-extensions-WikibaseRepository
Ladsgroup reassigned T364974: mediawiki_job_update_special_pages crashes with Error: Class 'Wikimedia\Rdbms\SubQuery' not found from Ladsgroup to Lucas_Werkmeister_WMDE.

<3

Wed, May 15, 10:49 AM · MW-1.43-notes (1.43.0-wmf.4; 2024-05-07), MediaWiki-extensions-FlaggedRevs, serviceops-radar, Wikimedia-production-error
Ladsgroup added a comment to T362786: Enable dbctl for parsercache.

I leave that to Manuel. I take care of the mw side of things.

Wed, May 15, 10:18 AM · Patch-For-Review, Infrastructure-Foundations, Data-Persistence, conftool
Ladsgroup added a project to T364974: mediawiki_job_update_special_pages crashes with Error: Class 'Wikimedia\Rdbms\SubQuery' not found: MediaWiki-extensions-FlaggedRevs.

Caused by migration to SQB. cc @DannyS712 @Umherirrender

Wed, May 15, 10:17 AM · MW-1.43-notes (1.43.0-wmf.4; 2024-05-07), MediaWiki-extensions-FlaggedRevs, serviceops-radar, Wikimedia-production-error
Ladsgroup placed T364546: namespaceDupes is not respecting links migration stage (again) up for grabs.

At least we know it's not going to break replication again but someone needs to fix the underlying problem. I might get to it eventually but no cookie licking so if someone else is willing to, sure.

Wed, May 15, 9:58 AM · Patch-For-Review, MediaWiki-Maintenance-system, MW-1.43-notes (1.43.0-wmf.3; 2024-04-30)
Ladsgroup added a comment to T364644: Set $wgEnableAsyncUploads = true on all wikis.

What would be the usecase for upload from other sites to non-commons. Assuming they are all fair use images (otherwise they should go to commons), maybe we shouldn't allow it? I know there are some discrepancies between copyright laws and some wikis allow some images that wouldn't be allowed in Commons but that's still quite a marginal usecase (unless I'm missing something super obvious). e.g. for T364288: Server-side upload request for hinnk why it's not being uploaded to commons?

Wed, May 15, 9:31 AM · Wikimedia-Site-requests
Ladsgroup added a comment to T364617: Deprecate and remove alllinks API endpoint.

I find it helpful to get all pages linking to a subset, most usable with prefix parameter.

Wed, May 15, 9:18 AM · Patch-For-Review, MediaWiki-Action-API, MW-Interfaces-Team
Ladsgroup added a comment to T20110: Define AbuseFilter consequence to display a CAPTCHA.

You could reorder the list of extensions to be loaded in production, it has been before for the exact same problem but 1- It's not sustainable 2- it might break other things.

Wed, May 15, 9:09 AM · MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), Patch-For-Review, User-notice, ConfirmEdit (CAPTCHA extension), Wikimedia-Hackathon-2024, AbuseFilter
Ladsgroup updated the task description for T363839: Remove old/unused/internal methods in rdbms library from the public APIs.
Wed, May 15, 8:59 AM · Patch-For-Review, MW-1.43-notes (1.43.0-wmf.6; 2024-05-21), DBA, MediaWiki-libs-Rdbms
Ladsgroup updated the task description for T352010: Gradually drop old pagelinks columns.
Wed, May 15, 8:38 AM · Schema-change-in-production, DBA, MediaWiki-Page-derived-data

Tue, May 14

Ladsgroup added a comment to T364691: Elevated 503 backend fetch failed reported by users.

Third one from third user:

grafik.png (587×949 px, 114 KB)

Tue, May 14, 8:38 PM · Traffic
Ladsgroup updated the task description for T352010: Gradually drop old pagelinks columns.
Tue, May 14, 8:35 PM · Schema-change-in-production, DBA, MediaWiki-Page-derived-data
Ladsgroup added a comment to T300371: Drop now unused user preferences from production database(s).

User properties over 1M rows in enwiki, maybe that'd be helpful for clean up:

mysql:research@s1-analytics-replica.eqiad.wmnet [enwiki]> select up_property, count(*) from user_properties group by up_property order by count(*) desc limit 100;
+-----------------------------------------------------+----------+
| up_property                                         | count(*) |
+-----------------------------------------------------+----------+
| echo-subscriptions-email-page-review                | 19153xxx |
| echo-subscriptions-email-edit-thank                 | 19033xxx |
| echo-subscriptions-web-article-linked               | 18891xxx |
| echo-subscriptions-email-mention                    | 18869xxx |
| echo-subscriptions-web-reverted                     | 18845xxx |
| echo-subscriptions-email-article-linked             | 18493xxx |
| popups                                              | 13718xxx |
| skin                                                | 10012xxx |
| thumbsize                                           |  9307xxx |
| rememberpassword                                    |  8187xxx |
| visualeditor-autodisable                            |  8005xxx |
| visualeditor-hidebetawelcome                        |  6998xxx |
| VectorSkinVersion                                   |  4377xxx |
| echo-subscriptions-email-dt-subscription            |  3708xxx |
| watchcreations                                      |  3468xxx |
| growthexperiments-homepage-pt-link                  |  2730xxx |
| growthexperiments-homepage-enable                   |  2730xxx |
| growthexperiments-help-panel-tog-help-panel         |  2717xxx |
| growthexperiments-homepage-variant                  |  2714xxx |
| growthexperiments-tour-help-panel                   |  2714xxx |
| growthexperiments-tour-homepage-mentorship          |  2704xxx |
| discussiontools-autotopicsub                        |  2575xxx |
| watchlisttoken                                      |  2527xxx |
| echo-subscriptions-web-wikibase-action              |  2492xxx |
| timecorrection                                      |  2320xxx |
| date                                                |  2217xxx |
| growthexperiments-homepage-mentorship-enabled       |  2099xxx |
| nickname                                            |  2048xxx |
| visualeditor-editor                                 |  1910xxx |
| growthexperiments-tour-homepage-discovery           |  1701xxx |
| homepage_mobile_discovery_notice_seen               |  1619xxx |
| gettingstarted-task-toolbar-show-intro              |  1351xxx |
| growthexperiments-tour-homepage-welcome             |  1294xxx |
| visualeditor-hideusered                             |  1260xxx |
| enotifusertalkpages                                 |  1127xxx |
| growthexperiments-homepage-se-filters               |  1089xxx |
| growthexperiments-tour-newimpact-discovery          |  1027xxx |
| variant                                             |  1015xxx |
| compact-language-links                              |  1008xxx |
Tue, May 14, 8:24 PM · MW-1.41-notes (1.41.0-wmf.13; 2023-06-13), MediaWiki-User-management, Platform Engineering, Data-Persistence (work done), Move-Files-To-Commons, WMDE-TechWish-Maintenance
Ladsgroup closed T364906: Create a mailing list for plwiki sysops as Resolved.

{{done}}
https://lists.wikimedia.org/postorius/lists/wikipedia-pl-admins.lists.wikimedia.org/

Tue, May 14, 8:19 PM · SRE, Wikimedia-Mailing-lists
Ladsgroup added a comment to T364906: Create a mailing list for plwiki sysops.

We will go with the name wikipedia-pl-admins to be consistent with other wikis. Hope that's fine with you.

Tue, May 14, 8:16 PM · SRE, Wikimedia-Mailing-lists
Ladsgroup claimed T364906: Create a mailing list for plwiki sysops.
Tue, May 14, 8:15 PM · SRE, Wikimedia-Mailing-lists
Ladsgroup added a comment to T359425: API:alllinks and API:alltransclusions query fails with RequestTimeout for several wikis.

@Umherirrender I hope to actually deprecate the endpoint: T364617: Deprecate and remove alllinks API endpoint

Tue, May 14, 2:18 PM · Patch-For-Review, Regression, MW-1.42-notes (1.42.0-wmf.24; 2024-03-26), MediaWiki-Action-API, Wikimedia-production-error, Wikimedia-Slow-DB-Query, WME-API-Usability
Ladsgroup added a comment to T120242: Eventually Consistent MediaWiki State Change Events.

So there is no real "source of truth".

So it is quite possible that we might even lose canonical data due to inconsistencies between master and its candidate. It is extremely rare but not out of question.

Wow that is very interesting!

Does that mean that it is possible (although unlikely) that a suppression of PII may be suppressed in one master but not the other? Or a page deleted in one master but not the other?

Tue, May 14, 11:26 AM · Data-Engineering, Analytics, DBA, WMF-Architecture-Team, Platform Team Legacy (Later), Event-Platform, Services (later)
Ladsgroup closed T364827: Wikimedia\Rdbms\DBQueryError: Error 1049: Unknown database 'cognate_wiktionary' as Resolved.
Tue, May 14, 11:19 AM · MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), MediaModeration, wmde-wikidata-tech, Wikidata, Patch-For-Review, DBA, Cognate, Wikimedia-production-error
Ladsgroup closed T364827: Wikimedia\Rdbms\DBQueryError: Error 1049: Unknown database 'cognate_wiktionary', a subtask of T361399: 1.43.0-wmf.5 deployment blockers, as Resolved.
Tue, May 14, 11:19 AM · Release-Engineering-Team (Yakisfaction), Release, Train Deployments
Ladsgroup added a comment to T364827: Wikimedia\Rdbms\DBQueryError: Error 1049: Unknown database 'cognate_wiktionary'.

if you used virtual domains, yes.

Tue, May 14, 11:10 AM · MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), MediaModeration, wmde-wikidata-tech, Wikidata, Patch-For-Review, DBA, Cognate, Wikimedia-production-error
Ladsgroup added a comment to T364827: Wikimedia\Rdbms\DBQueryError: Error 1049: Unknown database 'cognate_wiktionary'.

That code is used in other places now, making the roll back more complicated. The fix is straightforward.

Tue, May 14, 10:21 AM · MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), MediaModeration, wmde-wikidata-tech, Wikidata, Patch-For-Review, DBA, Cognate, Wikimedia-production-error
Ladsgroup claimed T364827: Wikimedia\Rdbms\DBQueryError: Error 1049: Unknown database 'cognate_wiktionary'.

Ah found it. Sneaky bug. I patch it now.

Tue, May 14, 10:13 AM · MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), MediaModeration, wmde-wikidata-tech, Wikidata, Patch-For-Review, DBA, Cognate, Wikimedia-production-error
Ladsgroup moved T364827: Wikimedia\Rdbms\DBQueryError: Error 1049: Unknown database 'cognate_wiktionary' from Triage to In progress on the DBA board.
Tue, May 14, 10:12 AM · MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), MediaModeration, wmde-wikidata-tech, Wikidata, Patch-For-Review, DBA, Cognate, Wikimedia-production-error
Ladsgroup updated subscribers of T364827: Wikimedia\Rdbms\DBQueryError: Error 1049: Unknown database 'cognate_wiktionary'.

All of these errors are clearly because virtual domains is now broken. cc @Tgr I debug and see what I can find.

Tue, May 14, 10:11 AM · MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), MediaModeration, wmde-wikidata-tech, Wikidata, Patch-For-Review, DBA, Cognate, Wikimedia-production-error
Ladsgroup merged task T364831: Wikimedia\Rdbms\DBQueryError from line 1203 of /srv/mediawiki/php-1.43.0-wmf.5/includes/libs/rdbms/database/Database.php: Error 1146: Table 'testwiki.ce_question_answers' doesn't exist into T364827: Wikimedia\Rdbms\DBQueryError: Error 1049: Unknown database 'cognate_wiktionary'.
Tue, May 14, 10:10 AM · serviceops-radar, Wikimedia-production-error, Campaign-Tools (Campaign-Tools-Current-Sprint), Wikimedia-Site-requests, Campaign-Registration
Ladsgroup merged T364831: Wikimedia\Rdbms\DBQueryError from line 1203 of /srv/mediawiki/php-1.43.0-wmf.5/includes/libs/rdbms/database/Database.php: Error 1146: Table 'testwiki.ce_question_answers' doesn't exist into T364827: Wikimedia\Rdbms\DBQueryError: Error 1049: Unknown database 'cognate_wiktionary'.
Tue, May 14, 10:10 AM · MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), MediaModeration, wmde-wikidata-tech, Wikidata, Patch-For-Review, DBA, Cognate, Wikimedia-production-error
Ladsgroup merged task T364828: Wikimedia\Rdbms\DBQueryError: Error 1049: Unknown database 'wikishared'Function: Wikimedia\Rdbms\DatabaseMySQL::doSelectDomainQuery: USE `wikishared` into T364827: Wikimedia\Rdbms\DBQueryError: Error 1049: Unknown database 'cognate_wiktionary'.
Tue, May 14, 10:09 AM · MediaWiki-extensions-LoginNotify, Community-Tech, Wikimedia-production-error
Ladsgroup merged T364828: Wikimedia\Rdbms\DBQueryError: Error 1049: Unknown database 'wikishared'Function: Wikimedia\Rdbms\DatabaseMySQL::doSelectDomainQuery: USE `wikishared` into T364827: Wikimedia\Rdbms\DBQueryError: Error 1049: Unknown database 'cognate_wiktionary'.
Tue, May 14, 10:09 AM · MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), MediaModeration, wmde-wikidata-tech, Wikidata, Patch-For-Review, DBA, Cognate, Wikimedia-production-error
Ladsgroup added a comment to T364827: Wikimedia\Rdbms\DBQueryError: Error 1049: Unknown database 'cognate_wiktionary'.

This is very likely caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1024973/3/includes/libs/rdbms/lbfactory/LBFactory.php a refactor we did on virtual domains, but I can't see how. I'm not spotting any obvious mistakes (I dig deeper). If you do, please let me know.

Tue, May 14, 10:03 AM · MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), MediaModeration, wmde-wikidata-tech, Wikidata, Patch-For-Review, DBA, Cognate, Wikimedia-production-error
Ladsgroup added a comment to T364827: Wikimedia\Rdbms\DBQueryError: Error 1049: Unknown database 'cognate_wiktionary'.

I think I know what's going on. Give me a bit.

Tue, May 14, 10:00 AM · MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), MediaModeration, wmde-wikidata-tech, Wikidata, Patch-For-Review, DBA, Cognate, Wikimedia-production-error

Mon, May 13

Ladsgroup added a comment to T298729: wikimediacz-l does not hold all posts for moderation.

Hi @Urbanecm is this resolved or you're still seeing stuff?

Mon, May 13, 8:42 PM · User-Urbanecm, User-Ladsgroup, SRE, Wikimedia-Mailing-lists
Ladsgroup closed T364731: Mailing list for English Wiktionary admins as Resolved.

Feel to create a separate request for mailing list for general matters of English Wiktionary. You can bring it up in your wiki's village pump to see how much of support it's going to get.

Mon, May 13, 8:37 PM · SRE, Wikimedia-Mailing-lists
Ladsgroup added a comment to T361671: Large ext.flaggedRevs.advanced module is loaded for anonymous users.

It would be great if a designer could sit and take a look at the design of FR. It has four modes via matrix of: Low profile vs non-low profile and simple UI vs non-simple UI. Which I would really like to merge and unify.

Mon, May 13, 8:15 PM · Verified, MW-1.43-notes (1.43.0-wmf.4; 2024-05-07), Web-Team-Backlog (FY2023-24 Q4 Sprint 3), Performance Issue, MediaWiki-extensions-FlaggedRevs
Ladsgroup added a comment to T362646: Enable more nuanced targeting and sampling on Quicksurveys.

Do you know if there is a simple way to "fill up" a local database with dataset? We want to make sure the code we run is as performant as possible, and we do not know how to achieve this with just the local database

Mon, May 13, 8:12 PM · Patch-For-Review, WMF-Safety-Survey
Ladsgroup added a comment to T364250: May 1, 2024 wikidatawiki dump not started.

We all have had such misfortunes! Fixing the issue in mw is rather easy, we should just drop the code piece, bump the number in several places, update the schema validation and update tests. Here is an example https://gerrit.wikimedia.org/r/c/mediawiki/core/+/464768

Mon, May 13, 8:02 PM · Data Products (Data Products Sprint 13), Dumps-Generation
Ladsgroup added a comment to T360930: Section-wide circuit breaking.

Pulling it in mwdebug and reducing the threshold to four connection led to this:

grafik.png (278×1 px, 16 KB)

Mon, May 13, 4:55 PM · Patch-For-Review, MW-1.43-notes (1.43.0-wmf.4; 2024-05-07), MediaWiki-libs-Rdbms, DBA
Ladsgroup awarded T364652: Make component boundaries in MediaWiki core easier to discover a Orange Medal token.
Mon, May 13, 4:27 PM · MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), MediaWiki-Engineering
Ladsgroup added a comment to T364587: FlaggedRevs notices became much bigger and more broken on mobile.

Seems like @Jdlrobson in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/1020418 while fixing T361671. Merged by @Ladsgroup.

Making such an unwarranted (and unannounced!) breaking change while fixing a routine issue is really strange. (edit: better wording)

Mon, May 13, 3:50 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 3), MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), Regression, MobileFrontend, MediaWiki-extensions-FlaggedRevs
Ladsgroup added a comment to T364250: May 1, 2024 wikidatawiki dump not started.

We should get rid of that part and bump the XML version as Daniel suggested. Wanna do it?

Mon, May 13, 3:04 PM · Data Products (Data Products Sprint 13), Dumps-Generation
Ladsgroup updated the task description for T352010: Gradually drop old pagelinks columns.
Mon, May 13, 2:58 PM · Schema-change-in-production, DBA, MediaWiki-Page-derived-data
Ladsgroup added a comment to T364691: Elevated 503 backend fetch failed reported by users.

Haven't checked logged out, what I get is logged in users.

Mon, May 13, 1:40 PM · Traffic
Ladsgroup added a comment to T364691: Elevated 503 backend fetch failed reported by users.

we had a big spike of 503s on eqiad/drmrs/esams yesterday during EU morning: https://grafana.wikimedia.org/goto/J4YqQuYIR?orgId=1:

image.png (699×1 px, 151 KB)

Mon, May 13, 1:35 PM · Traffic
Ladsgroup added a comment to T362646: Enable more nuanced targeting and sampling on Quicksurveys.

Oh no, that would explode the database and appservers if you query for an active editor. you can just do a left() in the sql. Just query group by left(rev_timestamp, 6) and get the count. I know it won't work with PG but it shouldn't be too hard to fix :P

Mon, May 13, 12:45 PM · Patch-For-Review, WMF-Safety-Survey
Ladsgroup added a comment to T364731: Mailing list for English Wiktionary admins.

if you want a general mailing list for English Wiktionary then it should be wiktionary-en@. We can have both.

Mon, May 13, 12:22 PM · SRE, Wikimedia-Mailing-lists
Ladsgroup added a comment to T362749: Deploy logo-detection model-server to LiftWing staging.

It's not just the privacy. For example, we want to eventually implement uploading from URLs via chunks which means a file being uploaded can have many stashed files instead of one. So this is about the encapsulation of how mw works.

Mon, May 13, 12:16 PM · Machine-Learning-Team
Ladsgroup added a comment to T364731: Mailing list for English Wiktionary admins.

Second: Should be public or private?

Mon, May 13, 12:09 PM · SRE, Wikimedia-Mailing-lists
Ladsgroup claimed T364731: Mailing list for English Wiktionary admins.

Hi, you mean English Wiktionary admins or admins of all wiktionary projects? If the former, then it should be wiktionary-en-admins@lists.wikimedia.org (see https://meta.wikimedia.org/wiki/Mailing_lists/Standardization)

Mon, May 13, 12:08 PM · SRE, Wikimedia-Mailing-lists
Ladsgroup closed T364693: DiscussionTools isFeatureEnabled check is taking 5% of all requests as Resolved.

It happens. I wish we had better monitoring to see jumps like this. I actually have a plan for a SLO that would have failed with such regressions forcing us to look at it. Hopefully soon.

Mon, May 13, 12:05 PM · MW-1.43-notes (1.43.0-wmf.4; 2024-05-07), MW-1.42-notes, MW-1.41-notes, Wikimedia-Performance-recommendation, MediaWiki-Platform-Team (Radar), Performance Issue, DBA, Editing-team, DiscussionTools
Ladsgroup added a comment to T256190: Update footer image links on all MediaWiki skins to be legible and accessible.

I have somewhat of a plan to deploy this without breaking the footer. If someone is willing to help shepherd this to production, please let me know. Maybe @Jdforrester-WMF ? <3

Mon, May 13, 10:49 AM · Web-Team-Backlog (Needs Prioritization (Tech)), Patch-For-Review, Wikimedia-Hackathon-2024, Wikimedia-Design, Design, MediaWiki-General, Accessibility
Ladsgroup added a comment to T256190: Update footer image links on all MediaWiki skins to be legible and accessible.

If we fix the sanization in the patch, this will be the result:

grafik.png (834×1 px, 197 KB)

Mon, May 13, 10:38 AM · Web-Team-Backlog (Needs Prioritization (Tech)), Patch-For-Review, Wikimedia-Hackathon-2024, Wikimedia-Design, Design, MediaWiki-General, Accessibility
Ladsgroup placed T358620: LoadBalancer::awaitSessionPrimaryPos needs a timeout up for grabs.

Avoiding cookie licking

Mon, May 13, 9:16 AM · MediaWiki-libs-Rdbms
Ladsgroup added a comment to T120242: Eventually Consistent MediaWiki State Change Events.

FWIW, for each section we have a master and a "candidate master". We always swap them when we need to do maintenance. So there is no real "source of truth". There are two (not to mention we change candidate masters from time to time if there are hw issues, refreshes, etc.). So it is quite possible that we might even lose canonical data due to inconsistencies between master and its candidate. It is extremely rare but not out of question.

Mon, May 13, 9:12 AM · Data-Engineering, Analytics, DBA, WMF-Architecture-Team, Platform Team Legacy (Later), Event-Platform, Services (later)
Marostegui awarded T364693: DiscussionTools isFeatureEnabled check is taking 5% of all requests a Love token.
Mon, May 13, 9:00 AM · MW-1.43-notes (1.43.0-wmf.4; 2024-05-07), MW-1.42-notes, MW-1.41-notes, Wikimedia-Performance-recommendation, MediaWiki-Platform-Team (Radar), Performance Issue, DBA, Editing-team, DiscussionTools
Ladsgroup added a comment to T364693: DiscussionTools isFeatureEnabled check is taking 5% of all requests.

Here is the load on the databases going down:
(deploy finished at 7:56)

grafik.png (791×1 px, 437 KB)

Mean latency of mw requests (k8s, currently 80% of traffic):
grafik.png (822×1 px, 118 KB)

Mean latency of mw requests (bare metal)
grafik.png (822×1 px, 142 KB)

Mon, May 13, 8:47 AM · MW-1.43-notes (1.43.0-wmf.4; 2024-05-07), MW-1.42-notes, MW-1.41-notes, Wikimedia-Performance-recommendation, MediaWiki-Platform-Team (Radar), Performance Issue, DBA, Editing-team, DiscussionTools